[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481735#comment-17481735 ] Martin Balin edited comment on NETBEANS-6384 at 1/25/22, 2:17 PM: -- The fix works and both ext packs are running (kind of) alongside. When MS Java was started before NBLS installed then it shows attached notifications. !Screenshot 2022-01-25 at 11.59.09.png! \ Will be great to do something about this, although I don't think we can suppress the {{Could not start client NB Java}} error. But we could extend the message to say something like "{{{}Could not start client NB Java. Check if another Java extension is not enabled".{}}} What do you think? was (Author: mbalin): The fix works and both ext packs are running (kind of) alongside. When MS Java was started before NBLS installed then it shows attached notifications. !Screenshot 2022-01-25 at 11.59.09.png! \ Will be great to do something about this, although I don't think we can suppress the {{Could not start client NB Java}} error. But we could extend the message to say something like "{{{}Could not start client NB Java. Check if another Java extension is not running".{}}} What do you think? > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: NB13 > > Attachments: Screenshot 2022-01-25 at 11.59.09.png > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481735#comment-17481735 ] Martin Balin edited comment on NETBEANS-6384 at 1/25/22, 2:16 PM: -- The fix works and both ext packs are running (kind of) alongside. When MS Java was started before NBLS installed then it shows attached notifications. !Screenshot 2022-01-25 at 11.59.09.png! \ Will be great to do something about this, although I don't think we can suppress the {{Could not start client NB Java}} error. But we could extend the message to say something like "{{{}Could not start client NB Java. Check if another Java extension is not running".{}}} What do you thin? was (Author: mbalin): The fix works and both ext packs are running (kind of) alongside. When MS Java was started before NBLS installed then it shows attached notifications. !Screenshot 2022-01-25 at 11.59.09.png! \ Will be great to do something about this, although I don't think we can suppress the Could not start client NB Java error. > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: NB13 > > Attachments: Screenshot 2022-01-25 at 11.59.09.png > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481735#comment-17481735 ] Martin Balin edited comment on NETBEANS-6384 at 1/25/22, 2:16 PM: -- The fix works and both ext packs are running (kind of) alongside. When MS Java was started before NBLS installed then it shows attached notifications. !Screenshot 2022-01-25 at 11.59.09.png! \ Will be great to do something about this, although I don't think we can suppress the {{Could not start client NB Java}} error. But we could extend the message to say something like "{{{}Could not start client NB Java. Check if another Java extension is not running".{}}} What do you think? was (Author: mbalin): The fix works and both ext packs are running (kind of) alongside. When MS Java was started before NBLS installed then it shows attached notifications. !Screenshot 2022-01-25 at 11.59.09.png! \ Will be great to do something about this, although I don't think we can suppress the {{Could not start client NB Java}} error. But we could extend the message to say something like "{{{}Could not start client NB Java. Check if another Java extension is not running".{}}} What do you thin? > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: NB13 > > Attachments: Screenshot 2022-01-25 at 11.59.09.png > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474644#comment-17474644 ] Jaroslav Tulach edited comment on NETBEANS-6384 at 1/25/22, 11:25 AM: -- Code is at [https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions |https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions] the newly rebuilt sample extension is [available as well|https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/838/] was (Author: jtulach): Code is at [https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions |https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions] sample extension is [available as well|https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/808/] > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: NB13 > > Attachments: Screenshot 2022-01-25 at 11.59.09.png > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[ https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474644#comment-17474644 ] Jaroslav Tulach edited comment on NETBEANS-6384 at 1/12/22, 3:57 PM: - Code is at [https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions |https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions] sample extension is [available as well|https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/808/] was (Author: jtulach): Code is at https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions > Detect another Java support ext and recommend to Disable one > > > Key: NETBEANS-6384 > URL: https://issues.apache.org/jira/browse/NETBEANS-6384 > Project: NetBeans > Issue Type: Task > Components: vscode >Affects Versions: 12.5 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 13.0 > > > VSNetBeans currently detects installation of MS Java ext pack and informs > user it will disable some services of it, code lenses and code completion. > See > [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284] > {code:javascript} > conf.update('java.test.editor.enableShortcuts', false, false).then(() => {}, > disablingFailed); > conf.update('java.debug.settings.enableRunDebugCodeLens', false, > false).then(() => {}, disablingFailed); > {code} > This behaviour should change to better coexist with MS Java ext. > VSNetBeans needs to show user a dialog recommending to Enable per workspace > one of the Java ext packs. Looking at VSCode API it seems there is still > missing API to DISABLE extension programatically, while there is > [uninstallExtension|https://code.visualstudio.com/api/references/commands] > command? > Proposed solution is not perfect: > VSNetBeans will show dialog with text like: _Another Java support extension > is already installed. It is recommended to use only one Java support per > workspace. Please Disable one of Java ext for workspace._ *OK* button to open > Extensions panel and user has to do it UX is TBD. > Some context info: > VSCode plans to stop recommend extensions see > [https://github.com/microsoft/vscode/issues/136301] in Feb. > And they are also working on extension sets per workspace > [https://github.com/microsoft/vscode/issues/40239] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists