[jira] [Commented] (NETBEANS-3729) [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
[
https://issues.apache.org/jira/browse/NETBEANS-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022139#comment-17022139
]
Rami Swailem commented on NETBEANS-3729:
[~DevCharly] You’re welcome and thank you again for resolving the issue quickly
> [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
> --
>
> Key: NETBEANS-3729
> URL: https://issues.apache.org/jira/browse/NETBEANS-3729
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Progress
>Affects Versions: Next
> Environment: Product Version: Apache NetBeans IDE DEV (Build
> dev-e9111499a7b3d71fce5496a633116574f617067b)
> Updates: Updates available
> Java: 15-ea; OpenJDK 64-Bit Server VM 15-ea+5-83
> Runtime: OpenJDK Runtime Environment 15-ea+5-83
> System: Mac OS X version 10.13.6 running on x86_64; UTF-8; en_DE (nb)
> User directory: /Users/rami/Library/Application Support/NetBeans/dev
> Cache directory: /Users/rami/Library/Caches/NetBeans/dev
>Reporter: Rami Swailem
>Assignee: Karl Tauber
>Priority: Trivial
> Labels: pull-request-available
> Attachments: Screen Shot 2020-01-22 at 14.50.10.png, Screen Shot
> 2020-01-22 at 15.12.49.png, image-2020-01-23-10-50-23-648.png,
> image-2020-01-23-11-07-28-246.png, image-2020-01-23-11-08-06-828.png,
> image-2020-01-23-11-34-57-947.png, image-2020-01-23-11-35-07-915.png,
> image-2020-01-23-11-35-26-873.png, image-2020-01-23-11-35-33-050.png,
> image-2020-01-23-11-36-00-310.png, image-2020-01-23-11-36-15-946.png,
> image-2020-01-23-11-36-26-998.png, image-2020-01-23-11-37-02-531.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> can someone reproduce the following situation? see screenshots
> its happen sometimes with aqua laf but with FlatLaf always
>
> {code:java}
> @ActionID(
> category = "Bugtracking",
> id = "org.netbeans.BugAction"
> )
> @ActionRegistration(
> displayName = "#CTL_BugAction"
> )
> @ActionReference(path = "Menu/File", position = 0)
> @Messages("CTL_BugAction=BaseProgressUtils FlatLaf bug")
> public class BugAction implements ActionListener {
> @Override
> public void actionPerformed(ActionEvent e) {
> ProgressHandle progress = ProgressHandle.createHandle("displayName",
> () -> true);
> BaseProgressUtils.showProgressDialogAndRun(operation, progress, true);
> }
> private Runnable operation = new Runnable() {
> @Override
> public void run() {
> try {
> Thread.sleep(6000);
> } catch (Exception e) {
> }
> }
> };
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3729) [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
[
https://issues.apache.org/jira/browse/NETBEANS-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022133#comment-17022133
]
Karl Tauber commented on NETBEANS-3729:
---
[~palman] thanks for providing a test action. This made it so much easier to
work on a fix (y)
> [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
> --
>
> Key: NETBEANS-3729
> URL: https://issues.apache.org/jira/browse/NETBEANS-3729
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Progress
>Affects Versions: Next
> Environment: Product Version: Apache NetBeans IDE DEV (Build
> dev-e9111499a7b3d71fce5496a633116574f617067b)
> Updates: Updates available
> Java: 15-ea; OpenJDK 64-Bit Server VM 15-ea+5-83
> Runtime: OpenJDK Runtime Environment 15-ea+5-83
> System: Mac OS X version 10.13.6 running on x86_64; UTF-8; en_DE (nb)
> User directory: /Users/rami/Library/Application Support/NetBeans/dev
> Cache directory: /Users/rami/Library/Caches/NetBeans/dev
>Reporter: Rami Swailem
>Assignee: Karl Tauber
>Priority: Trivial
> Labels: pull-request-available
> Attachments: Screen Shot 2020-01-22 at 14.50.10.png, Screen Shot
> 2020-01-22 at 15.12.49.png, image-2020-01-23-10-50-23-648.png,
> image-2020-01-23-11-07-28-246.png, image-2020-01-23-11-08-06-828.png,
> image-2020-01-23-11-34-57-947.png, image-2020-01-23-11-35-07-915.png,
> image-2020-01-23-11-35-26-873.png, image-2020-01-23-11-35-33-050.png,
> image-2020-01-23-11-36-00-310.png, image-2020-01-23-11-36-15-946.png,
> image-2020-01-23-11-36-26-998.png, image-2020-01-23-11-37-02-531.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> can someone reproduce the following situation? see screenshots
> its happen sometimes with aqua laf but with FlatLaf always
>
> {code:java}
> @ActionID(
> category = "Bugtracking",
> id = "org.netbeans.BugAction"
> )
> @ActionRegistration(
> displayName = "#CTL_BugAction"
> )
> @ActionReference(path = "Menu/File", position = 0)
> @Messages("CTL_BugAction=BaseProgressUtils FlatLaf bug")
> public class BugAction implements ActionListener {
> @Override
> public void actionPerformed(ActionEvent e) {
> ProgressHandle progress = ProgressHandle.createHandle("displayName",
> () -> true);
> BaseProgressUtils.showProgressDialogAndRun(operation, progress, true);
> }
> private Runnable operation = new Runnable() {
> @Override
> public void run() {
> try {
> Thread.sleep(6000);
> } catch (Exception e) {
> }
> }
> };
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3729) [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
[
https://issues.apache.org/jira/browse/NETBEANS-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021953#comment-17021953
]
Rami Swailem commented on NETBEANS-3729:
[~DevCharly] Thank you for fixing this issue
> [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
> --
>
> Key: NETBEANS-3729
> URL: https://issues.apache.org/jira/browse/NETBEANS-3729
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Progress
>Affects Versions: Next
> Environment: Product Version: Apache NetBeans IDE DEV (Build
> dev-e9111499a7b3d71fce5496a633116574f617067b)
> Updates: Updates available
> Java: 15-ea; OpenJDK 64-Bit Server VM 15-ea+5-83
> Runtime: OpenJDK Runtime Environment 15-ea+5-83
> System: Mac OS X version 10.13.6 running on x86_64; UTF-8; en_DE (nb)
> User directory: /Users/rami/Library/Application Support/NetBeans/dev
> Cache directory: /Users/rami/Library/Caches/NetBeans/dev
>Reporter: Rami Swailem
>Assignee: Karl Tauber
>Priority: Trivial
> Labels: pull-request-available
> Attachments: Screen Shot 2020-01-22 at 14.50.10.png, Screen Shot
> 2020-01-22 at 15.12.49.png, image-2020-01-23-10-50-23-648.png,
> image-2020-01-23-11-07-28-246.png, image-2020-01-23-11-08-06-828.png,
> image-2020-01-23-11-34-57-947.png, image-2020-01-23-11-35-07-915.png,
> image-2020-01-23-11-35-26-873.png, image-2020-01-23-11-35-33-050.png,
> image-2020-01-23-11-36-00-310.png, image-2020-01-23-11-36-15-946.png,
> image-2020-01-23-11-36-26-998.png, image-2020-01-23-11-37-02-531.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> can someone reproduce the following situation? see screenshots
> its happen sometimes with aqua laf but with FlatLaf always
>
> {code:java}
> @ActionID(
> category = "Bugtracking",
> id = "org.netbeans.BugAction"
> )
> @ActionRegistration(
> displayName = "#CTL_BugAction"
> )
> @ActionReference(path = "Menu/File", position = 0)
> @Messages("CTL_BugAction=BaseProgressUtils FlatLaf bug")
> public class BugAction implements ActionListener {
> @Override
> public void actionPerformed(ActionEvent e) {
> ProgressHandle progress = ProgressHandle.createHandle("displayName",
> () -> true);
> BaseProgressUtils.showProgressDialogAndRun(operation, progress, true);
> }
> private Runnable operation = new Runnable() {
> @Override
> public void run() {
> try {
> Thread.sleep(6000);
> } catch (Exception e) {
> }
> }
> };
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3729) [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
[
https://issues.apache.org/jira/browse/NETBEANS-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021944#comment-17021944
]
Karl Tauber commented on NETBEANS-3729:
---
The solution is to give the GridBagLayout panel (that contains progress bar and
cancel button) a minimum height and vertically center these components.
Result (colored):
!image-2020-01-23-11-34-57-947.png!
!image-2020-01-23-11-35-07-915.png!
without colors:
!image-2020-01-23-11-35-26-873.png!
!image-2020-01-23-11-35-33-050.png!
Windows LAF:
!image-2020-01-23-11-36-00-310.png!
!image-2020-01-23-11-37-02-531.png!
Nimbus LAF:
!image-2020-01-23-11-36-15-946.png!
Metal LAF:
!image-2020-01-23-11-36-26-998.png!
> [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
> --
>
> Key: NETBEANS-3729
> URL: https://issues.apache.org/jira/browse/NETBEANS-3729
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Progress
>Affects Versions: Next
> Environment: Product Version: Apache NetBeans IDE DEV (Build
> dev-e9111499a7b3d71fce5496a633116574f617067b)
> Updates: Updates available
> Java: 15-ea; OpenJDK 64-Bit Server VM 15-ea+5-83
> Runtime: OpenJDK Runtime Environment 15-ea+5-83
> System: Mac OS X version 10.13.6 running on x86_64; UTF-8; en_DE (nb)
> User directory: /Users/rami/Library/Application Support/NetBeans/dev
> Cache directory: /Users/rami/Library/Caches/NetBeans/dev
>Reporter: Rami Swailem
>Assignee: Karl Tauber
>Priority: Trivial
> Attachments: Screen Shot 2020-01-22 at 14.50.10.png, Screen Shot
> 2020-01-22 at 15.12.49.png, image-2020-01-23-10-50-23-648.png,
> image-2020-01-23-11-07-28-246.png, image-2020-01-23-11-08-06-828.png,
> image-2020-01-23-11-34-57-947.png, image-2020-01-23-11-35-07-915.png,
> image-2020-01-23-11-35-26-873.png, image-2020-01-23-11-35-33-050.png,
> image-2020-01-23-11-36-00-310.png, image-2020-01-23-11-36-15-946.png,
> image-2020-01-23-11-36-26-998.png, image-2020-01-23-11-37-02-531.png
>
>
> can someone reproduce the following situation? see screenshots
> its happen sometimes with aqua laf but with FlatLaf always
>
> {code:java}
> @ActionID(
> category = "Bugtracking",
> id = "org.netbeans.BugAction"
> )
> @ActionRegistration(
> displayName = "#CTL_BugAction"
> )
> @ActionReference(path = "Menu/File", position = 0)
> @Messages("CTL_BugAction=BaseProgressUtils FlatLaf bug")
> public class BugAction implements ActionListener {
> @Override
> public void actionPerformed(ActionEvent e) {
> ProgressHandle progress = ProgressHandle.createHandle("displayName",
> () -> true);
> BaseProgressUtils.showProgressDialogAndRun(operation, progress, true);
> }
> private Runnable operation = new Runnable() {
> @Override
> public void run() {
> try {
> Thread.sleep(6000);
> } catch (Exception e) {
> }
> }
> };
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3729) [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
[
https://issues.apache.org/jira/browse/NETBEANS-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021923#comment-17021923
]
Karl Tauber commented on NETBEANS-3729:
---
The reason is that the preferred height of a progress bar in FlatLaf is only
4px and because the label and the progress bar are layouted by a GridLayout
they all get the same height.
Here is a screenshot with green label and red background:
!image-2020-01-23-11-07-28-246.png!
When the cancel button is visible, the progress bar is stretched in height:
!image-2020-01-23-11-08-06-828.png!
The cancel button and the progress bar are located in an additional panel with
GridBagLayout.
BTW the issue is also there in Windows laf (see cut 'p' and 'y'):
!image-2020-01-23-10-50-23-648.png!
> [FlatLaf] Strang Bug in BaseProgressUtils.showProgressDialogAndRun
> --
>
> Key: NETBEANS-3729
> URL: https://issues.apache.org/jira/browse/NETBEANS-3729
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Progress
>Affects Versions: Next
> Environment: Product Version: Apache NetBeans IDE DEV (Build
> dev-e9111499a7b3d71fce5496a633116574f617067b)
> Updates: Updates available
> Java: 15-ea; OpenJDK 64-Bit Server VM 15-ea+5-83
> Runtime: OpenJDK Runtime Environment 15-ea+5-83
> System: Mac OS X version 10.13.6 running on x86_64; UTF-8; en_DE (nb)
> User directory: /Users/rami/Library/Application Support/NetBeans/dev
> Cache directory: /Users/rami/Library/Caches/NetBeans/dev
>Reporter: Rami Swailem
>Assignee: Karl Tauber
>Priority: Trivial
> Attachments: Screen Shot 2020-01-22 at 14.50.10.png, Screen Shot
> 2020-01-22 at 15.12.49.png, image-2020-01-23-10-50-23-648.png,
> image-2020-01-23-11-07-28-246.png, image-2020-01-23-11-08-06-828.png
>
>
> can someone reproduce the following situation? see screenshots
> its happen sometimes with aqua laf but with FlatLaf always
>
> {code:java}
> @ActionID(
> category = "Bugtracking",
> id = "org.netbeans.BugAction"
> )
> @ActionRegistration(
> displayName = "#CTL_BugAction"
> )
> @ActionReference(path = "Menu/File", position = 0)
> @Messages("CTL_BugAction=BaseProgressUtils FlatLaf bug")
> public class BugAction implements ActionListener {
> @Override
> public void actionPerformed(ActionEvent e) {
> ProgressHandle progress = ProgressHandle.createHandle("displayName",
> () -> true);
> BaseProgressUtils.showProgressDialogAndRun(operation, progress, true);
> }
> private Runnable operation = new Runnable() {
> @Override
> public void run() {
> try {
> Thread.sleep(6000);
> } catch (Exception e) {
> }
> }
> };
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
