[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799327#comment-16799327 ] Matthias Bläsing commented on NETBEANS-747: --- I created a PR for supporting the var function and variable syntax. A review in the reference PR and testing would be helpful. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Matthias Bläsing >Priority: Trivial > Labels: css, pull-request-available, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795296#comment-16795296 ] Jack J. Woehr commented on NETBEANS-747: Excellent! > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Matthias Bläsing >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794572#comment-16794572 ] Matthias Bläsing commented on NETBEANS-747: --- I want to see if I can implement instant rename and/or occurence highlighting. As NB11 is right before its release this feature won't make it anyway in time. For the "know the codebase": I knew the grammar location because I looked at it in the past and integrated the donated grammar. The interaction with the css.editor module was revealed, because my debugger lead me into the classes while looking into the parser warning about the unknown "var" keyword. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Matthias Bläsing >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794321#comment-16794321 ] Jack J. Woehr commented on NETBEANS-747: Thanks, it's nice to confer with someone who actually knows the source tree ;) It would take me a few years to catch up with you. I'm sure you're right. I just cloned css-variables branch of your fork, compiled the grammar and built NetBeans and it fixes the problem as I saw it. Is there more to do? > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Jack J. Woehr >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794221#comment-16794221 ] Matthias Bläsing commented on NETBEANS-747: --- I don't think that we need to change the complete grammar. You can't just switch to a basic CSS3 grammar, as the netbeans grammar also includes conditionals to support SCSS and Less. The lexer change looks minimal at this point. See here: https://github.com/matthiasblaesing/incubator-netbeans/commit/d5fe183642244e106f5d146058ffabab5e0ef938 > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Jack J. Woehr >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794113#comment-16794113 ] Jack J. Woehr commented on NETBEANS-747: Hmm, may require bumping the level of the antlr4 used by NetBeans. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Jack J. Woehr >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794083#comment-16794083 ] Jack J. Woehr commented on NETBEANS-747: Looks like the answer is simply to switch to antlr v4 and the css3 grammar at [https://github.com/antlr/grammars-v4] I can build the grammar nicely (thought antlr v4 does not have the -debug nor the -verbose switch). Of course NetBeans itself won't build then because things are structured differently; for me that's quite a research project figuring out the NetBeans build enough to make it accept the new grammar output. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Jack J. Woehr >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[
https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793912#comment-16793912
]
Jack J. Woehr commented on NETBEANS-747:
I am able to build
{noformat}
ide/css.lib/src/org/netbeans/modules/css/lib/Css3Lexer.java
ide/css.lib/src/org/netbeans/modules/css/lib/Csss3Parser.java{noformat}
via the NetBeans ide/css.lib/build.xml file using
{noformat}
antlr-3.5.2-complete-no-st3.jar{noformat}
downloaded from [https://www.antlr3.org/download.html]
Won't generate with Antlr4.
Will work now on editing grammar file.
> CSS Editor does not recognize variable syntax
> -
>
> Key: NETBEANS-747
> URL: https://issues.apache.org/jira/browse/NETBEANS-747
> Project: NetBeans
> Issue Type: Bug
> Components: web - CSS Editor
>Affects Versions: 8.2, 9.0, 10.0, 11.0
>Reporter: Peter
>Assignee: Jack J. Woehr
>Priority: Trivial
> Labels: css, variable
> Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png
>
>
> Netbeans reports my css has error but it should not
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793869#comment-16793869 ] Jack J. Woehr commented on NETBEANS-747: Apparently the grammar donation from Oracle is complete. I have forked the tree and will look at this as time permits. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584335#comment-16584335 ] Jack J. Woehr commented on NETBEANS-747: If no one more expert than myself claims this issue, I will address this issue when the grammar file is added to the repository. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0 >Reporter: Peter >Priority: Minor > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584330#comment-16584330 ] Matthias Bläsing commented on NETBEANS-747: --- Fixing issues in the CSS parsing require the grammar file to be present. The linked issue tracks the transfer/recreation of the grammar file. > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0 >Reporter: Peter >Priority: Minor > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[
https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571930#comment-16571930
]
Jack J. Woehr commented on NETBEANS-747:
[~mcheung63] I also have experienced this.
The CSS editor does not recognize variable syntax
e.g.,
{code:java}
--about-burnishing-column-width:50%;{code}
is highlighted as an error as is
{code:java}
width: var(--about-burnishing-column-width);{code}
I think this syntax is simply missing from
css.editor/src/org/netbeans/modules/css/lib/nblexer
I'm looking at this and struggling to grasp the code :)
> CSS Editor does not recognize variable syntax
> -
>
> Key: NETBEANS-747
> URL: https://issues.apache.org/jira/browse/NETBEANS-747
> Project: NetBeans
> Issue Type: Bug
> Components: web - CSS Editor
>Affects Versions: 8.2
>Reporter: Peter
>Priority: Major
> Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png
>
>
> Netbeans reports my css has error but it should not
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
