[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976492#comment-14976492
]
ASF subversion and git services commented on NIFI-447:
--
Commit
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976493#comment-14976493
]
ASF subversion and git services commented on NIFI-447:
--
Commit
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975411#comment-14975411
]
Mark Payne commented on NIFI-447:
-
[~JPercivall] this patch won't apply against master. Can you do a rebase
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957725#comment-14957725
]
Mark Payne commented on NIFI-447:
-
[~mcgilman] - I'm not sure what you were looking at, but I certainly do
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14950319#comment-14950319
]
Matt Gilman commented on NIFI-447:
--
Just giving a quick review and noticed a few style issues... it appears
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949283#comment-14949283
]
Mark Payne commented on NIFI-447:
-
I replaced the existing patch because i found that ReplaceText was
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947972#comment-14947972
]
Joseph Percivall commented on NIFI-447:
---
Whops sorry Michael
[~markap14] Ah that's a good catch with
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730952#comment-14730952
]
Mark Payne commented on NIFI-447:
-
[~JPercivall]: I would say yes, it makes sense. Good catch.
> Add
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730944#comment-14730944
]
Joseph Percivall commented on NIFI-447:
---
I'm working on this now.
Should the literal replace have a
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731233#comment-14731233
]
Joseph Percivall commented on NIFI-447:
---
[~markap14]: Why shouldn't we have linewise options for
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731240#comment-14731240
]
Mark Payne commented on NIFI-447:
-
I can't argue that we shouldn't. Though if we are going to allow it for
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731330#comment-14731330
]
Mark Payne commented on NIFI-447:
-
Agreed. That's the route that I would take.
> Add "Replacement Strategy"
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731248#comment-14731248
]
Joseph Percivall commented on NIFI-447:
---
Yup, that's exactly what I was thinking
> Add "Replacement
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731563#comment-14731563
]
Joseph Percivall commented on NIFI-447:
---
I created an initial patch. I wasn't sure of all the test
14 matches
Mail list logo