[GitHub] [incubator-nuttx] yamt commented on pull request #3551: esp32: module related fixes

2021-04-14 Thread GitBox
yamt commented on pull request #3551: URL: https://github.com/apache/incubator-nuttx/pull/3551#issuecomment-820156336 i guess i need to drop CONFIG_ESP32_QEMU_IMAGE from configs to pass the gate. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-nuttx] yamt commented on pull request #3549: modlib: Always use separate allocation for text and data

2021-04-14 Thread GitBox
yamt commented on pull request #3549: URL: https://github.com/apache/incubator-nuttx/pull/3549#issuecomment-820136501 it seems that i need to update CONFIG_BUILD_PROTECTED case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] yamt opened a new pull request #3551: esp32: module related fixes

2021-04-14 Thread GitBox
yamt opened a new pull request #3551: URL: https://github.com/apache/incubator-nuttx/pull/3551 ## Summary Fix a few issues I noticed when testing today's master. ## Impact esp32 CONFIG_MODULE ## Testing tested on a devkit-c board. -- This is an automated message

[GitHub] [incubator-nuttx] ocramlhark opened a new pull request #3550: 1wire: Removes duplicate device information

2021-04-14 Thread GitBox
ocramlhark opened a new pull request #3550: URL: https://github.com/apache/incubator-nuttx/pull/3550 ## Summary Removes the family identifier from the device configuration, since the device family is already part of the rom code and the underlying logic does know how to extract this

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-820047481 Sure, thanks for helping. Let's wait your result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
masayuki2009 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-820032116 > @masayuki2009 thanks for testing on the different board. Does lc823450-xgevk:rndis pass the test before applying the patch? @xiaoxiang781216 Yes. Th

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3549: modlib: Always use separate allocation for text and data

2021-04-14 Thread GitBox
xiaoxiang781216 edited a comment on pull request #3549: URL: https://github.com/apache/incubator-nuttx/pull/3549#issuecomment-820031379 Yes, the size will increase a little bit(less 16 bytes)? But, we have more chance to load ELF sucessfully in the fragment case. -- This is an automated

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3549: modlib: Always use separate allocation for text and data

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #3549: URL: https://github.com/apache/incubator-nuttx/pull/3549#issuecomment-820031379 Thanks, yes, the size will increase a little bit(less 16 bytes)? But, we have more chance to load ELF sucessfully in the fragment case. -- This is an automated

[GitHub] [incubator-nuttx] yamt opened a new pull request #3549: modlib: Always use separate allocation for text and data

2021-04-14 Thread GitBox
yamt opened a new pull request #3549: URL: https://github.com/apache/incubator-nuttx/pull/3549 ## Summary modlib: Always use separate allocation for text and data Pros: * Reduce code differences * Smaller allocations for !CONFIG_ARCH_USE_MODULE_TEXT Cons:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2064: include/sys/types.h: Warn on unexpected __WCHAR_WIDTH__

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #2064: URL: https://github.com/apache/incubator-nuttx/pull/2064#issuecomment-820023028 Yes, I think so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] yamt commented on pull request #2064: include/sys/types.h: Warn on unexpected __WCHAR_WIDTH__

2021-04-14 Thread GitBox
yamt commented on pull request #2064: URL: https://github.com/apache/incubator-nuttx/pull/2064#issuecomment-820022832 @xiaoxiang781216 yes. it passes the ci just because it uses -Wno-cpp. i guess i should make this to #error and try to fix fallouts. -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2064: include/sys/types.h: Warn on unexpected __WCHAR_WIDTH__

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #2064: URL: https://github.com/apache/incubator-nuttx/pull/2064#issuecomment-820021780 Oh, no it seem that Linux(arm-08) still has the warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx] yamt commented on issue #3548: binfmt/libelf should honor sh_addralign

2021-04-14 Thread GitBox
yamt commented on issue #3548: URL: https://github.com/apache/incubator-nuttx/issues/3548#issuecomment-820021711 @xiaoxiang781216 why? libelf needs a similar fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2064: include/sys/types.h: Warn on unexpected __WCHAR_WIDTH__

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #2064: URL: https://github.com/apache/incubator-nuttx/pull/2064#issuecomment-820021187 The change pass all CI, Is it ready for merge, @yamt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #3455: Use CMake

2021-04-14 Thread GitBox
xiaoxiang781216 commented on issue #3455: URL: https://github.com/apache/incubator-nuttx/issues/3455#issuecomment-820020555 Nice! I expect that many known issues will be resolved by migrating to CMake: 1. Support more host 2. Out of tree build 3. Fast build speed 4. Remove t

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #3548: binfmt/libelf should honor sh_addralign

2021-04-14 Thread GitBox
xiaoxiang781216 closed issue #3548: URL: https://github.com/apache/incubator-nuttx/issues/3548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #3548: binfmt/libelf should honor sh_addralign

2021-04-14 Thread GitBox
xiaoxiang781216 commented on issue #3548: URL: https://github.com/apache/incubator-nuttx/issues/3548#issuecomment-820017686 Let's close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-820015894 @masayuki2009 thanks for testing on the different board. Does lc823450-xgevk:rndis pass the test before applying the patch? -- This is an automated message fro

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#discussion_r613718196 ## File path: arch/avr/src/avr/up_createstack.c ## @@ -86,10 +86,6 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uin

[GitHub] [incubator-nuttx] yamt opened a new issue #3548: binfmt/libelf should honor sh_addralign

2021-04-14 Thread GitBox
yamt opened a new issue #3548: URL: https://github.com/apache/incubator-nuttx/issues/3548 the corresponding change in modlib: https://github.com/apache/incubator-nuttx/pull/3546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
xiaoxiang781216 merged pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[incubator-nuttx] branch master updated (7813b4f -> 51490ba)

2021-04-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7813b4f Refreshing default configs add 51490ba modlib: Implement sh_addralign handling No new rev

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613710639 ## File path: libs/libc/modlib/modlib_load.c ## @@ -271,16 +293,29 @@ int modlib_load(FAR struct mod_loadinfo_s *loadinfo) }

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
masayuki2009 edited a comment on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819929100 I checked the following configurations and found that the ostest with lc823450-xgevk failed. I will look into the issue later. qemu-i486:nsh -> OK

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
masayuki2009 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819929100 I checked the following configurations and found that the ostest with lc823450-xgevk failed. I will look into the issue later. qemu-i486:nsh -> OK qemu-

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
yamt commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613649367 ## File path: libs/libc/modlib/modlib_load.c ## @@ -271,16 +293,29 @@ int modlib_load(FAR struct mod_loadinfo_s *loadinfo) } } #else -

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
yamt commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613648726 ## File path: include/nuttx/lib/modlib.h ## @@ -198,6 +198,8 @@ struct mod_loadinfo_s uintptr_t datastart; /* Start of.bss/.data memory

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
Ouss4 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819894811 I rebased the internal branch earlier today and the tests passed as well. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-nuttx] davids5 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
davids5 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819894606 @patacongo Sqush was done > can we all test this on as many arches' real HW before merging? I want to run it on some real HW , but I am in the I am in the m

[GitHub] [incubator-nuttx] patacongo commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
patacongo commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819892298 What is the status of the PR? I approved it a couple of days ago. Looking over the comments it looks like we are now waiting for @Ouss4 to complete some testing. Is

[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support

2021-04-14 Thread GitBox
davids5 commented on pull request #3462: URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819874797 @jturnsek - Thank you for the contribution, and sticking with it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-nuttx] 05/11: Fixed comment lengths

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 2f92ecc7d62fd7f098a40e9a4883541d18783822 Author: jturnsek AuthorDate: Wed Apr 7 09:05:30 2021 +0200 Fixed

[incubator-nuttx] 08/11: Removing MMCEN pin setting from LPSPI1

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e32d18673974fd7502b9746a02d80d9b563e8df4 Author: jturnsek AuthorDate: Mon Apr 12 14:09:28 2021 +0200 Remo

[incubator-nuttx] 10/11: Default config without flexspi and mtd

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 61b0e530b0571c6050ed571e0e316b1a0be8966f Author: jturnsek AuthorDate: Tue Apr 13 19:36:50 2021 +0200 Defa

[incubator-nuttx] 02/11: Removing some none existing configurations from the default

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4e50ba14e847c416c2f8a0bd4661e8be15c6073d Author: jturnsek AuthorDate: Wed Apr 7 07:46:32 2021 +0200 Remov

[incubator-nuttx] 04/11: Removing some none existing initialization.

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a4857d78b96bc816e0af481916c5077598ad4a3b Author: jturnsek AuthorDate: Wed Apr 7 08:26:32 2021 +0200 Remov

[incubator-nuttx] 03/11: Change ALL copyright from Greg and David to apache since they already sign SGA or ICLA

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit f5d22ccd032e5586e0a304b786128c9c0e35e640 Author: jturnsek AuthorDate: Wed Apr 7 08:23:55 2021 +0200 Chang

[incubator-nuttx] branch master updated (0030c20 -> 7813b4f)

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0030c20 boards/esp32-wrover-kit: Remove deprecated README documentation new 33b071e MIMXRT1064-EVK

[incubator-nuttx] 07/11: FlexSPI NOR missing config and pin iomux

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e250006b1e7b8c497a009f0cf5fe87d7c8f82cae Author: jturnsek AuthorDate: Mon Apr 12 09:50:47 2021 +0200 Flex

[incubator-nuttx] 11/11: Refreshing default configs

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7813b4f88afc4b5be6c78733d9cf20392a701125 Author: jturnsek AuthorDate: Wed Apr 14 20:26:21 2021 +0200 Refr

[incubator-nuttx] 09/11: Copy .ARM.exidx together with .text to make linker happy

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit c12ccfc80b4ab64489f8fa523e127ca77bf47df4 Author: jturnsek AuthorDate: Tue Apr 13 08:18:32 2021 +0200 Copy

[GitHub] [incubator-nuttx] davids5 merged pull request #3462: MIMXRT1064-EVK support

2021-04-14 Thread GitBox
davids5 merged pull request #3462: URL: https://github.com/apache/incubator-nuttx/pull/3462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[incubator-nuttx] 06/11: FlexSPI NOR driver added

2021-04-14 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 0c4d66dcf07f0b8e32508dc425c8804f6659ca6e Author: jturnsek AuthorDate: Mon Apr 12 09:12:16 2021 +0200 Flex

[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support

2021-04-14 Thread GitBox
jturnsek commented on pull request #3462: URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819783194 @davids5 CI checks successful. Thank you very much. It has been a good day:) -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-nuttx] acassis merged pull request #3538: ESP-WROVER-KIT: LCD support via both FB and LCD chardev

2021-04-14 Thread GitBox
acassis merged pull request #3538: URL: https://github.com/apache/incubator-nuttx/pull/3538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[incubator-nuttx] branch master updated (9d5ed6e -> 0030c20)

2021-04-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9d5ed6e Documentation: Add FAQ entry add 71f9aca boards/esp32: Refactor SPI hooks to be shared among

[incubator-nuttx] branch master updated: Documentation: Add FAQ entry

2021-04-14 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9d5ed6e Documentation: Add FAQ entr

[GitHub] [incubator-nuttx] v01d merged pull request #3547: Documentation: Add FAQ entry

2021-04-14 Thread GitBox
v01d merged pull request #3547: URL: https://github.com/apache/incubator-nuttx/pull/3547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3547: Documentation: Add FAQ entry

2021-04-14 Thread GitBox
acassis commented on a change in pull request #3547: URL: https://github.com/apache/incubator-nuttx/pull/3547#discussion_r613460948 ## File path: Documentation/index.rst ## @@ -27,6 +27,7 @@ Last Updated: |today| components/index.rst applications/index.rst reference

[GitHub] [incubator-nuttx] v01d commented on issue #3455: Use CMake

2021-04-14 Thread GitBox
v01d commented on issue #3455: URL: https://github.com/apache/incubator-nuttx/issues/3455#issuecomment-819677105 Given the positive feedback so far I decided to start building the POC in the hopes that this helps move the decision forward. I'm basing my work on @dagar 's `pr-cmake_maste

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #3547: Documentation: Add FAQ entry

2021-04-14 Thread GitBox
v01d commented on a change in pull request #3547: URL: https://github.com/apache/incubator-nuttx/pull/3547#discussion_r613419457 ## File path: Documentation/index.rst ## @@ -27,6 +27,7 @@ Last Updated: |today| components/index.rst applications/index.rst reference/in

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #3547: Documentation: Add FAQ entry

2021-04-14 Thread GitBox
v01d commented on a change in pull request #3547: URL: https://github.com/apache/incubator-nuttx/pull/3547#discussion_r613418418 ## File path: Documentation/faq.rst ## @@ -0,0 +1,35 @@ +.. todo:: + Create new subsections as needed. + +=== +FAQ +=== + +NSH Tricks +== +

[GitHub] [incubator-nuttx] acassis opened a new pull request #3547: Documentation: Add FAQ entry

2021-04-14 Thread GitBox
acassis opened a new pull request #3547: URL: https://github.com/apache/incubator-nuttx/pull/3547 ## Summary Add FAQ entry to Documentation ## Impact User will get a FAQ in the Documentation ## Testing N/A -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2377: [DRAFT] STM32: Add TIM register mappings for STM32G47xxx family

2021-04-14 Thread GitBox
hartmannathan commented on pull request #2377: URL: https://github.com/apache/incubator-nuttx/pull/2377#issuecomment-819584339 Finally closing this pull request! @raiden00pl completed this work and integrated it in PR #3544. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] hartmannathan closed pull request #2377: [DRAFT] STM32: Add TIM register mappings for STM32G47xxx family

2021-04-14 Thread GitBox
hartmannathan closed pull request #2377: URL: https://github.com/apache/incubator-nuttx/pull/2377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [incubator-nuttx] hartmannathan merged pull request #3544: stm32: use TIMERS_V3 definitions for STM32G4

2021-04-14 Thread GitBox
hartmannathan merged pull request #3544: URL: https://github.com/apache/incubator-nuttx/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[incubator-nuttx] 03/03: stm32: include support for TIMERS_V3

2021-04-14 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit ad8c09d0a1ae14dcbae7dd3167d1ae77f3718d4b Author: raiden00pl AuthorDate: Wed Apr 14 09:29:57 2021 +0200

[incubator-nuttx] branch master updated (d199941 -> ad8c09d)

2021-04-14 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d199941 nucleo-g431rb: add ADC example new 6d69600 stm32/Kconfig: move configuration common fo

[incubator-nuttx] 01/03: stm32/Kconfig: move configuration common for G4 under STM32_STM32G4XXX option

2021-04-14 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 6d69600905871ee2023a91b5ed18bd8f0fe1bdad Author: raiden00pl AuthorDate: Wed Apr 14 08:03:48 2021 +0200

[incubator-nuttx] 02/03: stm32: add definitions for TIMERS_V3. All credit goes to Nathan Hartman (hartmannathan)

2021-04-14 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7c11397469b24bc1d9925deee702a68a456cbfdc Author: raiden00pl AuthorDate: Wed Apr 14 09:15:18 2021 +0200

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#discussion_r613244799 ## File path: arch/arm/src/common/arm_usestack.c ## @@ -127,37 +117,17 @@ int up_use_stack(struct tcb_s *tcb, void *stack, size_t stack_s

[GitHub] [incubator-nuttx] v01d commented on pull request #3543: feat(esp32c3): Support esp32c3 ble function

2021-04-14 Thread GitBox
v01d commented on pull request #3543: URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-819498211 > I've highlighted mostly styling issues and some questions about implementation. > I also think that creating a virtual serial port is incorrect, you should be exposing

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
davids5 commented on a change in pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#discussion_r613195609 ## File path: arch/arm/src/common/arm_usestack.c ## @@ -127,37 +117,17 @@ int up_use_stack(struct tcb_s *tcb, void *stack, size_t stack_size)

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 edited a comment on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819464216 > @xiaoxiang781216 - Is it time to squash or do the docs need to updated too? Once squashed, can we all test this on as many arches' real HW before mergin

[GitHub] [incubator-nuttx] jturnsek commented on pull request #3462: MIMXRT1064-EVK support

2021-04-14 Thread GitBox
jturnsek commented on pull request #3462: URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819468242 @davids5 OK, will do that this evening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819464216 > @xiaoxiang781216 - Is it time to squash or do the docs need to updated too? Once squashed, can we all test this on as many arches' real HW before merging?

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#discussion_r613180679 ## File path: arch/arm/src/common/arm_usestack.c ## @@ -127,37 +117,17 @@ int up_use_stack(struct tcb_s *tcb, void *stack, size_t stack_s

[GitHub] [incubator-nuttx] davids5 commented on pull request #3462: MIMXRT1064-EVK support

2021-04-14 Thread GitBox
davids5 commented on pull request #3462: URL: https://github.com/apache/incubator-nuttx/pull/3462#issuecomment-819456263 @jturnsek - I had a look I think that you need to rebase on master and run https://github.com/apache/incubator-nuttx/blob/master/tools/refresh.sh or `make oldconfig` and

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
yamt commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613169452 ## File path: include/nuttx/lib/modlib.h ## @@ -198,6 +198,8 @@ struct mod_loadinfo_s uintptr_t datastart; /* Start of.bss/.data memory

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
yamt commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613168335 ## File path: libs/libc/modlib/modlib_load.c ## @@ -271,16 +293,29 @@ int modlib_load(FAR struct mod_loadinfo_s *loadinfo) } } #else -

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
yamt commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613166785 ## File path: libs/libc/modlib/modlib_load.c ## @@ -271,16 +293,29 @@ int modlib_load(FAR struct mod_loadinfo_s *loadinfo) } } #else -

[GitHub] [incubator-nuttx] davids5 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
davids5 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-819447362 @xiaoxiang781216 - Is it time to squash or do the docs need to updated too? Once squashed, can we all test this on as many arches' real HW before merging? -- This is a

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

2021-04-14 Thread GitBox
davids5 commented on a change in pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#discussion_r613162096 ## File path: arch/arm/src/common/arm_usestack.c ## @@ -127,37 +117,17 @@ int up_use_stack(struct tcb_s *tcb, void *stack, size_t stack_size)

[GitHub] [incubator-nuttx] davids5 commented on pull request #3532: stm32g4xx: add support for PWM

2021-04-14 Thread GitBox
davids5 commented on pull request #3532: URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819434722 see https://github.com/apache/incubator-nuttx/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-nuttx] branch master updated: nucleo-g431rb: add ADC example

2021-04-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d199941 nucleo-g431rb: add ADC exam

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613112170 ## File path: include/nuttx/lib/modlib.h ## @@ -198,6 +198,8 @@ struct mod_loadinfo_s uintptr_t datastart; /* Start of.bss/.d

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3545: nucleo-g431rb: add ADC example

2021-04-14 Thread GitBox
xiaoxiang781216 merged pull request #3545: URL: https://github.com/apache/incubator-nuttx/pull/3545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546#discussion_r613105669 ## File path: libs/libc/modlib/modlib_load.c ## @@ -271,16 +293,29 @@ int modlib_load(FAR struct mod_loadinfo_s *loadinfo) }

[GitHub] [incubator-nuttx] yamt opened a new pull request #3546: modlib: Implement sh_addralign handling

2021-04-14 Thread GitBox
yamt opened a new pull request #3546: URL: https://github.com/apache/incubator-nuttx/pull/3546 ## Summary I've seen a module with 16 bytes .rodata alignment for xmm operations. It was getting SEGV on sim/Linux because of the alignment issue. ## Impact CONFIG_MODULE ##

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3544: stm32: use TIMERS_V3 definitions for STM32G4

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #3544: URL: https://github.com/apache/incubator-nuttx/pull/3544#issuecomment-819325774 @hartmannathan please review the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3545: nucleo-g431rb: add ADC example

2021-04-14 Thread GitBox
raiden00pl opened a new pull request #3545: URL: https://github.com/apache/incubator-nuttx/pull/3545 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3544: stm32: use TIMERS_V3 definitions for STM32G4

2021-04-14 Thread GitBox
raiden00pl opened a new pull request #3544: URL: https://github.com/apache/incubator-nuttx/pull/3544 ## Summary Use TIMERS_V3 definitons for STM32G4. **All credit for TIMERS_V3 definitions goes to Nathan Hartman (@hartmannathan)** ## Impact ## Testing --

[incubator-nuttx] branch master updated (099980e -> aea0135)

2021-04-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 099980e Support different hardware version of Wi-Fi add-on board (iS110B) add c726dac nuttx/1wire

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3487: Adds common master bus interface and implementation for onewire support

2021-04-14 Thread GitBox
xiaoxiang781216 merged pull request #3487: URL: https://github.com/apache/incubator-nuttx/pull/3487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3487: Adds common master bus interface and implementation for onewire support

2021-04-14 Thread GitBox
xiaoxiang781216 commented on pull request #3487: URL: https://github.com/apache/incubator-nuttx/pull/3487#issuecomment-819308985 > Mmh ... I think there is something wrong either with Kconfig, make savedefconfig, or with the build system. I disabled the following commands in the new board

[GitHub] [incubator-nuttx] Marco-Krahl commented on pull request #3487: Adds common master bus interface and implementation for onewire support

2021-04-14 Thread GitBox
Marco-Krahl commented on pull request #3487: URL: https://github.com/apache/incubator-nuttx/pull/3487#issuecomment-819293346 Mmh ... I think there is something wrong either with Kconfig, make savedefconfig, or with the build system. I disabled the following commands in the new board config

[GitHub] [incubator-nuttx] fujitatomoya commented on issue #3537: [cxd56xx] Not support hardware version v1.0B/v1.0C of WIFI board (iS110B)

2021-04-14 Thread GitBox
fujitatomoya commented on issue #3537: URL: https://github.com/apache/incubator-nuttx/issues/3537#issuecomment-819291336 @masayuki2009 thanks for quick response, appreciate that 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[incubator-nuttx] branch master updated (f467a74 -> 099980e)

2021-04-14 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from f467a74 nucleo-g431rb: add PWM example add 099980e Support different hardware version of Wi-Fi add-

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #3537: [cxd56xx] Not support hardware version v1.0B/v1.0C of WIFI board (iS110B)

2021-04-14 Thread GitBox
masayuki2009 commented on issue #3537: URL: https://github.com/apache/incubator-nuttx/issues/3537#issuecomment-819286515 >I have created PR #3542. The PR has been merged. Let me close this issue. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] masayuki2009 closed issue #3537: [cxd56xx] Not support hardware version v1.0B/v1.0C of WIFI board (iS110B)

2021-04-14 Thread GitBox
masayuki2009 closed issue #3537: URL: https://github.com/apache/incubator-nuttx/issues/3537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #3532: stm32g4xx: add support for PWM

2021-04-14 Thread GitBox
raiden00pl commented on pull request #3532: URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819286182 After some work on this I see that separating the definition to a new file will be better. Merge this to existing TIMERS_V2 causes too much mess and complexity --

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #3542: Support different hardware version of Wi-Fi add-on board (iS110B)

2021-04-14 Thread GitBox
masayuki2009 merged pull request #3542: URL: https://github.com/apache/incubator-nuttx/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3542: Support different hardware version of Wi-Fi add-on board (iS110B)

2021-04-14 Thread GitBox
masayuki2009 commented on pull request #3542: URL: https://github.com/apache/incubator-nuttx/pull/3542#issuecomment-819285609 @Barry-Xu-2018 @fujitatomoya Thanks for the PR. I confirmed that this PR works with the v1.0A board. -- This is an automated message from the Apache