[GitHub] [incubator-nuttx] iceaway opened a new pull request #4576: userleds: add missing include (stdbool.h)

2021-09-19 Thread GitBox
iceaway opened a new pull request #4576: URL: https://github.com/apache/incubator-nuttx/pull/4576 ## Summary My code would not compile when configured for userleds, unless I included stdbool.h in userled.h ## Impact Makes userleds compile. ## Testing Tested on a stm32

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4433: net/devif/devif_callback.c: corrected the connection event list to work as FIFO instead of LIFO

2021-09-19 Thread GitBox
a-lunev commented on a change in pull request #4433: URL: https://github.com/apache/incubator-nuttx/pull/4433#discussion_r711845368 ## File path: net/devif/devif_callback.c ## @@ -267,7 +283,7 @@ FAR struct devif_callback_s * { /* No.. release the ca

[GitHub] [incubator-nuttx] a-lunev commented on pull request #4575: net/devif: Simplify the logic in the error path of devif_callback_alloc

2021-09-19 Thread GitBox
a-lunev commented on pull request #4575: URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-922597930 @xiaoxiang781216 I tried to find if changing dev->d_flags is synchronized to net_lock() anywhere. It looks like dev->d_flags can be modified (e.g. by psock_ioctl()) asyn

[incubator-nuttx-website] branch asf-site updated: Publishing web: ea6fce84bf8202600a0318215864afe272c81f07 docs: b42d2a72847914f02a94da48dde99db2e22cff70

2021-09-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5529789 Publishing web

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4543: esp32: Use device specific lock as much as possible.

2021-09-19 Thread GitBox
Ouss4 commented on pull request #4543: URL: https://github.com/apache/incubator-nuttx/pull/4543#issuecomment-922547779 @masayuki2009 I'm seeing an issue with this defconfig with ESP32_WIFI_SAVE_PARAM enabled, which is also present in the master branch. I'll be taking a look tomorrow morni

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4543: esp32: Use device specific lock as much as possible.

2021-09-19 Thread GitBox
Ouss4 commented on pull request #4543: URL: https://github.com/apache/incubator-nuttx/pull/4543#issuecomment-922543079 > It looks good to me but esp32-devkitc:wapi_smp caused a deadlock when booting. It did? I tested that defconfig multiple times. Let me try once again. -- This

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4543: esp32: Use device specific lock as much as possible.

2021-09-19 Thread GitBox
masayuki2009 commented on pull request #4543: URL: https://github.com/apache/incubator-nuttx/pull/4543#issuecomment-922539677 @Ouss4 It looks good to me but esp32-devkitc:wapi_smp caused a deadlock when booting. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] hartmannathan merged pull request #4572: fix: nxstyle: detect --,->,++ not next to operand

2021-09-19 Thread GitBox
hartmannathan merged pull request #4572: URL: https://github.com/apache/incubator-nuttx/pull/4572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated: fix: nxstyle: detect --, ->, ++ not next to operand

2021-09-19 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new b42d2a7 fix: nxstyle: detect --

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4433: net/devif/devif_callback.c: corrected the connection event list to work as FIFO instead of LIFO

2021-09-19 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4433: URL: https://github.com/apache/incubator-nuttx/pull/4433#discussion_r711750254 ## File path: net/devif/devif_callback.c ## @@ -267,7 +283,7 @@ FAR struct devif_callback_s * { /* No.. releas

[GitHub] [incubator-nuttx] jerpelea commented on pull request #4571: Correct a few license headers under net/

2021-09-19 Thread GitBox
jerpelea commented on pull request #4571: URL: https://github.com/apache/incubator-nuttx/pull/4571#issuecomment-922470729 LGTM @patacongo Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4543: esp32: Use device specific lock as much as possible.

2021-09-19 Thread GitBox
Ouss4 commented on pull request #4543: URL: https://github.com/apache/incubator-nuttx/pull/4543#issuecomment-922446033 @masayuki2009 can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4433: net/devif/devif_callback.c: corrected the connection event list to work as FIFO instead of LIFO

2021-09-19 Thread GitBox
a-lunev commented on a change in pull request #4433: URL: https://github.com/apache/incubator-nuttx/pull/4433#discussion_r711709912 ## File path: net/devif/devif_callback.c ## @@ -267,7 +283,7 @@ FAR struct devif_callback_s * { /* No.. release the ca