[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r876588020 ## arch/z80/include/irq.h: ## @@ -32,4 +32,55 @@ #include #include +#ifndef __ASSEMBLY__ +# include +# include "chip/switch.h" +#endif +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r876483360 ## arch/z80/include/irq.h: ## @@ -32,4 +32,55 @@ #include #include +#ifndef __ASSEMBLY__ +# include +# include "chip/switch.h" +#endif +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876477533 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876478088 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876477533 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876477533 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1b39f27b512cbb1fc294b70e0e70a67d0092b98d docs: 517f179f8d7960836e339d80e2e2b92384ede78c

2022-05-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e948c09 Publishing

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6298: arch/arm/samv7: Fix PWM operation for single channel mode

2022-05-18 Thread GitBox
pkarashchenko opened a new pull request, #6298: URL: https://github.com/apache/incubator-nuttx/pull/6298 ## Summary Fix PWM operation for single channel mode The current SAMv7 PWM driver assumes that all PWM channels should work in sync mode, but that is a partial case of a

[GitHub] [incubator-nuttx-website] dependabot[bot] closed pull request #64: Bump nokogiri from 1.10.7 to 1.13.4

2022-05-18 Thread GitBox
dependabot[bot] closed pull request #64: Bump nokogiri from 1.10.7 to 1.13.4 URL: https://github.com/apache/incubator-nuttx-website/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx-website] dependabot[bot] commented on pull request #64: Bump nokogiri from 1.10.7 to 1.13.4

2022-05-18 Thread GitBox
dependabot[bot] commented on PR #64: URL: https://github.com/apache/incubator-nuttx-website/pull/64#issuecomment-1130724943 Superseded by #65. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx-website] dependabot[bot] opened a new pull request, #65: Bump nokogiri from 1.10.7 to 1.13.6

2022-05-18 Thread GitBox
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/incubator-nuttx-website/pull/65 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.7 to 1.13.6. Release notes Sourced from

[incubator-nuttx-website] branch dependabot/bundler/nokogiri-1.13.6 created (now 5efad08)

2022-05-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/bundler/nokogiri-1.13.6 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git at 5efad08 Bump nokogiri from 1.10.7 to 1.13.6 No new revisions were

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6295: URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r876426419 ## arch/arm/src/samv7/sam_progmem.c: ## @@ -202,9 +202,9 @@ void sam_progmem_initialize(void) { uint32_t regval; - /* Set flash access mode to

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6295: URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r876426419 ## arch/arm/src/samv7/sam_progmem.c: ## @@ -202,9 +202,9 @@ void sam_progmem_initialize(void) { uint32_t regval; - /* Set flash access mode to

[GitHub] [incubator-nuttx] jlaitine commented on a diff in pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
jlaitine commented on code in PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#discussion_r876253507 ## arch/arm/src/stm32h7/stm32h7x3xx_rcc.c: ## @@ -144,10 +148,6 @@ static inline void rcc_reset(void) RCC_CR_PLL2ON | RCC_CR_PLL3ON |

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r876247089 ## arch/avr/include/irq.h: ## @@ -55,27 +60,73 @@ * Public Types /

[incubator-nuttx] branch master updated: stm32h7: Adds the ability to choose the HSI divider, which must be indicated in board.h if used.

2022-05-18 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 517f179f8d stm32h7: Adds the ability

[GitHub] [incubator-nuttx] davids5 merged pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
davids5 merged PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
gustavonihei commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876240198 ## include/nuttx/mutex.h: ## @@ -42,6 +44,13 @@ typedef sem_t mutex_t; +typedef struct +{ + mutex_t mutex; + pid_t holder; + uint16_t count; +}

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
xiaoxiang781216 commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r876224950 ## arch/z80/include/irq.h: ## @@ -32,4 +32,55 @@ #include #include +#ifndef __ASSEMBLY__ +# include +# include "chip/switch.h" +#endif +

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r876218398 ## arch/z80/include/irq.h: ## @@ -32,4 +32,55 @@ #include #include +#ifndef __ASSEMBLY__ +# include +# include "chip/switch.h" +#endif +

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r876205387 ## arch/arm/include/irq.h: ## @@ -29,6 +29,12 @@ * Included Files / +#include

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6297: net/tcp: Zero keeptimer in case caller set keepalive to false

2022-05-18 Thread GitBox
xiaoxiang781216 opened a new pull request, #6297: URL: https://github.com/apache/incubator-nuttx/pull/6297 ## Summary Make the logic in https://github.com/apache/incubator-nuttx/pull/6290 more correct. ## Impact Shouldn't since nobody use keeptimer and keepretries when

[incubator-nuttx] branch master updated: RISC-V: add C++ support to crt0

2022-05-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 12476e1f43 RISC-V: add C++ support

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6235: RISC-V: add C++ support to crt0

2022-05-18 Thread GitBox
xiaoxiang781216 merged PR #6235: URL: https://github.com/apache/incubator-nuttx/pull/6235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6235: RISC-V: add C++ support to crt0

2022-05-18 Thread GitBox
xiaoxiang781216 commented on PR #6235: URL: https://github.com/apache/incubator-nuttx/pull/6235#issuecomment-1130295783 > @xiaoxiang781216 I do not have any comments. Pleas merge if your questions are addressed No, let's merge this patch first. I am preparing patch to unify c++

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6296: sched/wqueue: Add work_timeleft macro to get the left time to start

2022-05-18 Thread GitBox
xiaoxiang781216 opened a new pull request, #6296: URL: https://github.com/apache/incubator-nuttx/pull/6296 ## Summary - sched/wdog: Change the return type of wd_gettime from int to sclock_t ## Impact new API ## Testing Pass CI -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
xiaoxiang781216 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876096009 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
xiaoxiang781216 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r876092239 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-05-18 Thread GitBox
pkarashchenko commented on PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#issuecomment-1130216201 Will review later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[incubator-nuttx] branch master updated (d8b97d7ae8 -> b71a1f77c3)

2022-05-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from d8b97d7ae8 net/tcp: Use the relative value for keep alive timer add b71a1f77c3 xtensa: add perf

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6294: xtensa: add perf counter

2022-05-18 Thread GitBox
pkarashchenko merged PR #6294: URL: https://github.com/apache/incubator-nuttx/pull/6294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (aefe78a884 -> d8b97d7ae8)

2022-05-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from aefe78a884 xtensa: Add missing input operand on sys_call6 inline ASM add 2d3ee157ce net/tcp: Use

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2

2022-05-18 Thread GitBox
pkarashchenko merged PR #6290: URL: https://github.com/apache/incubator-nuttx/pull/6290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2

2022-05-18 Thread GitBox
xiaoxiang781216 commented on code in PR #6290: URL: https://github.com/apache/incubator-nuttx/pull/6290#discussion_r876049735 ## net/tcp/tcp_timer.c: ## @@ -470,7 +452,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn, #endif

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5931: fix: pthread_rwlock_timedwrlock.

2022-05-18 Thread GitBox
xiaoxiang781216 commented on PR #5931: URL: https://github.com/apache/incubator-nuttx/pull/5931#issuecomment-1130171732 @pkarashchenko could you review again? The change look good for me now. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6295: URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r876030507 ## arch/arm/src/samv7/sam_progmem.c: ## @@ -202,9 +202,9 @@ void sam_progmem_initialize(void) { uint32_t regval; - /* Set flash access mode to

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write

2022-05-18 Thread GitBox
acassis commented on code in PR #6295: URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r875999235 ## arch/arm/src/samv7/sam_progmem.c: ## @@ -202,9 +202,9 @@ void sam_progmem_initialize(void) { uint32_t regval; - /* Set flash access mode to 128bit and

[GitHub] [incubator-nuttx] jerpelea commented on pull request #6280: drivers: video: add ISX019 camera driver

2022-05-18 Thread GitBox
jerpelea commented on PR #6280: URL: https://github.com/apache/incubator-nuttx/pull/6280#issuecomment-1130116133 @pkarashchenko done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6295: arch/arm/samv7: fix sporadic bit flip after internal flash byte write

2022-05-18 Thread GitBox
pkarashchenko opened a new pull request, #6295: URL: https://github.com/apache/incubator-nuttx/pull/6295 ## Summary Fix sporadic bit flip after internal flash byte write ## Impact Improve progmem write for SAMv7 based devices ## Testing Verified with custom SAMe70

[incubator-nuttx] branch master updated (b30e0a26ef -> aefe78a884)

2022-05-18 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from b30e0a26ef Move "-nostartfiles -nodefaultlibs" from Make.defs to Toolchian.defs add aefe78a884

[GitHub] [incubator-nuttx] Ouss4 merged pull request #6293: Xtensa: Add missing input operand on sys_call6 inline ASM

2022-05-18 Thread GitBox
Ouss4 merged PR #6293: URL: https://github.com/apache/incubator-nuttx/pull/6293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request, #6294: xtensa: add perf counter

2022-05-18 Thread GitBox
zhuyanlinzyl opened a new pull request, #6294: URL: https://github.com/apache/incubator-nuttx/pull/6294 Signed-off-by: zhuyanlin ## Summary Xtensa performance timer. lower API is xtensa_count same with arm_perf.c ## Impact No . add new feature. ##

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r875859659 ## arch/arm/include/irq.h: ## @@ -29,6 +29,12 @@ * Included Files /

[GitHub] [incubator-nuttx] slorquet commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
slorquet commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129958319 Sure, will update that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] anjiahao1 commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
anjiahao1 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875840077 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875839220 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875835351 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
hartmannathan commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129951492 I think there is an error in the log message: "This commit adds the ability to choose the **HSE** divider, which must be indicated in board.h ." (Emphasis

[GitHub] [incubator-nuttx] anjiahao1 commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
anjiahao1 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875834682 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875835351 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] anjiahao1 commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
anjiahao1 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875834682 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] anjiahao1 commented on a diff in pull request #6279: include:add recursive lock

2022-05-18 Thread GitBox
anjiahao1 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r875831904 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); }

[GitHub] [incubator-nuttx] hartmannathan merged pull request #6276: Move "-nostartfiles -nodefaultlibs" from Make.defs to Toolchian.defs

2022-05-18 Thread GitBox
hartmannathan merged PR #6276: URL: https://github.com/apache/incubator-nuttx/pull/6276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated: Move "-nostartfiles -nodefaultlibs" from Make.defs to Toolchian.defs

2022-05-18 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new b30e0a26ef Move "-nostartfiles

[GitHub] [incubator-nuttx] davids5 commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
davids5 commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129923090 Yes. Better safe then sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6276: Move "-nostartfiles -nodefaultlibs" from Make.defs to Toolchian.defs

2022-05-18 Thread GitBox
hartmannathan commented on PR #6276: URL: https://github.com/apache/incubator-nuttx/pull/6276#issuecomment-1129922713 @pkarashchenko I am build-testing now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] slorquet commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
slorquet commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129920124 I did not and I have no issue to restore the default setting in rcc_reset. Shall I proceed to restore this just now? -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] davids5 commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
davids5 commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129916671 @slorquet I have pinged Jukka on Slack, I looking at this in detail now: I just has a quick look at the Clock tree and the code more carefully. Thing make less sense now :(

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2

2022-05-18 Thread GitBox
gustavonihei commented on code in PR #6290: URL: https://github.com/apache/incubator-nuttx/pull/6290#discussion_r875786926 ## net/tcp/tcp_timer.c: ## @@ -470,7 +452,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn, #endif /*

[incubator-nuttx] branch master updated: risc-v/opensbi: Generalize the SBI variable handling in makefile

2022-05-18 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d7f7867f76 risc-v/opensbi:

[GitHub] [incubator-nuttx] gustavonihei merged pull request #6292: risc-v/opensbi: Generalize the SBI variable handling in makefile

2022-05-18 Thread GitBox
gustavonihei merged PR #6292: URL: https://github.com/apache/incubator-nuttx/pull/6292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request, #6293: Xtensa: Add missing input operand on sys_call6 inline ASM

2022-05-18 Thread GitBox
gustavonihei opened a new pull request, #6293: URL: https://github.com/apache/incubator-nuttx/pull/6293 ## Summary This PR intends to provide a fix to the `sys_call6` function, where the argument `parm6` is missing from the list of input operands of the inline ASM for the generation of

[GitHub] [incubator-nuttx] slorquet commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
slorquet commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129867992 When the CI first failed, I was surprised to encounter an attempt to set the HSI divider in a board that did not use HSI. I investigated and found that code in the

[GitHub] [incubator-nuttx] davids5 commented on pull request #6287: stm32h7: allow definition of HSI divider in board config

2022-05-18 Thread GitBox
davids5 commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129811800 @slorquet You are much closer to the "Problem" then I am at the moment. But I am wondering why @jlaitine placed the code where he did. Can you think of any reason that init was

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6235: RISC-V: add C++ support to crt0

2022-05-18 Thread GitBox
pkarashchenko commented on PR #6235: URL: https://github.com/apache/incubator-nuttx/pull/6235#issuecomment-1129750093 @xiaoxiang781216 I do not have any comments. Pleas merge if your questions are addressed -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6280: drivers: video: add ISX019 camera driver

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6280: URL: https://github.com/apache/incubator-nuttx/pull/6280#discussion_r875642213 ## drivers/video/isx019.c: ## @@ -0,0 +1,3247 @@ +/ + * drivers/video/isx019.c

[GitHub] [incubator-nuttx] jerpelea commented on a diff in pull request #6280: drivers: video: add ISX019 camera driver

2022-05-18 Thread GitBox
jerpelea commented on code in PR #6280: URL: https://github.com/apache/incubator-nuttx/pull/6280#discussion_r875617168 ## drivers/video/isx019.c: ## @@ -0,0 +1,3247 @@ +/ + * drivers/video/isx019.c + *

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6280: drivers: video: add ISX019 camera driver

2022-05-18 Thread GitBox
pkarashchenko commented on code in PR #6280: URL: https://github.com/apache/incubator-nuttx/pull/6280#discussion_r875604200 ## drivers/video/isx019.c: ## @@ -0,0 +1,3247 @@ +/ + * drivers/video/isx019.c

[GitHub] [incubator-nuttx] jerpelea commented on pull request #6280: drivers: video: add ISX019 camera driver

2022-05-18 Thread GitBox
jerpelea commented on PR #6280: URL: https://github.com/apache/incubator-nuttx/pull/6280#issuecomment-1129671728 @xiaoxiang781216 ideas about the error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6292: risc-v/opensbi: Generalize the SBI variable handling in makefile

2022-05-18 Thread GitBox
pussuw opened a new pull request, #6292: URL: https://github.com/apache/incubator-nuttx/pull/6292 - Remove most of the ifeq-conditions and replace them with variables. - Move the -I flag for 3rd party headers to opensbi/Make.defs This clean-up / generalization makes it much simpler