[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6949: usrsock:refine usrsock's architecture

masayuki2009 commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1231151645 @ethanlcz I tried this PR with spresense:wifi_smp but it does not work. ``` NuttShell (NSH) nsh> uname -a NuttX 0.0.0 6bb1c0902d Aug 30 2022 14:01:59 arm

[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6957: riscv: Dump trap val in exception handler

no1wudi commented on code in PR #6957: URL: https://github.com/apache/incubator-nuttx/pull/6957#discussion_r957992392 ## arch/risc-v/src/common/riscv_exception.c: ## @@ -73,15 +73,15 @@ int riscv_exception(int mcause, void *regs, void *args) { uintptr_t cause = mcause &

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6957: riscv: Dump trap val in exception handler

xiaoxiang781216 commented on code in PR #6957: URL: https://github.com/apache/incubator-nuttx/pull/6957#discussion_r957988820 ## arch/risc-v/src/common/riscv_exception.c: ## @@ -73,15 +73,15 @@ int riscv_exception(int mcause, void *regs, void *args) { uintptr_t cause =

[incubator-nuttx-apps] branch master updated: Fixed compiler warnings.

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 1c7839c28 Fixed compiler

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1303: Fixed compiler warnings.

xiaoxiang781216 merged PR #1303: URL: https://github.com/apache/incubator-nuttx-apps/pull/1303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6957: riscv: Dump trap val in exception handler

no1wudi opened a new pull request, #6957: URL: https://github.com/apache/incubator-nuttx/pull/6957 ## Summary Dump trap val in exception handler ## Impact Exception message only ## Testing CI and custom board -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6956: net/tcp: use independent work to free the conn instance

anchao opened a new pull request, #6956: URL: https://github.com/apache/incubator-nuttx/pull/6956 ## Summary net/tcp: use independent work to free the conn instance I noticed that the conn instance will leak during stress test, The close work queued from

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957971720 ## drivers/mtd/Kconfig: ## @@ -192,6 +192,28 @@ config MTD_CONFIG_NAME_LEN ---help--- Sets the maximum length of config item names.

[GitHub] [incubator-nuttx] zhhyu7 closed pull request #6031: usrsock: Don't clear recvfrom available flag

zhhyu7 closed pull request #6031: usrsock: Don't clear recvfrom available flag URL: https://github.com/apache/incubator-nuttx/pull/6031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957967433 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957964754 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

xiaoxiang781216 commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957948863 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

xiaoxiang781216 commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957948586 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

xiaoxiang781216 commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957947818 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] ethanlcz commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

ethanlcz commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r957939333 ## net/usrsock/usrsock_dev.c: ## @@ -1129,91 +554,61 @@ static int usrsockdev_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957937919 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957937126 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[incubator-nuttx] branch master updated: libc: Port strtod fixes to strtof, strtold and improve comments

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new a0ee5d3747 libc: Port strtod fixes

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6954: libc: Port strtod fixes to strtof, strtold and improve comments

xiaoxiang781216 merged PR #6954: URL: https://github.com/apache/incubator-nuttx/pull/6954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: c83985c5ce7acca8b342dccd7aa77b4760f83aca

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new bb96e9b Publishing

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6952: Fixes in strtod parser.

hartmannathan commented on PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#issuecomment-1230967689 @fjpanag I ported these changes to strtof() and strtold() in PR #6954. If you could review, I'd appreciate that very much. Thanks! -- This is an automated message from

[GitHub] [incubator-nuttx] fjpanag commented on issue #6941: Wrong calculations by pow()

fjpanag commented on issue #6941: URL: https://github.com/apache/incubator-nuttx/issues/6941#issuecomment-1230942331 Oh nice! It would be great to include a high quality library in NuttX! For the record, I fixed this specific function. I just haven't pushed it yet. I haven't

[GitHub] [incubator-nuttx] acassis commented on issue #6941: Wrong calculations by pow()

acassis commented on issue #6941: URL: https://github.com/apache/incubator-nuttx/issues/6941#issuecomment-1230912451 @fjpanag I talked with project maintainer of the LibmCS and he trying to get authorization from ESA to let's include it on NuttX to replace our Rhombus' libm

[GitHub] [incubator-nuttx] acassis opened a new pull request, #6955: esp32c3/boards: Add support APA102/APDS0060 for Shift Game

acassis opened a new pull request, #6955: URL: https://github.com/apache/incubator-nuttx/pull/6955 ## Summary Add support APA102/APDS0060 for Shift Game ## Impact Users will be able to use the Shift game on esp32c3-devkit-rust-1 board ## Testing esp32c3-devkit-rust-1 board

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #6954: libc: Port strtod fixes to strtof, strtold and improve comments

hartmannathan opened a new pull request, #6954: URL: https://github.com/apache/incubator-nuttx/pull/6954 ## Summary Port the changes of PR #6952 to strtof() and strtold(). Also add a note of our implementation's limitations compared to POSIX. ## Impact Consistency

[incubator-nuttx] 01/01: libc: Port strtod fixes to strtof, strtold and improve comments

This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch strtod-fixes in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1d803dd7a81a09097cd0dee66ef396ad55452457 Author: Nathan Hartman

[incubator-nuttx] branch strtod-fixes created (now 1d803dd7a8)

This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch strtod-fixes in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git at 1d803dd7a8 libc: Port strtod fixes to strtof, strtold and improve comments This branch

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6944: boards/stm32h7: add support for mcuboot

acassis commented on code in PR #6944: URL: https://github.com/apache/incubator-nuttx/pull/6944#discussion_r957764831 ## boards/arm/stm32h7/nucleo-h743zi/configs/netnsh/defconfig: ## @@ -63,6 +63,7 @@ CONFIG_RR_INTERVAL=200 CONFIG_SCHED_HPWORK=y CONFIG_SCHED_LPWORK=y

[incubator-nuttx] branch master updated (3665180795 -> c83985c5ce)

This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 3665180795 risc-v/mpfs: usb: fix cppcheck findings add c83985c5ce Fixes in strtod parser. No new

[GitHub] [incubator-nuttx] acassis closed issue #6945: Wrong result with strtod().

acassis closed issue #6945: Wrong result with strtod(). URL: https://github.com/apache/incubator-nuttx/issues/6945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-nuttx] acassis merged pull request #6952: Fixes in strtod parser.

acassis merged PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6952: Fixes in strtod parser.

xiaoxiang781216 commented on code in PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#discussion_r957634428 ## libs/libc/stdlib/lib_strtod.c: ## @@ -195,6 +196,14 @@ double strtod(FAR const char *str, FAR char **endptr) /* Process string of digits */

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6953: risc-v/mpfs: usb: fix cppcheck findings

xiaoxiang781216 merged PR #6953: URL: https://github.com/apache/incubator-nuttx/pull/6953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated: risc-v/mpfs: usb: fix cppcheck findings

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3665180795 risc-v/mpfs: usb: fix

[incubator-nuttx] branch master updated (767ab06ecd -> 3b0516f6a2)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 767ab06ecd Update build.yml add 3b0516f6a2 libc/crc: Add full suffix to avoid the the

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6856: libc/crc: Add full suffix to avoid the the penitential symbol collision

pkarashchenko merged PR #6856: URL: https://github.com/apache/incubator-nuttx/pull/6856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx-apps] fjpanag opened a new pull request, #1303: Fixed compiler warnings.

fjpanag opened a new pull request, #1303: URL: https://github.com/apache/incubator-nuttx-apps/pull/1303 ## Summary Fixes a couple of compiler warnings in NSH. ## Impact N/A ## Testing Build test only. -- This is an automated message from the Apache

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6862: sched: Remove the unnecessary weak_function

xiaoxiang781216 commented on PR #6862: URL: https://github.com/apache/incubator-nuttx/pull/6862#issuecomment-1230501958 > @xiaoxiang781216 could you please add `FAR` to `unsigned int *prio` in `nxmq_do_receive` since we are changing this file? Done. -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6856: libc/crc: Add full suffix to avoid the the penitential symbol collision

xiaoxiang781216 commented on PR #6856: URL: https://github.com/apache/incubator-nuttx/pull/6856#issuecomment-1230500133 ping @pkarashchenko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6952: Fixes in strtod parser.

fjpanag commented on code in PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#discussion_r957508760 ## libs/libc/stdlib/lib_strtod.c: ## @@ -195,6 +196,14 @@ double strtod(FAR const char *str, FAR char **endptr) /* Process string of digits */ +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6952: Fixes in strtod parser.

xiaoxiang781216 commented on code in PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#discussion_r957495263 ## libs/libc/stdlib/lib_strtod.c: ## @@ -160,6 +160,7 @@ double strtod(FAR const char *str, FAR char **endptr) { set_errno(ERANGE);

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6952: Fixes in strtod parser.

fjpanag commented on code in PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#discussion_r957473135 ## libs/libc/stdlib/lib_strtod.c: ## @@ -195,6 +196,14 @@ double strtod(FAR const char *str, FAR char **endptr) /* Process string of digits */ +

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6952: Fixes in strtod parser.

fjpanag commented on code in PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#discussion_r957472912 ## libs/libc/stdlib/lib_strtod.c: ## @@ -160,6 +160,7 @@ double strtod(FAR const char *str, FAR char **endptr) { set_errno(ERANGE); number =

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6952: Fixes in strtod parser.

pkarashchenko commented on code in PR #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952#discussion_r957458971 ## libs/libc/stdlib/lib_strtod.c: ## @@ -195,6 +196,14 @@ double strtod(FAR const char *str, FAR char **endptr) /* Process string of digits */

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

xiaoxiang781216 commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r957431803 ## net/usrsock/usrsock_dev.c: ## @@ -1129,91 +554,61 @@ static int usrsockdev_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

xiaoxiang781216 commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r957372644 ## net/usrsock/usrsock_dev.c: ## @@ -1129,91 +554,60 @@ static int usrsockdev_poll(FAR struct file *filep, FAR struct pollfd *fds,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6926: list.h: Change inline function to macro as much as possbile

xiaoxiang781216 commented on code in PR #6926: URL: https://github.com/apache/incubator-nuttx/pull/6926#discussion_r957362164 ## include/nuttx/list.h: ## @@ -37,8 +37,67 @@ #define LIST_INITIAL_VALUE(list) { &(list), &(list) } #define LIST_INITIAL_CLEARED_VALUE { NULL, NULL }

[GitHub] [incubator-nuttx] eenurkka opened a new pull request, #6953: risc-v/mpfs: usb: fix cppcheck findings

eenurkka opened a new pull request, #6953: URL: https://github.com/apache/incubator-nuttx/pull/6953 Fix the following cppcheck findings. Privreq may be NULL, thus perform checks before using its member variables. Checking mpfs_usb.c ... mpfs_usb.c:1093:12: warning: Possible null

[incubator-nuttx-apps] branch master updated: Update build.yml

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new daf9e8093 Update build.yml

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1302: GitHub Workflows security hardening

xiaoxiang781216 merged PR #1302: URL: https://github.com/apache/incubator-nuttx-apps/pull/1302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated: Update build.yml

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 767ab06ecd Update build.yml

[incubator-nuttx] branch master updated (a97a6e1539 -> 90d9b6b8ac)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from a97a6e1539 sim: Add a new config minmea to detect build break add 90d9b6b8ac risc-v/mpfs: usb: fix

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6950: GitHub Workflows security hardening

xiaoxiang781216 merged PR #6950: URL: https://github.com/apache/incubator-nuttx/pull/6950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6951: risc-v/mpfs: usb: fix infinite loop issue

xiaoxiang781216 merged PR #6951: URL: https://github.com/apache/incubator-nuttx/pull/6951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx-apps] branch master updated: wireless/gs2200m: Rename usrsock_request to usrsock_handle_request

This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 0d8508474 wireless/gs2200m:

[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #1301: wireless/gs2200m: Rename usrsock_request to usrsock_handle_request

masayuki2009 merged PR #1301: URL: https://github.com/apache/incubator-nuttx-apps/pull/1301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #6952: Fixes in strtod parser.

fjpanag opened a new pull request, #6952: URL: https://github.com/apache/incubator-nuttx/pull/6952 ## Summary Fixes in `strtod()` as reported in issue #6945. ## Impact `strtod()` behaves more correctly now. ## Testing Tested all reported problematic

[GitHub] [incubator-nuttx] eenurkka opened a new pull request, #6951: risc-v/mpfs: usb: fix infinite loop issue

eenurkka opened a new pull request, #6951: URL: https://github.com/apache/incubator-nuttx/pull/6951 mpfs_write_tx_fifo() gets stuck in the following case: - CDCACM is used - ttyACM0 is opened and then closed from the remote end, such as Linux or Windows - data is

[GitHub] [incubator-nuttx] sashashura commented on pull request #6950: GitHub Workflows security hardening

sashashura commented on PR #6950: URL: https://github.com/apache/incubator-nuttx/pull/6950#issuecomment-1230093669 > @sashashura should we make the similar change to https://github.com/apache/incubator-nuttx-apps? Sure, just created

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1292: testcase for /dev/crypto

pkarashchenko commented on code in PR #1292: URL: https://github.com/apache/incubator-nuttx-apps/pull/1292#discussion_r957151390 ## testing/crypto/hmac.c: ## @@ -0,0 +1,230 @@ +/ + *

[GitHub] [incubator-nuttx-apps] sashashura opened a new pull request, #1302: GitHub Workflows security hardening

sashashura opened a new pull request, #1302: URL: https://github.com/apache/incubator-nuttx-apps/pull/1302 This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6926: list.h: Change inline function to macro as much as possbile

pkarashchenko commented on code in PR #6926: URL: https://github.com/apache/incubator-nuttx/pull/6926#discussion_r957146618 ## include/nuttx/list.h: ## @@ -37,8 +37,67 @@ #define LIST_INITIAL_VALUE(list) { &(list), &(list) } #define LIST_INITIAL_CLEARED_VALUE { NULL, NULL }

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6944: boards/stm32h7: add support for mcuboot

pkarashchenko commented on code in PR #6944: URL: https://github.com/apache/incubator-nuttx/pull/6944#discussion_r957141804 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c: ## @@ -0,0 +1,186 @@

[incubator-nuttx] branch master updated (5548676ab5 -> a97a6e1539)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 5548676ab5 sched: Fix macro "SCHED_NOTE_PRINTF" requires 3 argumnets, but only 1 given add

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6946: sim: Add a new config minmea to detect build break

xiaoxiang781216 merged PR #6946: URL: https://github.com/apache/incubator-nuttx/pull/6946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6950: GitHub Workflows security hardening

xiaoxiang781216 commented on PR #6950: URL: https://github.com/apache/incubator-nuttx/pull/6950#issuecomment-1230078024 @sashashura should we make the similar change to https://github.com/apache/incubator-nuttx-apps? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6947: net/tcp: fix devif callback list corruption on tcp_close()

pkarashchenko commented on PR #6947: URL: https://github.com/apache/incubator-nuttx/pull/6947#issuecomment-1230075199 > > @fjpanag could you try this patch with your stability test? > > Yes, I will! > > Today it is a bit rough, we are deploying. At most by tomorrow morning,

[incubator-nuttx] branch master updated: sched: Fix macro "SCHED_NOTE_PRINTF" requires 3 argumnets, but only 1 given

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5548676ab5 sched: Fix macro

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6948: sched: Fix macro "SCHED_NOTE_PRINTF" requires 3 argumnets, but only 1 given

pkarashchenko merged PR #6948: URL: https://github.com/apache/incubator-nuttx/pull/6948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] sashashura opened a new pull request, #6950: GitHub Workflows security hardening

sashashura opened a new pull request, #6950: URL: https://github.com/apache/incubator-nuttx/pull/6950 This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6918: Added lock in ifr ioctl calls.

xiaoxiang781216 commented on PR #6918: URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1230059564 > @xiaoxiang781216 Have you been able to identify the cause of the dead-lock? > > Is it device-specific, or is there any actual problem with this patch? Yes,

[GitHub] [incubator-nuttx] ethanlcz commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

ethanlcz commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r957107784 ## net/usrsock/usrsock_dev.c: ## @@ -264,22 +133,6 @@ static void usrsockdev_semgive(FAR sem_t *sem) nxsem_post(sem); }

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6949: usrsock:refine usrsock's architecture

xiaoxiang781216 commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1230033921 The break is fixed here: https://github.com/apache/incubator-nuttx-apps/pull/1301 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1301: wireless/gs2200m: Rename usrsock_request to usrsock_handle_request

xiaoxiang781216 opened a new pull request, #1301: URL: https://github.com/apache/incubator-nuttx-apps/pull/1301 ## Summary fix the conflict after usrsock reconstruct: https://github.com/apache/incubator-nuttx/pull/6949 ## Impact Minor ## Testing Pass CI --

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957102375 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2652 @@ +/ + *

[GitHub] [incubator-nuttx] fjpanag commented on pull request #6918: Added lock in ifr ioctl calls.

fjpanag commented on PR #6918: URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1230011516 @xiaoxiang781216 Have you been able to identify the cause of the dead-lock? Is it device-specific, or is there any actual problem with this patch? -- This is an automated

[GitHub] [incubator-nuttx] fjpanag commented on pull request #6947: net/tcp: fix devif callback list corruption on tcp_close()

fjpanag commented on PR #6947: URL: https://github.com/apache/incubator-nuttx/pull/6947#issuecomment-1230010428 > @fjpanag could you try this patch with your stability test? Yes, I will! Today it is a bit rough, we are deploying. At most by tomorrow morning, the tests will

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r957061981 ## drivers/mtd/Kconfig: ## @@ -192,6 +192,28 @@ config MTD_CONFIG_NAME_LEN ---help--- Sets the maximum length of config item names.

[GitHub] [incubator-nuttx] fjpanag commented on issue #6941: Wrong calculations by pow()

fjpanag commented on issue #6941: URL: https://github.com/apache/incubator-nuttx/issues/6941#issuecomment-1229975391 *Note to self.* This is how the C standard defines the `pow()` function: > The pow function computes x raised to the power y. A domain error occurs if x is

[GitHub] [incubator-nuttx] no1wudi commented on pull request #6946: sim: Add a new config minmea to detect build break

no1wudi commented on PR #6946: URL: https://github.com/apache/incubator-nuttx/pull/6946#issuecomment-1229963806 @xiaoxiang781216 The failed CI started before the fix merged, let's wait the result of new CI job -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6947: net/tcp: fix devif callback list corruption on tcp_close()

xiaoxiang781216 commented on PR #6947: URL: https://github.com/apache/incubator-nuttx/pull/6947#issuecomment-1229962860 @fjpanag could you try this patch with your stability test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

xiaoxiang781216 commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r957043352 ## net/usrsock/usrsock_dev.c: ## @@ -264,22 +133,6 @@ static void usrsockdev_semgive(FAR sem_t *sem) nxsem_post(sem); }

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6949: usrsock:refine usrsock's architecture

masayuki2009 commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1229936624 @ethanlcz, @xiaoxiang781216 Before refining the usrsock architecture, I think we need to fix apps/examples/usrsocktest first. -- This is an automated message from

[GitHub] [incubator-nuttx] ethanlcz commented on pull request #6949: usrsock:refine usrsock's architecture

ethanlcz commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1229936056 > @ethanlcz please fetch the last code and rebase your change. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6946: sim: Add a new config minmea to detect build break

xiaoxiang781216 commented on PR #6946: URL: https://github.com/apache/incubator-nuttx/pull/6946#issuecomment-1229925793 @no1wudi look like minmea still has some problem need to fix: https://github.com/apache/incubator-nuttx/runs/8064818153?check_suite_focus=true -- This is an

[GitHub] [incubator-nuttx] no1wudi closed pull request #6946: sim: Add a new config minmea to detect build break

no1wudi closed pull request #6946: sim: Add a new config minmea to detect build break URL: https://github.com/apache/incubator-nuttx/pull/6946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6949: usrsock:refine usrsock's architecture

xiaoxiang781216 commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1229923816 @ethanlcz please fetch the last code and rebase your change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] ethanlcz opened a new pull request, #6949: usrsock:refine usrsock's architecture

ethanlcz opened a new pull request, #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949 Seperate usrsock device driver with usrsock core function layer to make it more flexiable to adopt other kind of usrsock interface driver Signed-off-by: liangchaozhong ##

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6948: sched: Fix macro "SCHED_NOTE_PRINTF" requires 3 argumnets, but only 1 given

xiaoxiang781216 opened a new pull request, #6948: URL: https://github.com/apache/incubator-nuttx/pull/6948 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] anchao commented on pull request #6947: net/tcp: fix devif callback list corruption on tcp_close()

anchao commented on PR #6947: URL: https://github.com/apache/incubator-nuttx/pull/6947#issuecomment-1229849549 @fjpanag ,related issue: https://github.com/apache/incubator-nuttx/pull/6923#issuecomment-1228726044 -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] anchao commented on pull request #6923: net: remove pvconn reference from all devif callback

anchao commented on PR #6923: URL: https://github.com/apache/incubator-nuttx/pull/6923#issuecomment-1229848417 > I just had one device crash again. @fjpanag Thanks a lot for your analysis, I have a fix but can not evaluate the side effect, I am not sure if that can resolved your

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6947: net/tcp: fix devif callback list corruption on tcp_close()

anchao opened a new pull request, #6947: URL: https://github.com/apache/incubator-nuttx/pull/6947 ## Summary net/tcp: fix devif callback list corruption on tcp_close() devif_conn_event() will be called recursively in the psock_send_eventhandler(), if the tcp event

[incubator-nuttx-apps] branch master updated: gpusutils/minmea: Fix build break by wrong unpack path

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 1e4165220 gpusutils/minmea:

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1300: gpusutils/minmea: Fix build break by wrong unpack path

xiaoxiang781216 merged PR #1300: URL: https://github.com/apache/incubator-nuttx-apps/pull/1300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx-apps] branch master updated: interpreters/wamr/Kconfig: Add INTERPRETERS_WAMR_DEBUG_INTERP option

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 65b58724c

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1299: interpreters/wamr/Kconfig: Add INTERPRETERS_WAMR_DEBUG_INTERP option

xiaoxiang781216 merged PR #1299: URL: https://github.com/apache/incubator-nuttx-apps/pull/1299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: