[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7011: add chip GD32F450 of GD32MCU

2022-09-06 Thread GitBox
xiaoxiang781216 commented on PR #7011: URL: https://github.com/apache/incubator-nuttx/pull/7011#issuecomment-1238954181 @GD32-MCU could you squash the change into one patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-nuttx] branch master updated (22a5cc0973 -> b04ae46ea6)

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 22a5cc0973 drivers: wireless: Add SIOCGIFFLAGS support to gs2200m.c add b04ae46ea6 boards/arm/tiva: A

[GitHub] [incubator-nuttx] nealef commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238952965 > could you squash the patchset Do you want me to do it via rebase and push or the repo admin to use the github option to squash? -- This is an automated message from the

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7023: boards/arm/tiva: Add tm4c129e-launchpad

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #7023: URL: https://github.com/apache/incubator-nuttx/pull/7023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238945616 could you squash the patchset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] ethanlcz commented on pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
ethanlcz commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1238939400 > @ethanlcz Please test this PR with `CONFIG_DEBUG_ASSERTIONS=y` > > ``` > nsh> usrsocktest > Starting unit-tests... > Testing group "char_dev" => >Group "ch

[GitHub] [incubator-nuttx] ethanlcz commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
ethanlcz commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r964409062 ## net/usrsock/usrsock_sendmsg.c: ## @@ -71,7 +71,8 @@ static uint16_t sendto_event(FAR struct net_driver_s *dev, pstate->result = conn->resp.result;

[GitHub] [incubator-nuttx] ethanlcz commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
ethanlcz commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r964408774 ## net/usrsock/usrsock_recvmsg.c: ## @@ -83,8 +83,9 @@ static uint16_t recvfrom_event(FAR struct net_driver_s *dev, pstate->valuelen_nontrunc = conn-

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-09-06 Thread GitBox
masayuki2009 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1238927867 >Can you reproduce the crash with QEMU? @GUIDINGLI Also, please rebase this PR to the latest master. -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] buyuer opened a new pull request, #7028: Add some utility functions for nuttx.h

2022-09-06 Thread GitBox
buyuer opened a new pull request, #7028: URL: https://github.com/apache/incubator-nuttx/pull/7028 add min_t,max_t,min3_t,ma3_t,swap_t macro functions for include/nuttx/nuttx.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6997: net/procfs: add entry mapping table

2022-09-06 Thread GitBox
anchao commented on code in PR #6997: URL: https://github.com/apache/incubator-nuttx/pull/6997#discussion_r964383278 ## net/procfs/net_procfs.c: ## @@ -283,41 +328,14 @@ static ssize_t netprocfs_read(FAR struct file *filep, FAR char *buffer, /* Read according to the sub-di

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6997: net/procfs: add entry mapping table

2022-09-06 Thread GitBox
anchao commented on code in PR #6997: URL: https://github.com/apache/incubator-nuttx/pull/6997#discussion_r964383073 ## net/procfs/net_procfs.c: ## @@ -155,44 +214,31 @@ static int netprocfs_open(FAR struct file *filep, FAR const char *relpath, return -EACCES; } -

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6997: net/procfs: add entry mapping table

2022-09-06 Thread GitBox
anchao commented on code in PR #6997: URL: https://github.com/apache/incubator-nuttx/pull/6997#discussion_r964382987 ## net/procfs/net_procfs.c: ## @@ -155,44 +214,31 @@ static int netprocfs_open(FAR struct file *filep, FAR const char *relpath, return -EACCES; } -

[GitHub] [incubator-nuttx] buyuer closed pull request #7027: include/nuttx/nuttx.h: add max_t/min_t macro function.

2022-09-06 Thread GitBox
buyuer closed pull request #7027: include/nuttx/nuttx.h: add max_t/min_t macro function. URL: https://github.com/apache/incubator-nuttx/pull/7027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] buyuer opened a new pull request, #7027: include/nuttx/nuttx.h: add max_t/min_t macro function.

2022-09-06 Thread GitBox
buyuer opened a new pull request, #7027: URL: https://github.com/apache/incubator-nuttx/pull/7027 Add maxmin functions, using the specified type Signed-off-by: buyuer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-09-06 Thread GitBox
masayuki2009 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1238904956 @GUIDINGLI Can you reproduce the crash with QEMU? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964373476 ## net/netdev/netdev_ioctl.c: ## @@ -636,279 +700,183 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioctl(FAR s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6997: net/procfs: add entry mapping table

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #6997: URL: https://github.com/apache/incubator-nuttx/pull/6997#discussion_r964366198 ## net/procfs/net_procfs.c: ## @@ -155,44 +214,31 @@ static int netprocfs_open(FAR struct file *filep, FAR const char *relpath, return -EACCES;

[GitHub] [incubator-nuttx] nealef commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964363235 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x)) Review Co

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-09-06 Thread GitBox
xiaoxiang781216 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1238882354 @masayuki2009 could you test with your hardware? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#discussion_r964356305 ## net/usrsock/usrsock_recvmsg.c: ## @@ -83,8 +83,9 @@ static uint16_t recvfrom_event(FAR struct net_driver_s *dev, pstate->valuelen_nontrunc

[GitHub] [incubator-nuttx] nealef commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238877127 > @nealef let's squash the second patch to first one. Or squash after I `#define INFINITY_L` etc.? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
hartmannathan commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238876192 > @nealef let's squash the second patch to first one. Good catch. Forgot to check for that. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964354825 ## net/netdev/netdev_ioctl.c: ## @@ -636,279 +700,183 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_io

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964353029 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x))

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238872810 @nealef let's squash the second patch to first one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-nuttx] curuvar commented on issue #7022: Build / Linux (arm-05) uses old pico-sdk.

2022-09-06 Thread GitBox
curuvar commented on issue #7022: URL: https://github.com/apache/incubator-nuttx/issues/7022#issuecomment-1238872921 I don't know how to update the download script. If I knew where it was I could probably figure that out, but I don't even know that. For my build here I just grabbe

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964353029 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x))

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964351799 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +700,201 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioctl(FAR s

[GitHub] [incubator-nuttx] nealef commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238870658 > LGTM! Thanks! Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
masayuki2009 commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1238870190 @ethanlcz Also, please rebase this PR to the latest master so that we can test this PR with spresense + gs2200m. -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
masayuki2009 commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1238869569 @ethanlcz Please test this PR with `CONFIG_DEBUG_ASSERTIONS=y` ``` nsh> usrsocktest Starting unit-tests... Testing group "char_dev" => Group "char_d

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964349288 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +700,201 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_io

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
hartmannathan commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238866327 OK I have a workaround: ``` if (isinf(x) || isnan(x)) { return (x); } ``` nxstyle doesn't complain when this is written in a block

[incubator-nuttx-apps] branch master updated: wireless: gs2200m: Add SIOCGIFFLAGS support to gs2200m_main.c

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 383709158 wireless: gs2200m: Ad

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1311: wireless: gs2200m: Add SIOCGIFFLAGS support to gs2200m_main.c

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #1311: URL: https://github.com/apache/incubator-nuttx-apps/pull/1311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx] branch master updated: drivers: wireless: Add SIOCGIFFLAGS support to gs2200m.c

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 22a5cc0973 drivers: wireless: Add SI

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
hartmannathan commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238862373 > I am unsure what the alignment issue is. Is it spaces v tabs? Do I need to set my tabs to a nuttx standard setting? I just looked at it and I can't see anything wron

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7024: drivers: wireless: Add SIOCGIFFLAGS support to gs2200m.c

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #7024: URL: https://github.com/apache/incubator-nuttx/pull/7024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7026: Clean up psock_udp_recvfrom related code

2022-09-06 Thread GitBox
xiaoxiang781216 opened a new pull request, #7026: URL: https://github.com/apache/incubator-nuttx/pull/7026 ## Summary follow up https://github.com/apache/incubator-nuttx/pull/7009: - udp: Don't accumulate the receive length in psock_udp_recvfrom - udp: Remove the unnessary check of a

[GitHub] [incubator-nuttx] nealef commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964342540 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x)) Review Co

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964337848 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioctl(FAR s

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964337755 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioctl(FAR s

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964337633 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioctl(FAR s

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964336747 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioctl(FAR s

[GitHub] [incubator-nuttx] anchao closed pull request #7014: net/netdev: correct return value of SIOCGIFFLAGS/SIOCGIFCOUNT

2022-09-06 Thread GitBox
anchao closed pull request #7014: net/netdev: correct return value of SIOCGIFFLAGS/SIOCGIFCOUNT URL: https://github.com/apache/incubator-nuttx/pull/7014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] anchao commented on pull request #7014: net/netdev: correct return value of SIOCGIFFLAGS/SIOCGIFCOUNT

2022-09-06 Thread GitBox
anchao commented on PR #7014: URL: https://github.com/apache/incubator-nuttx/pull/7014#issuecomment-1238851483 Close this PR let us track https://github.com/apache/incubator-nuttx/pull/7020 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-nuttx] branch master updated (9bff29d7e7 -> 3b04450808)

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 9bff29d7e7 udp: add IPVx_PKTINFO related support add 3b04450808 sched: fix corner case wd_cancel asse

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7019: sched: fix corner case wd_cancel assert crash

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #7019: URL: https://github.com/apache/incubator-nuttx/pull/7019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: udp: add IPVx_PKTINFO related support

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9bff29d7e7 udp: add IPVx_PKTINFO rel

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7009: udp: add IPVx_PKTINFO related support

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #7009: URL: https://github.com/apache/incubator-nuttx/pull/7009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6983: compiler.h: Rename inline_function to always_inline_function

2022-09-06 Thread GitBox
xiaoxiang781216 commented on PR #6983: URL: https://github.com/apache/incubator-nuttx/pull/6983#issuecomment-1238846972 @pkarashchenko could you merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964332497 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x))

[GitHub] [incubator-nuttx] nealef commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238846009 I am unsure what the alignment issue is. Is it spaces v tabs? Do I need to set my tabs to a nuttx standard setting? -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-nuttx] nealef commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964331468 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x)) Review Co

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1238843703 @nealef please fix the warning here: https://github.com/apache/incubator-nuttx/runs/8219913869?check_suite_focus=true -- This is an automated message from the Apache

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964329608 ## libs/libc/math/lib_roundl.c: ## @@ -34,6 +34,9 @@ #ifdef CONFIG_HAVE_LONG_DOUBLE long double roundl(long double x) { + if (isinf(x) || isnan(x))

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7014: net/netdev: correct return value of SIOCGIFFLAGS/SIOCGIFCOUNT

2022-09-06 Thread GitBox
anchao commented on code in PR #7014: URL: https://github.com/apache/incubator-nuttx/pull/7014#discussion_r964329303 ## net/netdev/netdev_ioctl.c: ## @@ -905,9 +905,12 @@ static int netdev_ifr_ioctl(FAR struct socket *psock, int cmd, if (dev) {

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7022: Build / Linux (arm-05) uses old pico-sdk.

2022-09-06 Thread GitBox
xiaoxiang781216 commented on issue #7022: URL: https://github.com/apache/incubator-nuttx/issues/7022#issuecomment-1238842269 can you update the download script to point the lasts release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] ethanlcz commented on pull request #6949: usrsock:refine usrsock's architecture

2022-09-06 Thread GitBox
ethanlcz commented on PR #6949: URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1238838032 @xiaoxiang781216 @masayuki2009 I forgot to upgrade latest nuttx app and got the failure yesterday. Now it passed usrsocktest with latest nuttx kernel and app. -- This is an

[GitHub] [incubator-nuttx] nealef opened a new pull request, #7025: Add check in roundx() functions for infinite or NaN cases

2022-09-06 Thread GitBox
nealef opened a new pull request, #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025 ## Summary The round() functions do not return the correct value for infinite or NaN values. For example, round(NaN) returns 0 instead of NaN. ## Impact Incorrect results for these

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7024: drivers: wireless: Add SIOCGIFFLAGS support to gs2200m.c

2022-09-06 Thread GitBox
masayuki2009 commented on PR #7024: URL: https://github.com/apache/incubator-nuttx/pull/7024#issuecomment-1238803746 See https://github.com/apache/incubator-nuttx-apps/pull/1311 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request, #1311: wireless: gs2200m: Add SIOCGIFFLAGS support to gs2200m_main.c

2022-09-06 Thread GitBox
masayuki2009 opened a new pull request, #1311: URL: https://github.com/apache/incubator-nuttx-apps/pull/1311 ## Summary - I noticed that the latest ifconfig command shows nothing - Finally, I found that gs2200m_main.c needs to handle SIOCGIFFLAGS - This commit fixes this issue

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request, #7024: drivers: wireless: Add SIOCGIFFLAGS support to gs2200m.c

2022-09-06 Thread GitBox
masayuki2009 opened a new pull request, #7024: URL: https://github.com/apache/incubator-nuttx/pull/7024 ## Summary - I noticed that the latest ifconfig command shows nothing - Finally, I found that gs2200m.c needs to handle SIOCGIFFLAGS - This commit fixes this issue ## Im

[incubator-nuttx] branch master updated: sim: fix signal crash in SMP mode

2022-09-06 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 94cf99f310 sim: fix signal crash in S

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7015: sim: fix signal crash in SMP mode

2022-09-06 Thread GitBox
masayuki2009 merged PR #7015: URL: https://github.com/apache/incubator-nuttx/pull/7015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 179d64d99919dd77b1ae43087d82361344e00126

2022-09-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new f4a14db Publishing web

[incubator-nuttx] branch master updated (54dba40f87 -> 179d64d999)

2022-09-06 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 54dba40f87 net/netdev/ioctl: correct the argument length of ioctl MII/PHY new 3e16b6c9f1 update

[incubator-nuttx] 02/02: stm32h7: SPI is no more experimental

2022-09-06 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 179d64d99919dd77b1ae43087d82361344e00126 Author: Sebastien Lorquet AuthorDate: Tue Sep 6 15:39:49 2022 +

[incubator-nuttx] 01/02: update conditionals to select stm32h7 spi peripherals

2022-09-06 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 3e16b6c9f168bb26d708dfaef420f61b246facf2 Author: Sebastien Lorquet AuthorDate: Tue Sep 6 15:38:41 2022 +

[GitHub] [incubator-nuttx] hartmannathan merged pull request #7017: Stm32h7 kconfig

2022-09-06 Thread GitBox
hartmannathan merged PR #7017: URL: https://github.com/apache/incubator-nuttx/pull/7017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
hartmannathan commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964255606 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioct

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
hartmannathan commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964255066 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioct

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
hartmannathan commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964248968 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_ioct

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7014: net/netdev: correct return value of SIOCGIFFLAGS/SIOCGIFCOUNT

2022-09-06 Thread GitBox
hartmannathan commented on code in PR #7014: URL: https://github.com/apache/incubator-nuttx/pull/7014#discussion_r964245960 ## net/netdev/netdev_ioctl.c: ## @@ -947,6 +950,7 @@ static int netdev_ifr_ioctl(FAR struct socket *psock, int cmd, #endif {

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #7023: boards/arm/tiva: Add tm4c129e-launchpad

2022-09-06 Thread GitBox
hartmannathan opened a new pull request, #7023: URL: https://github.com/apache/incubator-nuttx/pull/7023 ## Summary Adds board support for the Texas Instruments EK-TM4C129EXL "TM4C Crypto Connected LaunchPad" in the new subdirectory boards/arm/tiva/tm4c129e-launchpad. This board supp

[GitHub] [incubator-nuttx] curuvar opened a new issue, #7022: Build / Linux (arm-05) uses old pico-sdk.

2022-09-06 Thread GitBox
curuvar opened a new issue, #7022: URL: https://github.com/apache/incubator-nuttx/issues/7022 There is a new version of pico-sdk that contains firmware needed to use the WiFi chip on the RaspberryPi Pico W. No test build that uses the Pico W's WiFi can succeed until this library is

[incubator-nuttx] branch master updated (9726be616a -> 54dba40f87)

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 9726be616a fs: Run the default action of FIONBIO/FIOCLEX/FIONCLEX in success path add 54dba40f87 net

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7016: net/netdev/ioctl: correct the argument length of ioctl MII/PHY

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #7016: URL: https://github.com/apache/incubator-nuttx/pull/7016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] curuvar opened a new pull request, #7021: Fix race condition in RaspberryPi Pico W WiFi and add "telnet" config

2022-09-06 Thread GitBox
curuvar opened a new pull request, #7021: URL: https://github.com/apache/incubator-nuttx/pull/7021 ## Summary Added code to resolve a race condition when writing data to the Pico W's WiFi chip. Also added a "telnet" configuration that demonstrates basic networking. ## Impact

[GitHub] [incubator-nuttx] acassis commented on pull request #7011: add chip GD32F450 of GD32MCU

2022-09-06 Thread GitBox
acassis commented on PR #7011: URL: https://github.com/apache/incubator-nuttx/pull/7011#issuecomment-1238507972 Hi @GD32-MCU please check out board config files, they seems outdated. Please run for each board and config: ``` $ ./tools/refresh.sh --silent yourboard:yourconfig ```

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7014: net/netdev: correct return value of SIOCGIFFLAGS/SIOCGIFCOUNT

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7014: URL: https://github.com/apache/incubator-nuttx/pull/7014#discussion_r964017175 ## net/netdev/netdev_ioctl.c: ## @@ -992,6 +996,7 @@ static int netdev_ifr_ioctl(FAR struct socket *psock, int cmd, #endif {

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
xiaoxiang781216 commented on code in PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964006952 ## net/netdev/netdev_ioctl.c: ## @@ -636,235 +636,204 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct ifreq *req) static int netdev_ifr_io

[incubator-nuttx-apps] branch master updated: ostest: fix sighand_test report error

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 048b79955 ostest: fix sighand_t

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1310: ostest: fix sighand_test report error

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #1310: URL: https://github.com/apache/incubator-nuttx-apps/pull/1310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx] branch master updated: fs: Run the default action of FIONBIO/FIOCLEX/FIONCLEX in success path

2022-09-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9726be616a fs: Run the default action o

[GitHub] [incubator-nuttx] anchao merged pull request #6976: fs: Run the default action of FIONBIO/FIOCLEX/FIONCLEX in success path

2022-09-06 Thread GitBox
anchao merged PR #6976: URL: https://github.com/apache/incubator-nuttx/pull/6976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nut

[incubator-nuttx] branch master updated (e0bb281e7a -> 4df8b16060)

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from e0bb281e7a net: Align the prototype of sock_intf_s::si_ioctl with file_operations::ioctl add 4df8b16

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7013: risc-v/mpfs: usb: provide more endpoints

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #7013: URL: https://github.com/apache/incubator-nuttx/pull/7013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1308: nshlib/netcmd: add sanity check for netdev

2022-09-06 Thread GitBox
xiaoxiang781216 merged PR #1308: URL: https://github.com/apache/incubator-nuttx-apps/pull/1308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: nshlib/netcmd: add sanity check for netdev

2022-09-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new e6e466113 nshlib/netcmd: add sa

[incubator-nuttx] branch master updated: net: Align the prototype of sock_intf_s::si_ioctl with file_operations::ioctl

2022-09-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new e0bb281e7a net: Align the prototype of

[GitHub] [incubator-nuttx] anchao merged pull request #6978: net: Align the prototype of sock_intf_s::si_ioctl with file_operations::ioctl

2022-09-06 Thread GitBox
anchao merged PR #6978: URL: https://github.com/apache/incubator-nuttx/pull/6978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nut

[GitHub] [incubator-nuttx] anchao commented on pull request #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao commented on PR #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020#issuecomment-1238245302 @hartmannathan https://github.com/apache/incubator-nuttx/pull/7014#pullrequestreview-1097567649 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7020: net/netdev: simplify handling of netdev ifr ioctl()

2022-09-06 Thread GitBox
anchao opened a new pull request, #7020: URL: https://github.com/apache/incubator-nuttx/pull/7020 ## Summary net/netdev: simplify handling of netdev ifr ioctl() 1. call netdev_ifr_dev() only once 2. unify error code of ENODEV Signed-off-by: chao an ## Impact

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request, #7019: sched: fix corner case wd_cancel assert crash

2022-09-06 Thread GitBox
GUIDINGLI opened a new pull request, #7019: URL: https://github.com/apache/incubator-nuttx/pull/7019 ## Summary sched: fix corner case wd_cancel assert crash There one ways can caused this: mq_timedreceive TIMER IRQ do wd_timer -> wd_func1 mq_send

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request, #7018: wqueue: change single queue to double queue to improve speed

2022-09-06 Thread GitBox
GUIDINGLI opened a new pull request, #7018: URL: https://github.com/apache/incubator-nuttx/pull/7018 ## Summary wqueue: change single queue to double queue to improve speed wqueue: fix work_qcancel() judge error caused by the union in struct work_s in struct work_s: un

[GitHub] [incubator-nuttx] slorquet opened a new pull request, #7017: Stm32h7 kconfig

2022-09-06 Thread GitBox
slorquet opened a new pull request, #7017: URL: https://github.com/apache/incubator-nuttx/pull/7017 ## Summary * stm32h7 Kconfig menu imbrication was broken, preventing spi peripheral selection * stm32h7 spi does not need to depend on EXPERIMENTAL ## Impact * none ## T

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-09-06 Thread GitBox
GUIDINGLI commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1238170478 @masayuki2009 please help to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-09-06 Thread GitBox
GUIDINGLI commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1238169380 This should be test base on: https://github.com/apache/incubator-nuttx/pull/7015 -- This is an automated message from the Apache Git Service. To respond to the message, plea

  1   2   >