[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7075: risc-v/mpfs: emmcsd: provide options for selecting clk speed

2022-09-13 Thread GitBox
pkarashchenko commented on code in PR #7075: URL: https://github.com/apache/incubator-nuttx/pull/7075#discussion_r970391739 ## boards/risc-v/mpfs/icicle/include/board.h: ## @@ -37,6 +37,10 @@ * Pre-processor Definitions ***

[GitHub] [incubator-nuttx] vuhuyhop197 commented on a diff in pull request #7083: sockopt:Change the flow of function psock_setsockopt and psock_getsockopt

2022-09-13 Thread GitBox
vuhuyhop197 commented on code in PR #7083: URL: https://github.com/apache/incubator-nuttx/pull/7083#discussion_r970361987 ## net/socket/getsockopt.c: ## @@ -337,50 +337,51 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, return -EBADF; } -

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7088: sched/msgq: add support of System V message queue

2022-09-13 Thread GitBox
anchao opened a new pull request, #7088: URL: https://github.com/apache/incubator-nuttx/pull/7088 ## Summary sched/msgq: add support of System V message queue sched/mqueue: decoupling condition member to common prologue https://man.openbsd.org/msgget.2 ## Impact

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 72313301e23f9c2de969fb64b9a0f67bb4c284df

2022-09-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e82 Publishing web

[incubator-nuttx] branch master updated (1913163c64 -> 72313301e2)

2022-09-13 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 1913163c64 drivers: Fix some Kconfig help texts add 72313301e2 net/w5500: Fix small typo No new

[GitHub] [incubator-nuttx] hartmannathan merged pull request #7087: net/w5500: Fix small typo

2022-09-13 Thread GitBox
hartmannathan merged PR #7087: URL: https://github.com/apache/incubator-nuttx/pull/7087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] acassis commented on issue #7086: Any chance of getting netcat working on Nuttx 8.2?

2022-09-13 Thread GitBox
acassis commented on issue #7086: URL: https://github.com/apache/incubator-nuttx/issues/7086#issuecomment-1246021452 Also, don't forget to run: "make apps_distclean" to remove previous configuration, after that run "make menuconfig" to confirm everything is configured! -- This is an aut

[GitHub] [incubator-nuttx] acassis commented on issue #7086: Any chance of getting netcat working on Nuttx 8.2?

2022-09-13 Thread GitBox
acassis commented on issue #7086: URL: https://github.com/apache/incubator-nuttx/issues/7086#issuecomment-1246020006 Hi @greg5678 unfortunately you cannot just copy a new directory from apps to old NuttX version neither vice-versa. You need to adapt the Makefile/Make.defs/Kconfig and eve

[GitHub] [incubator-nuttx] acassis opened a new pull request, #7087: net/w5500: Fix small typo

2022-09-13 Thread GitBox
acassis opened a new pull request, #7087: URL: https://github.com/apache/incubator-nuttx/pull/7087 ## Summary Fix small typo ## Impact It will fix compilation error ## Testing With external W5500 module -- This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] greg5678 opened a new issue, #7086: Any chance of getting netcat working on Nuttx 8.2?

2022-09-13 Thread GitBox
greg5678 opened a new issue, #7086: URL: https://github.com/apache/incubator-nuttx/issues/7086 So, it seems the Particle Photon's network functionality isn't working on the current version of Nuttx, but it does work on Nuttx 8.2. Is it possible to get netcat working on this older version of

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7084: drivers/mmcsd: Remove executable permissions from source files

2022-09-13 Thread GitBox
hartmannathan commented on PR #7084: URL: https://github.com/apache/incubator-nuttx/pull/7084#issuecomment-1245660934 > Maybe we can add some check to avoid it happen again. It's a good idea. Currently I am checking for this manually. An automatic check in GitHub pre-chec

[incubator-nuttx] branch master updated: drivers: Fix some Kconfig help texts

2022-09-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1913163c64 drivers: Fix some Kconfig

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7085: drivers: Fix some Kconfig help texts

2022-09-13 Thread GitBox
xiaoxiang781216 merged PR #7085: URL: https://github.com/apache/incubator-nuttx/pull/7085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6833: SMP: fix crash when switch to new task which is still running

2022-09-13 Thread GitBox
xiaoxiang781216 commented on PR #6833: URL: https://github.com/apache/incubator-nuttx/pull/6833#issuecomment-1245559597 let's add all arch? Otherwise people may forget to apply this change to other arch if they implement SMP for that arch someday. -- This is an automated message from the

[incubator-nuttx] branch master updated: drivers/mmcsd: Remove executable permissions from source files

2022-09-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 00666a8778 drivers/mmcsd: Remove exe

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7084: drivers/mmcsd: Remove executable permissions from source files

2022-09-13 Thread GitBox
xiaoxiang781216 merged PR #7084: URL: https://github.com/apache/incubator-nuttx/pull/7084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7084: drivers/mmcsd: Remove executable permissions from source files

2022-09-13 Thread GitBox
xiaoxiang781216 commented on PR #7084: URL: https://github.com/apache/incubator-nuttx/pull/7084#issuecomment-1245552357 Maybe we can add some check to avoid it happen again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7083: sockopt:Change the flow of function psock_setsockopt and psock_getsockopt

2022-09-13 Thread GitBox
xiaoxiang781216 commented on PR #7083: URL: https://github.com/apache/incubator-nuttx/pull/7083#issuecomment-1245551175 BTW, could you run sim:usrsocktest to ensure the change doesn't break anything. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #7085: drivers: Fix some Kconfig help texts

2022-09-13 Thread GitBox
hartmannathan opened a new pull request, #7085: URL: https://github.com/apache/incubator-nuttx/pull/7085 ## Summary Fix some help texts in Kconfig. ## Impact Improves readability. ## Testing None. -- This is an automated message from the Apache Git Servic

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #7084: drivers/mmcsd: Remove executable permissions from source files

2022-09-13 Thread GitBox
hartmannathan opened a new pull request, #7084: URL: https://github.com/apache/incubator-nuttx/pull/7084 ## Summary Remove executable permissions from source files. ## Impact Corrects the incorrect permissions. ## Testing nxstyle -- This is an automated m

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7083: sockopt:Change the flow of function psock_setsockopt and psock_getsockopt

2022-09-13 Thread GitBox
xiaoxiang781216 commented on code in PR #7083: URL: https://github.com/apache/incubator-nuttx/pull/7083#discussion_r969503102 ## net/socket/getsockopt.c: ## @@ -337,50 +337,51 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, return -EBADF; }

[GitHub] [incubator-nuttx] vuhuyhop197 commented on issue #7082: Change the flow code of function psock_setsockopt

2022-09-13 Thread GitBox
vuhuyhop197 commented on issue #7082: URL: https://github.com/apache/incubator-nuttx/issues/7082#issuecomment-1245232929 The origin code flow: setsockopt -> psock_setsockopt -> psock_socketlevel_option. We want to change: setsockopt -> psock_setsockopt -> usrsock_setsockopt if CONFIG_NET_U

[GitHub] [incubator-nuttx] vuhuyhop197 commented on a diff in pull request #7083: sockopt:Change the flow of function psock_setsockopt and psock_getsockopt

2022-09-13 Thread GitBox
vuhuyhop197 commented on code in PR #7083: URL: https://github.com/apache/incubator-nuttx/pull/7083#discussion_r969460910 ## net/socket/getsockopt.c: ## @@ -337,50 +337,51 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, return -EBADF; } -

[GitHub] [incubator-nuttx] vuhuyhop197 commented on issue #7082: Change the flow code of function psock_setsockopt

2022-09-13 Thread GitBox
vuhuyhop197 commented on issue #7082: URL: https://github.com/apache/incubator-nuttx/issues/7082#issuecomment-1245209854 @xiaoxiang781216 In the case of enabling CONFIG_NET_USRSOCK, we want psock_setsockopt process usrsock_setsockopt first. Because we have written a wrapper for usrsock_set

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7083: sockopt:Change the flow of function psock_setsockopt and psock_getsockopt

2022-09-13 Thread GitBox
xiaoxiang781216 commented on code in PR #7083: URL: https://github.com/apache/incubator-nuttx/pull/7083#discussion_r969419711 ## net/socket/getsockopt.c: ## @@ -337,50 +337,51 @@ int psock_getsockopt(FAR struct socket *psock, int level, int option, return -EBADF; }

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7064: armv7-a: icache also need SMP cache coherency configuration

2022-09-13 Thread GitBox
xiaoxiang781216 merged PR #7064: URL: https://github.com/apache/incubator-nuttx/pull/7064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: armv7-a: icache also need SMP cache coherency configuration

2022-09-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new bedd5d382d armv7-a: icache also need

[GitHub] [incubator-nuttx] ethanlcz commented on issue #7082: Change the flow code of function psock_setsockopt

2022-09-13 Thread GitBox
ethanlcz commented on issue #7082: URL: https://github.com/apache/incubator-nuttx/issues/7082#issuecomment-1245165218 > think the code flow should be: Could you please help to describe the issue you met in detail? I think your patch might introduce other issues, for example, in ori

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7082: Change the flow code of function psock_setsockopt

2022-09-13 Thread GitBox
xiaoxiang781216 commented on issue #7082: URL: https://github.com/apache/incubator-nuttx/issues/7082#issuecomment-1245164049 which option do you want the wifi chip process first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] vuhuyhop197 opened a new pull request, #7083: sockopt:Change the flow of function psock_setsockopt and psock_getsockopt

2022-09-13 Thread GitBox
vuhuyhop197 opened a new pull request, #7083: URL: https://github.com/apache/incubator-nuttx/pull/7083 ## Summary See the issue: #7082 ## Impact Prioritize to call usrsock_getsockopt / usrsock_setsockopt when enable CONFIG_NET_USRSOCK ## Testing -- This is an autom

[GitHub] [incubator-nuttx] vuhuyhop197 commented on issue #7082: Change the flow code of function psock_setsockopt

2022-09-13 Thread GitBox
vuhuyhop197 commented on issue #7082: URL: https://github.com/apache/incubator-nuttx/issues/7082#issuecomment-1245076977 The issue is the same with psock_getsockopt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7076: Remove duplicate calls and optimize compilation speed

2022-09-13 Thread GitBox
Gary-Hobson commented on code in PR #7076: URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r969291133 ## tools/Config.mk: ## @@ -555,26 +555,34 @@ endef # ARCHxxx means the predefined setting(either toolchain, arch, or system specific) -ARCHDEFINES += $

[GitHub] [incubator-nuttx] Gary-Hobson commented on pull request #7076: Remove duplicate calls and optimize compilation speed

2022-09-13 Thread GitBox
Gary-Hobson commented on PR #7076: URL: https://github.com/apache/incubator-nuttx/pull/7076#issuecomment-1245038893 > LGTM with the following caveat: I only tested ARM builds with GCC, since that is the only platform for which I have a toolchain currently. Hopefully this doesn't break anyth

[GitHub] [incubator-nuttx] vuhuyhop197 opened a new issue, #7082: Change the flow code of function psock_setsockopt

2022-09-13 Thread GitBox
vuhuyhop197 opened a new issue, #7082: URL: https://github.com/apache/incubator-nuttx/issues/7082 We are implementing a USRSOCK for our WIFI chip. The issue is the function psock_setsockopt doesn't call usrsock_setsockopt. Because it prioritizes checking the protocol level. I think the code