xiaotailang commented on issue #7215:
URL:
https://github.com/apache/incubator-nuttx/issues/7215#issuecomment-1272207828
> Hi @xiaotailang please give more information. We don't know that board you
are using, what config you are using, which steps you took to enable it, etc.
Please describ
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990573077
##
boards/sim/sim/sim/configs/ci_ostest/defconfig:
##
@@ -0,0 +1,76 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig"
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990572930
##
tools/testbuild.sh:
##
@@ -320,7 +320,11 @@ function refresh {
function run {
if [ ${RUN} -ne 0 ]; then
-run_script="$path/run"
+if [ -f $path/run
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990572895
##
.github/workflows/build.yml:
##
@@ -161,6 +161,7 @@ jobs:
git config --global --add safe.directory
/github/workspace/sources/apps
cd
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d8f9c60e9e boards/tm4c129e-launchpad:
masayuki2009 merged PR #7253:
URL: https://github.com/apache/incubator-nuttx/pull/7253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 0d52b5be56 mpfs_mm_init: Mark the L2 kernel page table as a global
mapping
add 4e095d2e90 arch: risc
xiaoxiang781216 merged PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990568619
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/**
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 05d1416 Publishing web
acassis commented on PR #7253:
URL: https://github.com/apache/incubator-nuttx/pull/7253#issuecomment-1271997139
Why MacOS test is cancelling when we click in re-run? Why is the MacOS' CI
so faulty?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
acassis commented on issue #7232:
URL:
https://github.com/apache/incubator-nuttx/issues/7232#issuecomment-1271990378
Hi @SPRESENSE do you know if "make export" was working in the paste when
```CONFIG_ARCH_BOARD_COMMON``` was selected?
--
This is an automated message from the Apache Git S
masayuki2009 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990331657
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/*
hartmannathan opened a new pull request, #7253:
URL: https://github.com/apache/incubator-nuttx/pull/7253
## Summary
Since priority inheritance boost restoration has been fixed in PR #6318, the
priority inheritance tests in `ostest` now pass.
This PR enables priority inheritance
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a change to branch tm4c129e-launchpad-ostest-prio
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
at 422bf1a3f0 boards/tm4c129e-launchpad: Enable priority inheritance in
ostest c
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a commit to branch tm4c129e-launchpad-ostest-prio
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 422bf1a3f0d65d9144329da00a66379215379920
Author: Nathan Hartman <59230071+hartman
hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1271756120
Thank you for all your work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1271755517
@pkarashchenko Finally got back and was able to test. Happy to report the
test **passes** on tm4c129e-launchpad:ostest with priority inheritance enabled!
--
This is an aut
xiaoxiang781216 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990185619
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/**
masayuki2009 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990052145
##
arch/risc-v/src/common/riscv_cpustart.c:
##
@@ -38,8 +38,21 @@
#include "sched/sched.h"
#include "init/init.h"
#include "riscv_internal.h"
+
+#ifdef C
masayuki2009 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990030405
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/*
masayuki2009 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990030405
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/*
xiaoxiang781216 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990015140
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/**
xiaoxiang781216 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r990015140
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/**
masayuki2009 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r989927588
##
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##
@@ -144,13 +146,22 @@ void qemu_rv_start(int mhartid)
#ifdef CONFIG_BUILD_KERNEL
+/*
masayuki2009 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r989921215
##
arch/risc-v/src/common/riscv_cpustart.c:
##
@@ -38,8 +38,21 @@
#include "sched/sched.h"
#include "init/init.h"
#include "riscv_internal.h"
+
+#ifdef C
xiaoxiang781216 commented on code in PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#discussion_r989902382
##
arch/risc-v/src/common/riscv_cpustart.c:
##
@@ -38,8 +38,21 @@
#include "sched/sched.h"
#include "init/init.h"
#include "riscv_internal.h"
+
+#ifde
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from df6bf3e614 arch: risc-v: Introduce RISCV_IPI macro for SMP
add dbc9a5ffa2 riscv_mmu: Add some basic s
xiaoxiang781216 merged PR #7246:
URL: https://github.com/apache/incubator-nuttx/pull/7246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989883167
##
fs/smartfs/smartfs_smart.c:
##
@@ -1406,22 +1406,22 @@ static int smartfs_readdir(FAR struct inode *mountpt,
sdir->fs_curroffset =
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989883011
##
fs/smartfs/smartfs_smart.c:
##
@@ -1977,21 +1962,21 @@ int smartfs_rename(struct inode *mountpt, const char
*oldrelpath,
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989882687
##
fs/smartfs/smartfs_utils.c:
##
@@ -284,8 +266,8 @@ int smartfs_mount(struct smartfs_mountpt_s *fs, bool
writeable)
g_mounthead = fs;
#endif
-
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989882085
##
fs/smartfs/smartfs_utils.c:
##
@@ -405,8 +387,8 @@ int smartfs_unmount(struct smartfs_mountpt_s *fs)
/* Set the buffer's to invalid value to
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989881832
##
fs/smartfs/smartfs_utils.c:
##
@@ -880,7 +862,7 @@ int smartfs_createentry(FAR struct smartfs_mountpt_s *fs,
readwrite.logsector = psector;
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989880759
##
fs/smartfs/smartfs_utils.c:
##
@@ -1121,15 +1103,15 @@ int smartfs_createentry(FAR struct smartfs_mountpt_s
*fs,
int smartfs_deleteentry(struct smar
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989879522
##
fs/smartfs/smartfs_utils.c:
##
@@ -1121,15 +1103,15 @@ int smartfs_createentry(FAR struct smartfs_mountpt_s
*fs,
int smartfs_deleteentry(struct smar
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989878847
##
fs/spiffs/src/spiffs_core.c:
##
@@ -183,7 +183,7 @@ static int spiffs_page_index_check(FAR struct spiffs_s *fs,
#ifdef CONFIG_SPIFFS_PAGE_CHECK
re
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989876748
##
fs/spiffs/src/spiffs_core.c:
##
@@ -1191,7 +1191,7 @@ int spiffs_page_move(FAR struct spiffs_s *fs,
*dst_pgndx = free_pgndx;
}
- phdr =
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989876206
##
fs/spiffs/src/spiffs_gc.c:
##
@@ -160,7 +160,7 @@ static int spiffs_gc_erase_block(FAR struct spiffs_s *fs,
int16_t blkndx)
static int spiffs_gc_e
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989875753
##
fs/smartfs/smartfs_utils.c:
##
@@ -1639,7 +1621,7 @@ off_t smartfs_seek_internal(FAR struct smartfs_mountpt_s
*fs,
sf->filepos = 0;
}
-
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989875284
##
fs/smartfs/smartfs_utils.c:
##
@@ -2030,7 +2012,7 @@ int smartfs_extendfile(FAR struct smartfs_mountpt_s *fs,
/* Copy the new sector to t
masayuki2009 commented on PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#issuecomment-1271282788
@xiaoxiang781216
I think this PR is much simpler than #7247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
masayuki2009 commented on PR #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252#issuecomment-1271281032
See the original discussion in
https://github.com/apache/incubator-nuttx/pull/7247
--
This is an automated message from the Apache Git Service.
To respond to the messag
masayuki2009 opened a new pull request, #7252:
URL: https://github.com/apache/incubator-nuttx/pull/7252
## Summary
- This commit adds SMP support for BUILD_KERNEL
## Impact
- RISC-V: BUILD_KERNEL + SMP only
## Testing
- Tested with QEMU 6.2
--
This is an
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989816966
##
fs/vfs/fs_eventfd.c:
##
@@ -50,7 +50,7 @@ typedef struct eventfd_waiter_sem_s
struct eventfd_priv_s
{
- sem_t exclsem;/* Enforces
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989811164
##
fs/vfs/fs_timerfd.c:
##
@@ -61,7 +62,7 @@ typedef struct timerfd_waiter_sem_s
struct timerfd_priv_s
{
- sem_t exclsem;/* Enforces
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989810227
##
include/nuttx/contactless/pn532.h:
##
@@ -57,8 +57,8 @@ struct pn532_config_s
/* External CS, if NULL then SPIDEV_WIRELESS(n) CS is used */
-
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989809866
##
fs/vfs/fs_timerfd.c:
##
@@ -282,10 +284,10 @@ static int timerfd_blocking_io(FAR struct timerfd_priv_s
*dev,
if (ret < 0)
{
/* Interru
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989807501
##
graphics/nxterm/nxterm.h:
##
@@ -110,7 +110,7 @@ struct nxterm_state_s
FAR const struct nxterm_operations_s *ops; /* Window operations */
FAR vo
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989806178
##
include/nuttx/analog/dac.h:
##
@@ -127,14 +128,14 @@ struct dac_ops_s
struct dac_dev_s
{
- const struct dac_ops_s *ad_ops; /* Arch-specific
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989804469
##
fs/smartfs/smartfs_smart.c:
##
@@ -763,14 +763,14 @@ static ssize_t smartfs_write(FAR struct file *filep,
const char *buffer,
*/
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989801921
##
fs/smartfs/smartfs_smart.c:
##
@@ -340,7 +340,7 @@ static int smartfs_open(FAR struct file *filep, const char
*relpath,
readwrite.logsector =
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989798995
##
fs/smartfs/smartfs.h:
##
@@ -33,7 +33,7 @@
#include
#include
-#include
+#include
Review Comment:
since it doesn't contain sem_t anymore
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989798391
##
fs/smartfs/smartfs_procfs.c:
##
@@ -90,7 +90,7 @@ struct smartfs_file_s
struct smartfs_procfs_entry_s
{
- const char *name; /* N
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989796044
##
fs/rpmsgfs/rpmsgfs.c:
##
@@ -308,21 +291,21 @@ static int rpmsgfs_open(FAR struct file *filep, FAR const
char *relpath,
DEBUGASSERT(fs != NULL);
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989795480
##
fs/procfs/fs_procfs.c:
##
@@ -947,7 +947,7 @@ static int procfs_rewinddir(struct inode *mountpt, struct
fs_dirent_s *dir)
if (priv->level > 0 &&
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989792272
##
fs/procfs/fs_procfs.c:
##
@@ -383,7 +383,7 @@ static int procfs_open(FAR struct file *filep, FAR const
char *relpath,
{
D
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989791707
##
fs/fat/fs_fat32.h:
##
@@ -1018,11 +1018,6 @@ EXTERN uint32_t fat_getuint32(uint8_t *ptr);
EXTERN void fat_putuint16(uint8_t *ptr, uint16_t value16)
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989788855
##
fs/nfs/nfs_mount.h:
##
@@ -68,7 +68,7 @@
struct nfsmount
{
FAR struct nfsnode *nm_head; /* A list of all files opened on
this mou
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989787921
##
drivers/wireless/nrf24l01.c:
##
@@ -329,7 +330,7 @@ static inline void nrf24l01_configspi(FAR struct spi_dev_s
*spi)
* Name: nrf24l01_select
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989787681
##
drivers/wireless/nrf24l01.c:
##
@@ -1077,15 +1078,15 @@ static ssize_t nrf24l01_write(FAR struct file *filep,
FAR const char *buffer,
DEBUGASSERT(
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989786030
##
drivers/wireless/nrf24l01.c:
##
@@ -338,7 +339,7 @@ static inline void nrf24l01_select(struct nrf24l01_dev_s *
dev)
* Name: nrf24l01_deselect
***
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989785163
##
drivers/wireless/lpwan/sx127x/sx127x.c:
##
@@ -867,8 +868,7 @@ static ssize_t sx127x_read(FAR struct file *filep, FAR char
*buffer,
ret = sx127x
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989778474
##
drivers/wireless/lpwan/sx127x/sx127x.c:
##
@@ -493,7 +494,7 @@ static void sx127x_unlock(FAR struct spi_dev_s *spi)
* Name: sx127x_select
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989776485
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_utils.h:
##
@@ -43,8 +41,6 @@
void bcmf_hexdump(uint8_t *data, unsigned int len, unsigned long offset);
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989773763
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_utils.h:
##
@@ -43,8 +41,6 @@
void bcmf_hexdump(uint8_t *data, unsigned int len, unsigned long offset);
R
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989768847
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -376,14 +376,14 @@ int bcmf_sdpcm_sendframe(FAR struct bcmf_dev_s *priv)
return -EAGAIN
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989768167
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi_f2_frame.c:
##
@@ -309,12 +309,12 @@ int bcmf_gspi_read_f2_frame(FAR struct bcmf_dev_s *priv,
int bcm
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989760753
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_driver.c:
##
@@ -1804,8 +1781,8 @@ int bcmf_wl_set_ssid(FAR struct bcmf_dev_s *priv, struct
iwreq *iwr)
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989759045
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi_f2_frame.c:
##
@@ -185,7 +185,7 @@ int bcmf_gspi_read_f2_frame(FAR struct bcmf_dev_s *priv,
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989758390
##
drivers/video/vnc/vnc_updater.c:
##
@@ -48,6 +48,9 @@
#include
#include
+#ifdef VNCSERVER_SEM_DEBUG
+#include
Review Comment:
Done
--
T
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989757760
##
drivers/video/video_framebuff.c:
##
@@ -252,7 +251,7 @@ void video_framebuff_capture_done(video_framebuff_t *fbuf)
}
}
-void video_framebuff_c
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989756616
##
drivers/video/video.c:
##
@@ -113,7 +114,7 @@ typedef struct video_format_s video_format_t;
struct video_type_inf_s
{
- sem_tlock
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989756253
##
drivers/usbmisc/fusb301.c:
##
@@ -529,7 +530,7 @@ static ssize_t fusb301_read(FAR struct file *filep,
ptr = (struct fusb301_result_s *)buffer;
R
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989755733
##
drivers/usbhost/usbhost_max3421e.c:
##
@@ -419,13 +414,6 @@ static void max3421e_sndblock(FAR struct
max3421e_usbhost_s *priv,
# define max3421e_pk
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989754949
##
drivers/audio/vs1053.c:
##
@@ -1751,12 +1751,12 @@ static int vs1053_reserve(FAR struct audio_lowerhalf_s
*lower,
static int vs1053_reserve(FAR stru
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989749850
##
drivers/usbhost/usbhost_hidkbd.c:
##
@@ -362,9 +357,9 @@ static uint32_t g_devinuse;
/* The following are used to managed the class creation operat
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989744471
##
drivers/usbdev/usbmsc_desc.c:
##
@@ -369,7 +369,7 @@ int16_t usbmsc_mkcfgdesc(uint8_t *buf,
{
/* Single interface descriptor */
- F
xiaoxiang781216 commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r989744195
##
drivers/syslog/syslog_device.c:
##
@@ -144,15 +144,6 @@ static inline int syslog_dev_takesem(FAR struct
syslog_dev_s *syslog_dev)
return nxrmutex_
79 matches
Mail list logo
