Re: [PR] Hardware Checksum Offload Support for NuttX Network Stack [nuttx]

2025-09-07 Thread via GitHub
acassis commented on PR #16940: URL: https://github.com/apache/nuttx/pull/16940#issuecomment-3263997669 > > All existing network applications function correctly > > How did you quantify this? Which applications did you run, on what hardware, and how did you verify that they worked cor

Re: [PR] arch/tricore: remove redundant and misleading pointer usage in tricore_doirq() [nuttx]

2025-09-07 Thread via GitHub
linguini1 merged PR #16981: URL: https://github.com/apache/nuttx/pull/16981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.ap

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-07 Thread via GitHub
linguini1 commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3263915135 > One remark @linguini1 we do not self-merge PRs :-P I apologize! Is there a way to enforce that in the GitHub merge rules? -- This is an automated message from the Apache G

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-07 Thread via GitHub
cederom commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3263910138 One remark @linguini1 we do not self-merge PRs :-P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-07 Thread via GitHub
trns1997 commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3255324129 ping @acassis @leducp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] tools/configure.sh: align tools/configure.sh with CmakeLists.txt [nuttx]

2025-09-07 Thread via GitHub
wangchdo opened a new pull request, #16974: URL: https://github.com/apache/nuttx/pull/16974 Add include patch to configure.sh when processing deconfig file to keep alignment with CmakeLists.txt *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blo

Re: [PR] Hardware Checksum Offload Support for NuttX Network Stack [nuttx]

2025-09-07 Thread via GitHub
linguini1 commented on PR #16940: URL: https://github.com/apache/nuttx/pull/16940#issuecomment-3263887336 > All existing network applications function correctly How did you quantify this? Which applications did you run, on what hardware, and how did you verify that they worked correct

Re: [PR] drivers/syslog: let syslog_write() return the maximum bytes writen through a channel [nuttx]

2025-09-07 Thread via GitHub
linguini1 commented on PR #16982: URL: https://github.com/apache/nuttx/pull/16982#issuecomment-3263886375 > ostest will cover the testing of this update Can you run OSTest and include the logs please? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] arch/xtensa: update E-Fuse driver on ESP32|S2|S3 [nuttx]

2025-09-07 Thread via GitHub
acassis merged PR #16975: URL: https://github.com/apache/nuttx/pull/16975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [I] [FEATURE] raspberrypi pico w/2/2w firmware flashing automation with make flash [nuttx]

2025-09-07 Thread via GitHub
linguini1 commented on issue #16271: URL: https://github.com/apache/nuttx/issues/16271#issuecomment-3263858196 > > @linguini1 Have a bootloader that puts the RP2040 into BOOTSEL when it detects something like 1200 baud on a UART line > > In my RP2040 board I have implemented this over

[PR] drivers/syslog: let syslog_write() return the maximum bytes writen through a channel [nuttx]

2025-09-07 Thread via GitHub
wangchdo opened a new pull request, #16982: URL: https://github.com/apache/nuttx/pull/16982 In current implementation, when do syslog_write(), there may be more than one channel, the syslog will iterate each channel, but only return the bytes writen through the last channel, the

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-07 Thread via GitHub
trns1997 commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3253429464 > [@leducp](https://github.com/leducp) did you get that same issue on your board? @acassis it seems to occur on all boards, i tried with the xmc4800 and i have the same error

[PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-07 Thread via GitHub
trns1997 opened a new pull request, #16976: URL: https://github.com/apache/nuttx/pull/16976 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary `make export` currently fails with the warning: ``` cp: cann

Re: [PR] sched/event: add nxevent_clear api [nuttx]

2025-09-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16920: URL: https://github.com/apache/nuttx/pull/16920#discussion_r2324889796 ## sched/event/event_clear.c: ## @@ -0,0 +1,71 @@ +/ + * sched/event/event_clear.c +

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-07 Thread via GitHub
leducp commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3257709832 What about adding a CI test linking a C++ helloworld with CMake to avoid regression in the future? (At least from a compile POV). -- This is an automated message from the Apache Git Serv

Re: [PR] doc: Update CMake C++ guide [nuttx]

2025-09-07 Thread via GitHub
leducp commented on PR #16970: URL: https://github.com/apache/nuttx/pull/16970#issuecomment-3257700071 It seems the build is broken since this commit: 422c43949a95845712b31ea8f1260e2f964aa5cf @trns1997 can you cross check on your side? -- This is an automated message from the Apach

Re: [I] [FEATURE] raspberrypi pico w/2/2w firmware flashing automation with make flash [nuttx]

2025-09-07 Thread via GitHub
nmaggioni commented on issue #16271: URL: https://github.com/apache/nuttx/issues/16271#issuecomment-3263701404 > @linguini1 Have a bootloader that puts the RP2040 into BOOTSEL when it detects something like 1200 baud on a UART line In my RP2040 board I have implemented this over USB C

[PR] arch/tricore: remove redundant and misleading pointer usage in tricore_doirq() [nuttx]

2025-09-07 Thread via GitHub
wangchdo opened a new pull request, #16981: URL: https://github.com/apache/nuttx/pull/16981 'struct tcb_s **running_task = &g_running_tasks[this_cpu()];' was updated to 'struct tcb_s *running_task = g_running_tasks[this_cpu()];' 'if (*running_task != NULL) {

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-07 Thread via GitHub
hartmannathan commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2323902595 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from multiprocessing import Pool +fro

Re: [PR] sched/event: add nxevent_getmask api [nuttx]

2025-09-07 Thread via GitHub
wangchdo closed pull request #16980: sched/event: add nxevent_getmask api URL: https://github.com/apache/nuttx/pull/16980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] sched/event: add nxevent_getmask api [nuttx]

2025-09-07 Thread via GitHub
wangchdo opened a new pull request, #16980: URL: https://github.com/apache/nuttx/pull/16980 In certain cases, when the event-wait thread is awakened, it needs to know the specific mask bit that triggered it, so that it can branch to different paths accordingly. This pat

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-06 Thread via GitHub
tmedicci commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3258103437 Should we add a documentation page about it? Explaining that we have codeowners, how can we eventually get in touch when opening an issue/PR etc? -- This is an automated message from t

Re: [PR] arch/tricore: add one_shot .tick_start implementation [nuttx]

2025-09-06 Thread via GitHub
acassis merged PR #16971: URL: https://github.com/apache/nuttx/pull/16971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-06 Thread via GitHub
acassis commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3258106403 > Should we add a documentation page about it? Explaining that we have codeowners, how can we eventually get in touch when opening an issue/PR etc? Good point! -- This is an auto

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-06 Thread via GitHub
hartmannathan commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2320485764 ## tools/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from typing import TypeAlias + +# Number of past

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-06 Thread via GitHub
linguini1 commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3258531099 > Should we add a documentation page about it? Explaining that we have codeowners, how can we eventually get in touch when opening an issue/PR etc? I will open a PR for that!

Re: [PR] sched/printk: add nxprintk() to support syncronous printf function for kernel debug [nuttx]

2025-09-06 Thread via GitHub
wangchdo commented on PR #16977: URL: https://github.com/apache/nuttx/pull/16977#issuecomment-3262491514 @acassis @xiaoxiang781216 @hartmannathan @linguini1 Thanks for your comments. What I need is a lightweight, synchronous printf function, which I will mainly use for debugging. Per

Re: [PR] sched/printk: add nxprintk() to support syncronous printf function for kernel debug [nuttx]

2025-09-06 Thread via GitHub
linguini1 commented on PR #16977: URL: https://github.com/apache/nuttx/pull/16977#issuecomment-3262496180 > @acassis @xiaoxiang781216 @hartmannathan @linguini1 > Thanks for your comments. What I need is a **lightweight**, **synchronous** printf function, which I will mainly use for debu

Re: [PR] docs/codeowners: Provide some relevant information about CODEOWNERS. [nuttx]

2025-09-05 Thread via GitHub
xiaoxiang781216 merged PR #16978: URL: https://github.com/apache/nuttx/pull/16978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-05 Thread via GitHub
trns1997 commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3257715424 > What about adding a CI test linking a C++ helloworld with CMake to avoid regression in the future? (At least from a compile POV). Totally agree, lets fix up all this get it funct

Re: [PR] nshlib/nsh_builtin.c : Add support to run builtin dirrectly without creating a separate thread [nuttx-apps]

2025-09-05 Thread via GitHub
xiaoxiang781216 commented on PR #3168: URL: https://github.com/apache/nuttx-apps/pull/3168#issuecomment-3258097206 @wangchdo my comment isn't addressed yet, BTW the build error need fix too -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] docs/codeowners: Provide some relevant information about CODEOWNERS. [nuttx]

2025-09-05 Thread via GitHub
linguini1 commented on code in PR #16978: URL: https://github.com/apache/nuttx/pull/16978#discussion_r2326285631 ## Documentation/contributing/making-changes.rst: ## @@ -265,6 +265,21 @@ squash before submitting the Pull Request: happy, they may suggest squashing and merging

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-05 Thread via GitHub
linguini1 merged PR #16962: URL: https://github.com/apache/nuttx/pull/16962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.ap

Re: [PR] sched/printk: add nxprintk() to support syncronous printf function for kernel debug [nuttx]

2025-09-05 Thread via GitHub
acassis commented on PR #16977: URL: https://github.com/apache/nuttx/pull/16977#issuecomment-3258056208 @wangchdo please see https://github.com/apache/nuttx/commit/2b445ddcccea1747f840e87ba92e4cf5dd005241 for reference, in the past NuttX used to have a lowsyslog() and it was removed in fav

Re: [PR] docs/codeowners: Provide some relevant information about CODEOWNERS. [nuttx]

2025-09-05 Thread via GitHub
fdcavalcanti commented on code in PR #16978: URL: https://github.com/apache/nuttx/pull/16978#discussion_r2326115569 ## Documentation/contributing/making-changes.rst: ## @@ -265,6 +265,21 @@ squash before submitting the Pull Request: happy, they may suggest squashing and merg

Re: [PR] documentation: update NTP and NTPC documentation [nuttx]

2025-09-05 Thread via GitHub
cederom merged PR #16979: URL: https://github.com/apache/nuttx/pull/16979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] system/ntpc: update ntpc messages [nuttx-apps]

2025-09-05 Thread via GitHub
cederom merged PR #3173: URL: https://github.com/apache/nuttx-apps/pull/3173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [I] [FEATURE] Complete RPi 4B I2C driver [nuttx]

2025-09-05 Thread via GitHub
linguini1 commented on issue #16937: URL: https://github.com/apache/nuttx/issues/16937#issuecomment-3259606603 Relevant section of the BCM2711 peripherals datasheet is `Chapter 3: BSC`. Some of the implementation for the I2C driver existed prior to now and did work for I2C reads, but

[PR] documentation: update NTP and NTPC documentation [nuttx]

2025-09-05 Thread via GitHub
fdcavalcanti opened a new pull request, #16979: URL: https://github.com/apache/nuttx/pull/16979 ## Summary This PR adds documentation for NTP client and daemon which did not exist. Relates to this [PR](https://github.com/apache/nuttx-apps/pull/3173) on nuttx-apps. ## Imp

[PR] system/ntpc: update ntpc messages [nuttx-apps]

2025-09-05 Thread via GitHub
fdcavalcanti opened a new pull request, #3173: URL: https://github.com/apache/nuttx-apps/pull/3173 ## Summary This PR updates verbosity on ntpc commands. Also updated documentation on NuttX side. ## Impact No impact for user, build or hardware. Only changes some program

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-05 Thread via GitHub
cederom commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3259315587 * I hope build pass this time :-) * Git commit message contains old location reference in `tools/`. * We may add comment in the ignore file like "# this file contains authors that ar

Re: [PR] doc: Update CMake C++ guide [nuttx]

2025-09-05 Thread via GitHub
trns1997 commented on PR #16970: URL: https://github.com/apache/nuttx/pull/16970#issuecomment-3257705519 > It seems the build is broken since this commit: [422c439](https://github.com/apache/nuttx/commit/422c43949a95845712b31ea8f1260e2f964aa5cf) > > @trns1997 can you cross check on yo

Re: [PR] mtd/nvs: Trigger `POLLPRI` on config change [nuttx]

2025-09-05 Thread via GitHub
xiaoxiang781216 merged PR #16972: URL: https://github.com/apache/nuttx/pull/16972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] docs/codeowners: Provide some relevant information about CODEOWNERS. [nuttx]

2025-09-05 Thread via GitHub
linguini1 opened a new pull request, #16978: URL: https://github.com/apache/nuttx/pull/16978 ## Summary Some brief information in the contributing workflow to tell new contributors about the CODEOWNERS file and what it achieves. ## Impact Provides information about the C

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-05 Thread via GitHub
raiden00pl commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2325406740 ## .codespellrc: ## @@ -8,6 +8,7 @@ exclude-file = .codespell-ignore-lines # Ignore complete files (e.g. legal text or other immutable material). skip = LICENSE

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-05 Thread via GitHub
linguini1 commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2325405267 ## .codespellrc: ## @@ -8,6 +8,7 @@ exclude-file = .codespell-ignore-lines # Ignore complete files (e.g. legal text or other immutable material). skip = LICENSE,

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-05 Thread via GitHub
raiden00pl commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2325402259 ## .codespellrc: ## @@ -8,6 +8,7 @@ exclude-file = .codespell-ignore-lines # Ignore complete files (e.g. legal text or other immutable material). skip = LICENSE

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-05 Thread via GitHub
linguini1 commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3258752891 Still, any ideas about fixing the codespell file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] doc: Update CMake C++ guide [nuttx]

2025-09-05 Thread via GitHub
trns1997 commented on PR #16970: URL: https://github.com/apache/nuttx/pull/16970#issuecomment-3258700291 @leducp if you use this `toolchain.cmake` the app should build: ``` set(CMAKE_SYSTEM_NAME Generic) set(CMAKE_SYSTEM_VERSION 1) set(NUTTX 1) set(CMAKE_TRY_COMPILE_TARGET_

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-05 Thread via GitHub
trns1997 commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3258692508 @leducp was right in comment: https://github.com/apache/nuttx/pull/16970#issuecomment-3257700071. This commit is caused the issue. The commit moved/centralized `crt0.c` from arch/* into

Re: [PR] sched/event: add nxevent_clear api [nuttx]

2025-09-05 Thread via GitHub
wangchdo commented on code in PR #16920: URL: https://github.com/apache/nuttx/pull/16920#discussion_r2324940520 ## sched/event/event_clear.c: ## @@ -0,0 +1,71 @@ +/ + * sched/event/event_clear.c + * + *

Re: [PR] sched/printk: add nxprintk() to support syncronous printf function for kernel debug [nuttx]

2025-09-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16977: URL: https://github.com/apache/nuttx/pull/16977#discussion_r2324891755 ## sched/printk/printk.c: ## @@ -0,0 +1,82 @@ +/ + * sched/printk/printk.c + * + * S

Re: [PR] doc: Update CMake C++ guide [nuttx]

2025-09-05 Thread via GitHub
leducp commented on PR #16970: URL: https://github.com/apache/nuttx/pull/16970#issuecomment-3257439561 > @leducp since `nuttx-12.10.0` i get the following error when trying to build the app: > > ``` > ➜ build make > [ 33%] Building CXX object src/CMakeFiles/hello.dir/HelloWorld

Re: [PR] arch/xtensa: update E-Fuse driver on ESP32|S2|S3 [nuttx]

2025-09-05 Thread via GitHub
acassis commented on code in PR #16975: URL: https://github.com/apache/nuttx/pull/16975#discussion_r2324819572 ## arch/xtensa/src/common/espressif/esp_efuse.c: ## @@ -0,0 +1,379 @@ +/ + * arch/xtensa/src

Re: [PR] sched/event: add nxevent_clear api [nuttx]

2025-09-05 Thread via GitHub
wangchdo commented on code in PR #16920: URL: https://github.com/apache/nuttx/pull/16920#discussion_r2324636794 ## sched/event/event_clear.c: ## @@ -0,0 +1,69 @@ +/ + * sched/event/event_clear.c + * + *

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-05 Thread via GitHub
trns1997 commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3257412856 When running: ``` ./tools/configure.sh -E -l stm32f4discovery:nsh && make export -j8 ``` with set -e enabled, the build stops with: ``` make: *** [tools/Unix.mk:781: expo

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-05 Thread via GitHub
trns1997 commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3257385667 @anchao i prefere option 2 as well but doesn't this already do the trick: ``` APPLD=gnu-elf.ld if [ -f "${BOARDDIR}/scripts/${APPLD}" ]; then cp -f "${BOARDDIR}/scripts/$

[PR] sched/printk: add nxprintk() to support syncronous printf function for kernel debug [nuttx]

2025-09-05 Thread via GitHub
wangchdo opened a new pull request, #16977: URL: https://github.com/apache/nuttx/pull/16977 The syncronous printf function is needed in some cases during kernel debug, so provide nxprintk() here。 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nutt

Re: [PR] sched: remove csection in event [nuttx]

2025-09-04 Thread via GitHub
GUIDINGLI merged PR #16933: URL: https://github.com/apache/nuttx/pull/16933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.ap

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
linguini1 commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3251160667 Would someone mind helping me exclude the CODEOWNERS file from the codespell check? I thought I had done it in accordance with the documented way, but it appears I've still got somethin

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-04 Thread via GitHub
anchao commented on PR #16976: URL: https://github.com/apache/nuttx/pull/16976#issuecomment-3256866431 @trns1997 @acassis Thanks for your detailed analysis! `CONFIG_LIBC_MODLIB` has been deprecated in commit https://github.com/apache/nuttx/pull/15765 and is now named `CONFIG_LIBC_M

Re: [PR] tools/configure.sh: align tools/configure.sh with CmakeLists.txt [nuttx]

2025-09-04 Thread via GitHub
anchao merged PR #16974: URL: https://github.com/apache/nuttx/pull/16974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] fix missing gnu-elf.ld cp when generating export [nuttx]

2025-09-04 Thread via GitHub
acassis commented on code in PR #16976: URL: https://github.com/apache/nuttx/pull/16976#discussion_r2323412562 ## tools/mkexport.sh: ## @@ -185,10 +187,15 @@ cp "${TOPDIR}/tools/incdir.c" "${EXPORTDIR}/tools/." # Copy the board specific linker if found, or use the default when

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
leducp commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3255317684 Agree: it is easy to copy this file only if it was generated. IMHO the copy should also fail the job since now there is an option activated by the user. -- This is an automated mess

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
acassis commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3255281503 @trns1997 nice catch. But I think you shouldn't force the generation of this gnu-elf.ld since CONFIG_LIBC_MODLIB is not enabled and probably some program will not be able to use it l

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
trns1997 commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3255162998 So `mkexport.sh`. The script still assumes that `gnu-elf.ld` always exists, but that file was removed and replaced with a template `gnu-elf.ld.in`. The actual `gnu-elf.ld` is only g

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
trns1997 commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3255095805 @acassis it is more this commit the real culprit: https://github.com/apache/nuttx/commit/657247bda89d60112d79bb9b8d223eca5f9641b5 -- This is an automated message from the Apache G

Re: [PR] doc: Update CMake C++ guide [nuttx]

2025-09-04 Thread via GitHub
trns1997 commented on PR #16970: URL: https://github.com/apache/nuttx/pull/16970#issuecomment-3254893411 @leducp since `nuttx-12.10.0` i get the following error when trying to build the app: ``` ➜ build make [ 33%] Building CXX object src/CMakeFiles/hello.dir/HelloWorld.cpp.obj

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
acassis commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3254954924 Nice work @leducp ! @anchao could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3254946134 Very nice speedup :-) Time depends mostly on CPU. I am surprised to see ZRAID was 2x faster than TMPFS RAMDISK!! Usually its the opposite o_O * 4xHDD/ZRAID: 3m0,11s real49m4

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2322986034 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from multiprocessing import Pool +from typi

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
linguini1 commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2323016047 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from multiprocessing import Pool +from ty

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2322994724 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from multiprocessing import Pool +from typi

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2322988661 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from multiprocessing import Pool +from typi

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2322987560 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from multiprocessing import Pool +from typi

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
trns1997 commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3254873448 This bug started occurring since `nuttx-12.9.0`, all releases before this version show no sign of failing `cp` -- This is an automated message from the Apache Git Service. To resp

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2322984705 ## tools/codeowners/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + Review Comment: Please add Apache license here :-) -- This is an automated mes

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
fdcavalcanti commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3254805867 > I've updated the script to use a process pool and it's been sped up significantly: > > ``` > real 6m18.345s > user 100m55.799s > sys12m25.601s

Re: [PR] doc: Update CMake C++ guide [nuttx]

2025-09-04 Thread via GitHub
trns1997 commented on code in PR #16970: URL: https://github.com/apache/nuttx/pull/16970#discussion_r2322942289 ## Documentation/guides/cpp_cmake.rst: ## @@ -82,154 +88,68 @@ Creating the project set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD_REQUIRED ON) -# s

Re: [I] [HELP] add 802.1Q header [nuttx]

2025-09-04 Thread via GitHub
matiamic commented on issue #16814: URL: https://github.com/apache/nuttx/issues/16814#issuecomment-3252624759 Sounds like expected behavior of [`arp_out`](https://github.com/apache/nuttx/blob/b5f6620a4c85735b28bbfdf2a806f4f40ea4de95/net/arp/arp_out.c#L106-L133). This should happen onl

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
linguini1 commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2320493301 ## tools/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from typing import TypeAlias + +# Number of past log

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
linguini1 commented on code in PR #16962: URL: https://github.com/apache/nuttx/pull/16962#discussion_r2320493301 ## tools/codeowners.py: ## @@ -0,0 +1,179 @@ +#!/usr/bin/env python3 + +import re +import subprocess +import sys +from typing import TypeAlias + +# Number of past log

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
linguini1 commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3254585939 I've updated the script to use a process pool and it's been sped up significantly: ``` real 6m18.345s user 100m55.799s sys 12m25.601s ``` Thank you for the sug

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
leducp commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3254158447 Here is the output using nuttx-12.7.0 commit 4ac2a5a (the one in use at my workplace): ``` P:➜ nuttx find . -name gnu-elf.ld ./binfmt/libelf/gnu-elf.ld ./libs/libc/modlib/

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
leducp commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3254131110 I have this problem on a recent version: I will try on an older one. I think this version should be auto generated in most cases from "libs/libc/elf/gnu-elf.ld.in" and that's wh

[PR] arch/xtensa: update E-Fuse driver on ESP32|S2|S3 [nuttx]

2025-09-04 Thread via GitHub
fdcavalcanti opened a new pull request, #16975: URL: https://github.com/apache/nuttx/pull/16975 ## Summary - arch/xtensa/esp32: Update E-Fuse driver Updates E-Fuse driver for ESP32, now sharing a common implementation across Xtensa devices. - arch/xtensa/esp32s2: Update E-

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
cederom commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3253715011 Maybe comparison with some existing python modules for git repo analysis may give some hints on how they deal with large amount of information processing faster? Probably async and thread

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
acassis commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3253495910 @trns1997 that is strange because this file doesn't exist there, maybe it was there as was moved to other place: ``` $ find . -name gnu-elf.ld ./boards/risc-v/k230/canmv2

Re: [PR] docs/codeowners: Add preliminary code owner file [nuttx]

2025-09-04 Thread via GitHub
fdcavalcanti commented on PR #16962: URL: https://github.com/apache/nuttx/pull/16962#issuecomment-3253476803 > Even with limiting to 25 logs only, this takes too long to run: > > ``` > real 62m33.696s > user 55m50.849s > sys6m34.291s > ``` > > Sug

Re: [PR] mtd/nvs: Trigger `POLLPRI` on config change [nuttx]

2025-09-04 Thread via GitHub
JianyuWang0623 commented on code in PR #16972: URL: https://github.com/apache/nuttx/pull/16972#discussion_r2321836502 ## drivers/mtd/mtd_config_fs.c: ## @@ -2048,6 +2049,11 @@ static int mtdconfig_ioctl(FAR struct file *filep, int cmd, /* Write a nvs item. */

Re: [I] [BUG] Non-blocking make export error: missing gnu-elf.ld [nuttx]

2025-09-04 Thread via GitHub
acassis commented on issue #16973: URL: https://github.com/apache/nuttx/issues/16973#issuecomment-3253268449 @leducp did you get that same issue on your board? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] [HELP] add 802.1Q header [nuttx]

2025-09-04 Thread via GitHub
acassis commented on issue #16814: URL: https://github.com/apache/nuttx/issues/16814#issuecomment-3253247352 Hi @ken-hutchinson, is it possible to you share your code? This way more people could analyze and help to test. I see that NuttX has some support to 802.1Q, but there is no documenta

Re: [PR] nshlib/nsh_builtin.c : Add support to run builtin dirrectly without creating a separate thread [nuttx-apps]

2025-09-04 Thread via GitHub
wangchdo commented on PR #3168: URL: https://github.com/apache/nuttx-apps/pull/3168#issuecomment-3253240630 > @wangchdo Great idea—thank you! And I have some questions. > > This conflicts with the background configuration (where `CONFIG_NSH_DISABLEBG=n`). Since "sh" is executed as a c

Re: [PR] nshlib/nsh_builtin.c : Add support to run builtin dirrectly without creating a separate thread [nuttx-apps]

2025-09-04 Thread via GitHub
JianyuWang0623 commented on PR #3168: URL: https://github.com/apache/nuttx-apps/pull/3168#issuecomment-3253075035 @wangchdo Great idea—thank you! And I have some questions. This conflicts with the background configuration (where `CONFIG_NSH_DISABLEBG=n`). Since "sh" is executed as a c

Re: [PR] mtd/nvs: Trigger `POLLPRI` on config change [nuttx]

2025-09-04 Thread via GitHub
anchao commented on code in PR #16972: URL: https://github.com/apache/nuttx/pull/16972#discussion_r2321506029 ## drivers/mtd/mtd_config_fs.c: ## @@ -2048,6 +2049,11 @@ static int mtdconfig_ioctl(FAR struct file *filep, int cmd, /* Write a nvs item. */ ret =

Re: [PR] mtd/nvs: Trigger `POLLPRI` on config change [nuttx]

2025-09-03 Thread via GitHub
JianyuWang0623 commented on code in PR #16972: URL: https://github.com/apache/nuttx/pull/16972#discussion_r2320764551 ## drivers/mtd/mtd_config_fs.c: ## @@ -2095,10 +2101,18 @@ static int mtdconfig_ioctl(FAR struct file *filep, int cmd, static int mtdconfig_poll(FAR struct fil

Re: [PR] arch/tricore: add one_shot .tick_start implementation [nuttx]

2025-09-03 Thread via GitHub
wangchdo commented on code in PR #16971: URL: https://github.com/apache/nuttx/pull/16971#discussion_r2320763280 ## arch/tricore/src/common/tricore_systimer.c: ## @@ -67,6 +67,9 @@ static int tricore_systimer_cancel(struct oneshot_lowerhalf_s *lower,

Re: [PR] arch/tricore: add one_shot .tick_start implementation [nuttx]

2025-09-03 Thread via GitHub
anchao commented on code in PR #16971: URL: https://github.com/apache/nuttx/pull/16971#discussion_r2320747630 ## arch/tricore/src/common/tricore_systimer.c: ## @@ -67,6 +67,9 @@ static int tricore_systimer_cancel(struct oneshot_lowerhalf_s *lower,

Re: [PR] arch/tricore: add one_shot .tick_start implementation [nuttx]

2025-09-03 Thread via GitHub
wangchdo commented on code in PR #16971: URL: https://github.com/apache/nuttx/pull/16971#discussion_r2320716152 ## arch/tricore/src/common/tricore_systimer.c: ## @@ -67,6 +67,9 @@ static int tricore_systimer_cancel(struct oneshot_lowerhalf_s *lower,

Re: [PR] arch/tricore: add one_shot .tick_start implementation [nuttx]

2025-09-03 Thread via GitHub
wangchdo commented on code in PR #16971: URL: https://github.com/apache/nuttx/pull/16971#discussion_r2320697509 ## arch/tricore/src/common/tricore_systimer.c: ## @@ -274,6 +278,47 @@ static int tricore_systimer_current(struct oneshot_lowerhalf_s *lower, return 0; } +/

  1   2   3   4   5   6   7   8   9   10   >