[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635470410 In usbhost.h, the main problem was that there was a missing */ which confused nxstyle. in the ft232 file, nxstyle was getting upset about the braces not being on

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635468920 I just fixed the nxstyle problems, rebased, and pushed to your branch. Everything should be good now. --

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635455020 I am looking at usbhost.h now. I will try to push something to your branch. This is an automated

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635440002 I can also help you with the usbhost.h files if you remembered to keep the box check to allow maintainers access to your branch. -

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635438863 There are a few style problems that need to be fixed before we can do the merge. There is one in your new files? drivers/usbhost/usbhost_ft232r.c:831:26: error: