[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625252903 This is all very annoying to me. It is difficult to work in an environment where people are making many, arbitrary changes that are not improvements that but just

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625250198 Please remove the controversional name changes from this PR and lets deal with that separately. I definitely want to keep the name sched_get_stackinfo(). I just wrote

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625249087 > But there are many name already violative your rule: > sched_getaffinity > sched_getcpu > sched_getparam > sched_getscheduler > sched_getstreams >

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625244585 But this is hard to have a real technical discussion because this is about your ego, not about the engineering work.

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625240973 Also I do not like the name clock_systimetick(). It feels like bad English to me. This is an

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625237776 > Here is another example you need decide: > [4bb943a](https://github.com/apache/incubator-nuttx/commit/4bb943a0c0ab173d7f5eb0178fd3a332726ce861) Yes, that is

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-06 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625008732 > I am fine if you still think the clock_systimer is better than clock_systimetick. I don't have strong feelings about names as long as the following the naming