[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo edited a comment on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625244585 But this is hard to have a real technical discussion because this is about your ego, not about the engineering work. This is a name for that: NIH

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo edited a comment on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625240973 Also I do not like the name clock_systimetick(). It feels like bad English to me. I have seen naming conventions that put the units at the end of the name