patacongo opened a new pull request #895:
URL: https://github.com/apache/incubator-nuttx/pull/895
## Summary
Commit 3b9efc95a2e introduced an error in the generation of include file
paths. The logic that determined if cygpath should be called to create a
Windows native path for the case of Cygwin using a native toolchain was
incorrect.
## Impact
This corrects this warning noted in Issue #886:
./tools/configure.sh -c sim:nsh
$ make
<CUT>
make[1]: Entering directory '/home/btashton/apache/apps'
make[2]: Entering directory '/home/btashton/apache/apps/builtin'
./exec_builtin.c:54:10: fatal error: builtin/builtin.h: No such file or
directory
54 | #include "builtin/builtin.h"
| ^~~~~~~~~~~~~~~~~~~
compilation terminated.
ERROR: cc failed: 1
command: cc -MT
./exec_builtin.home.btashton.apache.apps.builtin.o -M -Wall
-Wstrict-prototypes -Wshadow -Wundef -g -fno-builtin -fno-common -I. -isystem
/home/btashton/apache/nuttx/include -D__KERNEL__ -pipe -I
C:\cygwin64\home\btashton\apache\apps\include ./exec_builtin.c
make[2]: *** [/home/btashton/apache/apps/Application.mk:224: .depend]
Error 1
make[2]: Leaving directory '/home/btashton/apache/apps/builtin'
make[1]: *** [Makefile:67: /home/btashton/apache/apps/builtin_depend]
Error 2
In this case a Cygwin POSIX toolchain is being used by the path in the
CFLAGS to apps/include is incorrectly a Windows native path. This error is
corrected by this change to tools/incdir.sh
## Testing
Verified by building the sim:nsh configuration on a Cygwin development
platform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
