patacongo opened a new pull request #897:
URL: https://github.com/apache/incubator-nuttx/pull/897
## Summary
In an older PR, the standard kconfig-tweak calls were replaced with sed
edit. This is an incorrect change and results in invalid configurations. This
change restores the use of kconfig-tweak and always generates correct
configurations. NOTE: It is never necessary to disable options with
kconfig-tweak. If you enable a choice selection, it is smart enough to
automatically disable the other options. These greately reduces the size and
complexity of sethost.sh.
This change resolves issue #386
## Impact
sed edits do not handle all of the dependencies correct and generates
invalid configurations. Most defconfig files specify Linux by default, so you
will only see the effect of the corruped configuration when sethost changes
changes to a different configuration. Then, when 'make olddefconfig' is
subsequentyly run, the corruption in the defconfig file is reflected by
warnings such as:
$ tools/configure.sh -c stm32f4discovery:nsh
Copy files
Select CONFIG_HOST_WINDOWS=y
Select CONFIG_WINDOWS_CYGWIN=y
Refreshing...
.config:62:warning: override: reassigning to symbol HOST_WINDOWS
.config:62:warning: override: HOST_WINDOWS changes choice state
Those warnings are eliminated by this changed.
## Testing
Tested by repeatedly doing:
tools/configure.sh -c stm32f4discovery:nsh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
