[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1015161690 @ptka thank you very much for time spent on the issue fix and the review! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1015139932 @xiaoxiang781216 please take a loop. If you approve I think we can merge this change -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1014982463 Hi, Yes. That seems to be true. I was confused about "if (BUF->type == HTONS(ETHTYPE_IP))" and I didn't expect it to fail anymore with a packed

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-101415 Please fix ``` Error: usbdev/cdcecm.c:2098:23: error: assignment to 'uint8_t *' {aka 'unsigned char *'} from incompatible pointer type 'uint16_t *' {aka