[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625881521 @btashton Thank you. Let's continue there. > I also have a PCIe FPGA board that should be here in a few weeks that will allow me to test some of this against a

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625793332 @btashton I have checked your modifications. I didn't make it work with my serial card because of lacking find_cap and msi/msix routines. But I did confirmed that

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625326953 @btashton It sounds good to me. Should we support 64bit r/w natively? This is an automated

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625210301 I am quite uncertain that `pci_cfg_read` should directly return the value or not. Need suggestions. Yes, it more convenient to use and the semantics are much

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625203136 Seems quite good. I will try it out on my jailhuose machine with a serial PCI-E card on weekend. Hope it works.

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625201838 @btashton Sounds fantastic! I will take a look, but I am kinda of exhausted today. I will reply on weekend

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-624588711 I need suggestion on this, should we use pci or pcie as the function prefix? I am kind of mixing these 2 at the moment, but I want to unify it.

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-624422211 Oh, good. It's running now. I did some cosmetic changes. This is an automated message from the

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-624420616 The affected list * pre-processor definitions * pci_find_cap() * qemu_pci_enumerate() * qemu_pci_msix_register() * qemu_pci_msi_register() * Whole

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-624415804 @patacongo @btashton I will try to force push it, but where should I rebase to? About the licensing problem, if we have another implementation, it will be