[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'

2020-02-23 Thread GitBox
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590087053 Ok, maybe it is better to change CONFIG_ARCH_[TIMER|RTC|ALARM] to CONFIG_ARCH_HAVE_[TIMER|RTC|ALARM] without prompt string, than each

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'

2020-02-23 Thread GitBox
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590082027 > > Not a whole architecture, different chipset in the same architecture can select the different approach because each chipset has

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'

2020-02-23 Thread GitBox
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590080225 > @patacongo @xiaoxiang781216 , also find multi definition of up_rtc_getdatetime, up_rtc_settime and so on. I list the code from

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'

2020-02-23 Thread GitBox
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590074752 Not a whole architecture, different chipset in the same architecture can select the different approach because each chipset has own

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'

2020-02-22 Thread GitBox
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590031621 But, arch code don't need reference any specific config for arch_timer.c/arch_rtc.c/arch_oneshot.c since this is design decision

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'

2020-02-22 Thread GitBox
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-589976655 @klmchp and @patacongo , we don't need add any config here: if some chipset decide to use arch_timer.c, the chipset just need remove