[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1280: Implement fseeko and ftello

2020-06-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1280: URL: https://github.com/apache/incubator-nuttx/pull/1280#issuecomment-650952843 Yes, off_t define to int is strange, the better type is long at least. This is an

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1280: Implement fseeko and ftello

2020-06-24 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1280: URL: https://github.com/apache/incubator-nuttx/pull/1280#issuecomment-648636305 > what's the point to have prototypes without implementations? Normally, I will try to implement the function if it isn't to hard like:

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1280: Implement fseeko and ftello

2020-06-24 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1280: URL: https://github.com/apache/incubator-nuttx/pull/1280#issuecomment-648636305 > what's the point to have prototypes without implementations? Normally, I will try to implement the function if it isn't to hard like: