[GitHub] [nuttx] anchao commented on pull request #6718: add CMake build system support (Enhance #3704)

2023-07-17 Thread via GitHub
anchao commented on PR #6718: URL: https://github.com/apache/nuttx/pull/6718#issuecomment-1639370248 > @anchao Have you updated https://nuttx.apache.org/docs/latest/quickstart/compiling.html with a cmake how to? @davids5 Yes, I will add cmake chapter later -- This is an automated

[GitHub] [nuttx] anchao commented on pull request #6718: add CMake build system support (Enhance #3704)

2023-07-09 Thread via GitHub
anchao commented on PR #6718: URL: https://github.com/apache/nuttx/pull/6718#issuecomment-1627959961 > Hmm, CMake error still happens after I installed kconfiglib. @masayuki2009 emm... Sorry for bad experience, it seems that some files in the base of our internal code has

[GitHub] [nuttx] anchao commented on pull request #6718: add CMake build system support (Enhance #3704)

2023-07-09 Thread via GitHub
anchao commented on PR #6718: URL: https://github.com/apache/nuttx/pull/6718#issuecomment-1627923231 > @anchao > > I noticed that the following error happens with the latest upstream. Does this PR work with the latest PR? Hi @masayuki2009 , The initial version only

[GitHub] [nuttx] anchao commented on pull request #6718: add CMake build system support (Enhance #3704)

2023-07-07 Thread via GitHub
anchao commented on PR #6718: URL: https://github.com/apache/nuttx/pull/6718#issuecomment-1624795391 > @anchao What do you think about creating some CI targets to to ensure this continues to be functional? Hi, @davids5 , of course, I will send a separate PR later to add

[GitHub] [nuttx] anchao commented on pull request #6718: add CMake build system support (Enhance #3704)

2023-07-06 Thread via GitHub
anchao commented on PR #6718: URL: https://github.com/apache/nuttx/pull/6718#issuecomment-1624789560 > Given this CMake project is meant to be built from the user project repository (as opposed to the traditional CMake workflow), IMHO instructions like the ones suggested below would be

[GitHub] [nuttx] anchao commented on pull request #6718: add CMake build system support (Enhance #3704)

2023-07-04 Thread via GitHub
anchao commented on PR #6718: URL: https://github.com/apache/nuttx/pull/6718#issuecomment-1619641716 Hi all, @acassis @davids5 @xiaoxiang781216 @pkarashchenko I rebase this PR based on the latest dev, please review again, thanks! -- This is an automated message from the Apache Git