[GitHub] [nuttx] fjpanag commented on pull request #7992: modify the strtof

2023-02-06 Thread via GitHub
fjpanag commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1418867515 @flyingfish89 I just applied this, and the tests now pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nuttx] fjpanag commented on pull request #7992: modify the strtof

2023-02-03 Thread via GitHub
fjpanag commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1415738185 I just tried using the official NuttX app: ```sh $ git clone https://github.com/apache/nuttx.git nuttx $ git clone https://github.com/apache/nuttx-apps.git apps $ cd nuttx

[GitHub] [nuttx] fjpanag commented on pull request #7992: modify the strtof

2023-02-03 Thread via GitHub
fjpanag commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1415708616 > em.,so what board should I test it on and what configuration should I turn it on. Ah, sorry I misunderstood your question! I am running these tests in sim. I've

[GitHub] [nuttx] fjpanag commented on pull request #7992: modify the strtof

2023-02-03 Thread via GitHub
fjpanag commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1415546615 > CONFIG_HAVE_DOUBLE Yes `CONFIG_HAVE_DOUBLE` is defined (although as I see, there is no Kconfig for it). > could you describe how this scenario would have been triggered

[GitHub] [nuttx] fjpanag commented on pull request #7992: modify the strtof

2023-02-02 Thread via GitHub
fjpanag commented on PR #7992: URL: https://github.com/apache/nuttx/pull/7992#issuecomment-1414032529 This PR broke our tests. Specifically the Lua test fails on the following line: ```lua assert(string.len(string.format('%99.99f', -1e308)) >= 100) ```