[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux

2023-03-08 Thread via GitHub
slorquet commented on PR #8623: URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460831841 I save the current .config as my defconfig, so it contains all parameters. This way I am sure that the configuration is stable. @Donny9 hi, it was stuck at 17 because I keep full

[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux

2023-03-08 Thread via GitHub
slorquet commented on PR #8623: URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460042336 It was changed here from 20 to 31

[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux

2023-03-08 Thread via GitHub
slorquet commented on PR #8623: URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460040475 dont you believe me? ``` CC: string/lib_strsignal.c string/lib_strsignal.c: In function 'strsignal': string/lib_strsignal.c:169:7: error: duplicate case value 169 |

[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux

2023-03-08 Thread via GitHub
slorquet commented on PR #8623: URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1459998578 duplicate switch case because SIGCHLD ==SIGWORK when CONFIG_SCHED_HAS_PARENT SIGCHLD is forced to 17 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux

2023-03-07 Thread via GitHub
slorquet commented on PR #8623: URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1458289191 This was not reviewed before merging, why? Also this breaks if CONFIG_SCHED_HAS_PARENT is not defined because SIGCHLD will collide with the new values. -- This is an automated