GC-20-20 closed pull request #2171: Add missing variables and change to be more
intuitive to use
URL: https://github.com/apache/nuttx-apps/pull/2171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xiaoxiang781216 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1381796313
##
examples/serialrx/serialrx_main.c:
##
@@ -173,7 +172,6 @@ int main(int argc, FAR char *argv[])
UNUSED(eof);
}
-
Review Comment:
revert
xiaoxiang781216 commented on PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#issuecomment-1792568419
please squash your patch and update the commit message to reflect your
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
xiaoxiang781216 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378622996
##
examples/serialrx/serialrx_main.c:
##
@@ -118,8 +118,7 @@ int main(int argc, FAR char *argv[])
while (cnt < bytecount)
{
#ifdef
GC-20-20 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378414801
##
examples/serialrx/serialrx_main.c:
##
@@ -118,8 +118,7 @@ int main(int argc, FAR char *argv[])
while (cnt < bytecount)
{
#ifdef
xiaoxiang781216 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378410290
##
examples/serialrx/serialrx_main.c:
##
@@ -118,8 +118,7 @@ int main(int argc, FAR char *argv[])
while (cnt < bytecount)
{
#ifdef
GC-20-20 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378380224
##
examples/serialrx/serialrx_main.c:
##
@@ -118,8 +118,7 @@ int main(int argc, FAR char *argv[])
while (cnt < bytecount)
{
#ifdef
GC-20-20 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378378099
##
examples/serialrx/Kconfig:
##
@@ -39,22 +39,22 @@ config EXAMPLES_SERIALRX_DEVPATH
choice
prompt "Output method"
- default
xiaoxiang781216 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378373428
##
examples/serialrx/Kconfig:
##
@@ -39,22 +39,22 @@ config EXAMPLES_SERIALRX_DEVPATH
choice
prompt "Output method"
- default
GC-20-20 opened a new pull request, #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171
## Summary
Add missing variables and change to be more intuitive to use
## Impact
Variables that do cause compilation to fail
## Testing
local test
--
This is an automated
10 matches
Mail list logo
