acassis closed pull request #2239: apps: Select PIPES when enabling system popen
URL: https://github.com/apache/nuttx-apps/pull/2239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xiaoxiang781216 commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868541250
> > > @xiaoxiang781216 but popen is not used by default by the project, so
there is not possibility to it be disabled and break the relation.
> >
> >
> > user may
acassis commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868519618
> > @xiaoxiang781216 but popen is not used by default by the project, so
there is not possibility to it be disabled and break the relation.
>
> user may call both pipes and
xiaoxiang781216 commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868435272
> @xiaoxiang781216 but popen is not used by default by the project, so there
is not possibility to it be disabled and break the relation.
>
user may call both pipes
acassis commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868332167
@xiaoxiang781216 but popen is not used by default by the project, so there
is not possibility to it be disabled and break the relation.
I think "depends on" doesn't protect the
xiaoxiang781216 commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868183721
But, there are other path which directly use pipes, if someday the project
decides to avoid use popen to save the code size, the end user will surprise
that the linker can't
acassis commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868064014
@xiaoxiang781216 right, but in this case here it is a direct dependence:
Let's say assume Features:
A = popen example app
B = system popen
C = pipes
-> A depends on B
xiaoxiang781216 commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1867747126
We found that select expose some bad effect, for example:
1. Feature A depends on Feature C
2. Feature B select Feature C
The initial defconfig set both A and C
acassis commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1867679286
> here is some recommendation for `select` from zephyr:
https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-recommendations
@xiaoxiang781216 in this case
xiaoxiang781216 commented on PR #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1867237335
here is some recommendation for `select` from zephyr:
https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-recommendations
--
This is an automated message
acassis opened a new pull request, #2239:
URL: https://github.com/apache/nuttx-apps/pull/2239
## Summary
Select PIPES when enabling system popen
## Impact
Users will be able to get popen working correctly
## Testing
Build
--
This is an automated message from the Apache
11 matches
Mail list logo
