[PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-04-04 Thread via GitHub
JianyuWang0623 opened a new pull request, #16094: URL: https://github.com/apache/nuttx/pull/16094 ## Summary Enable GPIO and LCD for the szpi-esp32s3 development board. 1. Init GPIO for LCD SPI D/C 2. Add doc for GPIO 3. Add support for ST7789 LCD 4. Init configuration for LC

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-04-04 Thread via GitHub
JianyuWang0623 commented on code in PR #16094: URL: https://github.com/apache/nuttx/pull/16094#discussion_r2022531443 ## drivers/lcd/st7789.c: ## @@ -497,6 +497,39 @@ static void st7789_setorientation(FAR struct st7789_dev_s *dev) } #endif +static void st7789_ramctl(FAR str

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-04-01 Thread via GitHub
JianyuWang0623 commented on code in PR #16094: URL: https://github.com/apache/nuttx/pull/16094#discussion_r2022531443 ## drivers/lcd/st7789.c: ## @@ -497,6 +497,39 @@ static void st7789_setorientation(FAR struct st7789_dev_s *dev) } #endif +static void st7789_ramctl(FAR str

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-04-01 Thread via GitHub
JianyuWang0623 commented on code in PR #16094: URL: https://github.com/apache/nuttx/pull/16094#discussion_r2022588281 ## drivers/lcd/st7789.c: ## @@ -497,6 +497,39 @@ static void st7789_setorientation(FAR struct st7789_dev_s *dev) } #endif +static void st7789_ramctl(FAR str

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-04-01 Thread via GitHub
michallenc commented on code in PR #16094: URL: https://github.com/apache/nuttx/pull/16094#discussion_r2022407104 ## drivers/lcd/st7789.c: ## @@ -497,6 +497,39 @@ static void st7789_setorientation(FAR struct st7789_dev_s *dev) } #endif +static void st7789_ramctl(FAR struct

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-31 Thread via GitHub
acassis merged PR #16094: URL: https://github.com/apache/nuttx/pull/16094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-31 Thread via GitHub
JianyuWang0623 commented on PR #16094: URL: https://github.com/apache/nuttx/pull/16094#issuecomment-2765601250 > I think G and B channels are at inverted positions. When it should be Blue it is Green and when it should be Green it is Blue @acassis It seems that the RGB data endian

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-29 Thread via GitHub
JianyuWang0623 commented on PR #16094: URL: https://github.com/apache/nuttx/pull/16094#issuecomment-2763643795 > I think G and B channels are at inverted positions. When it should be Blue it is Green and when it should be Green it is Blue @acassis Got it, I will update according to yo

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-29 Thread via GitHub
acassis commented on PR #16094: URL: https://github.com/apache/nuttx/pull/16094#issuecomment-2763384315 Nice work @JianyuWang0623 !!! I noticed that the colors seems wrong, see the expected colors: https://nuttx.apache.org/docs/latest/platforms/sim/sim/index.html#supported-boards

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-29 Thread via GitHub
acassis commented on PR #16094: URL: https://github.com/apache/nuttx/pull/16094#issuecomment-2763385248 I think G and B channels are at inverted positions. When it should be Blue it is Green and when it should be Green it is Blue -- This is an automated message from the Apache Git Service

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-28 Thread via GitHub
nuttxpr commented on PR #16094: URL: https://github.com/apache/nuttx/pull/16094#issuecomment-2763108398 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is good, but could be improved by explic