acassis merged PR #11868:
URL: https://github.com/apache/nuttx/pull/11868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
acassis commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2007894525
Nice work @radek-pesina !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tmedicci commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2007275102
Well, there are a couple of things to be explained here:
This PR itself implements a generic driver. Generic drivers should provide
interfaces to be run using different interfaces
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2006384340
> Hi @ppisa,
>
> I've updated the use of the word "addr" as per your suggestion to "reg".
>
> Regarding a demonstration of this driver's use, please refer to the pull
request
radek-pesina commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2005469218
Hi Pavel,
I've updated the use of the word "addr" as per your suggestion to "reg".
Regarding a demonstration of this driver's use, please refer to the pull
request
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2005374586
> Hi, apologies, I'm not sure I fully follow - the SJA1000 is the lower-half
driver, implementing the SJA1000 (or in this instance you can say TWAI)
peripheral. The board level
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2005228815
@tmedicci: In the fact as I am trying to find from which location our TWAI
work should be used with non-legacy setup, I cannot find it. It seems to me
that our whole work is lost It
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2005175220
@radek-pesina, @tmedicci and others, it would be great if the core part of
the driver can sit in common location. In the fact, we have interest in ESP32C6
now and there is that change in
radek-pesina commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2005154955
> > Hi,
> > The TWAI is a ESP32 implementation of the SJA1000 controller - I think
they renamed it to TWAI for legal purposes when implementing it within the
ESP32? Anyway it's a
radek-pesina commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2005129980
Accidentally closed the pull request yesterday (wrong button). Re-opened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tmedicci commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2003708839
> Hi,
>
> The TWAI is a ESP32 implementation of the SJA1000 controller - I think
they renamed it to TWAI for legal purposes when implementing it within the
ESP32? Anyway it's a
radek-pesina closed pull request #11868: drivers/can/sja1000: Add SJA1000 CAN
driver support
URL: https://github.com/apache/nuttx/pull/11868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
radek-pesina commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-2002660004
> Hi!
>
> I checked this code and, as far as I was able to figure out, it uses a
generic interface (TWAI peripheral for ESP32-C3, for instance) to interact with
the
tmedicci commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1999670058
Hi!
I checked this code and, as far as I was able to figure out, it uses a
generic interface (TWAI peripheral for ESP32-C3, for instance) to interact with
the
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993816633
> > As for the TWAI code changes, I ma not sure if to change identifier of
the type `struct can_bittiming_const` to `to struct
sja1000_can_bittiming_const`.
>
> This prefix was
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993800133
> > I expect that you use code with our old SJA1000 FD tolerant design
https://gitlab.fel.cvut.cz/canbus/zynq/sja1000-fdtol . I have no time to look
at it for years but if you have some
AndrewD commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993592476
> As for the TWAI code changes, I ma not sure if to change identifier of the
type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`.
This prefix was added
AndrewD commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993576209
> In general, I am happy that driver will be moved to the common code area
and can be used with all ESP32 chips and even SJA1000 chips from single source
which allows to keep it update
ppisa commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521741723
##
include/nuttx/can/sja1000.h:
##
@@ -0,0 +1,163 @@
+/
+ * include/nuttx/can/sja1000.h
+ *
+
ppisa commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521689770
##
drivers/can/sja1000.h:
##
@@ -0,0 +1,911 @@
+/
+ * drivers/can/sja1000.h
+ *
+ * SJA1000
ppisa commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521671256
##
include/nuttx/can/sja1000.h:
##
@@ -0,0 +1,163 @@
+/
+ * include/nuttx/can/sja1000.h
+ *
+
ppisa commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521649736
##
include/nuttx/can/sja1000.h:
##
@@ -0,0 +1,163 @@
+/
+ * include/nuttx/can/sja1000.h
+ *
+
acassis commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991861068
Sorry, pressed the incorrect button, I was willing to cancel my comment.
These github buttons are prone to lead us to make mistakes.
--
This is an automated message from the Apache Git
acassis commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991857341
> As for the TWAI code changes, I ma not sure if to change identifier of the
type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`.
My long term goal is to reach
acassis closed pull request #11868: drivers/can/sja1000: Add SJA1000 CAN driver
support
URL: https://github.com/apache/nuttx/pull/11868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991811989
As for the TWAI code changes, I ma not sure if to change identifier of the
type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`.
My long term goal is to reach
ppisa commented on PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991785732
In general, I am happy that driver will be moved to the common code area and
can be used with all ESP32 chips and even SJA1000 chips from single source
which allows to keep it update and
ppisa commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521499968
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate "Philips/NXP
acassis commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521125131
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate "Philips/NXP
xiaoxiang781216 commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520877050
##
include/nuttx/can/sja1000.h:
##
@@ -0,0 +1,163 @@
+/
+ *
radek-pesina commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520546877
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate
radek-pesina commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520546877
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate
radek-pesina commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520546877
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate
acassis commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1518872227
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate "Philips/NXP
acassis commented on code in PR #11868:
URL: https://github.com/apache/nuttx/pull/11868#discussion_r1518666482
##
drivers/can/Kconfig:
##
@@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY
endif # CAN_MCP2515
-endif
+menuconfig CAN_SJA1000
+ tristate "Philips/NXP
35 matches
Mail list logo
