Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-24 Thread via GitHub
masayuki2009 commented on PR #11758: URL: https://github.com/apache/nuttx/pull/11758#issuecomment-1962359971 >@masayuki2009 fixed here https://github.com/apache/nuttx/pull/11764 I messed up something in my patches Please make sure that your commits work with the latest upstream

Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-24 Thread via GitHub
szafonimateusz-mi commented on PR #11758: URL: https://github.com/apache/nuttx/pull/11758#issuecomment-1962358327 @masayuki2009 fixed here https://github.com/apache/nuttx/pull/11764 I messed up something in my patches -- This is an automated message from the Apache Git Service. To

Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-24 Thread via GitHub
szafonimateusz-mi commented on PR #11758: URL: https://github.com/apache/nuttx/pull/11758#issuecomment-1962356316 @masayuki2009 I'll fix it right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-24 Thread via GitHub
masayuki2009 commented on PR #11758: URL: https://github.com/apache/nuttx/pull/11758#issuecomment-1962350353 @szafonimateusz-mi I noticed that qemu-intel64:nsh can not boot with this PR on ubuntu 20.04 x86_64 (Core-i7) + QEMU-8.2.0. -- This is an automated message from the

Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-23 Thread via GitHub
xiaoxiang781216 merged PR #11758: URL: https://github.com/apache/nuttx/pull/11758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-23 Thread via GitHub
raiden00pl commented on code in PR #11758: URL: https://github.com/apache/nuttx/pull/11758#discussion_r1500714976 ## arch/x86_64/src/intel64/intel64_start.c: ## @@ -0,0 +1,143 @@ +/ + *

Re: [PR] arch/intel64: various cosmetic improvements after code review [nuttx]

2024-02-23 Thread via GitHub
acassis commented on code in PR #11758: URL: https://github.com/apache/nuttx/pull/11758#discussion_r1500676518 ## arch/x86_64/src/intel64/intel64_start.c: ## @@ -0,0 +1,143 @@ +/ + *