Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

masayuki2009 merged PR #11226: URL: https://github.com/apache/nuttx/pull/11226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

masayuki2009 commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1825112643 Modify nsh_smp/defconfig as follows ``` --- a/boards/arm64/qemu/qemu-armv8a/configs/nsh_smp/defconfig +++ b/boards/arm64/qemu/qemu-armv8a/configs/nsh_smp/defconfig @@

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

xiaoxiang781216 commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1823245697 @masayuki2009 could you try this patch: https://github.com/apache/nuttx-apps/pull/2208? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

GUIDINGLI commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1820493411 > > @GUIDINGLI > > > The error is in step 6: > > > > > > Could you tell us how we can reproduce the error? > > Compile cmd: qemu-armv8a:nsh_smp change

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

GUIDINGLI commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1400051074 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

GUIDINGLI commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1820285832 And actually, there is another way to resolve this issue. We can do more things at Step 8 sched_unlcok, re-pick the task from ready-to-run list. Then the CPU1 will execute the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

GUIDINGLI commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1400051074 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

GUIDINGLI commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1400051074 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

GUIDINGLI commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1820221961 > @GUIDINGLI > > > The error is in step 6: > > Could you tell us how we can reproduce the error? Compile cmd: qemu-armv8a:nsh_smp change CONFIG_SMP_NCPUS to 2

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399880424 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399880424 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399880424 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399880424 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399880424 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1819872293 What if multiple tasks running on different CPUs lock the scheduler? This is the legacy behavior. Seems to me that there is a hole in the logic for this case. We can't suspend the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on code in PR #11226: URL: https://github.com/apache/nuttx/pull/11226#discussion_r1399759336 ## sched/sched/sched_removereadytorun.c: ## @@ -194,22 +194,15 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb, bool merge) * next tcb in the

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

patacongo commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1819814269 I am a little confused. sched_removereadytorun() is part of the level implementation of a context switch. High level checks such as if the scheduler is locked should have already

Re: [PR] sched: delete check when pick nexttcb in readytorun list [nuttx]

masayuki2009 commented on PR #11226: URL: https://github.com/apache/nuttx/pull/11226#issuecomment-1819151404 @GUIDINGLI >The error is in step 6: Could you tell us how we can reproduce the error? -- This is an automated message from the Apache Git Service. To respond to the