btashton commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704697785
The this PR would enable users to optionally include the LTP as an
application. To do so requires a very large patch applied (included in the PR)
to what the user
justinmclean commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704695863
Just trying to understand the GPL comment above. The GPL license is not
compatible with the Apache one and we can't have GPL code in our repo. ASF
projects
masayuki2009 opened a new pull request #1938:
URL: https://github.com/apache/incubator-nuttx/pull/1938
## Summary
- This commit fixes compile errors if CONFIG_DEBUG_ASSERTIONS=y
## Impact
- Affects noteram_driver only
## Testing
- Tested with
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 822497d drivers: note: Fix compile
xiaoxiang781216 merged pull request #1938:
URL: https://github.com/apache/incubator-nuttx/pull/1938
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jerpelea commented on pull request #1938:
URL: https://github.com/apache/incubator-nuttx/pull/1938#issuecomment-704093202
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log
masayuki2009 commented on pull request #1939:
URL: https://github.com/apache/incubator-nuttx/pull/1939#issuecomment-704155411
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the
masayuki2009 commented on pull request #1938:
URL: https://github.com/apache/incubator-nuttx/pull/1938#issuecomment-704064175
@xiaoxiang781216
This is an automated message from the Apache Git Service.
To respond to the
masayuki2009 opened a new pull request #1939:
URL: https://github.com/apache/incubator-nuttx/pull/1939
## Summary
- This PR introduces cxd56_cpuindex.h
- Also adds interrupt stack for SMP
## Impact
- Affects SMP only
## Testing
- Tested with
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 822497d drivers: note: Fix compile errors in noteram_driver.c
new 4c0602f arch: cxd56xx: Introduce
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2be53a9335e45e33651bcbaa8d099d91860f6d80
Author: Masayuki Ishikawa
AuthorDate: Tue Oct 6 18:10:58 2020 +0900
acassis commented on a change in pull request #1933:
URL: https://github.com/apache/incubator-nuttx/pull/1933#discussion_r500226463
##
File path: arch/xtensa/src/esp32/Kconfig
##
@@ -497,6 +517,114 @@ config ESP32_SPIFLASH_DEBUG
endmenu # ESP32_SPIFLASH
+menu "SPI RAM
patacongo commented on a change in pull request #419:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/419#discussion_r500276324
##
File path: fsutils/ipcfg/ipcfg.h
##
@@ -49,7 +50,8 @@
struct ipcfg_header_s
{
- uint8_t next; /* Offset to the next IP
davids5 commented on a change in pull request #419:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/419#discussion_r500278866
##
File path: fsutils/ipcfg/ipcfg.h
##
@@ -49,7 +50,8 @@
struct ipcfg_header_s
{
- uint8_t next; /* Offset to the next IP
patacongo commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500286027
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
RB-tel opened a new pull request #1940:
URL: https://github.com/apache/incubator-nuttx/pull/1940
## Summary
The Makefile is updated for the cygwin library path. The build on cygwin was
failing since the path to libc, libm, etc were incorrect.
EXTRA_LIBPATHS is updated to match the
patacongo commented on a change in pull request #419:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/419#discussion_r500277093
##
File path: fsutils/ipcfg/ipcfg.h
##
@@ -49,7 +50,8 @@
struct ipcfg_header_s
{
- uint8_t next; /* Offset to the next IP
patacongo commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500291336
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
davids5 commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500293343
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4c0602f52c8f97269f9ed6a868e0b0bff097c3f1
Author: Masayuki Ishikawa
AuthorDate: Tue Oct 6 17:49:08 2020 +0900
jerpelea merged pull request #1939:
URL: https://github.com/apache/incubator-nuttx/pull/1939
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
patacongo commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500286471
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
davids5 commented on pull request #417:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/417#issuecomment-704259797
> > @patacongo based on the last comment above, can you please use the extra
16 bit in the header as a version number?
>
> No, but you are welcome to submit a
patacongo commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500280302
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
patacongo commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500293426
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
davids5 commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500216142
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
davids5 opened a new pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419
## Summary
This adds a version for the binary file structure.
## Impact
Should be none as this is not used yet.
## Testing
inspection.
xiaoxiang781216 merged pull request #1940:
URL: https://github.com/apache/incubator-nuttx/pull/1940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 2be53a9 arch: cxd56xx: Add interrupt stack for SMP
add 2f95f3a cygwin build - path issue fix
No
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 2be53a9 arch: cxd56xx: Add interrupt stack for SMP
add 2f95f3a cygwin build - path issue fix
No
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from a627561 apps/fsutils/ipcfg: Add support for IPv6
add 833d231 ipcfg:Version the binary structure
acassis commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704308788
@ttnie is it ready to merge?
This is an automated message from the Apache Git Service.
To respond
btashton commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704346428
It's 20k lines of GPL we cannot have that in the Apache release bundle.
Also it's not clear to me how we would maintain it.
xiaoxiang781216 commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle.
Also it's not clear to me how we would maintain it.
The change isn't
xiaoxiang781216 edited a comment on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle.
Also it's not clear to me how we would maintain it.
All changes
patacongo edited a comment on pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#issuecomment-704362629
This is an automated message from the Apache Git Service.
To respond to the message, please
patacongo commented on a change in pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500300394
##
File path: netutils/netinit/netinit.c
##
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
#endif
btashton commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704324362
I would want to know more about the 20k line patch file before merging this
in. It's GPL code in the patch.
patacongo opened a new pull request #420:
URL: https://github.com/apache/incubator-nuttx-apps/pull/420
## Summary
Some old assertions were never updated. As a result, they were testing
uninitialized data and causing spurious assertions.
## Impact
None other than
xiaoxiang781216 edited a comment on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle.
Also it's not clear to me how we would maintain it.
@btashton all
patacongo commented on pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#issuecomment-704362629
I have finished verification of this change. Looks good.
This is an automated message from the
btashton commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704363416
> > It's 20k lines of GPL we cannot have that in the Apache release bundle.
Also it's not clear to me how we would maintain it.
>
> @btashton all changes
patacongo merged pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from a627561 apps/fsutils/ipcfg: Add support for IPv6
add 833d231 ipcfg:Version the binary structure
acassis commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704343906
Since it will be used only for testing and will not be included in the final
product's firmware, maybe it is not a big concern. What you think?
xiaoxiang781216 edited a comment on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704359576
> @ttnie is it ready to merge?
@acassis there are few compiling warnings need to resolve before merging. We
ares in China Nation Holiday, the
xiaoxiang781216 commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704359576
> @ttnie is it ready to merge?
There are few compiling warnings need to resolve before merging. We ares in
China Nation Holiday, the progress is a
xiaoxiang781216 edited a comment on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle.
Also it's not clear to me how we would maintain it.
@btashton all
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 3eee887 Typo fix.
3eee887 is
acassis commented on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704592095
Thank you Fotis, it is fine now!
This is an automated message from the Apache Git Service.
To respond
acassis merged pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 2e4ec44
masayuki2009 merged pull request #1941:
URL: https://github.com/apache/incubator-nuttx/pull/1941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
acassis commented on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704523613
Hi @fjpanag this is not just a Typo, this patch is removing the
"stm32_pwr_enableoverdrive()". If stm32_pwr_enableoverdrive() is not working,
then we need to fix it,
fjpanag commented on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704528159
@acassis
??? I don't understand... The stm32_pwr_enableoverdrive is already removed
in #1841... And nevertheless this is not what Github showed me when I created
acassis edited a comment on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704532894
> @acassis
> ??? I don't understand... The stm32_pwr_enableoverdrive is already removed
in #1841... And nevertheless this is not what Github showed me when I
fjpanag opened a new pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944
## Summary
Just a minor typo fix in mkdeps.
## Impact
N/A
## Testing
N/A
This is an automated
fjpanag commented on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704529525
Hmmm... Indeed it shows 3 commits, but only one file changed...
acassis commented on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704532894
> @acassis
> ??? I don't understand... The stm32_pwr_enableoverdrive is already removed
in #1841... And nevertheless this is not what Github showed me when I created
acassis commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704404617
> > @ttnie is it ready to merge?
>
> @acassis there are few compiling warnings need to resolve before merging.
We ares in China Nation Holiday, the progress
acassis edited a comment on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704404617
> > @ttnie is it ready to merge?
>
> @acassis there are few compiling warnings need to resolve before merging.
We ares in China Nation Holiday, the
Ouss4 opened a new pull request #1941:
URL: https://github.com/apache/incubator-nuttx/pull/1941
## Summary
The mask arguments was going through A2, clearing A2 was also clearing the
mask and preventing the interrupt state to be reset.
## Impact
Fix interrupt clearing in
patacongo commented on pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#issuecomment-704472277
> @patacongo - thank you for this!
You are welcome. I am of the belief that if you are going to bitch and moan
about someone else's solution, then it
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new f65b16b Incorporate IP
davids5 merged pull request #418:
URL: https://github.com/apache/incubator-nuttx-apps/pull/418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
davids5 commented on pull request #418:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/418#issuecomment-704439286
@patacongo - thank you for this!
This is an automated message from the Apache Git Service.
To
Ouss4 opened a new pull request #1942:
URL: https://github.com/apache/incubator-nuttx/pull/1942
## Summary
Implement basic reset logic and how to retrieve the cause of the reset.
## Impact
Add reset to ESP32
## Testing
Testing with reboot command from NSH and also by
Ouss4 commented on a change in pull request #1933:
URL: https://github.com/apache/incubator-nuttx/pull/1933#discussion_r500429408
##
File path: arch/xtensa/src/esp32/esp32_psram.c
##
@@ -0,0 +1,1693 @@
xiaoxiang781216 commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704411770
Friday, but people may take one ro two days vacation.
This is an automated message from the
Ouss4 opened a new pull request #1943:
URL: https://github.com/apache/incubator-nuttx/pull/1943
## Summary
- Remove a GPIO that's not available.
- There is no "special" function, all GPIOs have 6 functions
- Set the GPIO function as it was provided by the `attr` argument
-
acassis commented on pull request #1933:
URL: https://github.com/apache/incubator-nuttx/pull/1933#issuecomment-704449166
Thank you @Ouss4 I fixed those issues too!
This is an automated message from the Apache Git Service.
To
patacongo closed pull request #420:
URL: https://github.com/apache/incubator-nuttx-apps/pull/420
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
saramonteiro opened a new pull request #1945:
URL: https://github.com/apache/incubator-nuttx/pull/1945
## Summary
This PR adds the Timer support for ESP32 in NuttX.
## Impact
Now, the 4 available generic timers may be used.
## Testing
To test it, the Example Timer
fjpanag commented on pull request #1944:
URL: https://github.com/apache/incubator-nuttx/pull/1944#issuecomment-704550647
I actually synced my repo to upstream, but maybe I did something wrong...
Nevertheless, I think it is fixed now.
(Thank you for your advice on how to fix this!)
74 matches
Mail list logo