masayuki2009 commented on pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960#issuecomment-866406163
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
masayuki2009 merged pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new b9e553b Publishing
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from ea11446 sched/task/task_spawn.c: initialize variables explicitly
add 6582c19
xiaoxiang781216 opened a new pull request #3967:
URL: https://github.com/apache/incubator-nuttx/pull/3967
## Summary
And remove g_retchar from basename/dirname to avoid the race condtion.
## Impact
## Testing
"/home//dwc//test" return "/home//dwc" instead "/home//dwc/"
xiaoxiang781216 closed pull request #785:
URL: https://github.com/apache/incubator-nuttx-apps/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
xiaoxiang781216 commented on pull request #785:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/785#issuecomment-866485343
Close since the standard require to include sys/time.h:
https://pubs.opengroup.org/onlinepubs/7908799/xsh/select.html
--
This is an automated message
xiewenxiang commented on pull request #3543:
URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-864961579
Hi @protobits
I have refactored the tty driver, could you please help re-reivew this MR.
--
This is an automated message from the Apache Git Service.
To
xiaoxiang781216 merged pull request #3956:
URL: https://github.com/apache/incubator-nuttx/pull/3956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
a-lunev commented on pull request #3958:
URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-864997606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
a-lunev edited a comment on pull request #3958:
URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-864997606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xiaoxiang781216 commented on a change in pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655942059
##
File path: arch/xtensa/src/esp32/esp32_textheap.c
##
@@ -57,16 +51,11 @@ struct mm_heap_s g_textheap;
void up_textheap_init()
{
-
no1wudi commented on a change in pull request #3951:
URL: https://github.com/apache/incubator-nuttx/pull/3951#discussion_r655947540
##
File path: libs/libc/sched/task_onexit.c
##
@@ -0,0 +1,71 @@
+/
+
xiaoxiang781216 merged pull request #3882:
URL: https://github.com/apache/incubator-nuttx/pull/3882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
michallenc edited a comment on issue #3765:
URL:
https://github.com/apache/incubator-nuttx/issues/3765#issuecomment-864926968
Hi @acassis. Unfortunately there is no digital/analog converter output on
the iMXRT 1060 chip at all. There is just a 6 bit DAC for on chip internal
signals only,
Ouss4 commented on a change in pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655935160
##
File path: arch/xtensa/src/esp32/esp32_textheap.c
##
@@ -57,16 +51,11 @@ struct mm_heap_s g_textheap;
void up_textheap_init()
{
-
hartmannathan commented on pull request #3958:
URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-865214101
@a-lunev what are you trying to achieve? Is this similar to the BDMA/SRAM4
heap clobbering issue fixed in
Ouss4 commented on a change in pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655935160
##
File path: arch/xtensa/src/esp32/esp32_textheap.c
##
@@ -57,16 +51,11 @@ struct mm_heap_s g_textheap;
void up_textheap_init()
{
-
xiaoxiang781216 merged pull request #3952:
URL: https://github.com/apache/incubator-nuttx/pull/3952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
xiewenxiang edited a comment on pull request #3543:
URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-864961579
Hi @protobits
I have refactored the tty driver, could you please help re-reivew this MR,
thanks!
--
This is an automated message from the Apache
masayuki2009 opened a new pull request #3955:
URL: https://github.com/apache/incubator-nuttx/pull/3955
## Summary
- I noticed that the getcoreid macro in the latest esp-idf
is much simpler than the current NuttX's.
- This commit replaces the macro with the latest esp-idf's
michallenc commented on issue #3765:
URL:
https://github.com/apache/incubator-nuttx/issues/3765#issuecomment-864926968
Hi @acassis. Unfortunately there is no digital/analog converter output on
the iMXRT 1060 chip at all. There is just a 6 bit DAC for on chip internal
signals only, but
davids5 commented on pull request #3958:
URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-864966538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
no1wudi commented on a change in pull request #3951:
URL: https://github.com/apache/incubator-nuttx/pull/3951#discussion_r655947540
##
File path: libs/libc/sched/task_onexit.c
##
@@ -0,0 +1,71 @@
+/
+
ocramlhark edited a comment on pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864596501
Hi Alan,
yes I will do that tomorrow.
On Sun, Jun 20, 2021, 19:26 Alan Carvalho de Assis ***@***.***>
wrote:
> Please @ocramlhark
acassis commented on issue #3765:
URL:
https://github.com/apache/incubator-nuttx/issues/3765#issuecomment-865022893
Hmm, understood to point. In fact it is sad they didn't included the DAC
support in the board!
--
This is an automated message from the Apache Git Service.
To respond to
Ouss4 commented on a change in pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655935160
##
File path: arch/xtensa/src/esp32/esp32_textheap.c
##
@@ -57,16 +51,11 @@ struct mm_heap_s g_textheap;
void up_textheap_init()
{
-
xiaoxiang781216 merged pull request #3955:
URL: https://github.com/apache/incubator-nuttx/pull/3955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
xiaoxiang781216 commented on a change in pull request #3960:
URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655829504
##
File path: arch/xtensa/src/esp32/esp32_textheap.c
##
@@ -57,16 +51,11 @@ struct mm_heap_s g_textheap;
void up_textheap_init()
{
-
juniskane opened a new pull request #3962:
URL: https://github.com/apache/incubator-nuttx/pull/3962
## Summary
'pid' cannot really be used uninitialized, but Clang analyzer does not
see it. Add initializer to silence it and also make debugging slightly
easier.
xiaoxiang781216 merged pull request #3962:
URL: https://github.com/apache/incubator-nuttx/pull/3962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new ea11446 sched/task/task_spawn.c:
xiaoxiang781216 opened a new pull request #3963:
URL: https://github.com/apache/incubator-nuttx/pull/3963
## Summary
And map the nice value more correctly
## Impact
Add new API(nice) and correct the return value of setpriorty/getpriority
## Testing
--
This is
xiaoxiang781216 opened a new pull request #3964:
URL: https://github.com/apache/incubator-nuttx/pull/3964
## Summary
## Impact
Minor the change for the header file inclusion
## Testing
Pass the build
--
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 8b66a62 apps/system: fix
acassis merged pull request #771:
URL: https://github.com/apache/incubator-nuttx-apps/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
acassis merged pull request #770:
URL: https://github.com/apache/incubator-nuttx-apps/pull/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new c89e933 system/ping[6]: correct
xiaoxiang781216 opened a new pull request #785:
URL: https://github.com/apache/incubator-nuttx-apps/pull/785
## Summary
Replace sys/time.h with sys/select.h
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the
robertlipe opened a new pull request #3965:
URL: https://github.com/apache/incubator-nuttx/pull/3965
Largely borrowed from C906.
The IRQ code isn't quite right and needs further work.
The port in general needs additional work for networking, storage, VM, and
more, but this gets it in
acassis commented on pull request #767:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/767#issuecomment-865986372
Hi @xiaoxiang781216 why ignore the signal action twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
acassis merged pull request #766:
URL: https://github.com/apache/incubator-nuttx-apps/pull/766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
davids5 commented on pull request #3958:
URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-866071078
> It's still not clear what is the strategy to fix those situations?
On the buffer. It is not dache-aligned either. Using the granular allocator,
is the best
xiaoxiang781216 commented on pull request #3543:
URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-866086009
@xiewenxiang please fix all nxstyle warning except "Mixed case identifier
found":
xiaoxiang781216 opened a new pull request #3966:
URL: https://github.com/apache/incubator-nuttx/pull/3966
## Summary
## Impact
Avoid the undefined behaviour reported by UBSan
## Testing
--
This is an automated message from the Apache Git Service.
To respond to
acassis commented on pull request #749:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/749#issuecomment-865991979
@btashton if you agree I will merge it and let you apply the improvements
when you get the chance, is it ok for you?
--
This is an automated message from the
xiaoxiang781216 commented on pull request #767:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/767#issuecomment-866012624
Oh, the merge in our internal git looks wrong. Sorry, let's close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the
xiaoxiang781216 closed pull request #767:
URL: https://github.com/apache/incubator-nuttx-apps/pull/767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new c7f28f5 usrsock/rpmsg/server:
49 matches
Mail list logo