[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
masayuki2009 commented on pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960#issuecomment-866406163 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
masayuki2009 merged pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[incubator-nuttx-website] branch asf-site updated: Publishing web: 934a4647f20f1ab1148ce00d3b05b97fb19ad702 docs: 60da4317b971dae6f570f4bcd0d31c37437a24fc

2021-06-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new b9e553b Publishing

[incubator-nuttx] branch master updated (ea11446 -> 60da431)

2021-06-22 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from ea11446 sched/task/task_spawn.c: initialize variables explicitly add 6582c19

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3967: libc/dirname: Handle the consecutive '/' correctly

2021-06-22 Thread GitBox
xiaoxiang781216 opened a new pull request #3967: URL: https://github.com/apache/incubator-nuttx/pull/3967 ## Summary And remove g_retchar from basename/dirname to avoid the race condtion. ## Impact ## Testing "/home//dwc//test" return "/home//dwc" instead "/home//dwc/"

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #785: canutils: Fix error: unknown type name 'fd_set'

2021-06-22 Thread GitBox
xiaoxiang781216 closed pull request #785: URL: https://github.com/apache/incubator-nuttx-apps/pull/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #785: canutils: Fix error: unknown type name 'fd_set'

2021-06-22 Thread GitBox
xiaoxiang781216 commented on pull request #785: URL: https://github.com/apache/incubator-nuttx-apps/pull/785#issuecomment-866485343 Close since the standard require to include sys/time.h: https://pubs.opengroup.org/onlinepubs/7908799/xsh/select.html -- This is an automated message

[GitHub] [incubator-nuttx] xiewenxiang commented on pull request #3543: feat(esp32c3): Support esp32c3 ble function

2021-06-22 Thread GitBox
xiewenxiang commented on pull request #3543: URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-864961579 Hi @protobits I have refactored the tty driver, could you please help re-reivew this MR. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3956: xtensa/esp32_aes.c: Use the same output as SHA and RSA when testing the AES driver.

2021-06-22 Thread GitBox
xiaoxiang781216 merged pull request #3956: URL: https://github.com/apache/incubator-nuttx/pull/3956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nuttx] a-lunev commented on pull request #3958: stm32h7:sdmmc: prevent SRAM123 and SRAM4 from using by SDMMC1 IDMA

2021-06-22 Thread GitBox
a-lunev commented on pull request #3958: URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-864997606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-nuttx] a-lunev edited a comment on pull request #3958: stm32h7:sdmmc: prevent SRAM123 and SRAM4 from using by SDMMC1 IDMA

2021-06-22 Thread GitBox
a-lunev edited a comment on pull request #3958: URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-864997606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655942059 ## File path: arch/xtensa/src/esp32/esp32_textheap.c ## @@ -57,16 +51,11 @@ struct mm_heap_s g_textheap; void up_textheap_init() { -

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #3951: libc: Move atexit/on_exit to user space

2021-06-22 Thread GitBox
no1wudi commented on a change in pull request #3951: URL: https://github.com/apache/incubator-nuttx/pull/3951#discussion_r655947540 ## File path: libs/libc/sched/task_onexit.c ## @@ -0,0 +1,71 @@ +/ +

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3882: risc-v/esp32c3: Support ESP32-C3 SHA accelerator

2021-06-22 Thread GitBox
xiaoxiang781216 merged pull request #3882: URL: https://github.com/apache/incubator-nuttx/pull/3882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nuttx] michallenc edited a comment on issue #3765: GSoC: NuttX support for pysimCoder (info thread)

2021-06-22 Thread GitBox
michallenc edited a comment on issue #3765: URL: https://github.com/apache/incubator-nuttx/issues/3765#issuecomment-864926968 Hi @acassis. Unfortunately there is no digital/analog converter output on the iMXRT 1060 chip at all. There is just a 6 bit DAC for on chip internal signals only,

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
Ouss4 commented on a change in pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655935160 ## File path: arch/xtensa/src/esp32/esp32_textheap.c ## @@ -57,16 +51,11 @@ struct mm_heap_s g_textheap; void up_textheap_init() { -

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #3958: stm32h7:sdmmc: prevent SRAM123 and SRAM4 from using by SDMMC1 IDMA

2021-06-22 Thread GitBox
hartmannathan commented on pull request #3958: URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-865214101 @a-lunev what are you trying to achieve? Is this similar to the BDMA/SRAM4 heap clobbering issue fixed in

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
Ouss4 commented on a change in pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655935160 ## File path: arch/xtensa/src/esp32/esp32_textheap.c ## @@ -57,16 +51,11 @@ struct mm_heap_s g_textheap; void up_textheap_init() { -

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3952: SDIO IO_RW_EXTENDED command (CMD53) related fixes

2021-06-22 Thread GitBox
xiaoxiang781216 merged pull request #3952: URL: https://github.com/apache/incubator-nuttx/pull/3952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nuttx] xiewenxiang edited a comment on pull request #3543: feat(esp32c3): Support esp32c3 ble function

2021-06-22 Thread GitBox
xiewenxiang edited a comment on pull request #3543: URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-864961579 Hi @protobits I have refactored the tty driver, could you please help re-reivew this MR, thanks! -- This is an automated message from the Apache

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #3955: arch: esp32: Replace getcoreid with the latest esp-idf's

2021-06-22 Thread GitBox
masayuki2009 opened a new pull request #3955: URL: https://github.com/apache/incubator-nuttx/pull/3955 ## Summary - I noticed that the getcoreid macro in the latest esp-idf is much simpler than the current NuttX's. - This commit replaces the macro with the latest esp-idf's

[GitHub] [incubator-nuttx] michallenc commented on issue #3765: GSoC: NuttX support for pysimCoder (info thread)

2021-06-22 Thread GitBox
michallenc commented on issue #3765: URL: https://github.com/apache/incubator-nuttx/issues/3765#issuecomment-864926968 Hi @acassis. Unfortunately there is no digital/analog converter output on the iMXRT 1060 chip at all. There is just a 6 bit DAC for on chip internal signals only, but

[GitHub] [incubator-nuttx] davids5 commented on pull request #3958: stm32h7:sdmmc: prevent SRAM123 and SRAM4 from using by SDMMC1 IDMA

2021-06-22 Thread GitBox
davids5 commented on pull request #3958: URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-864966538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #3951: libc: Move atexit/on_exit to user space

2021-06-22 Thread GitBox
no1wudi commented on a change in pull request #3951: URL: https://github.com/apache/incubator-nuttx/pull/3951#discussion_r655947540 ## File path: libs/libc/sched/task_onexit.c ## @@ -0,0 +1,71 @@ +/ +

[GitHub] [incubator-nuttx] ocramlhark edited a comment on pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST

2021-06-22 Thread GitBox
ocramlhark edited a comment on pull request #3954: URL: https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864596501 Hi Alan, yes I will do that tomorrow. On Sun, Jun 20, 2021, 19:26 Alan Carvalho de Assis ***@***.***> wrote: > Please @ocramlhark

[GitHub] [incubator-nuttx] acassis commented on issue #3765: GSoC: NuttX support for pysimCoder (info thread)

2021-06-22 Thread GitBox
acassis commented on issue #3765: URL: https://github.com/apache/incubator-nuttx/issues/3765#issuecomment-865022893 Hmm, understood to point. In fact it is sad they didn't included the DAC support in the board! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
Ouss4 commented on a change in pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655935160 ## File path: arch/xtensa/src/esp32/esp32_textheap.c ## @@ -57,16 +51,11 @@ struct mm_heap_s g_textheap; void up_textheap_init() { -

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3955: arch: esp32: Replace getcoreid with the latest esp-idf's

2021-06-22 Thread GitBox
xiaoxiang781216 merged pull request #3955: URL: https://github.com/apache/incubator-nuttx/pull/3955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3960: xtensa/esp32: Refactor the text heap and add RTC memory to it

2021-06-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3960: URL: https://github.com/apache/incubator-nuttx/pull/3960#discussion_r655829504 ## File path: arch/xtensa/src/esp32/esp32_textheap.c ## @@ -57,16 +51,11 @@ struct mm_heap_s g_textheap; void up_textheap_init() { -

[GitHub] [incubator-nuttx] juniskane opened a new pull request #3962: sched/task/task_spawn.c: initialize variables explicitly

2021-06-22 Thread GitBox
juniskane opened a new pull request #3962: URL: https://github.com/apache/incubator-nuttx/pull/3962 ## Summary 'pid' cannot really be used uninitialized, but Clang analyzer does not see it. Add initializer to silence it and also make debugging slightly easier.

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3962: sched/task/task_spawn.c: initialize variables explicitly

2021-06-22 Thread GitBox
xiaoxiang781216 merged pull request #3962: URL: https://github.com/apache/incubator-nuttx/pull/3962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[incubator-nuttx] branch master updated: sched/task/task_spawn.c: initialize variables explicitly

2021-06-22 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new ea11446 sched/task/task_spawn.c:

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3963: libc/sched: Implement nice API

2021-06-22 Thread GitBox
xiaoxiang781216 opened a new pull request #3963: URL: https://github.com/apache/incubator-nuttx/pull/3963 ## Summary And map the nice value more correctly ## Impact Add new API(nice) and correct the return value of setpriorty/getpriority ## Testing -- This is

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3964: Correct the inclusion relationship between sys/select.h and sys/time.h

2021-06-22 Thread GitBox
xiaoxiang781216 opened a new pull request #3964: URL: https://github.com/apache/incubator-nuttx/pull/3964 ## Summary ## Impact Minor the change for the header file inclusion ## Testing Pass the build -- This is an automated message from the Apache Git Service. To

[incubator-nuttx-apps] branch master updated: apps/system: fix command history behavior (2)

2021-06-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8b66a62 apps/system: fix

[GitHub] [incubator-nuttx-apps] acassis merged pull request #771: apps/system: fix command history behavior

2021-06-22 Thread GitBox
acassis merged pull request #771: URL: https://github.com/apache/incubator-nuttx-apps/pull/771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-nuttx-apps] acassis merged pull request #770: system/ping[6]: correct the ping return value

2021-06-22 Thread GitBox
acassis merged pull request #770: URL: https://github.com/apache/incubator-nuttx-apps/pull/770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[incubator-nuttx-apps] branch master updated: system/ping[6]: correct the ping return value

2021-06-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new c89e933 system/ping[6]: correct

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #785: canutils: Fix error: unknown type name 'fd_set'

2021-06-22 Thread GitBox
xiaoxiang781216 opened a new pull request #785: URL: https://github.com/apache/incubator-nuttx-apps/pull/785 ## Summary Replace sys/time.h with sys/select.h ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] robertlipe opened a new pull request #3965: Add BeagleV Starlight JH7100 and JH7110

2021-06-22 Thread GitBox
robertlipe opened a new pull request #3965: URL: https://github.com/apache/incubator-nuttx/pull/3965 Largely borrowed from C906. The IRQ code isn't quite right and needs further work. The port in general needs additional work for networking, storage, VM, and more, but this gets it in

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #767: examples: Ignore the default action if app call sigwait

2021-06-22 Thread GitBox
acassis commented on pull request #767: URL: https://github.com/apache/incubator-nuttx-apps/pull/767#issuecomment-865986372 Hi @xiaoxiang781216 why ignore the signal action twice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx-apps] acassis merged pull request #766: usrsock/rpmsg/server: select eventfd by default

2021-06-22 Thread GitBox
acassis merged pull request #766: URL: https://github.com/apache/incubator-nuttx-apps/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-nuttx] davids5 commented on pull request #3958: stm32h7:sdmmc: prevent SRAM123 and SRAM4 from using by SDMMC1 IDMA

2021-06-22 Thread GitBox
davids5 commented on pull request #3958: URL: https://github.com/apache/incubator-nuttx/pull/3958#issuecomment-866071078 > It's still not clear what is the strategy to fix those situations? On the buffer. It is not dache-aligned either. Using the granular allocator, is the best

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3543: feat(esp32c3): Support esp32c3 ble function

2021-06-22 Thread GitBox
xiaoxiang781216 commented on pull request #3543: URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-866086009 @xiewenxiang please fix all nxstyle warning except "Mixed case identifier found":

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3966: net: Fix: left shift of 1 by 31 places cannot be represented in type long int

2021-06-22 Thread GitBox
xiaoxiang781216 opened a new pull request #3966: URL: https://github.com/apache/incubator-nuttx/pull/3966 ## Summary ## Impact Avoid the undefined behaviour reported by UBSan ## Testing -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #749: Add initial support libtommath and libtomcrypt libraries

2021-06-22 Thread GitBox
acassis commented on pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#issuecomment-865991979 @btashton if you agree I will merge it and let you apply the improvements when you get the chance, is it ok for you? -- This is an automated message from the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #767: examples: Ignore the default action if app call sigwait

2021-06-22 Thread GitBox
xiaoxiang781216 commented on pull request #767: URL: https://github.com/apache/incubator-nuttx-apps/pull/767#issuecomment-866012624 Oh, the merge in our internal git looks wrong. Sorry, let's close this PR. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #767: examples: Ignore the default action if app call sigwait

2021-06-22 Thread GitBox
xiaoxiang781216 closed pull request #767: URL: https://github.com/apache/incubator-nuttx-apps/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[incubator-nuttx-apps] branch master updated: usrsock/rpmsg/server: select eventfd by default

2021-06-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new c7f28f5 usrsock/rpmsg/server: