xiaoxiang781216 commented on PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#issuecomment-1115780258
Ok, I squash your patchset in my machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pussuw opened a new pull request, #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197
## Summary
Implement atexit(), on_exit(), exit() to libc. Using the call gate versions
is problematic as they basically inject userland code into the kernel, which is
then run with kernel
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0b84e074672b6f6ea6e2a2cac514901eee0e6a11
Author: Xiang Xiao
AuthorDate: Tue May 3 20:08:13 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from fead1964cb boards/space: Remove the unneeded XXXEXT definition
new 03c31d332f arch/arm: Remove
pkarashchenko merged PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Ouss4 opened a new pull request, #6203:
URL: https://github.com/apache/incubator-nuttx/pull/6203
## Summary
In Windowed ABI, we don't need to skip over any memory as we are only saving
A0.
The old code was working just because `ENTRY` works with multiples of 8, so
we were already
SimonFilgis opened a new pull request, #6204:
URL: https://github.com/apache/incubator-nuttx/pull/6204
…andeled
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiaoxiang781216 opened a new pull request, #6200:
URL: https://github.com/apache/incubator-nuttx/pull/6200
## Summary
and new gcov on sim:asan and pimoroni-tiny2040:nsh to improve the ci coverage
## Impact
gcov for device
## Testing
Pass CI
--
This is an
xiaoxiang781216 commented on code in PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193#discussion_r863722914
##
binfmt/libelf/libelf_addrenv.c:
##
@@ -145,6 +145,92 @@ int elf_addrenv_alloc(FAR struct elf_loadinfo_s *loadinfo,
size_t textsize,
#endif
}
xiaoxiang781216 commented on code in PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193#discussion_r863726147
##
include/nuttx/arch.h:
##
@@ -1185,6 +1185,44 @@ int up_addrenv_attach(FAR struct task_group_s *group,
FAR struct tcb_s *tcb);
int
xiaoxiang781216 commented on code in PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193#discussion_r863726147
##
include/nuttx/arch.h:
##
@@ -1185,6 +1185,44 @@ int up_addrenv_attach(FAR struct task_group_s *group,
FAR struct tcb_s *tcb);
int
pkarashchenko merged PR #6199:
URL: https://github.com/apache/incubator-nuttx/pull/6199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
SimonFilgis closed pull request #6202: MCAN_INT_ACKE must be on the list of
MCAN_TXERR_INTS to be properly h…
URL: https://github.com/apache/incubator-nuttx/pull/6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
SimonFilgis commented on PR #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202#issuecomment-1116174373
rebased against correct branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 862b815f87 Restore lost flash
xiaoxiang781216 merged PR #6201:
URL: https://github.com/apache/incubator-nuttx/pull/6201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 248b738f255374c1e9a99f1e3f69d3c0f615f727
Author: Ville Juven
AuthorDate: Tue May 3 08:42:15 2022 +0300
masayuki2009 merged PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 0ba891c1b0 armv7-a: smp: fix stack coloration
new 9af8b740e6 Elf loader: give temporary write access
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9af8b740e6a2e07efd4a924b2b13ff35f66150f0
Author: Ville Juven
AuthorDate: Tue Mar 29 12:15:30 2022 +0300
pkarashchenko commented on PR #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202#issuecomment-1116152008
Please squash commits into one:
```
git checkout bugfix/can_add_acke_int2listOfTxErrors_cherry
git rebase -i master
-- mark first ans "pick" and other as "sqash"
gustavonihei commented on code in PR #6135:
URL: https://github.com/apache/incubator-nuttx/pull/6135#discussion_r863839060
##
sched/sched/sched_cpuload_period.c:
##
@@ -183,6 +192,37 @@ static bool nxsched_period_callback(FAR uint32_t
*next_interval_us,
return true;
}
pkarashchenko merged PR #1159:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
from e2f0ae381 import/Make.defs: Fix C++ library linkage with
CONFIG_BUILD_KERNEL
add 0e9946956
pkarashchenko commented on code in PR #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196#discussion_r863797846
##
libs/libc/misc/lib_cxx_initialize.c:
##
@@ -75,13 +77,18 @@ extern uintptr_t _etext;
*
toshbi4 opened a new pull request, #6201:
URL: https://github.com/apache/incubator-nuttx/pull/6201
It was used in the previous nuttx versions, but then it was removed for
unknown reasons.
It's still in use in some projects and I really don't want to include it in
project files.
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 248b738f25 arm_addrenv: Add stubs for modifying permissions
add fead1964cb boards/space: Remove
pkarashchenko commented on code in PR #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202#discussion_r863808027
##
arch/arm/src/samv7/sam_mcan.c:
##
@@ -777,7 +777,7 @@
MCAN_INT_TEFL)
#define MCAN_TXDEDBUF_INTS MCAN_TXCOMMON_INTS
xiaoxiang781216 commented on code in PR #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196#discussion_r863885427
##
libs/libc/misc/lib_cxx_initialize.c:
##
@@ -75,13 +77,18 @@ extern uintptr_t _etext;
*
pkarashchenko commented on code in PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#discussion_r863805251
##
drivers/audio/wm8994.c:
##
@@ -1374,24 +1890,324 @@ static void *wm8994_workerthread(pthread_addr_t pvarg)
static void wm8994_audio_output(FAR
SimonFilgis opened a new pull request, #6202:
URL: https://github.com/apache/incubator-nuttx/pull/6202
…andeled
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gustavonihei commented on code in PR #6135:
URL: https://github.com/apache/incubator-nuttx/pull/6135#discussion_r863827953
##
sched/sched/sched_cpuload_oneshot.c:
##
@@ -225,6 +231,37 @@ static void nxsched_oneshot_callback(FAR struct
oneshot_lowerhalf_s *lower,
xiaoxiang781216 commented on PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#issuecomment-1116025607
Done all too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xiaoxiang781216 commented on PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#issuecomment-1115782196
@takayoshi-k please fix the below warning:
```
Error:
/home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/audioutils/mml_parser/mml_parser.c:2:1:
minabeoki opened a new pull request, #6198:
URL: https://github.com/apache/incubator-nuttx/pull/6198
## Summary
- The stack pointer is subtracted to alloc xcptcontext area in the
`__cpu?_start:` block
- Fix the stack coloration overrun to the previous cpu's xcpt area
## Impact
pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r862893524
##
arch/arm/src/tiva/common/tiva_can.c:
##
@@ -2157,9 +2157,9 @@ static void tivacan_disable_mbox(FAR struct can_dev_s
*dev,
* Return value: 0 on
xiaoxiang781216 merged PR #6198:
URL: https://github.com/apache/incubator-nuttx/pull/6198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaoxiang781216 opened a new pull request, #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196
## Summary
and simplify the implementation of c++ initialization
## Impact
c++ initialization
## Testing
Pass local test
--
This is an automated message
xiaoxiang781216 opened a new pull request, #1159:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1159
## Summary
## Impact
git status
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 0ba891c1b0 armv7-a: smp: fix stack
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1115867882
Seems like the style check does not appreciate the casts on 140 / 144:
Error:
/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/libs/libc/stdlib/lib_atexit.c:140:32:
xiaoxiang781216 opened a new pull request, #6199:
URL: https://github.com/apache/incubator-nuttx/pull/6199
## Summary
these make variable is defined in common place now
## Impact
No, code refactor only
## Testing
Pass CI
--
This is an automated message from the
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1115860360
Marked this as draft, this is still WIP. I wanted to make this visible
because there are some issues I need help with:
- Where should the "atexit.h" header be placed ? Or should
xiaoxiang781216 opened a new pull request, #1160:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1160
## Summary
pair with https://github.com/apache/incubator-nuttx/pull/4730
## Impact
New tools for gcov
## Testing
sim
--
This is an automated message
pkarashchenko commented on code in PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#discussion_r864255476
##
boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c:
##
@@ -183,21 +271,32 @@ int stm32_wm8994_initialize(int minor)
goto error;
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new c5c3ebd Publishing
okayserh commented on PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#issuecomment-1116594321
Thanks for the review and the suggestions. I've included these into the code
and gave the "squash" another try.
--
This is an automated message from the Apache Git Service.
takayoshi-k commented on PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#issuecomment-1116770384
@xiaoxiang781216
Thank you for your comment.
I fixed it. Please check it after finishing execution.
--
This is an automated message from the Apache Git Service.
pussuw commented on code in PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193#discussion_r863947997
##
include/nuttx/arch.h:
##
@@ -1185,6 +1185,44 @@ int up_addrenv_attach(FAR struct task_group_s *group,
FAR struct tcb_s *tcb);
int up_addrenv_detach(FAR
pussuw commented on code in PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193#discussion_r863947997
##
include/nuttx/arch.h:
##
@@ -1185,6 +1185,44 @@ int up_addrenv_attach(FAR struct task_group_s *group,
FAR struct tcb_s *tcb);
int up_addrenv_detach(FAR
pussuw commented on code in PR #6193:
URL: https://github.com/apache/incubator-nuttx/pull/6193#discussion_r863943105
##
binfmt/libelf/libelf_addrenv.c:
##
@@ -145,6 +145,92 @@ int elf_addrenv_alloc(FAR struct elf_loadinfo_s *loadinfo,
size_t textsize,
#endif
}
xiaoxiang781216 merged PR #6203:
URL: https://github.com/apache/incubator-nuttx/pull/6203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b19b931722
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6e8c32e778 MCAN_INT_ACKE must be on
xiaoxiang781216 merged PR #6204:
URL: https://github.com/apache/incubator-nuttx/pull/6204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaoxiang781216 commented on PR #6025:
URL: https://github.com/apache/incubator-nuttx/pull/6025#issuecomment-1116952773
@pkarashchenko @masayuki2009 and @Ouss4 could you continue review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
56 matches
Mail list logo