[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #380: arm: Fix "make export" for KERNEL build

2020-05-28 Thread GitBox
patacongo edited a comment on pull request #380: URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-635647655 @yamt @xiaoxiang781216 Can we close this PR? it is almost four months old and there have been no updates or comments for almost three months now.

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #380: arm: Fix "make export" for KERNEL build

2020-05-28 Thread GitBox
patacongo edited a comment on pull request #380: URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-635647655 Can we close this PR? it is almost four months old and there have been no updates or comments for almost three months now.

[GitHub] [incubator-nuttx] patacongo commented on pull request #380: arm: Fix "make export" for KERNEL build

2020-05-28 Thread GitBox
patacongo commented on pull request #380: URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-635647655 Can we close this PR? it is over three months old and there have been no updates or comments for almost two months now.

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #583: [Do Not Merge] experimental clang-format code-formatting tool

2020-05-28 Thread GitBox
adamfeuer commented on pull request #583: URL: https://github.com/apache/incubator-nuttx/pull/583#issuecomment-635647112 @patacongo Thanks– I will take it up in the future again, right now I'm working on the SAMA5D27 SDMMC driver and that's taking all my NuttX time at the moment.

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #583: [Do Not Merge] experimental clang-format code-formatting tool

2020-05-28 Thread GitBox
patacongo edited a comment on pull request #583: URL: https://github.com/apache/incubator-nuttx/pull/583#issuecomment-635644673 @adamfeuer I am closing this for the time being. If you need to work on it further in the future, please feel free to re-open it. I would just like to get it

[GitHub] [incubator-nuttx] patacongo closed pull request #583: [Do Not Merge] experimental clang-format code-formatting tool

2020-05-28 Thread GitBox
patacongo closed pull request #583: URL: https://github.com/apache/incubator-nuttx/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] patacongo commented on pull request #583: [Do Not Merge] experimental clang-format code-formatting tool

2020-05-28 Thread GitBox
patacongo commented on pull request #583: URL: https://github.com/apache/incubator-nuttx/pull/583#issuecomment-635644673 @adamfeuer I am closing this for the time being. If you need to work on it further in the future, please feel free to re-open it. I would just like to get it out of

[GitHub] [incubator-nuttx] patacongo commented on pull request #1096: Updated Rx65n rtc for non CONFIG_RTC_HIRES

2020-05-28 Thread GitBox
patacongo commented on pull request #1096: URL: https://github.com/apache/incubator-nuttx/pull/1096#issuecomment-635639534 I pulled the changes, resolved the conflicts, and merged to master. I will now have to close this PR. Please verify that the changes are in place correctly.

[GitHub] [incubator-nuttx] patacongo closed pull request #1096: Updated Rx65n rtc for non CONFIG_RTC_HIRES

2020-05-28 Thread GitBox
patacongo closed pull request #1096: URL: https://github.com/apache/incubator-nuttx/pull/1096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (738f3c6 -> f47151f)

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 738f3c6 drivers/usbhost/usbhost_ft232r.c: Cosmetic add f47151f Updated Rx65n rtc for non

[GitHub] [incubator-nuttx] patacongo removed a comment on pull request #1096: Updated Rx65n rtc for non CONFIG_RTC_HIRES

2020-05-28 Thread GitBox
patacongo removed a comment on pull request #1096: URL: https://github.com/apache/incubator-nuttx/pull/1096#issuecomment-635633538 I think I can merge this onto a branch, fix the conflicts, then merge it to main. That is not the preferred way of doing things, but might allow us to make

[GitHub] [incubator-nuttx] patacongo commented on pull request #1096: Updated Rx65n rtc for non CONFIG_RTC_HIRES

2020-05-28 Thread GitBox
patacongo commented on pull request #1096: URL: https://github.com/apache/incubator-nuttx/pull/1096#issuecomment-635633538 I think I can merge this onto a branch, fix the conflicts, then merge it to main. That is not the preferred way of doing things, but might allow us to make some

[incubator-nuttx] branch master updated: drivers/usbhost/usbhost_ft232r.c: Cosmetic

2020-05-28 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 738f3c6

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1146: drivers/usbhost/usbhost_ft232r.c: Cosmetic

2020-05-28 Thread GitBox
Ouss4 merged pull request #1146: URL: https://github.com/apache/incubator-nuttx/pull/1146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] patacongo opened a new pull request #1146: drivers/usbhost/usbhost_ft232r.c: Cosmetic

2020-05-28 Thread GitBox
patacongo opened a new pull request #1146: URL: https://github.com/apache/incubator-nuttx/pull/1146 ## Summary Cosmetic changes to alignment. Also fixes some C89 non-compliance. Sorry to be so OCD. This is an

[incubator-nuttx] 02/02: Fix the indentation and spacing that don't conform to the coding standard.

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 20ef084712652aebb2a1f45ca1f5637ee122d250 Author: Erdem Meydanli AuthorDate: Thu May 28 19:03:43 2020 +0200

[incubator-nuttx] branch master updated (1c002e1 -> 20ef084)

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1c002e1 fs/vfs/fs_fstat: Correct fstat() for proxied block and MTD drivers. new 7f018e7

[incubator-nuttx] branch master updated (20ef084 -> 5a9f792)

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 20ef084 Fix the indentation and spacing that don't conform to the coding standard. new 560ba3a

[incubator-nuttx] 01/02: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 560ba3adcd1a80555cbab4d0ebbd49789e5052fe Author: Nicholas Chin AuthorDate: Wed May 27 15:32:29 2020 -0400

[incubator-nuttx] 01/02: fs/nfs/nfs_proto.h: Use of uint64_t in the data types breaks NFS functionality.

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7f018e7898c3508cb26962ee4a2e1b8956721ef0 Author: Erdem Meydanli AuthorDate: Wed May 27 23:56:53 2020 +0200

[incubator-nuttx] 02/02: nxstyle fixes

2020-05-28 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 5a9f7927ee43d6561f163796242383483264eb54 Author: Gregory Nutt AuthorDate: Thu May 28 10:53:16 2020 -0600

[GitHub] [incubator-nuttx] patacongo merged pull request #1142: fs/nfs/nfs_proto.h: Use of uint64_t in the data types breaks NFS func…

2020-05-28 Thread GitBox
patacongo merged pull request #1142: URL: https://github.com/apache/incubator-nuttx/pull/1142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] patacongo merged pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo merged pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] meerd commented on pull request #1142: fs/nfs/nfs_proto.h: Use of uint64_t in the data types breaks NFS func…

2020-05-28 Thread GitBox
meerd commented on pull request #1142: URL: https://github.com/apache/incubator-nuttx/pull/1142#issuecomment-635488557 I've made the necessary changes. The only remaining type of error is the "Mixed case identifier found." In the TO-DO file, under "MISSING FILE SYSTEM FEATURES"

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635470410 In usbhost.h, the main problem was that there was a missing */ which confused nxstyle. in the ft232 file, nxstyle was getting upset about the braces not being

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635468920 I just fixed the nxstyle problems, rebased, and pushed to your branch. Everything should be good now.

[GitHub] [incubator-nuttx] NicholasChin commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
NicholasChin commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635459461 I'm at a loss for why checkpatch is reporting: `drivers/usbhost/usbhost_ft232r.c:831:26: error: Multiple data definitions` The line it is complaining about

[incubator-nuttx] branch master updated (48c88f2 -> 1c002e1)

2020-05-28 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 48c88f2 arch/arm/src/stm32h7: Add the spi slave bus control driver add 1c002e1 fs/vfs/fs_fstat:

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1143: fs/vfs/fs_fstat: Correct fstat() for proxied block and MTD drivers.

2020-05-28 Thread GitBox
Ouss4 merged pull request #1143: URL: https://github.com/apache/incubator-nuttx/pull/1143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635455020 I am looking at usbhost.h now. I will try to push something to your branch. This is an automated

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #274: netlib_parseurl silently truncates the path

2020-05-28 Thread GitBox
xiaoxiang781216 commented on issue #274: URL: https://github.com/apache/incubator-nuttx-apps/issues/274#issuecomment-635449227 Yes. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed issue #274: netlib_parseurl silently truncates the path

2020-05-28 Thread GitBox
xiaoxiang781216 closed issue #274: URL: https://github.com/apache/incubator-nuttx-apps/issues/274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] NicholasChin commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
NicholasChin commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635444714 Oh must have missed that one. The box to allows maintainers access is checked, so you should be able to edit usbhost.c, Greg. However like I was trying to

[GitHub] [incubator-nuttx-apps] Ouss4 commented on issue #274: netlib_parseurl silently truncates the path

2020-05-28 Thread GitBox
Ouss4 commented on issue #274: URL: https://github.com/apache/incubator-nuttx-apps/issues/274#issuecomment-635440925 So this one should be closed, right? This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635440002 I can also help you with the usbhost.h files if you remembered to keep the box check to allow maintainers access to your branch.

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
patacongo commented on pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635438863 There are a few style problems that need to be fixed before we can do the merge. There is one in your new files? drivers/usbhost/usbhost_ft232r.c:831:26:

[GitHub] [incubator-nuttx] NicholasChin opened a new pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

2020-05-28 Thread GitBox
NicholasChin opened a new pull request #1145: URL: https://github.com/apache/incubator-nuttx/pull/1145 ## Summary I have created a usbhost driver for the FT232R. The CDC/ACM driver was used as a basis. ## Testing I have test built using the current head 48c88f2 and the

[GitHub] [incubator-nuttx] patacongo commented on pull request #1142: fs/nfs/nfs_proto.h: Use of uint64_t in the data types breaks NFS func…

2020-05-28 Thread GitBox
patacongo commented on pull request #1142: URL: https://github.com/apache/incubator-nuttx/pull/1142#issuecomment-635424391 We have made exceptions for the "error: Mixed case identifier found" errors if there is no reasonable option. But otherwise, all modified files must pass the style

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new issue #1144: Crtical section should be replaced with semaphore or spinlock as much as we can to improve SMP performance

2020-05-28 Thread GitBox
xiaoxiang781216 opened a new issue #1144: URL: https://github.com/apache/incubator-nuttx/issues/1144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] patacongo opened a new pull request #1143: fs/vfs/fs_fstat: Correct fstat() for proxied block and MTD drivers.

2020-05-28 Thread GitBox
patacongo opened a new pull request #1143: URL: https://github.com/apache/incubator-nuttx/pull/1143 ## Summary Block and MTD drivers may be opened and managed as though they were character drivers. But this is really sleight of hand; there is a hidden character driver proxy that

[incubator-nuttx] 03/04: arch/arm/src/samv7/sam_spi_slave.c: Change for modified spi slave interface

2020-05-28 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b2a9a8cf814eae801bd876fdfd01b81ab6d6e29b Author: Jukka Laitinen AuthorDate: Tue May 26 10:42:13 2020 +0300

[incubator-nuttx] 02/04: update to SPI slave intefaces

2020-05-28 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e030047f4598162543accbe8b048415fcb088037 Author: Jukka Laitinen AuthorDate: Fri Sep 20 09:17:10 2019 +0300

[incubator-nuttx] 04/04: arch/arm/src/stm32h7: Add the spi slave bus control driver

2020-05-28 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 48c88f2af36c235262eb74a3e1810dd1ab75cebe Author: Jukka Laitinen AuthorDate: Thu Sep 12 12:29:11 2019 +0300

[incubator-nuttx] branch master updated (102c4c2 -> 48c88f2)

2020-05-28 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 102c4c2 tools/testbuild.sh: Call makefunc with JOPTION directly new 8d3c9a8

[incubator-nuttx] 01/04: arch/arm/src/stm32h7/stm32_spi.h: Split long lines

2020-05-28 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8d3c9a8773a7da61f40bb83c225e1e6d665a1986 Author: Jukka Laitinen AuthorDate: Mon May 25 12:13:54 2020 +0300

[incubator-nuttx] branch master updated (124e6ee -> 102c4c2)

2020-05-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 124e6ee sched/sched/sched_releasetcb.c: Handle custom stack allocations. add b5dc837 build:

[incubator-nuttx-apps] branch master updated (a455f13 -> a49f951)

2020-05-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from a455f13 webclient: Check the return value of netlib_parseurl correctly new 585d63b

[incubator-nuttx-apps] 01/02: netlib_parseurl: Fix pathlen check

2020-05-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 585d63b30d378dcf4277eac888d8c498a084b519 Author: YAMAMOTO Takashi AuthorDate: Thu May 28 17:22:37 2020

[incubator-nuttx-apps] 02/02: netlib_parsehttpurl: Fix pathlen check

2020-05-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit a49f951c8607ba30b779e5f10a1f27d3f03450a7 Author: YAMAMOTO Takashi AuthorDate: Thu May 28 17:24:54 2020

[incubator-nuttx-apps] branch master updated: webclient: Check the return value of netlib_parseurl correctly

2020-05-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new a455f13 webclient: Check the

[incubator-nuttx-apps] branch master updated: webclient: include string.h for strlen

2020-05-28 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 415010b webclient: include

[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #280: webclient: include string.h for strlen

2020-05-28 Thread GitBox
jerpelea merged pull request #280: URL: https://github.com/apache/incubator-nuttx-apps/pull/280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #282: netlib_parseurl: Fix pathlen check

2020-05-28 Thread GitBox
yamt commented on pull request #282: URL: https://github.com/apache/incubator-nuttx-apps/pull/282#issuecomment-635198349 https://github.com/apache/incubator-nuttx-apps/issues/274 netlib_parseurl is tested. netlib_parsehttpurl is not. nxstyle "error: C++ style comment"

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #282: netlib_parseurl: Fix pathlen check

2020-05-28 Thread GitBox
yamt opened a new pull request #282: URL: https://github.com/apache/incubator-nuttx-apps/pull/282 ## Summary ## Impact ## Testing This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #281: webclient: Check the return value of netlib_parseurl correctly

2020-05-28 Thread GitBox
yamt opened a new pull request #281: URL: https://github.com/apache/incubator-nuttx-apps/pull/281 ## Summary ## Impact ## Testing This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] yamt commented on pull request #1142: fs/nfs/nfs_proto.h: Use of uint64_t in the data types breaks NFS func…

2020-05-28 Thread GitBox
yamt commented on pull request #1142: URL: https://github.com/apache/incubator-nuttx/pull/1142#issuecomment-635138912 lgtm. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #280: webclient: include string.h for strlen

2020-05-28 Thread GitBox
yamt opened a new pull request #280: URL: https://github.com/apache/incubator-nuttx-apps/pull/280 Instead of relying on indirect namespace pollutions. ## Summary ## Impact ## Testing This is an