Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520877050 ## include/nuttx/can/sja1000.h: ## @@ -0,0 +1,163 @@ +/ + *

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520870616 ## fs/mount/fs_mount.c: ## @@ -293,7 +293,7 @@ int nx_mount(FAR const char *source, FAR const char *target, /* Find the specified filesystem. Try the

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-11 Thread via GitHub
yf13 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520766100 ## fs/mount/fs_mount.c: ## @@ -293,7 +293,7 @@ int nx_mount(FAR const char *source, FAR const char *target, /* Find the specified filesystem. Try the block driver

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1990037212 > @xiaoxiang781216 but libc-test is focused on musl and probably only tested on NuttX and it is not integrated on NuttX. Also that project seems very inactive (one commit per

[PR] xtensa/esp32: Fix wrong interrupt number [nuttx]

2024-03-11 Thread via GitHub
cwespressif opened a new pull request, #11897: URL: https://github.com/apache/nuttx/pull/11897 ## Summary - Fix wrong interrupt number: it should be `ESP32_IRQ_EMAC` instead of `priv->cpuint` ## Impact ## Testing -- This is an automated message from the

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-11 Thread via GitHub
yf13 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520766100 ## fs/mount/fs_mount.c: ## @@ -293,7 +293,7 @@ int nx_mount(FAR const char *source, FAR const char *target, /* Find the specified filesystem. Try the block driver

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-11 Thread via GitHub
yf13 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520766100 ## fs/mount/fs_mount.c: ## @@ -293,7 +293,7 @@ int nx_mount(FAR const char *source, FAR const char *target, /* Find the specified filesystem. Try the block driver

Re: [I] Can't create new folder on the dialog when vscode.window.showOpenDialog is called on WSL environment. [nuttx]

2024-03-11 Thread via GitHub
takayoshi-k commented on issue #11800: URL: https://github.com/apache/nuttx/issues/11800#issuecomment-1989892944 Oh... I am sorry... I thought I make this issue on VSCode github... But thank you for your reply. I will check it.. -- This is an automated message from the Apache Git

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
SPRESENSE commented on PR #11008: URL: https://github.com/apache/nuttx/pull/11008#issuecomment-1989855041 @xiaoxiang781216 @Donny9 Thank you for information. I verified that work well with #11892 without my change. I withdraw this PR. -- This is an automated message from the Apache Git

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520722098 ## fs/mount/fs_mount.c: ## @@ -310,7 +310,7 @@ int nx_mount(FAR const char *source, FAR const char *target, goto errout_with_inode; }

Re: [I] Simulator export fails [nuttx]

2024-03-11 Thread via GitHub
xuxin930 commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1989772048 hi @acassis @nicolas71640 Thank you for your reminder  The current CMake base does not support the `import` `export` feat. We considered using `cmake install `during the

[PR] revise comments and harden nx_mount logic [nuttx]

2024-03-11 Thread via GitHub
yf13 opened a new pull request, #11896: URL: https://github.com/apache/nuttx/pull/11896 ## Summary This patch contains improvements to harden logic of nx_mount(): - currently some variables may not get populated by called functions, thus initialization is added. - empty string

(nuttx-website) branch asf-site updated: Publishing web: f355c37abb2c2dea4b5ff1c582aacf9520a34e3a docs: 63782c7ff277e861aad41e4c43a362304ab615df

2024-03-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3bdf9f8d3 Publishing web:

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-11 Thread via GitHub
radek-pesina commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520546877 ## drivers/can/Kconfig: ## @@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY endif # CAN_MCP2515 -endif +menuconfig CAN_SJA1000 + tristate

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-11 Thread via GitHub
radek-pesina commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520546877 ## drivers/can/Kconfig: ## @@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY endif # CAN_MCP2515 -endif +menuconfig CAN_SJA1000 + tristate

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-11 Thread via GitHub
radek-pesina commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1520546877 ## drivers/can/Kconfig: ## @@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY endif # CAN_MCP2515 -endif +menuconfig CAN_SJA1000 + tristate

Re: [I] undefined reference to `arm_serialinit' [nuttx]

2024-03-11 Thread via GitHub
nimish commented on issue #7856: URL: https://github.com/apache/nuttx/issues/7856#issuecomment-1989438814 This happens if no uart is enabled. Enable UART0 and it'll pull in the right files. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
PetteriAimonen commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1989216435 I have run into some NuttX libc bugs before (which have since been fixed), so I think it would be a good idea to incorporate some established libc test suite. -- This is an

[PR] Esp32 openeth [nuttx]

2024-03-11 Thread via GitHub
casaroli opened a new pull request, #11895: URL: https://github.com/apache/nuttx/pull/11895 ## Summary Adds the ESP32 Opencores ethernet driver for use with QEMU emulation. ## Impact Now networking can be achieved with QEMU with the new driver ## Testing

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
acassis commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1989150999 @xiaoxiang781216 but libc-test is focused on musl and probably only tested on NuttX and it is not integrated on NuttX. Also that project seems very inactive (one commit per year).

Re: [PR] ostest: add test for libc memmem() function [nuttx-apps]

2024-03-11 Thread via GitHub
acassis commented on PR #2327: URL: https://github.com/apache/nuttx-apps/pull/2327#issuecomment-1989067493 Is if failing because chicken-egg CI test: ``` /usr/bin/ld: nuttx.rel: in function `user_main': /github/workspace/sources/apps/testing/ostest/ostest_main.c:266: undefined

Re: [PR] camera_example: modify initialize interface after v4l2 refactor [nuttx-apps]

2024-03-11 Thread via GitHub
acassis commented on PR #2326: URL: https://github.com/apache/nuttx-apps/pull/2326#issuecomment-1989064623 @shizhenghui please fix coding style check issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Simulator export fails [nuttx]

2024-03-11 Thread via GitHub
acassis commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1989058094 @xuxin930 since you are fixing the CMake, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(nuttx) branch master updated: arch/xmc4 Add tickless support

2024-03-11 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 63782c7ff2 arch/xmc4 Add tickless support

Re: [PR] arch/xmc4 Add tickless support [nuttx]

2024-03-11 Thread via GitHub
acassis merged PR #11737: URL: https://github.com/apache/nuttx/pull/11737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] arch/xmc4 Add tickless support [nuttx]

2024-03-11 Thread via GitHub
acassis commented on PR #11737: URL: https://github.com/apache/nuttx/pull/11737#issuecomment-1988952824 @nicolas71640 thank you very much for your investigation on these issues and for making things work! Kudos!!! -- This is an automated message from the Apache Git Service. To respond to

(nuttx) branch master updated: docs/esp32c6: Add spiflash docs for esp32c6 docs/esp32c6: Remove sotest docs esp32c6 docs/esp32c3: Add spiflash docs esp32c3 docs/esp32c3: Remove sotest docs esp32c3 doc

2024-03-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 61689237f6 docs/esp32c6: Add spiflash docs

(nuttx) branch master updated: sched/pthread: replace pthread_sem_give() to nxsem_post() to unify the post method

2024-03-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new be482cd830 sched/pthread: replace

Re: [PR] sched/pthread: replace pthread_sem_give() to nxsem_post() to unify the post method [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 merged PR #11891: URL: https://github.com/apache/nuttx/pull/11891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] docs/esp32c6: Add spiflash docs for esp32c6 [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 merged PR #11894: URL: https://github.com/apache/nuttx/pull/11894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1988639855 > @juniskane sounds like a good idea! @PetteriAimonen @xiaoxiang781216 What do you think? > > We could have a simple Pass/Fail suite with all tests. The ostest is more

[PR] testing/getprime: allow running with zero threads [nuttx-apps]

2024-03-11 Thread via GitHub
juniskane opened a new pull request, #2328: URL: https://github.com/apache/nuttx-apps/pull/2328 ## Summary getprime can now run without creating any additional threads. This helps testing pthreads and measuring performance of directly searching primes from main thread versus

(nuttx) 15/15: drivers/video/isx012: Fix buffer overrun of isx012_putreg()

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit bac0228825ee93af86b66ee1d69081f54b248d4c Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 11/15: drivers/video: Fix bug that can not use scene mode

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit ae970a8ed3e42f38718413fa9dc67c83d3cf630f Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 14/15: drivers/video/isx019: Delete unnecessary code

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3419f018a432ce33192d5423bd33314c731c15a8 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 03/15: drivers/video/isx012: Fix control type of some parameters

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fdf9f009529b40e48842b6367fb08fab4513ffaf Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 07/15: drivers/video/isx019: Fix bug that read value is not correct

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fd5c2d49225cb51a6831c2f67925a4d4bed42e84 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 10/15: drivers/video/isx019: Fix mismatch bug of HUE value

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 8f0ed67339305e3d0c9f1fe11b9f0372b371c4cb Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 12/15: drivers/video/isx019: Fix default ISO sensitivity

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 2b04210b16df8bb54cb715537efb8edd79ed171d Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 09/15: drivers/video/isx019: Fix control type about some parameters

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit de3bee313ed556688e49688aae07f2a8c049d71e Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 06/15: drivers/video/isx019: Fix bug that initial exposure time is not correct

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 33f7923d7247fdbb34fe92821c9ef9e418533361 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 08/15: drivers/video: Add elems setting

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 865c88e34b9e5e64e481c319bc3571e33175f25c Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 13/15: drivers/video/isx019: Store initial gamma value

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit baa2dc5cad84c96f8a306916d36e5a190e007bf0 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 01/15: drivers/video: Modify control id definition

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 75a0a08a4dd3d487b858e7e4ff7a8f7e4b753970 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) branch master updated (47026978bf -> bac0228825)

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 47026978bf libs/libc/string: fix memmem() boundary case when needle is at end of haystack new 75a0a08a4d

(nuttx) 05/15: drivers/video/isx019: Fix maximum value of exposure time

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 76e91a69f78e4e4411fb3f342ae48a89ca16813c Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 02/15: drivers/video/isx019: Fix supported ISO sensitivity

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit f1bc6aada3136e5503f593562e42727cfdf7c0b5 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

(nuttx) 04/15: drivers/video/isx019: Fix control type of some parameters

2024-03-11 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit dc82022769a3721097fc07ca2aac923626e08dd0 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate:

Re: [PR] drivers/video: Update for improvement and bug fix [nuttx]

2024-03-11 Thread via GitHub
jerpelea merged PR #11859: URL: https://github.com/apache/nuttx/pull/11859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
juniskane commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1988600012 I crafted a commit to add this testcase to ostest, so that it is stored at least somewhere. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] ostest: add test for libc memmem() function [nuttx-apps]

2024-03-11 Thread via GitHub
juniskane opened a new pull request, #2327: URL: https://github.com/apache/nuttx-apps/pull/2327 ## Summary ostest: add test for libc memmem() function See https://github.com/apache/nuttx/pull/11889 ## Impact ## Testing -- This is an automated message

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
acassis commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1988584378 @juniskane sounds like a google idea! @PetteriAimonen @xiaoxiang781216 What do you think? We could have a simple Pass/Fail suite with all tests. The ostest is more iterative

[PR] docs/esp32c6: Add spiflash docs for esp32c6 [nuttx]

2024-03-11 Thread via GitHub
eren-terzioglu opened a new pull request, #11894: URL: https://github.com/apache/nuttx/pull/11894 ## Summary - docs/esp32c6: Remove sotest docs esp32c6 - docs/esp32c3: Add spiflash docs esp32c3 - docs/esp32c3: Remove sotest docs esp32c3 - docs/esp32h2: Add spiflash docs

Re: [PR] arch/xmc4 Add tickless support [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11737: URL: https://github.com/apache/nuttx/pull/11737#discussion_r1519784635 ## arch/arm/src/xmc4/xmc4_tickless.c: ## @@ -0,0 +1,576 @@ +/ + *

Re: [PR] arch/xmc4 Add tickless support [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11737: URL: https://github.com/apache/nuttx/pull/11737#discussion_r1519784376 ## arch/arm/src/xmc4/xmc4_tickless.c: ## @@ -0,0 +1,576 @@ +/ + *

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 merged PR #11889: URL: https://github.com/apache/nuttx/pull/11889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated: libs/libc/string: fix memmem() boundary case when needle is at end of haystack

2024-03-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 47026978bf libs/libc/string: fix memmem()

(nuttx) branch master updated: sched/pthread/join: remove unused joininfo

2024-03-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 68c21df444 sched/pthread/join: remove unused

Re: [PR] sched/pthread/join: remove unused joininfo [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 merged PR #11890: URL: https://github.com/apache/nuttx/pull/11890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
juniskane commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1988524141 > @juniskane please include this test_memmem() to apps/testing/ostest I view ostest as testing RTOS features like semaphores, scheduler, threads etc. Maybe we should have a

[PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]

2024-03-11 Thread via GitHub
xuxin930 opened a new pull request, #11893: URL: https://github.com/apache/nuttx/pull/11893 ## Summary In the original Makefile, we have `ARCHCXXFLAG` and `ARCHCFLAG` to distinguish the header file search paths of cxx files and c files. However, in the CMake

Re: [PR] arch/xmc4 Add tickless support [nuttx]

2024-03-11 Thread via GitHub
nicolas71640 commented on code in PR #11737: URL: https://github.com/apache/nuttx/pull/11737#discussion_r1519713127 ## arch/arm/src/xmc4/xmc4_tickless.c: ## @@ -0,0 +1,576 @@ +/ + *

Re: [PR] V4l2 refactor [nuttx]

2024-03-11 Thread via GitHub
shizhenghui commented on PR #11887: URL: https://github.com/apache/nuttx/pull/11887#issuecomment-1988393443 Submitted to the nuttx apps repository:https://github.com/apache/nuttx-apps/pull/2326 > @shizhenghui please fix compilation errors: > > ``` > camera_main.c: In

[PR] camera_example: modify initialize interface after v4l2 refactor [nuttx-apps]

2024-03-11 Thread via GitHub
shizhenghui opened a new pull request, #2326: URL: https://github.com/apache/nuttx-apps/pull/2326 ## Summary Fix apps dependency, see commit: https://github.com/apache/nuttx/pull/11887 ## Impact NA ## Testing CI -- This is an automated message from the

Re: [PR] tools/minidumpserver.py: support quit with gdb [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 merged PR #11888: URL: https://github.com/apache/nuttx/pull/11888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Discussion]How to elegantly implement ALLSYMS feat in CMake build [nuttx]

2024-03-11 Thread via GitHub
xuxin930 commented on issue #11875: URL: https://github.com/apache/nuttx/issues/11875#issuecomment-1988378243 > How about adding multiple execution targets? Okay let me give it a try -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] arch/xmc4 Add tickless support [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on PR #11737: URL: https://github.com/apache/nuttx/pull/11737#issuecomment-1988399027 @nicolas71640 please squash the change into one patch and fix the nxstyle issue reported by: https://github.com/apache/nuttx/actions/runs/8233183407/job/22512126340?pr=11737

(nuttx) branch master updated (5ac401d941 -> 836715a2d6)

2024-03-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5ac401d941 mm/kconfig: fix typo in MM_DEFAULT_ALIGNMENT add 836715a2d6 tools/minidumpserver.py: support quit

Re: [PR] V4l2 refactor [nuttx]

2024-03-11 Thread via GitHub
acassis commented on PR #11887: URL: https://github.com/apache/nuttx/pull/11887#issuecomment-1988339862 @shizhenghui please fix compilation errors: ``` camera_main.c: In function 'camera_main': Error: camera_main.c:503:9: error: implicit declaration of function 'video_initialize';

Re: [PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
acassis commented on PR #11889: URL: https://github.com/apache/nuttx/pull/11889#issuecomment-1988333599 @juniskane please include this test_memmem() to apps/testing/ostest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] STM32H7 (& STM32F4): UART write issue [nuttx]

2024-03-11 Thread via GitHub
maxikrie commented on issue #11877: URL: https://github.com/apache/nuttx/issues/11877#issuecomment-1988330586 @acassis Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] STM32H7 (& STM32F4): UART write issue [nuttx]

2024-03-11 Thread via GitHub
maxikrie closed issue #11877: STM32H7 (& STM32F4): UART write issue URL: https://github.com/apache/nuttx/issues/11877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fs/driver: using nx_unlink to call unlink ops to release some resource [nuttx]

2024-03-11 Thread via GitHub
acassis commented on PR #11892: URL: https://github.com/apache/nuttx/pull/11892#issuecomment-1988324671 @Donny9 do you know if this driver reduces or increases the kernel size? Please include the change of memory usage before and after this patch. I think NuttX should include the

Re: [I] CMake Support for The JH7110 Board [nuttx]

2024-03-11 Thread via GitHub
acassis commented on issue #11870: URL: https://github.com/apache/nuttx/issues/11870#issuecomment-1988318412 @theoparis thank you for your effort trying to add support for CMakefile to compile this board. As @anchao explained currently CMakefile has support only for building NuttX

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
Donny9 commented on code in PR #11008: URL: https://github.com/apache/nuttx/pull/11008#discussion_r1519621769 ## drivers/video/video.c: ## @@ -3488,7 +3494,16 @@ int video_register(FAR const char *devpath, int video_unregister(FAR const char *devpath) { - return

Re: [I] STM32H7 (& STM32F4): UART write issue [nuttx]

2024-03-11 Thread via GitHub
acassis commented on issue #11877: URL: https://github.com/apache/nuttx/issues/11877#issuecomment-1988306785 @maxikrie I think these differences between ESP32 and STM32 could happen because the former has internal HW FIFO and the later doesn't. More info about O_NONBLOCK please read

[PR] sched/pthread: replace pthread_sem_give() to nxsem_post() to unify the post method [nuttx]

2024-03-11 Thread via GitHub
anchao opened a new pull request, #11891: URL: https://github.com/apache/nuttx/pull/11891 ## Summary sched/pthread: replace pthread_sem_give() to nxsem_post() to unify the post method replace pthread_sem_give() to nxsem_post() to unify the post method

[PR] sched/pthread/join: remove unused joininfo [nuttx]

2024-03-11 Thread via GitHub
anchao opened a new pull request, #11890: URL: https://github.com/apache/nuttx/pull/11890 ## Summary sched/pthread/join: remove unused joininfo remove unused joininfo, minor issue found from code reading Signed-off-by: chao an ## Impact N/A ##

[PR] libs/libc/string: fix memmem() boundary case when needle is at end of haystack [nuttx]

2024-03-11 Thread via GitHub
juniskane opened a new pull request, #11889: URL: https://github.com/apache/nuttx/pull/11889 ## Summary libs/libc/string: fix memmem() boundary case when needle is at end of haystack This fixes calls like memmem("hello", 5, "lo", 2); Also zero-length needle is deemed to

Re: [PR] STM32H7 serial TX DMA fix [nuttx]

2024-03-11 Thread via GitHub
davids5 commented on PR #11871: URL: https://github.com/apache/nuttx/pull/11871#issuecomment-1988110803 @kk-thrane I am glad you went through the `nxsem_trywait` and see the contrast now. If you consider the foregrounds looping trying to transmit. I have concerns about the

Re: [PR] drivers/video: Update for improvement and bug fix [nuttx]

2024-03-11 Thread via GitHub
SPRESENSE commented on code in PR #11859: URL: https://github.com/apache/nuttx/pull/11859#discussion_r1519489829 ## drivers/video/isx019.c: ## @@ -797,6 +811,122 @@ static const int32_t g_isx019_wbmode[] = #define NR_WBMODE (sizeof(g_isx019_wbmode) / sizeof(int32_t))

Re: [PR] drivers/video: Update for improvement and bug fix [nuttx]

2024-03-11 Thread via GitHub
SPRESENSE commented on code in PR #11859: URL: https://github.com/apache/nuttx/pull/11859#discussion_r1519489123 ## include/nuttx/video/imgsensor.h: ## @@ -34,49 +34,49 @@ /* Camera parameter IDs */ -#define IMGSENSOR_ID_BRIGHTNESS (0x) -#define

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11008: URL: https://github.com/apache/nuttx/pull/11008#discussion_r1519352890 ## drivers/video/video.c: ## @@ -3488,7 +3494,16 @@ int video_register(FAR const char *devpath, int video_unregister(FAR const char *devpath) { - return

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11008: URL: https://github.com/apache/nuttx/pull/11008#discussion_r1519352890 ## drivers/video/video.c: ## @@ -3488,7 +3494,16 @@ int video_register(FAR const char *devpath, int video_unregister(FAR const char *devpath) { - return

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11008: URL: https://github.com/apache/nuttx/pull/11008#discussion_r1519352890 ## drivers/video/video.c: ## @@ -3488,7 +3494,16 @@ int video_register(FAR const char *devpath, int video_unregister(FAR const char *devpath) { - return

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #11008: URL: https://github.com/apache/nuttx/pull/11008#discussion_r1519352890 ## drivers/video/video.c: ## @@ -3488,7 +3494,16 @@ int video_register(FAR const char *devpath, int video_unregister(FAR const char *devpath) { - return

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-11 Thread via GitHub
SPRESENSE commented on code in PR #11008: URL: https://github.com/apache/nuttx/pull/11008#discussion_r1519342452 ## drivers/video/video.c: ## @@ -3488,7 +3494,16 @@ int video_register(FAR const char *devpath, int video_unregister(FAR const char *devpath) { - return

Re: [PR] STM32H7 serial TX DMA fix [nuttx]

2024-03-11 Thread via GitHub
kk-thrane commented on PR #11871: URL: https://github.com/apache/nuttx/pull/11871#issuecomment-1987826207 To my surprise, nuttx implements nxsem_trywait() using a critical section... so yes, using a critical section instead of the semaphore provides better performance. Hasn't nuttx got