Re: [PR] riscv/k230: add ARCH_HAVE_RESET and revise logging [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11906: URL: https://github.com/apache/nuttx/pull/11906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated: riscv/k230: add ARCH_HAVE_RESET revise logging

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1fa2559f00 riscv/k230: add ARCH_HAVE_RESET

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
AndrewD commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993592476 > As for the TWAI code changes, I ma not sure if to change identifier of the type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`. This prefix was added

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
AndrewD commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993576209 > In general, I am happy that driver will be moved to the common code area and can be used with all ESP32 chips and even SJA1000 chips from single source which allows to keep it update

(nuttx) branch master updated: sim/nxcamera: add CONFIG_SIM_FBBPP=32

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9f056fdd47 sim/nxcamera: add

Re: [PR] sim/nxcamera: add CONFIG_SIM_FBBPP=32 [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11905: URL: https://github.com/apache/nuttx/pull/11905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fs/driver: using nx_unlink to call unlink ops to release some resource [nuttx]

2024-03-12 Thread via GitHub
Donny9 commented on PR #11892: URL: https://github.com/apache/nuttx/pull/11892#issuecomment-1993458883 > @Donny9 do you know if this driver reduces or increases the kernel size? Please include the change of memory usage before and after this patch. > > I think NuttX should include

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
masayuki2009 commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1993418802 > @anchao Do you know why the Build / Linux (sim-01) fails? OK. I understand that ci-test needs https://github.com/apache/nuttx-apps/pull/2329. -- This is an automated

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
masayuki2009 commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1993408658 @anchao Do you know why the Build / Linux (sim-01) fails? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] riscv/k230: add ARCH_HAVE_RESET and revise logging [nuttx]

2024-03-12 Thread via GitHub
yf13 opened a new pull request, #11906: URL: https://github.com/apache/nuttx/pull/11906 ## Summary This patch adds board_reset and revises debug logging. ## Impact K230 devices ## Testing Checked with CanMV230 -- This is an automated message from the

[PR] sim/nxcamera: add CONFIG_SIM_FBBPP=32 [nuttx]

2024-03-12 Thread via GitHub
shizhenghui opened a new pull request, #11905: URL: https://github.com/apache/nuttx/pull/11905 ## Summary When using nxcamera, CONFIG_SIM_FBBPP is default to 8, which causes incorrect color display. The formats supported by nxcamera are the same as x11, supporting both 32-bit and

(nuttx) branch master updated (2b18917a6b -> 255090d594)

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2b18917a6b Revert "assert/panic: disable panic message to save the code size" add c3a3f79741 video: extend

(nuttx-apps) branch master updated: camera_example: modify initialize interface after v4l2 refactor

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new a00ba19eb camera_example: modify

Re: [PR] V4l2 refactor [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11887: URL: https://github.com/apache/nuttx/pull/11887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] camera_example: modify initialize interface after v4l2 refactor [nuttx-apps]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #2326: URL: https://github.com/apache/nuttx-apps/pull/2326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] camera_example: modify initialize interface after v4l2 refactor [nuttx-apps]

2024-03-12 Thread via GitHub
shizhenghui commented on PR #2326: URL: https://github.com/apache/nuttx-apps/pull/2326#issuecomment-1993072058 @jerpelea I updated the summary of the pull_request. this change should build with [v4l2_refactor](https://github.com/apache/nuttx/pull/11887) and open

Re: [PR] binfmt/loadmodule: replace kmm_free() to lib_free() [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #11904: URL: https://github.com/apache/nuttx/pull/11904#discussion_r1522364061 ## binfmt/binfmt_loadmodule.c: ## @@ -194,7 +194,7 @@ int load_module(FAR struct binary_s *bin, FAR const char *filename, /* Free the

(nuttx) branch master updated: Revert "assert/panic: disable panic message to save the code size"

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2b18917a6b Revert "assert/panic: disable

Re: [PR] Revert "assert/panic: disable panic message to save the code size" [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11903: URL: https://github.com/apache/nuttx/pull/11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Revert "assert/panic: disable panic message to save the code size" [nuttx]

2024-03-12 Thread via GitHub
anchao closed pull request #11903: Revert "assert/panic: disable panic message to save the code size" URL: https://github.com/apache/nuttx/pull/11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Revert "assert/panic: disable panic message to save the code size" [nuttx]

2024-03-12 Thread via GitHub
anchao commented on PR #11903: URL: https://github.com/apache/nuttx/pull/11903#issuecomment-1992947400 @tmedicci Thank you, let us revert this commit first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(nuttx-website) branch asf-site updated: Publishing web: f355c37abb2c2dea4b5ff1c582aacf9520a34e3a docs: 87cec8d5c74676d739962d127f54866c8c87088c

2024-03-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 666bf3fab Publishing web:

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
masayuki2009 commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1992675717 > @masayuki2009 san, could you please help to review this PR? Thank you! > > This PR depends on: [apache/nuttx-apps#2329](https://github.com/apache/nuttx-apps/pull/2329)

Re: [PR] Revert "assert/panic: disable panic message to save the code size" [nuttx]

2024-03-12 Thread via GitHub
tmedicci commented on PR #11903: URL: https://github.com/apache/nuttx/pull/11903#issuecomment-1992361374 > @tmedicci @anchao should we call panic_notifier_call_chain and board_reset even when CONFIG_DEBUG_ASSERTIONS isn't defined? The problem still happens if user disable

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521741723 ## include/nuttx/can/sja1000.h: ## @@ -0,0 +1,163 @@ +/ + * include/nuttx/can/sja1000.h + * +

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521689770 ## drivers/can/sja1000.h: ## @@ -0,0 +1,911 @@ +/ + * drivers/can/sja1000.h + * + * SJA1000

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
nicolas71640 commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1991933886 I'm not using cmake. I'm using make targets "export" and "import". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Revert "assert/panic: disable panic message to save the code size" [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 commented on PR #11903: URL: https://github.com/apache/nuttx/pull/11903#issuecomment-1991919234 @tmedicci @anchao should we call panic_notifier_call_chain and board_reset even when CONFIG_DEBUG_ASSERTIONS isn't defined? The problem still happens if user disable

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521671256 ## include/nuttx/can/sja1000.h: ## @@ -0,0 +1,163 @@ +/ + * include/nuttx/can/sja1000.h + * +

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1991901900 we export and import only with make, not try export with make and build with cmake. Your usage doesn't coverage by daily ci or even mention in document. -- This is an

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521649736 ## include/nuttx/can/sja1000.h: ## @@ -0,0 +1,163 @@ +/ + * include/nuttx/can/sja1000.h + * +

[PR] Revert "assert/panic: disable panic message to save the code size" [nuttx]

2024-03-12 Thread via GitHub
tmedicci opened a new pull request, #11903: URL: https://github.com/apache/nuttx/pull/11903 ## Summary This reverts commit 9b1c451f2f881077cd7d56f6496ea3c06ea30f17, introduced by [#11796](https://github.com/apache/nuttx/pull/11796) Please note that the introduced change

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
acassis commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991861068 Sorry, pressed the incorrect button, I was willing to cancel my comment. These github buttons are prone to lead us to make mistakes. -- This is an automated message from the Apache Git

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
acassis commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991857341 > As for the TWAI code changes, I ma not sure if to change identifier of the type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`. My long term goal is to reach

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
acassis closed pull request #11868: drivers/can/sja1000: Add SJA1000 CAN driver support URL: https://github.com/apache/nuttx/pull/11868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
nicolas71640 commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1991822092 @xiaoxiang781216 What do you mean by "only for Makefile" ? as said I said here : https://github.com/apache/nuttx/issues/11863#issuecomment-1991042732 without any cmake

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991811989 As for the TWAI code changes, I ma not sure if to change identifier of the type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`. My long term goal is to reach

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1991785732 In general, I am happy that driver will be moved to the common code area and can be used with all ESP32 chips and even SJA1000 chips from single source which allows to keep it update and

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
ppisa commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521499968 ## drivers/can/Kconfig: ## @@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY endif # CAN_MCP2515 -endif +menuconfig CAN_SJA1000 + tristate "Philips/NXP

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-12 Thread via GitHub
beginner77-git commented on PR #11896: URL: https://github.com/apache/nuttx/pull/11896#issuecomment-1991673614 > ## Summary > This patch contains improvements to harden logic of nx_mount(): > > * currently some variables may not get populated by called functions, thus

Re: [PR] stm32f40xxx_pinmap: add 3rd alternate mapping for USART6 [nuttx]

2024-03-12 Thread via GitHub
acassis merged PR #11902: URL: https://github.com/apache/nuttx/pull/11902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated (02dc6fa219 -> 87cec8d5c7)

2024-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 02dc6fa219 stm32_serial.c: fix compilation of onewire driver mode add 87cec8d5c7 stm32f40xxx_pinmap: add 3rd

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
anchao commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1991585301 @masayuki2009 san, could you please help to review this PR? Thank you! This PR depends on: https://github.com/apache/nuttx-apps/pull/2329 -- This is an automated message from

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
anchao commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1991582837 > Very nice @anchao ! Please test also with osperf and let us know what was the impact before and after this change @acassis osperf results as below, performance has no impact

(nuttx) branch master updated: stm32_serial.c: fix compilation of onewire driver mode

2024-03-12 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 02dc6fa219 stm32_serial.c: fix compilation of

Re: [PR] stm32_serial.c: fix compilation of onewire driver mode [nuttx]

2024-03-12 Thread via GitHub
jerpelea merged PR #11901: URL: https://github.com/apache/nuttx/pull/11901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated (5bf6ea0c20 -> 73576e0d02)

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5bf6ea0c20 fs/mount: harden nx_mount logic add 73576e0d02 Fix cmake-format wrong execution order No new

Re: [PR] Fix cmake-format wrong execution order [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11900: URL: https://github.com/apache/nuttx/pull/11900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 commented on PR #11008: URL: https://github.com/apache/nuttx/pull/11008#issuecomment-1991467138 Ok, let me close this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] camera_example: modify initialize interface after v4l2 refactor [nuttx-apps]

2024-03-12 Thread via GitHub
xiaoxiang781216 commented on PR #2326: URL: https://github.com/apache/nuttx-apps/pull/2326#issuecomment-1991469648 > @shizhenghui please fix coding style check issue it's a false alarm:

Re: [PR] drivers/video: Update unlink() and video_uninitialize() operation [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 closed pull request #11008: drivers/video: Update unlink() and video_uninitialize() operation URL: https://github.com/apache/nuttx/pull/11008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(nuttx) branch master updated (1be1149fdd -> 5bf6ea0c20)

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 1be1149fdd arch/esp32 bringup openeth new 813f67f93b mm_heap/mm.h: revising comments new 5bf6ea0c20

(nuttx) 01/02: mm_heap/mm.h: revising comments

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 813f67f93b29c2ca50d78e182f1e1dbdb6f609ae Author: Yanfeng Liu AuthorDate: Tue Mar 12 16:25:36 2024 +0800

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11896: URL: https://github.com/apache/nuttx/pull/11896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) 02/02: fs/mount: harden nx_mount logic

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5bf6ea0c20df83575ed94d03bf43598ca961f6e4 Author: Yanfeng Liu AuthorDate: Tue Mar 12 16:26:17 2024 +0800

(nuttx-apps) branch master updated: testing/getprime: allow running with zero threads

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 767642b4e testing/getprime: allow

Re: [PR] testing/getprime: allow running with zero threads [nuttx-apps]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #2328: URL: https://github.com/apache/nuttx-apps/pull/2328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1991447885 Yes, but only for Makefile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(nuttx) branch master updated (768c5a28a1 -> 1be1149fdd)

2024-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 768c5a28a1 arch/x86_64: move common Make.defs to common new d048caf1d2 arch/esp32 add openeth mac driver

(nuttx) 01/03: arch/esp32 add openeth mac driver

2024-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit d048caf1d27104f8198f2d829154255215e8f0cb Author: Marco Casaroli AuthorDate: Mon Mar 11 18:30:05 2024 +

(nuttx) 03/03: arch/esp32 bringup openeth

2024-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1be1149fdde7739d2c575b41775a86e5777f9cd0 Author: Marco Casaroli AuthorDate: Mon Mar 11 18:49:31 2024 +

Re: [PR] ESP32 opencores network driver for QEMU [nuttx]

2024-03-12 Thread via GitHub
acassis merged PR #11895: URL: https://github.com/apache/nuttx/pull/11895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) 02/03: arch/esp32 add config for qemu-openeth

2024-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9af8299af56c8048592786390c84f6280b2c4c5d Author: Marco Casaroli AuthorDate: Mon Mar 11 18:43:02 2024 +

(nuttx) branch master updated: arch/x86_64: move common Make.defs to common

2024-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 768c5a28a1 arch/x86_64: move common Make.defs

Re: [PR] arch/x86_64: move common Make.defs to common [nuttx]

2024-03-12 Thread via GitHub
acassis merged PR #11899: URL: https://github.com/apache/nuttx/pull/11899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ESP32 opencores network driver for QEMU [nuttx]

2024-03-12 Thread via GitHub
acassis commented on PR #11895: URL: https://github.com/apache/nuttx/pull/11895#issuecomment-1991408841 > > @casaroli what you think about creating a qemu-esp32 board (at boards/xtensa/esp32/qemu-esp32) ? This way it will be easy to test features validated on QEMU for ESP32 > > We

Re: [PR] ESP32 opencores network driver for QEMU [nuttx]

2024-03-12 Thread via GitHub
casaroli commented on PR #11895: URL: https://github.com/apache/nuttx/pull/11895#issuecomment-1991404850 > @casaroli what you think about creating a qemu-esp32 board (at boards/xtensa/esp32/qemu-esp32) ? This way it will be easy to test features validated on QEMU for ESP32 We can do

Re: [PR] ESP32 opencores network driver for QEMU [nuttx]

2024-03-12 Thread via GitHub
acassis commented on PR #11895: URL: https://github.com/apache/nuttx/pull/11895#issuecomment-1991355095 @casaroli what you think about creating a qemu-esp32 board (at boards/xtensa/esp32/qemu-esp32) ? This way it will be easy to test features validated on QEMU for ESP32 -- This is an

[PR] stm32f40xxx_pinmap: add 3rd alternate mapping for USART6 [nuttx]

2024-03-12 Thread via GitHub
mlyszczek opened a new pull request, #11902: URL: https://github.com/apache/nuttx/pull/11902 Some stm32 has alternate USART6 pinout on G9/G14 but others have it on A12/A11. Unfortunately it's very difficult to make proper ifdefs for this since position is based on package (and pincount)

Re: [PR] camera_example: modify initialize interface after v4l2 refactor [nuttx-apps]

2024-03-12 Thread via GitHub
acassis commented on PR #2326: URL: https://github.com/apache/nuttx-apps/pull/2326#issuecomment-1991294808 please fix CI check errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
acassis commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1991257488 Very nice @anchao ! Please test also with osperf and let us know what was the impact before and after this change -- This is an automated message from the Apache Git Service. To

Re: [PR] cmake: fix libxx header file search path issue and enable libxx for CMake build [nuttx]

2024-03-12 Thread via GitHub
xuxin930 commented on PR #11893: URL: https://github.com/apache/nuttx/pull/11893#issuecomment-1991249693 CI failed because `matter` needs to be adapted im working on it, and plan to open CMake's libxx CI -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] stm32_serial.c: fix compilation of onewire driver mode [nuttx]

2024-03-12 Thread via GitHub
acassis commented on PR #11901: URL: https://github.com/apache/nuttx/pull/11901#issuecomment-1991242383 Very nice @mlyszczek !!! Thank you for writing a good commit log explaining the issue! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] V4l2 refactor [nuttx]

2024-03-12 Thread via GitHub
shizhenghui commented on PR #11887: URL: https://github.com/apache/nuttx/pull/11887#issuecomment-1991240992 rebase https://github.com/apache/nuttx/pull/11859/commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
acassis commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1991238357 @nicolas71640 I got same errors you got: ``` LD: nuttx ld --entry=__start -Wl,--gc-sections -Wl,-Ttext-segment=0x40 -Wl,-Map=/home/alan/nuttxspace/nuttx/nuttx.map

[PR] stm32_serial.c: fix compilation of onewire driver mode [nuttx]

2024-03-12 Thread via GitHub
mlyszczek opened a new pull request, #11901: URL: https://github.com/apache/nuttx/pull/11901 Onewire driver wants to use "struct up_dev_s *priv", which is extracted from "struct uart_dev_s" and "struct inode". But inode and uart dev are only declared when TERMIOS or BSDCOMPAT is also

Re: [I] stringstream linker problem when Normal, Full Optimization Activated [nuttx]

2024-03-12 Thread via GitHub
trns1997 commented on issue #11227: URL: https://github.com/apache/nuttx/issues/11227#issuecomment-1991218568 @SPRESENSE ah sadly it is not as trivial as we thought. @leducp found an alternative approach to string stream with char conv, he could give you some tips and guide you through it.

Re: [PR] ostest: add test for libc memmem() function [nuttx-apps]

2024-03-12 Thread via GitHub
acassis commented on PR #2327: URL: https://github.com/apache/nuttx-apps/pull/2327#issuecomment-1991216163 Done: https://github.com/apache/nuttx/pull/11900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Fix cmake-format wrong execution order [nuttx]

2024-03-12 Thread via GitHub
acassis opened a new pull request, #11900: URL: https://github.com/apache/nuttx/pull/11900 ## Summary Fix cmake-format wrong execution order ## Impact Improve users life ## Testing N/A -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] ostest: add test for libc memmem() function [nuttx-apps]

2024-03-12 Thread via GitHub
acassis commented on PR #2327: URL: https://github.com/apache/nuttx-apps/pull/2327#issuecomment-1991196505 > I forgot someone wanted to add cmake to nuttx. This CI error is misleading: > > ``` > cmake-format check failed, run following command to update the style: > $

Re: [I] stringstream linker problem when Normal, Full Optimization Activated [nuttx]

2024-03-12 Thread via GitHub
SPRESENSE commented on issue #11227: URL: https://github.com/apache/nuttx/issues/11227#issuecomment-1991182059 @trns1997 @xiaoxiang781216 I have the same problem with the Spresense board. What is the status of this issue? -- This is an automated message from the Apache Git

Re: [PR] ostest: add test for libc memmem() function [nuttx-apps]

2024-03-12 Thread via GitHub
juniskane commented on PR #2327: URL: https://github.com/apache/nuttx-apps/pull/2327#issuecomment-1991149782 I forgot someone wanted to add cmake to nuttx. This CI error is misleading: ``` cmake-format check failed, run following command to update the style: $ cmake-format -o

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-12 Thread via GitHub
acassis commented on code in PR #11868: URL: https://github.com/apache/nuttx/pull/11868#discussion_r1521125131 ## drivers/can/Kconfig: ## @@ -193,4 +193,44 @@ config MCP2515_SPI_SCK_FREQUENCY endif # CAN_MCP2515 -endif +menuconfig CAN_SJA1000 + tristate "Philips/NXP

[PR] arch/x86_64: move common Make.defs to common [nuttx]

2024-03-12 Thread via GitHub
szafonimateusz-mi opened a new pull request, #11899: URL: https://github.com/apache/nuttx/pull/11899 ## Summary arch/x86_64: move common Make.defs to common ## Impact cosmetic change to simplify intel64 Make.defs ## Testing CI -- This is an automated message

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
nicolas71640 commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1991042732 Thank you all for your help. As I understand it, @acassis and @xuxin930 you suggest to use the export AND Import script to us the Makefile to build the final binary. I

Re: [I] Simulator export fails [nuttx]

2024-03-12 Thread via GitHub
leducp commented on issue #11863: URL: https://github.com/apache/nuttx/issues/11863#issuecomment-1990998302 I think there is a quiproquo here: we are using CMake as our project tool, but we build NuttX with Make file. The exported CMake toolchain file is based on the export.sh script and I

[PR] testing/ostest/cancel: joining a detached/canceled thread should return EINVAL, not ESRCH [nuttx-apps]

2024-03-12 Thread via GitHub
anchao opened a new pull request, #2329: URL: https://github.com/apache/nuttx-apps/pull/2329 ## Summary testing/ostest/cancel: joining a detached/canceled thread should return EINVAL, not ESRCH Reference:

[PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-12 Thread via GitHub
anchao opened a new pull request, #11898: URL: https://github.com/apache/nuttx/pull/11898 ## Summary sched/pthread/join: refactor pthread join to support join task 1. add support to join main task ``` | static pthread_t self; | | static void *join_task(void

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-12 Thread via GitHub
davids5 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520927255 ## mm/mm_heap/mm.h: ## @@ -121,8 +121,10 @@ #define MM_ALIGN_UP(a) (((a) + MM_GRAN_MASK) & ~MM_GRAN_MASK) #define MM_ALIGN_DOWN(a) ((a) & ~MM_GRAN_MASK) -/* An

Re: [PR] revise comments and harden nx_mount logic [nuttx]

2024-03-12 Thread via GitHub
davids5 commented on code in PR #11896: URL: https://github.com/apache/nuttx/pull/11896#discussion_r1520926766 ## mm/mm_heap/mm.h: ## @@ -121,8 +121,10 @@ #define MM_ALIGN_UP(a) (((a) + MM_GRAN_MASK) & ~MM_GRAN_MASK) #define MM_ALIGN_DOWN(a) ((a) & ~MM_GRAN_MASK) -/* An

(nuttx) branch master updated: xtensa/esp32: Fix wrong interrupt number

2024-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 277ca97b44 xtensa/esp32: Fix wrong interrupt

Re: [PR] xtensa/esp32: Fix wrong interrupt number [nuttx]

2024-03-12 Thread via GitHub
xiaoxiang781216 merged PR #11897: URL: https://github.com/apache/nuttx/pull/11897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: