anchao edited a comment on pull request #1291: URL: https://github.com/apache/incubator-nuttx/pull/1291#issuecomment-650964575
> ok. sync with IPPROTO_ makes sense. > actually, shouldn't we just remove all SOL_ constants except SOL_SOCKET, and use IPPROTO_ constants instead? Done, please help to review the following PR: https://github.com/apache/incubator-nuttx/pull/1320 https://github.com/apache/incubator-nuttx-apps/pull/311 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org