patacongo opened a new pull request #467: arch/z80/src/ez80/ez80_spi.c:  
Correct oversight in previous commit
URL: https://github.com/apache/incubator-nuttx/pull/467
 
 
   Commit 797e45d6bfc467743a3ff350858d2169cad5126e attempted to reduce the 
frequency of SPI reconfiguration by keeping track of the current frequency and 
mode settings and changing these settings only when the new settings differ 
from the old settings.
   
   However, the original commit neglected to save the new frequency setting 
and, hence, was not effective in what it was trying to do:  Every time the SPI 
setfrequency() method was called, it still looked like a new frequency and the 
frequency was still reconfigured, even though it hadn't really changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to