xiaoxiang781216 merged PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaoxiang781216 commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2081315493
@XuNeo please fix the nxstyle warning:
https://github.com/apache/nuttx-apps/actions/runs/8849934321/job/24303028511?pr=2312
--
This is an automated message from the
XuNeo commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2068067693
Hi,
I have removed the config option to select different LVGL version. Now it's
fixed to v9.1.0.
Manually tested with https://github.com/apache/nuttx/pull/11780 on local
Ubuntu
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2066544630
@XuNeo another point: is it possible to integrate your lua+lvgl binding
(https://github.com/XuNeo/luavgl) into nuttx-apps?
--
This is an automated message from the Apache Git
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2054093083
> > maybe an alternative is just create an empty lvgl repository with only
the Kconfig from LVGL 9.x
>
> Unfortunately, I cannot find a better solution. Create an empty lvgl
XuNeo commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2053944591
> maybe an alternative is just create an empty lvgl repository with only the
Kconfig from LVGL 9.x
Unfortunately, I cannot find a better solution. Create an empty lvgl
repository
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2052244492
> it's resolved internally by osource:
https://docs.zephyrproject.org/latest/build/kconfig/extensions.html
Interesting, but it doesn't solve all the issue, because the LVGL
xiaoxiang781216 commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2052149869
it's resolved internally by osource:
https://docs.zephyrproject.org/latest/build/kconfig/extensions.html
--
This is an automated message from the Apache Git Service.
To
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2052077509
> I'm not an expert on NuttX, so please forgive me the silly question: why
don't you have the same issue with other 3rd party libraries used in NuttX? I
think LVGL uses Kconfig in a
kisvegabor commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2040284250
I'm not an expert on NuttX, so please forgive me the silly question: why
don't you have the same issue with other 3rd party libraries used in NuttX? I
think LVGL uses Kconfig in a
cederom commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039915221
Right, keeping things minimal is important, additional repository with
necessary libs seems best solution (either as nuttx/libs or apache/nuttx-libs),
just to have all in one place,
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039902048
> What about full copy of external library (i.e. LVGL) to our source tree so
everything is always in one place and ready do build offline with no additional
downloads? Would that be
cederom commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039892107
What about full copy of external library (i.e. LVGL) to our source tree so
everything is always in one place and ready do build offline with no additional
downloads? Would that be
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039858663
> > Yes, I think we could have a "make download" to download all libraries
to let user compile it online.
>
> This can be also achieved with `git submodule` if the code is in
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039853557
@XuNeo I think this is a limitation of Kconfig (or the way our build system
works), it is not dynamic. If we modify some Kconfig and don't run "make
menuconfig" our .config will not
cederom commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039849580
> Yes, I think we could have a "make download" to download all libraries to
let user compile it online.
This can be also achieved with `git submodule` if the code is in external
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039836079
> I also thought about that and in a perfect situation we have all source
code modules etc as part of repository do no additional downloads are necessary
and everything should work
cederom commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039824816
I also thought about that and in a perfect situation we have all source code
modules etc as part of repository do no additional downloads are necessary and
everything should work out
acassis commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039552809
> What about a script that pre-downloads the lvgl library? The main NuttX
Kconfig lvgl entry could say that running the script is advisable and to re-run
make menuconfig having done
TimJTi commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2028874013
What about a script that pre-downloads the lvgl library? The main NuttX
Kconfig lvgl entry could say that running the script is advisable and to
re-run make menuconfig having done so?
xiaoxiang781216 commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2012498748
Yes, I think so:(, not perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
XuNeo commented on PR #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2009404993
LVGL has released version v9.1.0. Locally tested and works.
I have to copy file content from lvgl/lvgl/Kconfig to lvgl/Kconfig because
`source lvgl/Kconfig` won't work if the
XuNeo opened a new pull request, #2312:
URL: https://github.com/apache/nuttx-apps/pull/2312
## Summary
Dependson https://github.com/apache/nuttx/pull/11780
### Limitations
1. Should wait LVGL to release v9.0.1 to fix existing issues firstly.
2. For now cmake only
23 matches
Mail list logo