Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-23 Thread via GitHub
xiaoxiang781216 merged PR #11745: URL: https://github.com/apache/nuttx/pull/11745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-23 Thread via GitHub
xiaoxiang781216 commented on PR #11745: URL: https://github.com/apache/nuttx/pull/11745#issuecomment-1961388126 > the CI failure dose not caused by this patch. yes, other patch make the break, but it fix. please update your patch to retrigger ci. -- This is an automated message

Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-23 Thread via GitHub
xuxin930 commented on PR #11745: URL: https://github.com/apache/nuttx/pull/11745#issuecomment-1961301900 the CI failure dose not caused by this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-22 Thread via GitHub
xuxin930 commented on code in PR #11745: URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500264224 ## CMakeLists.txt: ## @@ -84,7 +84,8 @@ if(NOT KCONFIGLIB) $ pip install kconfiglib") endif() -if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)

Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-22 Thread via GitHub
anchao commented on code in PR #11745: URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500230541 ## CMakeLists.txt: ## @@ -84,7 +84,8 @@ if(NOT KCONFIGLIB) $ pip install kconfiglib") endif() -if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)

Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-22 Thread via GitHub
xuxin930 commented on code in PR #11745: URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500182454 ## CMakeLists.txt: ## @@ -84,7 +84,8 @@ if(NOT KCONFIGLIB) $ pip install kconfiglib") endif() -if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)

Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-22 Thread via GitHub
anchao commented on code in PR #11745: URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500078532 ## CMakeLists.txt: ## @@ -84,7 +84,8 @@ if(NOT KCONFIGLIB) $ pip install kconfiglib") endif() -if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)

[PR] cmake:fix the problems of using cmake to compile custom board [nuttx]

2024-02-22 Thread via GitHub
xuxin930 opened a new pull request, #11745: URL: https://github.com/apache/nuttx/pull/11745 ## Summary ### 1. **No config found when reconfig** when reconfiguring a custom configuration, because `${BOARD_CONFIG}` uses a _relative path_, it will cause the following error: