acassis closed pull request #2184: lte/lapi: Remove the PIN feature
URL: https://github.com/apache/nuttx-apps/pull/2184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
acassis commented on PR #2184:
URL: https://github.com/apache/nuttx-apps/pull/2184#issuecomment-2083614497
Closing this PR, let's keep the PIN support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
acassis commented on PR #2184:
URL: https://github.com/apache/nuttx-apps/pull/2184#issuecomment-1977217877
ping @SPRESENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hartmannathan commented on PR #2184:
URL: https://github.com/apache/nuttx-apps/pull/2184#issuecomment-1803951314
I noticed the APIs do not have docstrings. Perhaps as @cederom and
@raiden00pl suggest, don't delete the APIs? Instead, consider adding a comment
block before the functions,
raiden00pl commented on PR #2184:
URL: https://github.com/apache/nuttx-apps/pull/2184#issuecomment-1803388298
Isn't it the user's responsibility to use the API correctly? If the API is
dangerous for some reason, it is better to hide it behind an Kconfig option
than to remove it completely.
cederom commented on PR #2184:
URL: https://github.com/apache/nuttx-apps/pull/2184#issuecomment-1803026977
* It this code to be removed works well in general?
* What will happen with SIM that requires PIN and the code gets now removed?
* Why not add option to disable that functionality
SPRESENSE opened a new pull request, #2184:
URL: https://github.com/apache/nuttx-apps/pull/2184
## Summary
Remove the PIN feature, because the SIM may accidentally become unusable.
## Impact
Only LTE feature.
## Testing
Test with Spresense LTE board.
--
This is
