Re: [PR] rpmsgdev_server: do not notify the client when the fds has teardown [nuttx]

2024-01-04 Thread via GitHub
xiaoxiang781216 merged PR #11483: URL: https://github.com/apache/nuttx/pull/11483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] rpmsgdev_server: do not notify the client when the fds has teardown [nuttx]

2024-01-04 Thread via GitHub
CV-Bowen commented on code in PR #11483: URL: https://github.com/apache/nuttx/pull/11483#discussion_r1442435982 ## drivers/misc/rpmsgdev_server.c: ## @@ -324,15 +324,20 @@ static void rpmsgdev_poll_worker(FAR void *arg) container_of(fds, FAR struct rpmsgdev_device_s, fd);

Re: [PR] rpmsgdev_server: do not notify the client when the fds has teardown [nuttx]

2024-01-04 Thread via GitHub
anchao commented on code in PR #11483: URL: https://github.com/apache/nuttx/pull/11483#discussion_r1442394644 ## drivers/misc/rpmsgdev_server.c: ## @@ -324,15 +324,20 @@ static void rpmsgdev_poll_worker(FAR void *arg) container_of(fds, FAR struct rpmsgdev_device_s, fd);

[PR] rpmsgdev_server: do not notify the client when the fds has teardown [nuttx]

2024-01-04 Thread via GitHub
CV-Bowen opened a new pull request, #11483: URL: https://github.com/apache/nuttx/pull/11483 ## Summary Print an error log instead assert when poll notify is called after the teardown. ## Impact rpmsgdev ## Testing sim:rpserver and sim:proxy -- This is an