Re: svn commit: r1818291 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/

2017-12-15 Thread Jacques Le Roux
Le 15/12/2017 à 17:51, Jacques Le Roux a écrit : Le 15/12/2017 à 16:10, mbr...@apache.org a écrit : + Debug.logError("Problems with digital product status change : " + null, module); What is the point of putting null there :) ? Jacques Removed at r1818348 Jacques

svn commit: r1818348 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderChangeHelper.java

2017-12-15 Thread jleroux
Author: jleroux Date: Fri Dec 15 22:55:44 2017 New Revision: 1818348 URL: http://svn.apache.org/viewvc?rev=1818348=rev Log: No functional change, removes a trivial not useful null Modified:

buildbot success in on ofbiz-trunk-framework

2017-12-15 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/860 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in on ofbiz-trunk-framework-plugins

2017-12-15 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/896 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

svn commit: r1818337 - in /ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/survey: PdfSurveyServices.java SurveyWrapper.java

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 21:02:07 2017 New Revision: 1818337 URL: http://svn.apache.org/viewvc?rev=1818337=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.content.survey. (OFBIZ-10079) Thanks Julian Leichert for reporting and providing the patches.

svn commit: r1818335 - /ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/webapp/ftl/

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 20:56:29 2017 New Revision: 1818335 URL: http://svn.apache.org/viewvc?rev=1818335=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.content.webapp.ftl. (OFBIZ-10080) Thanks Julian Leichert for reporting and providing the

svn commit: r1818333 - /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/promo/PromoServices.java

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 20:43:18 2017 New Revision: 1818333 URL: http://svn.apache.org/viewvc?rev=1818333=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.product.promo. (OFBIZ-10081) Thanks Dennis Balkir for reporting and providing the patches.

svn commit: r1818330 - in /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/spreadsheetimport: ImportProductHelper.java ImportProductServices.java

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 20:37:55 2017 New Revision: 1818330 URL: http://svn.apache.org/viewvc?rev=1818330=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.product.spreadsheetimport. (OFBIZ-10082) Thanks Julian Leichert for reporting and providing

svn commit: r1818329 [3/3] - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-12-15 Thread mbrohl
Modified: ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java URL:

svn commit: r1818329 [2/3] - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-12-15 Thread mbrohl
Modified: ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java URL:

svn commit: r1818329 [1/3] - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 20:33:56 2017 New Revision: 1818329 URL: http://svn.apache.org/viewvc?rev=1818329=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.order.shoppingcart. (OFBIZ-10084) Thanks Dennis Balkir for reporting and providing the

svn commit: r1818325 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/tax/TaxAuthorityServices.java

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 20:15:42 2017 New Revision: 1818325 URL: http://svn.apache.org/viewvc?rev=1818325=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.accounting.tax. (OFBIZ-9877) Thanks Julian Leichert for reporting and providing the patches.

Re: svn commit: r1818291 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/

2017-12-15 Thread Jacques Le Roux
Le 15/12/2017 à 16:10, mbr...@apache.org a écrit : +Debug.logError("Problems with digital product status change : " + null, module); What is the point of putting null there :) ? Jacques

svn commit: r1818291 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/

2017-12-15 Thread mbrohl
Author: mbrohl Date: Fri Dec 15 15:10:32 2017 New Revision: 1818291 URL: http://svn.apache.org/viewvc?rev=1818291=rev Log: Improved: Fixing defects reported by FindBugs, package org.apache.ofbiz.order.order. (OFBIZ-10056) Thanks Julian Leichert for reporting and providing the patch. Modified:

buildbot success in on ofbiz-trunk-framework-plugins

2017-12-15 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/891 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

svn commit: r1818274 - in /ofbiz/branches/release16.11: ./ applications/content/src/main/java/org/apache/ofbiz/content/content/ContentSearch.java

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 12:03:41 2017 New Revision: 1818274 URL: http://svn.apache.org/viewvc?rev=1818274=rev Log: Applied fix from trunk for revision: 1818273 === Fixed: Screen rendering error on Content Advanced Search page (OFBIZ-9365) Thanks Aditya Sharma for reporting the issue.

svn commit: r1818273 - /ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentSearch.java

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 12:01:39 2017 New Revision: 1818273 URL: http://svn.apache.org/viewvc?rev=1818273=rev Log: Fixed: Screen rendering error on Content Advanced Search page (OFBIZ-9365) Thanks Aditya Sharma for reporting the issue. Content Advanced search was broken since long, still

buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-15 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/890 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

svn commit: r1818270 - in /ofbiz/branches/release16.11: ./ applications/party/widget/partymgr/ProfileScreens.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 11:34:10 2017 New Revision: 1818270 URL: http://svn.apache.org/viewvc?rev=1818270=rev Log: Applied fix from trunk for revision: 1818269 === Fixed: Edit Party Group page does not shows current set values (OFBIZ-9532) Thansk Aditya Sharma for reporting the issue.

svn commit: r1818269 - /ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 11:30:48 2017 New Revision: 1818269 URL: http://svn.apache.org/viewvc?rev=1818269=rev Log: Fixed: Edit Party Group page does not shows current set values (OFBIZ-9532) Thansk Aditya Sharma for reporting the issue. Modified:

svn commit: r1818260 - /ofbiz/ofbiz-plugins/trunk/projectmgr/widget/ResourceScreens.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 10:34:14 2017 New Revision: 1818260 URL: http://svn.apache.org/viewvc?rev=1818260=rev Log: Fixed: Updated ViewPartyRoles inclusion from include-form to include-grid in projectmgr application Modified:

svn commit: r1818259 - /ofbiz/ofbiz-plugins/trunk/scrum/widget/ResourceScreens.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 10:28:56 2017 New Revision: 1818259 URL: http://svn.apache.org/viewvc?rev=1818259=rev Log: Fixed: RuntimeException on viewroles page of Scrum component (OFBIZ-10033) ViewPartyRoles form was changed to grid at r#18151933 Thanks Aditya Sharma for

svn commit: r1818255 - /ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 09:58:38 2017 New Revision: 1818255 URL: http://svn.apache.org/viewvc?rev=1818255=rev Log: Fixed: PropertyNotFoundException occuring while accessing ecommerce applicaiton, moved InitTheme.groovy code at the starting of man-decorator, as layoutSettings variable

svn commit: r1818254 - /ofbiz/ofbiz-plugins/trunk/ecommerce/template/customer/NewCustomer.ftl

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 09:51:39 2017 New Revision: 1818254 URL: http://svn.apache.org/viewvc?rev=1818254=rev Log: Improved: Update markup of Register page according to standard markup given by Bootstrap v4.0.0 (OFBIZ-10018) Thanks Nitish Mishra for your contribution Modified:

svn commit: r1818250 - in /ofbiz/ofbiz-plugins/trunk/ecommerce: webapp/ecommerce/js/popper.js widget/CommonScreens.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 09:25:37 2017 New Revision: 1818250 URL: http://svn.apache.org/viewvc?rev=1818250=rev Log: Fixed: Added popper.js file to fix ecommerce js console error (OFBIZ-10016) currently, there is an open issue with bootstrap.bundle.min.js, It gives 'Uncaught

buildbot success in on ofbiz-trunk-framework-plugins

2017-12-15 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/884 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

svn commit: r1818245 - in /ofbiz/ofbiz-plugins/trunk/ecommerce: template/cart/MiniCart.ftl template/catalog/CompareProductsList.ftl template/catalog/KeywordSearchBox.ftl widget/CartScreens.xml widget/

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 08:56:27 2017 New Revision: 1818245 URL: http://svn.apache.org/viewvc?rev=1818245=rev Log: Improved: Update markup of Home page according to standard markup given by Bootstrap v4.0.0 (OFBIZ-10011) Thanks Parakh and Mayank for your contribution Added:

svn commit: r1818244 - in /ofbiz/ofbiz-framework/trunk/applications: content/servicedef/secas.xml order/servicedef/services_shoppinglist.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 08:46:55 2017 New Revision: 1818244 URL: http://svn.apache.org/viewvc?rev=1818244=rev Log: Fixed xml validation error found while console read Modified: ofbiz/ofbiz-framework/trunk/applications/content/servicedef/secas.xml

svn commit: r1818243 - /ofbiz/ofbiz-framework/trunk/applications/datamodel/entitydef/product-entitymodel.xml

2017-12-15 Thread deepak
Author: deepak Date: Fri Dec 15 08:39:39 2017 New Revision: 1818243 URL: http://svn.apache.org/viewvc?rev=1818243=rev Log: Fxied: Corrected fk-name warning for newly added entities, fk-name was greater than 18 character.(OFBIZ-10040) Modified: