svn commit: r1860028 - in /ofbiz/ofbiz-plugins/trunk: birt/src/main/java/org/apache/ofbiz/birt/webapp/view/ ecommerce/src/main/java/org/apache/ofbiz/ecommerce/webapp/view/ ldap/src/main/java/org/apach

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 23:44:25 2019 New Revision: 1860028 URL: http://svn.apache.org/viewvc?rev=1860028=rev Log: Improved: Use the ‘@Override’ annotation (OFBIZ-10939) The ‘@Override’ annotation helps readers understand that the method at hand is overriding a super class or implementing

svn commit: r1860027 - in /ofbiz/ofbiz-plugins/trunk: ldap/src/main/java/org/apache/ofbiz/ldap/LdapLoginWorker.java msggateway/src/main/java/org/apache/ofbiz/msg91/Msg91Services.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 23:43:45 2019 New Revision: 1860027 URL: http://svn.apache.org/viewvc?rev=1860027=rev Log: Improved: Remove useless imports Modified: ofbiz/ofbiz-plugins/trunk/ldap/src/main/java/org/apache/ofbiz/ldap/LdapLoginWorker.java

svn commit: r1860025 [2/2] - in /ofbiz/ofbiz-plugins/trunk: assetmaint/src/main/java/org/apache/ofbiz/assetmaint/ birt/src/main/java/org/apache/ofbiz/birt/email/ birt/src/main/java/org/apache/ofbiz/bi

2019-05-25 Thread mthl
Modified: ofbiz/ofbiz-plugins/trunk/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumEvents.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumEvents.java?rev=1860025=1860024=1860025=diff

svn commit: r1860025 [1/2] - in /ofbiz/ofbiz-plugins/trunk: assetmaint/src/main/java/org/apache/ofbiz/assetmaint/ birt/src/main/java/org/apache/ofbiz/birt/email/ birt/src/main/java/org/apache/ofbiz/bi

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 23:42:00 2019 New Revision: 1860025 URL: http://svn.apache.org/viewvc?rev=1860025=rev Log: Improved: Remove redundant type declarations (OFBIZ-10937) Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is

svn commit: r1860026 - /ofbiz/ofbiz-plugins/trunk/solr/src/main/java/org/apache/ofbiz/solr/ProductUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 23:42:50 2019 New Revision: 1860026 URL: http://svn.apache.org/viewvc?rev=1860026=rev Log: Improved: Remove useless null check (OFBIZ-10054) Modified: ofbiz/ofbiz-plugins/trunk/solr/src/main/java/org/apache/ofbiz/solr/ProductUtil.java Modified:

svn commit: r1860024 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/conversion/test/ src/test/java/org/apache/ofbiz/base/conversion/TestJSONConverters.java testd

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:58:15 2019 New Revision: 1860024 URL: http://svn.apache.org/viewvc?rev=1860024=rev Log: Improved: Turn ‘TestJSONConverters’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1860023 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/conversion/test/TestBooleanConverters.java src/test/java/org/apache/ofbiz/base/conversion/Tes

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:54:01 2019 New Revision: 1860023 URL: http://svn.apache.org/viewvc?rev=1860023=rev Log: Improved: Turn ‘TestBooleanConverters’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1860022 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/test/BaseUnitTests.java src/test/java/org/apache/ofbiz/base/test/ src/test/java/org/apache/of

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:29:31 2019 New Revision: 1860022 URL: http://svn.apache.org/viewvc?rev=1860022=rev Log: Improved: Turn ‘BaseUnitTests’ into a unit test class (OFBIZ-11067) Added: ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/org/apache/ofbiz/base/test/

svn commit: r1860021 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/AssertTests.java src/test/java/org/apache/ofbiz/base/util/AssertTests.java testdef/

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:28:23 2019 New Revision: 1860021 URL: http://svn.apache.org/viewvc?rev=1860021=rev Log: Improved: Turn ‘AssertTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1860020 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/UtilMiscTests.java src/test/java/org/apache/ofbiz/base/util/UtilMiscTests.java test

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:27:30 2019 New Revision: 1860020 URL: http://svn.apache.org/viewvc?rev=1860020=rev Log: Improved: Turn ‘UtilMiscTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1860019 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/UtilIOTests.java src/test/java/org/apache/ofbiz/base/util/UtilIOTests.java testdef/

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:24:02 2019 New Revision: 1860019 URL: http://svn.apache.org/viewvc?rev=1860019=rev Log: Improved: Turn ‘UtilIOTests’ into a unit test class (OFBIZ-11067) Previously this test was disabled, however since it now seems to work now we enable it. Added:

buildbot success in on ofbizTrunkFramework

2019-05-25 Thread buildbot
The Buildbot has detected a restored build on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/879 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1860018 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/UtilHttpTests.java testdef/basetests.xml

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:21:05 2019 New Revision: 1860018 URL: http://svn.apache.org/viewvc?rev=1860018=rev Log: Improved: Remove empty ‘UtilHttpTests’ class (OFBIZ-11067) This test class was empty so no need to convert it in a unit test class. Removed:

svn commit: r1860017 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/cache/test/ src/test/java/org/apache/ofbiz/base/util/cache/ testdef/

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:19:54 2019 New Revision: 1860017 URL: http://svn.apache.org/viewvc?rev=1860017=rev Log: Improved: Turn ‘UtilCacheTests’ into a unit test class (OFBIZ-11067) Added: ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/org/apache/ofbiz/base/util/cache/

svn commit: r1860016 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/TimeDurationTests.java src/test/java/org/apache/ofbiz/base/util/TimeDurationTests.j

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:15:04 2019 New Revision: 1860016 URL: http://svn.apache.org/viewvc?rev=1860016=rev Log: Improved: Turn ‘TimeDurationTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1860015 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/ReferenceCleanerTests.java src/test/java/org/apache/ofbiz/base/util/ReferenceCleane

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 21:13:46 2019 New Revision: 1860015 URL: http://svn.apache.org/viewvc?rev=1860015=rev Log: Improved: Turn ‘ReferenceCleanerTests’ into a unit test class (OFBIZ-11067) Keep it disabled since it is failing for obscure reasons. Added:

buildbot failure in on ofbizTrunkFramework

2019-05-25 Thread buildbot
The Buildbot has detected a new failure on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/878 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1860006 - /ofbiz/ofbiz-framework/trunk/framework/base/testdef/basetests.xml

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 17:49:57 2019 New Revision: 1860006 URL: http://svn.apache.org/viewvc?rev=1860006=rev Log: Fixed: Remove entry for ‘StringUtilTests’ in “basetests.xml” (OFBIZ-11014) This XML element should have been removed in r1859937 when turning this integration test class into

svn commit: r1860005 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 16:45:44 2019 New Revision: 1860005 URL: http://svn.apache.org/viewvc?rev=1860005=rev Log: Improved: Unit test case for service - CreateReturnItemShipment. (OFBIZ-8859) Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch.

svn commit: r1860004 - /ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 16:35:56 2019 New Revision: 1860004 URL: http://svn.apache.org/viewvc?rev=1860004=rev Log: Improved: Unit test case for service - CheckCreateProductRequirementForFacility. (OFBIZ-8937) Thanks Avnindra Sharma for reporting the issue and Anushi Gupta for providing

svn commit: r1860003 - /ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 16:28:28 2019 New Revision: 1860003 URL: http://svn.apache.org/viewvc?rev=1860003=rev Log: Improved: Used more declarative style for the context map, preferring map literals over imperative map. (OFBIZ-8853) Thanks Mathieu Lirzin for your suggestion. Modified:

svn commit: r1860000 - /ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 15:50:49 2019 New Revision: 186 URL: http://svn.apache.org/viewvc?rev=186=rev Log: Improved: Unit test case for service - CheckPaymentAmountForRefund. (OFBIZ-8852) Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch.

svn commit: r1859999 - /ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 15:48:08 2019 New Revision: 185 URL: http://svn.apache.org/viewvc?rev=185=rev Log: Improved: Unit test case for service - CheckReturnComplete. (OFBIZ-8853) Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch.

svn commit: r1859994 - /ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 15:38:44 2019 New Revision: 1859994 URL: http://svn.apache.org/viewvc?rev=1859994=rev Log: Improved: Unit test case for service - CreateReturnAndItemOrAdjustment. (OFBIZ-8858) Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the

svn commit: r1859992 - /ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 15:34:59 2019 New Revision: 1859992 URL: http://svn.apache.org/viewvc?rev=1859992=rev Log: Improved: Unit test case for service - quickReturnOrder. (OFBIZ-8809) Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch. Modified:

svn commit: r1859985 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ applications/marketing/widget/sfa/forms/AccountForms.xml

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:32:23 2019 New Revision: 1859985 URL: http://svn.apache.org/viewvc?rev=1859985=rev Log: "Applied fix from trunk for revision: 1859981" r1859981 | jleroux | 2019-05-25 16:24:30 +0200 (sam.

svn commit: r1859987 - in /ofbiz/branches/release16.11: ./ applications/marketing/widget/sfa/forms/AccountForms.xml

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:32:37 2019 New Revision: 1859987 URL: http://svn.apache.org/viewvc?rev=1859987=rev Log: "Applied fix from trunk framework for revision: 1859981" r1859981 | jleroux | 2019-05-25 16:24:30

svn commit: r1859986 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ applications/marketing/widget/sfa/forms/AccountForms.xml

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:32:24 2019 New Revision: 1859986 URL: http://svn.apache.org/viewvc?rev=1859986=rev Log: "Applied fix from trunk for revision: 1859981" r1859981 | jleroux | 2019-05-25 16:24:30 +0200 (sam.

svn commit: r1859984 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/ObjectTypeTests.java src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:28:15 2019 New Revision: 1859984 URL: http://svn.apache.org/viewvc?rev=1859984=rev Log: Improved: Turn ‘ObjectTypeTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1859982 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/conversion/test/MiscTests.java src/test/java/org/apache/ofbiz/base/conversion/MiscTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:25:28 2019 New Revision: 1859982 URL: http://svn.apache.org/viewvc?rev=1859982=rev Log: Improved: Turn ‘MiscTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1859981 - /ofbiz/ofbiz-framework/trunk/applications/marketing/widget/sfa/forms/AccountForms.xml

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:24:30 2019 New Revision: 1859981 URL: http://svn.apache.org/viewvc?rev=1859981=rev Log: Fixed: Runtime error exceptions at Leads page (OFBIZ-11059) Step to recreate issue - Login to https://demo-trunk.ofbiz.apache.org/ordermgr/control/main Application

svn commit: r1859979 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/IndentingWriterTests.java src/test/java/org/apache/ofbiz/base/util/IndentingWriterT

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:23:12 2019 New Revision: 1859979 URL: http://svn.apache.org/viewvc?rev=1859979=rev Log: Turn ‘IndentingWriterTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1859978 - in /ofbiz/ofbiz-framework/trunk/framework/base/src: main/java/org/apache/ofbiz/base/util/collections/test/GenericMapTest.java test/java/org/apache/ofbiz/base/util/collections/Ge

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:20:53 2019 New Revision: 1859978 URL: http://svn.apache.org/viewvc?rev=1859978=rev Log: Improved: Turn ‘GenericMapTest’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1859977 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/conversion/test/ src/test/java/org/apache/ofbiz/base/conversion/ testdef/

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:18:19 2019 New Revision: 1859977 URL: http://svn.apache.org/viewvc?rev=1859977=rev Log: Improved: Turn ‘DateTimeTests’ into a unit test class (OFBIZ-11067) Added: ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/org/apache/ofbiz/base/conversion/

svn commit: r1859976 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/lang/test/ src/test/java/org/apache/ofbiz/base/lang/ src/test/java/org/apache/ofbiz/base/lang

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:15:40 2019 New Revision: 1859976 URL: http://svn.apache.org/viewvc?rev=1859976=rev Log: Improved: Turn ‘ComparableRangeTests’ into a unit test class (OFBIZ-11067) Added: ofbiz/ofbiz-framework/trunk/framework/base/src/test/java/org/apache/ofbiz/base/lang/

svn commit: r1859975 - in /ofbiz/ofbiz-framework/trunk/framework/base: src/main/java/org/apache/ofbiz/base/util/test/UtilPropertiesTests.java src/test/java/org/apache/ofbiz/base/util/UtilPropertiesTes

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 14:12:37 2019 New Revision: 1859975 URL: http://svn.apache.org/viewvc?rev=1859975=rev Log: Improved: Turn ‘UtilPropertiesTests’ into a unit test class (OFBIZ-11067) Added:

svn commit: r1859974 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java framework/webapp/src/main/java/org/apache/ofbiz/webapp/

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:10:49 2019 New Revision: 1859974 URL: http://svn.apache.org/viewvc?rev=1859974=rev Log: "Applied fix from trunk for revision: 1859972" r1859972 | jleroux | 2019-05-25 16:08:48 +0200 (sam.

svn commit: r1859973 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java framework/webapp/src/main/java/org/apache/ofbiz/webapp/

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:10:46 2019 New Revision: 1859973 URL: http://svn.apache.org/viewvc?rev=1859973=rev Log: "Applied fix from trunk for revision: 1859972" r1859972 | jleroux | 2019-05-25 16:08:48 +0200 (sam.

svn commit: r1859972 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java webapp/src/main/java/org/apache/ofbiz/webapp/event/ServiceEventHandler.jav

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 14:08:48 2019 New Revision: 1859972 URL: http://svn.apache.org/viewvc?rev=1859972=rev Log: Fixed: Duplicate entries in paramWithSuffix (OFBIZ-11056) when using string-list-suffix attribute for service definition, invoke method (from associated event handler)

buildbot success in on ofbizBranch17Framework

2019-05-25 Thread buildbot
The Buildbot has detected a restored build on builder ofbizBranch17Framework while building . Full details are available at: https://ci.apache.org/builders/ofbizBranch17Framework/builds/289 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in on ofbizBranch18Framework

2019-05-25 Thread buildbot
The Buildbot has detected a restored build on builder ofbizBranch18Framework while building . Full details are available at: https://ci.apache.org/builders/ofbizBranch18Framework/builds/134 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1859971 - in /ofbiz/branches/release16.11: ./ build.gradle framework/base/src/main/java/org/apache/ofbiz/base/util/UtilCodec.java

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 13:34:49 2019 New Revision: 1859971 URL: http://svn.apache.org/viewvc?rev=1859971=rev Log: "Applied fix from trunk framework for revision: 1859968" r1859968 | jleroux | 2019-05-25 15:25:34

svn commit: r1859969 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ build.gradle framework/base/src/main/java/org/apache/ofbiz/base/util/UtilCodec.java

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 13:34:45 2019 New Revision: 1859969 URL: http://svn.apache.org/viewvc?rev=1859969=rev Log: "Applied fix from trunk for revision: 1859968" r1859968 | jleroux | 2019-05-25 15:25:34 +0200 (sam.

svn commit: r1859970 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ build.gradle framework/base/src/main/java/org/apache/ofbiz/base/util/UtilCodec.java

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 13:34:47 2019 New Revision: 1859970 URL: http://svn.apache.org/viewvc?rev=1859970=rev Log: "Applied fix from trunk for revision: 1859968" r1859968 | jleroux | 2019-05-25 15:25:34 +0200 (sam.

buildbot success in on ofbizTrunkFramework

2019-05-25 Thread buildbot
The Buildbot has detected a restored build on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/868 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1859968 - in /ofbiz/ofbiz-framework/trunk: build.gradle framework/base/src/main/java/org/apache/ofbiz/base/util/UtilCodec.java

2019-05-25 Thread jleroux
Author: jleroux Date: Sat May 25 13:25:34 2019 New Revision: 1859968 URL: http://svn.apache.org/viewvc?rev=1859968=rev Log: Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe" (OFBIZ-5254) The testCreateNewRequest was failing due to escaped single quotes in related

svn commit: r1859938 - /ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ServiceDispatcher.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 10:01:14 2019 New Revision: 1859938 URL: http://svn.apache.org/viewvc?rev=1859938=rev Log: Improved: ‘ServiceDispatcher’ is not meant to be extended (OFBIZ-11032) This makes the ‘ServiceDispatcher’ class final and replaces the ‘protected’ modifier with ‘private’ for

svn commit: r1859937 - in /ofbiz/ofbiz-framework/trunk/framework/base/src: main/java/org/apache/ofbiz/base/util/test/StringUtilTests.java test/java/org/apache/ofbiz/base/util/StringUtilTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:38:42 2019 New Revision: 1859937 URL: http://svn.apache.org/viewvc?rev=1859937=rev Log: Improved: Turn ‘StringUtilTests’ into a unit test class (OFBIZ-11014) Since there is no dependency on the delegator and dispatcher for those tests, it is better to run them as

svn commit: r1859935 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ applications/workeffort/servicedef/services.xml

2019-05-25 Thread swapnilmmane
Author: swapnilmmane Date: Sat May 25 09:31:15 2019 New Revision: 1859935 URL: http://svn.apache.org/viewvc?rev=1859935=rev Log: Applied fix from trunk for revision: 1859931 === Fixed: Error on deleting the survey associated with the task (OFBIZ-7594) The following error is generated on

svn commit: r1859933 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ applications/workeffort/servicedef/services.xml

2019-05-25 Thread swapnilmmane
Author: swapnilmmane Date: Sat May 25 09:28:09 2019 New Revision: 1859933 URL: http://svn.apache.org/viewvc?rev=1859933=rev Log: Applied fix from trunk for revision: 1859931 === Fixed: Error on deleting the survey associated with the task (OFBIZ-7594) The following error is generated on

svn commit: r1859934 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util: StringUtil.java test/StringUtilTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:28:36 2019 New Revision: 1859934 URL: http://svn.apache.org/viewvc?rev=1859934=rev Log: Improved: Remove unused ‘StringUtil#appendTo’ methods (OFBIZ-11014) Modified:

svn commit: r1859931 - /ofbiz/ofbiz-framework/trunk/applications/workeffort/servicedef/services.xml

2019-05-25 Thread swapnilmmane
Author: swapnilmmane Date: Sat May 25 09:25:56 2019 New Revision: 1859931 URL: http://svn.apache.org/viewvc?rev=1859931=rev Log: Fixed: Error on deleting the survey associated with the task (OFBIZ-7594) The following error is generated on deleting the survey associated with the task. Error

svn commit: r1859930 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:25:41 2019 New Revision: 1859930 URL: http://svn.apache.org/viewvc?rev=1859930=rev Log: Improved: Remove unused ‘StringUtil#collapseSpaces’ method (OFBIZ-11014) Modified:

svn commit: r1859929 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:24:37 2019 New Revision: 1859929 URL: http://svn.apache.org/viewvc?rev=1859929=rev Log: Improved: Remove unused ‘StringUtil#collapseNewlines’ method (OFBIZ-11014) Modified:

svn commit: r1859928 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util: StringUtil.java test/StringUtilTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:22:58 2019 New Revision: 1859928 URL: http://svn.apache.org/viewvc?rev=1859928=rev Log: Improved: Remove unused ‘StringUtil#removeNumeric’ method (OFBIZ-11014) Modified:

svn commit: r1859927 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util: StringUtil.java test/StringUtilTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:21:53 2019 New Revision: 1859927 URL: http://svn.apache.org/viewvc?rev=1859927=rev Log: Improved: Remove unused ‘StringUtil#convertChar’ method (OFBIZ-11014) Modified:

svn commit: r1859926 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util: StringUtil.java test/StringUtilTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:21:06 2019 New Revision: 1859926 URL: http://svn.apache.org/viewvc?rev=1859926=rev Log: Improved: Remove unused ‘StringUtil#mapToStr’ method (OFBIZ-11014) Modified:

svn commit: r1859925 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:18:55 2019 New Revision: 1859925 URL: http://svn.apache.org/viewvc?rev=1859925=rev Log: Improved: Remove unused ‘StringUtil#strToMap’ overload (OFBIZ-11014) Make the other overload which is only used internally private. Modified:

svn commit: r1859924 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/ base/src/main/java/org/apache/ofbiz/base/util/test/ widget/src/main/java/org/apache/ofb

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:17:12 2019 New Revision: 1859924 URL: http://svn.apache.org/viewvc?rev=1859924=rev Log: Improved: Inline ‘StringUtil#quoteStrList’ method (OFBIZ-11014) Modified:

svn commit: r1859923 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:15:38 2019 New Revision: 1859923 URL: http://svn.apache.org/viewvc?rev=1859923=rev Log: Improved: Remove unused ‘StringUtil#split’ overload (OFBIZ-11014) Modified:

svn commit: r1859922 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util: StringUtil.java test/StringUtilTests.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:13:41 2019 New Revision: 1859922 URL: http://svn.apache.org/viewvc?rev=1859922=rev Log: Improved: Remove unused ‘StringUtil#append’ method (OFBIZ-11014) Modified:

svn commit: r1859921 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:12:05 2019 New Revision: 1859921 URL: http://svn.apache.org/viewvc?rev=1859921=rev Log: Improved: Rewrite ‘StringUtil#join’ method (OFBIZ-11014) Use streams instead of low-level string builder. Modified:

svn commit: r1859920 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java

2019-05-25 Thread mthl
Author: mthl Date: Sat May 25 09:10:12 2019 New Revision: 1859920 URL: http://svn.apache.org/viewvc?rev=1859920=rev Log: Improved: Remove useless ‘StringUtil#join’ overload (OFBIZ-11014) ‘List’ extends ‘Collection’ so there is no need to overload ‘StringUtil#join(Collection,String)’ with

svn commit: r1859917 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ framework/webtools/groovyScripts/entity/FindGeneric.groovy framework/widget/dtd/widget-form.xsd framework/widget/src/main/jav

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 08:28:36 2019 New Revision: 1859917 URL: http://svn.apache.org/viewvc?rev=1859917=rev Log: Applied fix from trunk for revision: 1859915 === Fixed: Enable entity timestamp fields. (OFBIZ-10959) While working on a Production environment, it is found that for some

svn commit: r1859916 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ framework/webtools/groovyScripts/entity/FindGeneric.groovy framework/widget/dtd/widget-form.xsd framework/widget/src/main/jav

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 08:27:34 2019 New Revision: 1859916 URL: http://svn.apache.org/viewvc?rev=1859916=rev Log: Applied fix from trunk for revision: 1859915 === Fixed: Enable entity timestamp fields. (OFBIZ-10959) While working on a Production environment, it is found that for some

svn commit: r1859915 - in /ofbiz/ofbiz-framework/trunk/framework: webtools/groovyScripts/entity/FindGeneric.groovy widget/dtd/widget-form.xsd widget/src/main/java/org/apache/ofbiz/widget/model/ModelFo

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 08:26:33 2019 New Revision: 1859915 URL: http://svn.apache.org/viewvc?rev=1859915=rev Log: Fixed: Enable entity timestamp fields. (OFBIZ-10959) While working on a Production environment, it is found that for some reason entity timestamp fields are disabled at

svn commit: r1859914 - /ofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/css/custom.css

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 07:20:21 2019 New Revision: 1859914 URL: http://svn.apache.org/viewvc?rev=1859914=rev Log: Fixed: Product image not scaling properly on ecommerce at different screen resolution. (OFBIZ-10880) Thanks Arpit Mor for reporting and Praveen Sharma for providing the

svn commit: r1859913 - in /ofbiz/ofbiz-framework/trunk/applications/datamodel: data/seed/PartySeedData.xml data/seed/WorkEffortSeedData.xml entitydef/party-entitymodel.xml

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 06:40:54 2019 New Revision: 1859913 URL: http://svn.apache.org/viewvc?rev=1859913=rev Log: Improved: ContactMechPurposeType entity should be extended with generic type entity fields. (OFBIZ-11008) Thanks Jacques for reviewing the patch. Modified:

svn commit: r1859912 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ applications/product/groovyScripts/product/promo/ProductPromoCondServices.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 06:26:30 2019 New Revision: 1859912 URL: http://svn.apache.org/viewvc?rev=1859912=rev Log: Applied fix from trunk for revision: 1859911 === Fixed: Issue in order history promotion. (OFBIZ-10847) Issue: According to the promotion customer should spend 000 in any

svn commit: r1859911 - /ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/product/promo/ProductPromoCondServices.groovy

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 06:23:31 2019 New Revision: 1859911 URL: http://svn.apache.org/viewvc?rev=1859911=rev Log: Fixed: Issue in order history promotion. (OFBIZ-10847) Issue: According to the promotion customer should spend 000 in any 12 months to avail 5% discount. The system is

svn commit: r1859910 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 06:13:21 2019 New Revision: 1859910 URL: http://svn.apache.org/viewvc?rev=1859910=rev Log: Applied fix from trunk for revision: 1859909 === Fixed: Drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the

svn commit: r1859909 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java

2019-05-25 Thread surajk
Author: surajk Date: Sat May 25 06:12:37 2019 New Revision: 1859909 URL: http://svn.apache.org/viewvc?rev=1859909=rev Log: Fixed: Drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart. (OFBIZ-11021) RequirementMethodEnumId should