buildbot success in on ofbizTrunkFrameworkPlugins
The Buildbot has detected a restored build on builder ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are available at: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/2178 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf945_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'onTrunkPluginsCommit' triggered this build Build Source Stamp: [branch trunk] 0606714363b0a8cb7114e28468902d2eb03deb31 Blamelist: Jacques Le Roux Build succeeded! Sincerely, -The Buildbot
buildbot failure in on ofbizTrunkFrameworkPlugins
The Buildbot has detected a new failure on builder ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are available at: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/2177 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf947_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'onTrunkPluginsCommit' triggered this build Build Source Stamp: [branch trunk] 69eea73ba280e5c97c1e41f105c77eadec1af115 Blamelist: Jacques Le Roux BUILD FAILED: failed testIntegration Sincerely, -The Buildbot
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/trunk by this push:
new 30ec649 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
30ec649 is described below
commit 30ec649c573f094dedb13547c4297455ebfdae5e
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 18:29:43 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes last bugs
---
multiflex/webapp/multiflex/style.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/multiflex/webapp/multiflex/style.css
b/multiflex/webapp/multiflex/style.css
index 2f0355f..b90414b 100644
--- a/multiflex/webapp/multiflex/style.css
+++ b/multiflex/webapp/multiflex/style.css
@@ -516,7 +516,7 @@ footer {
}
.nocolumns {
-w_idth: 900px;
+width: 900px;
width: 870px;
padding: 0 1em 0 1em;
background: #FF url(/images/bg_head_breadcrumbs.jpg) repeat-y;
@@ -1010,7 +1010,7 @@ p:after {
.nocolumns .screenlet-title-bar,
.rightonly .screenlet-title-bar,
.leftonly .screenlet-title-bar {
-c_lear: both;
+clear: both;
margin: 0px;
padding: 4px 20px 3px 20px;
background-color: rgb(190, 190, 190);
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git The following commit(s) were added to refs/heads/trunk by this push: new 229b9b9 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) 229b9b9 is described below commit 229b9b9ca1e0a9c9b7c484832446f9d21fcd56dc Author: Jacques Le Roux AuthorDate: Fri Aug 6 18:22:16 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Another fake change in .sonarcloud.properties to test setting changes in GitHub sonarQBE UI --- .sonarcloud.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index 8b13789..139597f 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -1 +1,2 @@ +
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/trunk by this push:
new 874c830 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
874c830 is described below
commit 874c830fbbbec9c54e608683344c20bee26e4b8a
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 18:16:41 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes few bugs
---
ecommerce/webapp/ecommerce/error/404.jsp | 5 +++--
multiflex/webapp/multiflex/style.css | 5 ++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ecommerce/webapp/ecommerce/error/404.jsp
b/ecommerce/webapp/ecommerce/error/404.jsp
index 0ba9b92..78cfcf9 100644
--- a/ecommerce/webapp/ecommerce/error/404.jsp
+++ b/ecommerce/webapp/ecommerce/error/404.jsp
@@ -27,7 +27,8 @@ ServletContext context = pageContext.getServletContext();
String webSiteId = WebSiteWorker.getWebSiteId(request);
List webAnalytics = delegator.findByAnd("WebAnalyticsConfig",
UtilMisc.toMap("webSiteId", webSiteId), null, false);
%>
-
+
+
Error 404
<%if (webAnalytics != null) {%>
@@ -40,7 +41,7 @@ List webAnalytics =
delegator.findByAnd("WebAnalyticsConfig", Util
-404.
+404.
Thats an error.
diff --git a/multiflex/webapp/multiflex/style.css
b/multiflex/webapp/multiflex/style.css
index b00b662..2f0355f 100644
--- a/multiflex/webapp/multiflex/style.css
+++ b/multiflex/webapp/multiflex/style.css
@@ -407,14 +407,13 @@ footer {
position: absolute;
z-index: 999;
top: 3.1em;
-t\op: 3.0em;
left: 0;
-marg\in-top: 0.1em;
+margin-top: 0.1em;
}
.nav2 ul li a:hover ul li a {
display: block;
-w\idth: 10.0em;
+width: 10.0em;
height: 1px;
line-height: 1.3em;
padding: 4px 16px 4px 16px;
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/trunk by this push:
new eee69f9 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
eee69f9 is described below
commit eee69f91c5a069e63efea14ac91a065b9e9b00f3
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 17:47:21 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes a possible http issue (not a big deal)
---
scrum/data/hookscripts/commit.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scrum/data/hookscripts/commit.py b/scrum/data/hookscripts/commit.py
index 3dbd991..515ab97 100644
--- a/scrum/data/hookscripts/commit.py
+++ b/scrum/data/hookscripts/commit.py
@@ -137,7 +137,7 @@ if REPOS and REV:
doc = Document()
soapenv = doc.createElement("soapenv:Envelope")
doc.appendChild(soapenv)
-soapenv.setAttribute("xmlns:soapenv",
"http://schemas.xmlsoap.org/soap/envelope/;)
+soapenv.setAttribute("xmlns:soapenv",
"https://schemas.xmlsoap.org/soap/envelope/;)
soapenv.setAttribute("xmlns:ser", OFBIZ_WEBSERVICE_URL)
header = doc.createElement("soapenv:Header")
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git The following commit(s) were added to refs/heads/trunk by this push: new 4f4328b Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) 4f4328b is described below commit 4f4328bf68a88f59819a6ee12f1a93a78bd1 Author: Jacques Le Roux AuthorDate: Fri Aug 6 17:16:45 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Another fake change in .sonarcloud.properties to test setting changes in GitHub sonarQBE UI --- .sonarcloud.properties | 1 - 1 file changed, 1 deletion(-) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index 139597f..8b13789 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -1,2 +1 @@ -
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 46433e8 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
46433e8 is described below
commit 46433e85b76d231f7000707f2b9fa6809f4f08a5
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 17:14:40 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
"moz-linear-gradient(bottom" should be better than "moz-linear-gradient(to
bottom"
---
themes/flatgrey/webapp/flatgrey/style.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/themes/flatgrey/webapp/flatgrey/style.css
b/themes/flatgrey/webapp/flatgrey/style.css
index 73b898b..cbeda35 100644
--- a/themes/flatgrey/webapp/flatgrey/style.css
+++ b/themes/flatgrey/webapp/flatgrey/style.css
@@ -918,7 +918,7 @@ form .basic-table,
border-radius: 1em;
background: #ddd url(images/button.png) repeat-x;
background: -webkit-gradient(linear, left top, left bottom, color-stop(0,
#fff), color-stop(1, #ddd));
-background: -moz-linear-gradient(to bottom, #fff 0%, #ddd 100%);
+background: -moz-linear-gradient(bottom, #fff 0%, #ddd 100%);
border: 0.1em solid;
border-color: #ddd #bbb #999;
cursor: pointer;
@@ -1502,7 +1502,7 @@ input[type="button"] {
border-radius: 1.1em;
background: #ddd url(images/button.png) repeat-x;
background: -webkit-gradient(linear, left top, left bottom, color-stop(0,
#fff), color-stop(1, #ddd));
-background: -moz-linear-gradient(to bottom, #fff 0%, #ddd 100%);
+background: -moz-linear-gradient(bottom, #fff 0%, #ddd 100%);
border: 0.1em solid;
border-color: #ddd #bbb #999;
cursor: pointer;
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git The following commit(s) were added to refs/heads/trunk by this push: new 0606714 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) 0606714 is described below commit 0606714363b0a8cb7114e28468902d2eb03deb31 Author: Jacques Le Roux AuthorDate: Fri Aug 6 17:11:33 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Another fake change in .sonarcloud.properties to test setting changes in GitHub sonarQBE UI --- .sonarcloud.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index 8b13789..139597f 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -1 +1,2 @@ +
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 4d3039c Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
4d3039c is described below
commit 4d3039c5def904179b1fa570411f96b4bfddd2c6
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 17:07:58 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
SonarQBE did not detect bug put in in ModelInduceFromDb.jsp by 13d6bc2,
found it by chance
"moz-linear-gradient(bottom" should be better than "moz-linear-gradient(to
bottom"
---
framework/webtools/template/entity/ModelInduceFromDb.jsp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/framework/webtools/template/entity/ModelInduceFromDb.jsp
b/framework/webtools/template/entity/ModelInduceFromDb.jsp
index 9fe696a..d0941c3 100644
--- a/framework/webtools/template/entity/ModelInduceFromDb.jsp
+++ b/framework/webtools/template/entity/ModelInduceFromDb.jsp
@@ -30,14 +30,14 @@ if(security.hasPermission("ENTITY_MAINT", session)) {
ModelInduceFromDB
-Put the name of the Datasource in the EntityEngine.xml
to induce from:
+Put the name of the Datasource in the EntityEngine.xml
to induce from:
It's the datasource name. It doesn't need to be associated with a
delegator, just defined in entityengine.xml.
-Use the browser to view the source and see the entities that were
created.
+Use the browser to view the source and see the entities that were
created.
[ofbiz-plugins] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git The following commit(s) were added to refs/heads/trunk by this push: new 69eea73 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) 69eea73 is described below commit 69eea73ba280e5c97c1e41f105c77eadec1af115 Author: Jacques Le Roux AuthorDate: Fri Aug 6 17:04:14 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Fake change in .sonarcloud.properties to test setting changes in sonarQBE following https://sonarcloud.io/documentation/advanced-setup/analysis-scope/ and https://sonarcloud.io/project/settings?category=exclusions=apache_ofbiz-plugins 1st step, maybe others will be needed... --- .sonarcloud.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index e69de29..8b13789 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -0,0 +1 @@ +
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 9ad9cd6 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
9ad9cd6 is described below
commit 9ad9cd6a2ffab8339f2e62390259f5d5167c80b9
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 16:41:29 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Makes moz-linear-gradient the same than webkit-gradient. Both should be
replaced
by linear-gradient but that's another issue...
Second try, based on search on Net
---
themes/flatgrey/webapp/flatgrey/style.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/themes/flatgrey/webapp/flatgrey/style.css
b/themes/flatgrey/webapp/flatgrey/style.css
index 6474c02..73b898b 100644
--- a/themes/flatgrey/webapp/flatgrey/style.css
+++ b/themes/flatgrey/webapp/flatgrey/style.css
@@ -918,7 +918,7 @@ form .basic-table,
border-radius: 1em;
background: #ddd url(images/button.png) repeat-x;
background: -webkit-gradient(linear, left top, left bottom, color-stop(0,
#fff), color-stop(1, #ddd));
-background: -moz-linear-gradient(to left bottom, #fff 0%, #ddd 100%);
+background: -moz-linear-gradient(to bottom, #fff 0%, #ddd 100%);
border: 0.1em solid;
border-color: #ddd #bbb #999;
cursor: pointer;
@@ -1502,7 +1502,7 @@ input[type="button"] {
border-radius: 1.1em;
background: #ddd url(images/button.png) repeat-x;
background: -webkit-gradient(linear, left top, left bottom, color-stop(0,
#fff), color-stop(1, #ddd));
-background: -moz-linear-gradient(to left bottom, #fff 0%, #ddd 100%);
+background: -moz-linear-gradient(to bottom, #fff 0%, #ddd 100%);
border: 0.1em solid;
border-color: #ddd #bbb #999;
cursor: pointer;
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new cdf7d23 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
cdf7d23 is described below
commit cdf7d23686da587f6ecdda1d2b681afce572937b
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 16:15:24 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Makes moz-linear-gradient the same than webkit-gradient. Both should be
replaced
by webkit-gradient linear-gradient but that's another issue...
---
themes/flatgrey/webapp/flatgrey/style.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/themes/flatgrey/webapp/flatgrey/style.css
b/themes/flatgrey/webapp/flatgrey/style.css
index cdc1116..6474c02 100644
--- a/themes/flatgrey/webapp/flatgrey/style.css
+++ b/themes/flatgrey/webapp/flatgrey/style.css
@@ -918,7 +918,7 @@ form .basic-table,
border-radius: 1em;
background: #ddd url(images/button.png) repeat-x;
background: -webkit-gradient(linear, left top, left bottom, color-stop(0,
#fff), color-stop(1, #ddd));
-background: -moz-linear-gradient(top center, #fff 0%, #ddd 100%);
+background: -moz-linear-gradient(to left bottom, #fff 0%, #ddd 100%);
border: 0.1em solid;
border-color: #ddd #bbb #999;
cursor: pointer;
@@ -1502,7 +1502,7 @@ input[type="button"] {
border-radius: 1.1em;
background: #ddd url(images/button.png) repeat-x;
background: -webkit-gradient(linear, left top, left bottom, color-stop(0,
#fff), color-stop(1, #ddd));
-background: -moz-linear-gradient(top center, #fff 0%, #ddd 100%);
+background: -moz-linear-gradient(to left bottom, #fff 0%, #ddd 100%);
border: 0.1em solid;
border-color: #ddd #bbb #999;
cursor: pointer;
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 4cedb51 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
4cedb51 is described below
commit 4cedb5183fe1179a9cc61bdec69360eade3cbbb7
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 12:35:07 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Removes useless empty
.contentarea {
}
---
themes/flatgrey/webapp/flatgrey/style.css | 3 ---
1 file changed, 3 deletions(-)
diff --git a/themes/flatgrey/webapp/flatgrey/style.css
b/themes/flatgrey/webapp/flatgrey/style.css
index 60b7a39..cdc1116 100644
--- a/themes/flatgrey/webapp/flatgrey/style.css
+++ b/themes/flatgrey/webapp/flatgrey/style.css
@@ -257,9 +257,6 @@ th, th a {
font-weight: bold;
}
-.contentarea {
-}
-
/* */
/* Masthead Style */
/* */
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new f6a0acb Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
f6a0acb is described below
commit f6a0acbd127cb9affd308a16d3f64b3617e8c542
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 12:33:30 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Fixes issues in helveticus-main-theme.less file. Not quite sure about
removing
padding:2rem;
but should be OK
---
themes/helveticus/webapp/helveticus/helveticus-main-theme.less | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
b/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
index 2b96123..fd5b3c9 100644
--- a/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
+++ b/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
@@ -274,9 +274,9 @@ a.buttontext{
column-gap:1rem;
border-radius: 0.5rem;
display:inline-block;
+ margin:0.3rem;
margin-right:0.5rem;
font-weight: 600;
- margin:0.3rem;
&:hover{
color: @light-color-theme;
background:@main-color-theme;
@@ -445,7 +445,6 @@ a.buttontext{
border-radius: 4px;
padding:0 2rem;
box-shadow: 0 0 50px 0 @shadow-color;
-padding:2rem;
z-index: 15;
color: @font-color-for-main;
#user-name {
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 13d6bc2 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
13d6bc2 is described below
commit 13d6bc291387617198d2c7268e1abf14cdfa156c
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 11:45:30 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Those should be OK, for instance I see no reasons to do something like that:
window.location.href = window.location.href;
---
framework/webtools/template/entity/ModelInduceFromDb.jsp | 4 ++--
themes/common-theme/webapp/common/js/util/application.js | 2 +-
themes/common-theme/webapp/common/js/util/fieldlookup.js | 2 --
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/framework/webtools/template/entity/ModelInduceFromDb.jsp
b/framework/webtools/template/entity/ModelInduceFromDb.jsp
index f3c8240..9fe696a 100644
--- a/framework/webtools/template/entity/ModelInduceFromDb.jsp
+++ b/framework/webtools/template/entity/ModelInduceFromDb.jsp
@@ -30,14 +30,14 @@ if(security.hasPermission("ENTITY_MAINT", session)) {
ModelInduceFromDB
-Put the name of the Datasource in the EntityEngine.xml to
induce from:
+Put the name of the Datasource in the EntityEngine.xml
to induce from:
It's the datasource name. It doesn't need to be associated with a
delegator, just defined in entityengine.xml.
-Use the browser to view the source and see the entities that were
created.
+Use the browser to view the source and see the entities that were
created.
diff --git a/themes/common-theme/webapp/common/js/util/application.js
b/themes/common-theme/webapp/common/js/util/application.js
index fbecfef..927e752 100644
--- a/themes/common-theme/webapp/common/js/util/application.js
+++ b/themes/common-theme/webapp/common/js/util/application.js
@@ -102,7 +102,7 @@ var j = 1;
/*
JQuery Formalize
*/
-var FORMALIZE = (function($, window, document, undefined) {
+var FORMALIZE = (function($, window, document, notDefined) {
var PLACEHOLDER_SUPPORTED = 'placeholder' in
document.createElement('input');
var AUTOFOCUS_SUPPORTED = 'autofocus' in document.createElement('input');
var WEBKIT = 'webkitAppearance' in document.createElement('select').style;
diff --git a/themes/common-theme/webapp/common/js/util/fieldlookup.js
b/themes/common-theme/webapp/common/js/util/fieldlookup.js
index 47b31f4..7f6e38b 100644
--- a/themes/common-theme/webapp/common/js/util/fieldlookup.js
+++ b/themes/common-theme/webapp/common/js/util/fieldlookup.js
@@ -641,7 +641,6 @@ function lookupFormAjaxRequest(formAction, form) {
},
success : function(result) {
if (result.search(/loginform/) != -1) {
-window.location.href = window.location.href;
return;
}
// Here we are removing the spinner.
@@ -678,7 +677,6 @@ function lookupPaginationAjaxRequest(navAction, type) {
},
success : function(result) {
if (result.search(/loginform/) != -1) {
-window.location.href = window.location.href;
return;
}
// Here we are removing the spinner.
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 42ce0f6 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
42ce0f6 is described below
commit 42ce0f6cfd071f8dfb92579b027b77054b565e91
Author: Jacques Le Roux
AuthorDate: Fri Aug 6 10:54:28 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
I guess a space is needed after question mark for CSS expression when using
ternary operator
---
themes/flatgrey/webapp/flatgrey/style.css | 2 +-
themes/rainbowstone/webapp/rainbowstone/style.css | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/themes/flatgrey/webapp/flatgrey/style.css
b/themes/flatgrey/webapp/flatgrey/style.css
index 1389ef5..60b7a39 100644
--- a/themes/flatgrey/webapp/flatgrey/style.css
+++ b/themes/flatgrey/webapp/flatgrey/style.css
@@ -109,7 +109,7 @@ body {
color: #000;
min-width: 780px;
margin: 0;
-width: expression(document.body.clientWidth < 782? "780px" : "auto");
+width: expression(document.body.clientWidth < 782 ? "780px" : "auto");
}
hr {
diff --git a/themes/rainbowstone/webapp/rainbowstone/style.css
b/themes/rainbowstone/webapp/rainbowstone/style.css
index 0d30b26..d76b5da 100644
--- a/themes/rainbowstone/webapp/rainbowstone/style.css
+++ b/themes/rainbowstone/webapp/rainbowstone/style.css
@@ -111,7 +111,7 @@ body {
color: #000;
min-width: 780px;
margin: 0;
-width: expression(document.body.clientWidth < 782? "780px" : "auto");
+width: expression(document.body.clientWidth < 782 ? "780px" : "auto");
}
hr {
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git The following commit(s) were added to refs/heads/trunk by this push: new 9708d22 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) 9708d22 is described below commit 9708d22afe8d77ebe93bda294d4216042f8c0784 Author: Jacques Le Roux AuthorDate: Fri Aug 6 10:48:26 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Same than what Nicolas did before: <> --- themes/helveticus/webapp/helveticus/helveticus-main-theme.less | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/themes/helveticus/webapp/helveticus/helveticus-main-theme.less b/themes/helveticus/webapp/helveticus/helveticus-main-theme.less index f8f761f..2b96123 100644 --- a/themes/helveticus/webapp/helveticus/helveticus-main-theme.less +++ b/themes/helveticus/webapp/helveticus/helveticus-main-theme.less @@ -32,10 +32,10 @@ @warning: #ff9100; @warningLight: #fff6ec; -@font-color-for-dark : @grey; -@font-color-for-main : @grey-darker; +@font-color-for-dark: @grey; +@font-color-for-main: @grey-darker; @border-color:@grey-light; -@shadow-color : rgba(72, 90, 117, 0.05); +@shadow-color: rgba(72, 90, 117, 0.05); @app-bar-height: 60px; @footer-height: 20px;
[ofbiz-framework] branch trunk updated: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git The following commit(s) were added to refs/heads/trunk by this push: new 55fa3d1 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) 55fa3d1 is described below commit 55fa3d115464420b08dab6a2016c18e255de3514 Author: Jacques Le Roux AuthorDate: Fri Aug 6 10:38:58 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Another fake change in .sonarcloud.properties to test setting changes in GitHub sonarQBE UI --- .sonarcloud.properties | 1 - 1 file changed, 1 deletion(-) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index 139597f..8b13789 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -1,2 +1 @@ -
[ofbiz-framework] 01/02: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit 59ef7a4c9eb7985dfbec39226bc3e97b26d99c99
Author: Jacques Le Roux
AuthorDate: Fri Jul 30 19:04:34 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Not sure all is exact, rather a try...
---
themes/flatgrey/webapp/flatgrey/style.css | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/themes/flatgrey/webapp/flatgrey/style.css
b/themes/flatgrey/webapp/flatgrey/style.css
index 303fdd8..1389ef5 100644
--- a/themes/flatgrey/webapp/flatgrey/style.css
+++ b/themes/flatgrey/webapp/flatgrey/style.css
@@ -109,7 +109,7 @@ body {
color: #000;
min-width: 780px;
margin: 0;
-width: expression(document.body.clientWidth < 782px? "780px" : "auto");
+width: expression(document.body.clientWidth < 782? "780px" : "auto");
}
hr {
@@ -227,7 +227,7 @@ th, th a {
/* = Used to align elements = */
/* == */
.align-bottom {
-vertical-align: bottom;;
+vertical-align: bottom;
}
.align-center {
text-align: center;
@@ -239,7 +239,7 @@ th, th a {
text-align: left;
}
.align-middle {
-vertical-align: bottom;;
+vertical-align: bottom;
}
.align-right {
text-align: right;
@@ -479,7 +479,6 @@ th, th a {
padding: 0.1em 0.3em 0.1em 0.3em;
}
-#app-navigation ul .selected,
#app-navigation ul .selected {
background-color: #f5f5f5;
border: 0.1em solid;
@@ -753,10 +752,6 @@ th, th a {
margin-bottom: 0.5em;
}
-.button-style-2 {
-display: table;
-}
-
/* = In line bar = */
.in-line-bar ul {
display: inline; /* IE Fix */
[ofbiz-framework] 02/02: Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git commit 1459e1f6c8955934529fb2eaede0bd9a7b5b71d6 Author: Jacques Le Roux AuthorDate: Fri Aug 6 10:15:39 2021 +0200 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) Fake change in .sonarcloud.properties to test setting changes in sonarQBE following https://sonarcloud.io/documentation/advanced-setup/analysis-scope/ and https://sonarcloud.io/project/settings?category=exclusions=apache_ofbiz-framework --- .sonarcloud.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/.sonarcloud.properties b/.sonarcloud.properties index 8b13789..139597f 100644 --- a/.sonarcloud.properties +++ b/.sonarcloud.properties @@ -1 +1,2 @@ +
[ofbiz-framework] branch trunk updated (e6b16a5 -> 1459e1f)
This is an automated email from the ASF dual-hosted git repository. jleroux pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git. from e6b16a5 Fixed: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) new 59ef7a4 Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) new 1459e1f Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .sonarcloud.properties| 1 + themes/flatgrey/webapp/flatgrey/style.css | 11 +++ 2 files changed, 4 insertions(+), 8 deletions(-)
