Repository: oozie Updated Branches: refs/heads/master 14e3b035a -> d9f3b84d3
OOZIE-2961 Build contains multiple warnings for is not a parameter name (Artem Ervits via gezapeti) Project: http://git-wip-us.apache.org/repos/asf/oozie/repo Commit: http://git-wip-us.apache.org/repos/asf/oozie/commit/d9f3b84d Tree: http://git-wip-us.apache.org/repos/asf/oozie/tree/d9f3b84d Diff: http://git-wip-us.apache.org/repos/asf/oozie/diff/d9f3b84d Branch: refs/heads/master Commit: d9f3b84d3150ff77e36102b223b0869d13851245 Parents: 14e3b03 Author: Gezapeti Cseh <gezap...@gmail.com> Authored: Mon Jul 31 14:44:29 2017 +0200 Committer: Gezapeti Cseh <gezap...@gmail.com> Committed: Mon Jul 31 14:44:29 2017 +0200 ---------------------------------------------------------------------- .../main/java/org/apache/oozie/BundleEngine.java | 18 +++++++++--------- .../java/org/apache/oozie/CoordinatorEngine.java | 8 ++++---- .../oozie/command/coord/CoordCommandUtils.java | 8 ++++---- .../apache/oozie/command/wf/SubmitXCommand.java | 2 +- .../org/apache/oozie/coord/CoordELFunctions.java | 6 +++--- .../java/org/apache/oozie/service/ELService.java | 2 +- .../org/apache/oozie/service/SchemaService.java | 2 +- .../java/org/apache/oozie/util/DateUtils.java | 4 ++-- .../java/org/apache/oozie/util/XLogFilter.java | 2 +- release-log.txt | 1 + 10 files changed, 27 insertions(+), 26 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/BundleEngine.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/BundleEngine.java b/core/src/main/java/org/apache/oozie/BundleEngine.java index e994bff..5c70b2e 100644 --- a/core/src/main/java/org/apache/oozie/BundleEngine.java +++ b/core/src/main/java/org/apache/oozie/BundleEngine.java @@ -490,9 +490,9 @@ public class BundleEngine extends BaseEngine { /** * return a list of killed Bundle job * - * @param filter, the filter string for which the bundle jobs are killed - * @param start, the starting index for bundle jobs - * @param len, maximum number of jobs to be killed + * @param filter the filter string for which the bundle jobs are killed + * @param start the starting index for bundle jobs + * @param len maximum number of jobs to be killed * @return the list of jobs being killed * @throws BundleEngineException thrown if one or more of the jobs cannot be killed */ @@ -513,9 +513,9 @@ public class BundleEngine extends BaseEngine { /** * return a list of suspended Bundle job * - * @param filter, the filter string for which the bundle jobs are suspended - * @param start, the starting index for bundle jobs - * @param len, maximum number of jobs to be suspended + * @param filter the filter string for which the bundle jobs are suspended + * @param start the starting index for bundle jobs + * @param len maximum number of jobs to be suspended * @return the list of jobs being suspended * @throws BundleEngineException thrown if one or more of the jobs cannot be suspended */ @@ -536,9 +536,9 @@ public class BundleEngine extends BaseEngine { /** * return a list of resumed Bundle job * - * @param filter, the filter string for which the bundle jobs are resumed - * @param start, the starting index for bundle jobs - * @param len, maximum number of jobs to be resumed + * @param filter the filter string for which the bundle jobs are resumed + * @param start the starting index for bundle jobs + * @param len maximum number of jobs to be resumed * @return the list of jobs being resumed * @throws BundleEngineException thrown if one or more of the jobs cannot be resumed */ http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/CoordinatorEngine.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/CoordinatorEngine.java b/core/src/main/java/org/apache/oozie/CoordinatorEngine.java index 85de6f9..1eacc92 100644 --- a/core/src/main/java/org/apache/oozie/CoordinatorEngine.java +++ b/core/src/main/java/org/apache/oozie/CoordinatorEngine.java @@ -886,10 +886,10 @@ public class CoordinatorEngine extends BaseEngine { /** * return a list of killed Coordinator job * - * @param filter, the filter string for which the coordinator jobs are killed - * @param start, the starting index for coordinator jobs - * @param length, maximum number of jobs to be killed - * @return the list of jobs being killed + * @param filter the filter string for which the coordinator jobs are killed + * @param start the starting index for coordinator jobs + * @param length maximum number of jobs to be killed + * @return coordinatorJobInfo the list of jobs being killed * @throws CoordinatorEngineException thrown if one or more of the jobs cannot be killed */ public CoordinatorJobInfo killJobs(String filter, int start, int length) throws CoordinatorEngineException { http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java index fd1230b..d0995a0 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java @@ -188,8 +188,8 @@ public class CoordCommandUtils { } /** - * @param startInst: EL function name - * @param endInst: EL function name + * @param startInst EL function name + * @param endInst EL function name * @throws CommandException if both are not the same function */ public static void checkIfBothSameType(String startInst, String endInst) throws CommandException { @@ -218,7 +218,7 @@ public class CoordCommandUtils { * @param instances * @param actionInst * @param conf - * @param eval: ELEvalautor + * @param eval ELEvalautor * @throws Exception */ public static void resolveInstances(Element event, StringBuilder instances, SyncCoordAction actionInst, @@ -241,7 +241,7 @@ public class CoordCommandUtils { * @param instances * @param appInst * @param conf - * @param eval: ELEvalautor + * @param eval ELEvalautor * @throws Exception */ public static void resolveInstanceRange(Element event, StringBuilder instances, SyncCoordAction appInst, http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java b/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java index 54b1d46..a4d3e2f 100644 --- a/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java @@ -95,7 +95,7 @@ public class SubmitXCommand extends WorkflowXCommand<String> { * Constructor for submitting wf through coordinator * * @param conf : Configuration for workflow job - * @param parentId: the coord action id + * @param parentId the coord action id */ public SubmitXCommand(Configuration conf, String parentId) { this(conf); http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java b/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java index 1af5ec7..8965782 100644 --- a/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java +++ b/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java @@ -161,7 +161,7 @@ public class CoordELFunctions { * Used in defining the frequency in 'month' unit and specify the "end of month" property. <p> Every instance will * start at first day of each month at 00:00 hour. <p> domain: <code> val > 0</code> and should be integer. * - * @param val: frequency in number of months. + * @param val frequency in number of months. * @return number of months and also set the frequency timeunit to "month" and end_of_duration flag to "month" */ public static int ph1_coord_endOfMonths(int val) { @@ -255,7 +255,7 @@ public class CoordELFunctions { * @param n :instance count * <p> * domain: n >= 0, n is integer - * @param instance: How many future instance it should check? value should + * @param instance How many future instance it should check? value should * be >=0 * @return date-time in Oozie processing timezone of the n-th instance * <p> @@ -298,7 +298,7 @@ public class CoordELFunctions { * @param end : end instance offset * <p> * domain: end >= 0, end is integer - * @param instance: How many future instance it should check? value should + * @param instance How many future instance it should check? value should * be >=0 * @return date-time in Oozie processing timezone of the instances from start to end offsets * delimited by comma. http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/service/ELService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/ELService.java b/core/src/main/java/org/apache/oozie/service/ELService.java index d27d47f..4a1a895 100644 --- a/core/src/main/java/org/apache/oozie/service/ELService.java +++ b/core/src/main/java/org/apache/oozie/service/ELService.java @@ -161,7 +161,7 @@ public class ELService implements Service { * EL-functions and variables defined in the configuration. If the group name doesn't exist, * IllegalArgumentException is thrown * - * @param group: Name of the group of required EL Evaluator. + * @param group Name of the group of required EL Evaluator. * @return a preconfigured {@link ELEvaluator}. */ public ELEvaluator createEvaluator(String group) { http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/service/SchemaService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/SchemaService.java b/core/src/main/java/org/apache/oozie/service/SchemaService.java index 3181495..137e2c0 100644 --- a/core/src/main/java/org/apache/oozie/service/SchemaService.java +++ b/core/src/main/java/org/apache/oozie/service/SchemaService.java @@ -147,7 +147,7 @@ public class SchemaService implements Service { /** * Return the schema for XML validation of application definitions. * - * @param schemaName: Name of schema definition (i.e. + * @param schemaName Name of schema definition (i.e. * WORKFLOW/COORDINATOR/BUNDLE) * @return the schema for XML validation of application definitions. */ http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/util/DateUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/util/DateUtils.java b/core/src/main/java/org/apache/oozie/util/DateUtils.java index 3c39e7a..13d2586 100644 --- a/core/src/main/java/org/apache/oozie/util/DateUtils.java +++ b/core/src/main/java/org/apache/oozie/util/DateUtils.java @@ -249,7 +249,7 @@ public class DateUtils { * This function returns number of hour in a day when given a Calendar with appropriate TZ. It consider DST to find * the number of hours. Generally it is 24. At some tZ, in one day of a year it is 23 and another day it is 25 * - * @param cal: The date for which the number of hours is requested + * @param cal The date for which the number of hours is requested * @return number of hour in that day. */ public static int hoursInDay(Calendar cal) { @@ -270,7 +270,7 @@ public class DateUtils { /** * Determine whether a specific date is on DST change day * - * @param cal: Date to know if it is DST change day. Appropriate TZ is specified + * @param cal Date to know if it is DST change day. Appropriate TZ is specified * @return true , if it DST change date otherwise false */ public static boolean isDSTChangeDay(Calendar cal) { http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/core/src/main/java/org/apache/oozie/util/XLogFilter.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/util/XLogFilter.java b/core/src/main/java/org/apache/oozie/util/XLogFilter.java index 505f945..5fa3078 100644 --- a/core/src/main/java/org/apache/oozie/util/XLogFilter.java +++ b/core/src/main/java/org/apache/oozie/util/XLogFilter.java @@ -121,7 +121,7 @@ public class XLogFilter { /** * Checks if the logLevel and logMessage goes through the logFilter. * - * @param logParts + * @param logParts ArrayList of logParts * @return */ public boolean splitsMatches(LogLine logLine) { http://git-wip-us.apache.org/repos/asf/oozie/blob/d9f3b84d/release-log.txt ---------------------------------------------------------------------- diff --git a/release-log.txt b/release-log.txt index c117819..7d70c2a 100644 --- a/release-log.txt +++ b/release-log.txt @@ -1,5 +1,6 @@ -- Oozie 5.0.0 release (trunk - unreleased) +OOZIE-2961 Build contains multiple warnings for is not a parameter name (Artem Ervits via gezapeti) OOZIE-3018 Use Hadoop's CredentialProvider for passwords in SchemaCheckerService (andras.piros via gezapeti) OOZIE-2958 TestLauncherAM fails in Share Lib Oozie (pbacsko) OOZIE-2662 DB migration fails if database is too big (andras.piros via gezapeti)