[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101143#comment-17101143 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit 418c61b4f0a5905d1b9f8b11dee42c8e35d838c6 in openmeetings's branch refs/heads/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=418c61b ] OPENMEETINGS-2343 Fix text also to give more space when available. > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing updated (f7aa311 -> 418c61b)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from f7aa311 OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough. add 418c61b OPENMEETINGS-2343 Fix text also to give more space when available. No new revisions were added by this update. Summary of changes: openmeetings-web/src/main/webapp/css/raw-room.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[openmeetings] branch feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing updated (418c61b -> a7c4676)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from 418c61b OPENMEETINGS-2343 Fix text also to give more space when available. add a7c4676 OPENMEETINGS-2343 leave some space between ellipses and border. No new revisions were added by this update. Summary of changes: openmeetings-web/src/main/webapp/css/raw-room.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101152#comment-17101152 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit a7c46766b108ba052ead8e00e7b7acbf0d7b033e in openmeetings's branch refs/heads/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=a7c4676 ] OPENMEETINGS-2343 leave some space between ellipses and border. > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2347) Recording Page - File explorer - resize text - does not resize
Sebastian Wagner created OPENMEETINGS-2347: -- Summary: Recording Page - File explorer - resize text - does not resize Key: OPENMEETINGS-2347 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2347 Project: Openmeetings Issue Type: Bug Components: UI Affects Versions: 5.0.0-M4 Reporter: Sebastian Wagner Assignee: Sebastian Wagner Fix For: 5.0.0-M5 Attachments: image-2020-05-07-08-26-32-566.png See discussion at: [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2347) Recording Page - File explorer - resize text - does not resize
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2347: --- Attachment: image-2020-05-07-08-26-32-566.png > Recording Page - File explorer - resize text - does not resize > -- > > Key: OPENMEETINGS-2347 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2347 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-05-07-08-26-32-566.png > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner resolved OPENMEETINGS-2343. Resolution: Fixed > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2343: --- Issue Type: Improvement (was: Bug) > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2347) Recording Page - File explorer - resize text - does not resize
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2347: --- Issue Type: Improvement (was: Bug) > Recording Page - File explorer - resize text - does not resize > -- > > Key: OPENMEETINGS-2347 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2347 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-05-07-08-26-32-566.png > > > The fix for resizing text - in the recording section doesn't work cause this > section doesn't apply room-sidebar-width. > But also its not resizable. So it will be very difficult for users to reach > any nested folders, cause you can't neither scroll nor resize. > !image-2020-05-07-08-26-32-566.png|width=417,height=478! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2344: --- Issue Type: Improvement (was: Bug) > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2347) Recording Page - File explorer - resize text - does not resize
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2347: --- Description: The fix for resizing text - in the recording section doesn't work cause this section doesn't apply room-sidebar-width. But also its not resizable. So it will be very difficult for users to reach any nested folders, cause you can't neither scroll nor resize. !image-2020-05-07-08-26-32-566.png|width=417,height=478! was: See discussion at: [https://markmail.org/message/tvqfiryzodf4iagg] > Recording Page - File explorer - resize text - does not resize > -- > > Key: OPENMEETINGS-2347 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2347 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-05-07-08-26-32-566.png > > > The fix for resizing text - in the recording section doesn't work cause this > section doesn't apply room-sidebar-width. > But also its not resizable. So it will be very difficult for users to reach > any nested folders, cause you can't neither scroll nor resize. > !image-2020-05-07-08-26-32-566.png|width=417,height=478! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated (87b7629 -> fc1c189)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from 87b7629 Merge branch 'master' of github.com:apache/openmeetings add f7aa311 OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough. add 418c61b OPENMEETINGS-2343 Fix text also to give more space when available. add a7c4676 OPENMEETINGS-2343 leave some space between ellipses and border. new fc1c189 Merge pull request #78 from apache/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: openmeetings-web/src/main/webapp/css/raw-room.css | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)
[openmeetings] 01/01: Merge pull request #78 from apache/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit fc1c1895c11eda832a4df684f4a44c9a06c4f86c Merge: 87b7629 a7c4676 Author: Sebastian Wagner AuthorDate: Thu May 7 12:15:45 2020 +1200 Merge pull request #78 from apache/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing OPENMEETINGS-2343 Menu header minor change to spacing and size openmeetings-web/src/main/webapp/css/raw-room.css | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101278#comment-17101278 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit a7c46766b108ba052ead8e00e7b7acbf0d7b033e in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=a7c4676 ] OPENMEETINGS-2343 leave some space between ellipses and border. > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101280#comment-17101280 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit fc1c1895c11eda832a4df684f4a44c9a06c4f86c in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=fc1c189 ] Merge pull request #78 from apache/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing OPENMEETINGS-2343 Menu header minor change to spacing and size > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101277#comment-17101277 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit 418c61b4f0a5905d1b9f8b11dee42c8e35d838c6 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=418c61b ] OPENMEETINGS-2343 Fix text also to give more space when available. > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101279#comment-17101279 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit fc1c1895c11eda832a4df684f4a44c9a06c4f86c in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=fc1c189 ] Merge pull request #78 from apache/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing OPENMEETINGS-2343 Menu header minor change to spacing and size > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101276#comment-17101276 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit f7aa3115568c713dec1d1d93c759ab588dcc9ce1 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=f7aa311 ] OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough. > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2334) DateTimeLocal invalid start/end error caused by Canadian am/pm format
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101319#comment-17101319 ] Sebastian Wagner commented on OPENMEETINGS-2334: Can we not just change the format for this localised time/date ? I'm sure the French-Canadians wouldn't mind if its just AM/PM format. Although how many other languages default to this format ? > DateTimeLocal invalid start/end error caused by Canadian am/pm format > - > > Key: OPENMEETINGS-2334 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2334 > Project: Openmeetings > Issue Type: Bug > Components: Calendar >Affects Versions: 5.0.0-M3 >Reporter: Martin Chamberland >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: openmeetings-bug-calendar-30avril2020-vanille.jpg > > > The original issue is caused by Canadian am/pm format > It should be: "a.m."/"p.m." but displayed as AM/PM by js library > This causes invalid start/end error > Will see what I can do > > There is no issue with Australian tz > You are entering local date/time it is a bit shifted -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2334) DateTimeLocal invalid start/end error caused by Canadian am/pm format
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2334. Resolution: Fixed Hopefully is fixed :) Please re-open with `usual` datails if still reproducible :) [~sebawagner] I will not change the format, users should work with dates in format they like :) I'll try to make it "just work" :)) I'm not sure how many other issues like this do we still have ... > DateTimeLocal invalid start/end error caused by Canadian am/pm format > - > > Key: OPENMEETINGS-2334 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2334 > Project: Openmeetings > Issue Type: Bug > Components: Calendar >Affects Versions: 5.0.0-M3 >Reporter: Martin Chamberland >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: openmeetings-bug-calendar-30avril2020-vanille.jpg > > > The original issue is caused by Canadian am/pm format > It should be: "a.m."/"p.m." but displayed as AM/PM by js library > This causes invalid start/end error > Will see what I can do > > There is no issue with Australian tz > You are entering local date/time it is a bit shifted -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2334) DateTimeLocal invalid start/end error caused by Canadian am/pm format
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101302#comment-17101302
]
Maxim Solodovnik commented on OPENMEETINGS-2334:
OK,
This issue caused by the fact the date/time format looks like {{yy-MM-dd HH 'h'
mm}} for {{fr-CA}}
This {{'h'}} is replaced with value for current hour in JS
I'll try to investigate what can be done here
[~sebawagner] here is org.apache.openmeetings.util.TestDateTime date/time
playground
> DateTimeLocal invalid start/end error caused by Canadian am/pm format
> -
>
> Key: OPENMEETINGS-2334
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2334
> Project: Openmeetings
> Issue Type: Bug
> Components: Calendar
>Affects Versions: 5.0.0-M3
>Reporter: Martin Chamberland
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: openmeetings-bug-calendar-30avril2020-vanille.jpg
>
>
> The original issue is caused by Canadian am/pm format
> It should be: "a.m."/"p.m." but displayed as AM/PM by js library
> This causes invalid start/end error
> Will see what I can do
>
> There is no issue with Australian tz
> You are entering local date/time it is a bit shifted
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OPENMEETINGS-2334) DateTimeLocal invalid start/end error caused by Canadian am/pm format
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101302#comment-17101302
]
Maxim Solodovnik edited comment on OPENMEETINGS-2334 at 5/7/20, 2:02 AM:
-
OK,
This issue caused by the fact the date/time format looks like {{yy-MM-dd HH 'h'
mm}} for {{fr-CA}}
This {{'h'}} is replaced with value for current hour in JS
UPDATE {{'h'}} should be escaped with {{[ ]}} to work as expected
I'll try to investigate what can be done here
[~sebawagner] here is org.apache.openmeetings.util.TestDateTime date/time
playground
was (Author: solomax):
OK,
This issue caused by the fact the date/time format looks like {{yy-MM-dd HH 'h'
mm}} for {{fr-CA}}
This {{'h'}} is replaced with value for current hour in JS
I'll try to investigate what can be done here
[~sebawagner] here is org.apache.openmeetings.util.TestDateTime date/time
playground
> DateTimeLocal invalid start/end error caused by Canadian am/pm format
> -
>
> Key: OPENMEETINGS-2334
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2334
> Project: Openmeetings
> Issue Type: Bug
> Components: Calendar
>Affects Versions: 5.0.0-M3
>Reporter: Martin Chamberland
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: openmeetings-bug-calendar-30avril2020-vanille.jpg
>
>
> The original issue is caused by Canadian am/pm format
> It should be: "a.m."/"p.m." but displayed as AM/PM by js library
> This causes invalid start/end error
> Will see what I can do
>
> There is no issue with Australian tz
> You are entering local date/time it is a bit shifted
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2334] fr-CA date-time parsing/formatting should work
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 128a145 [OPENMEETINGS-2334] fr-CA date-time parsing/formatting should
work
128a145 is described below
commit 128a145366def0f4b53a840a29256e50a6bf0988
Author: Maxim Solodovnik
AuthorDate: Thu May 7 09:55:00 2020 +0700
[OPENMEETINGS-2334] fr-CA date-time parsing/formatting should work
---
.../web/common/AbstractOmDateTimePicker.java| 21 ++---
.../org/apache/openmeetings/util/TestDateTime.java | 13 +
2 files changed, 31 insertions(+), 3 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/AbstractOmDateTimePicker.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/AbstractOmDateTimePicker.java
index 062da09..96450c2 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/AbstractOmDateTimePicker.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/AbstractOmDateTimePicker.java
@@ -20,6 +20,7 @@ package org.apache.openmeetings.web.common;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
+import java.util.Locale;
import org.apache.openmeetings.web.app.WebSession;
import org.apache.wicket.model.IModel;
@@ -41,7 +42,7 @@ public abstract class AbstractOmDateTimePicker extends
AbstractDateTimePicker
public AbstractOmDateTimePicker(String id, IModel model, String
format) {
super(id, model, new DatetimePickerConfig()
//.useLocale(WebSession.get().getLocale().toLanguageTag())
- .withFormat(format)
+ .withFormat(patch(format))
.with(new DatetimePickerIconConfig()
.useDateIcon(FontAwesome5IconType.calendar_s)
.useTimeIcon(FontAwesome5IconType.clock_s)
@@ -56,8 +57,18 @@ public abstract class AbstractOmDateTimePicker extends
AbstractDateTimePicker
setRenderBodyOnly(false);
}
+ public static String patch(String format) {
+ // in Java free text is escaped with single-quotes
+ // moment.js uses []
+ return format.replaceFirst("(.*)([']{1}(.*)[']{1})(.*)",
"$1\\[$3\\]$4");
+ }
+
public static String getDateTimeFormat() {
- DateFormat fmt =
DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.SHORT,
WebSession.get().getLocale());
+ return getDateTimeFormat(WebSession.get().getLocale());
+ }
+
+ public static String getDateTimeFormat(Locale loc) {
+ DateFormat fmt =
DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.SHORT, loc);
if (fmt instanceof SimpleDateFormat) {
return ((SimpleDateFormat)fmt).toPattern();
}
@@ -65,7 +76,11 @@ public abstract class AbstractOmDateTimePicker extends
AbstractDateTimePicker
}
public static String getDateFormat() {
- DateFormat fmt = DateFormat.getDateInstance(DateFormat.SHORT,
WebSession.get().getLocale());
+ return getDateFormat(WebSession.get().getLocale());
+ }
+
+ public static String getDateFormat(Locale loc) {
+ DateFormat fmt = DateFormat.getDateInstance(DateFormat.SHORT,
loc);
if (fmt instanceof SimpleDateFormat) {
return ((SimpleDateFormat)fmt).toPattern();
}
diff --git
a/openmeetings-web/src/test/java/org/apache/openmeetings/util/TestDateTime.java
b/openmeetings-web/src/test/java/org/apache/openmeetings/util/TestDateTime.java
index ac9120d..a5f5c32 100644
---
a/openmeetings-web/src/test/java/org/apache/openmeetings/util/TestDateTime.java
+++
b/openmeetings-web/src/test/java/org/apache/openmeetings/util/TestDateTime.java
@@ -29,6 +29,7 @@ import java.util.Calendar;
import java.util.Date;
import java.util.Locale;
+import org.apache.openmeetings.web.common.AbstractOmDateTimePicker;
import org.junit.jupiter.api.Test;
public class TestDateTime {
@@ -73,4 +74,16 @@ public class TestDateTime {
.toFormatter(Locale.ENGLISH);
assertNotNull(formatter1.parse(jsDateStr));
}
+
+ @Test
+ public void test3() throws Exception {
+ final Locale loc = new Locale.Builder()
+ .setLanguage("fr")
+ .setRegion("CA")
+ .build();
+ String format = AbstractOmDateTimePicker.getDateTimeFormat(loc);
+ assertEquals("yy-MM-dd HH [h] mm",
AbstractOmDateTimePicker.patch(format));
+
[jira] [Commented] (OPENMEETINGS-2334) DateTimeLocal invalid start/end error caused by Canadian am/pm format
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101328#comment-17101328 ] ASF subversion and git services commented on OPENMEETINGS-2334: --- Commit 128a145366def0f4b53a840a29256e50a6bf0988 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=128a145 ] [OPENMEETINGS-2334] fr-CA date-time parsing/formatting should work > DateTimeLocal invalid start/end error caused by Canadian am/pm format > - > > Key: OPENMEETINGS-2334 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2334 > Project: Openmeetings > Issue Type: Bug > Components: Calendar >Affects Versions: 5.0.0-M3 >Reporter: Martin Chamberland >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: openmeetings-bug-calendar-30avril2020-vanille.jpg > > > The original issue is caused by Canadian am/pm format > It should be: "a.m."/"p.m." but displayed as AM/PM by js library > This causes invalid start/end error > Will see what I can do > > There is no issue with Australian tz > You are entering local date/time it is a bit shifted -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101294#comment-17101294 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit 927161aa1055674b81c7d560ab0a54529f9a01e5 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=927161a ] OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size. (#77) > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size. (#77)
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 927161a OPENMEETINGS-2344 Add horizontal scroll if size exceeds
window size. (#77)
927161a is described below
commit 927161aa1055674b81c7d560ab0a54529f9a01e5
Author: Sebastian Wagner
AuthorDate: Thu May 7 13:15:45 2020 +1200
OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size. (#77)
---
openmeetings-web/src/main/webapp/css/raw-tree.css | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/openmeetings-web/src/main/webapp/css/raw-tree.css
b/openmeetings-web/src/main/webapp/css/raw-tree.css
index 8ce7d97..b978f1d 100644
--- a/openmeetings-web/src/main/webapp/css/raw-tree.css
+++ b/openmeetings-web/src/main/webapp/css/raw-tree.css
@@ -7,7 +7,8 @@
}
.file-tree .trees {
height: calc(100% - var(--tree-header-height) -
var(--tree-footer-height));
- overflow-x: hidden;
+ width: var(--room-sidebar-width);
+ overflow-x: auto;
overflow-y: auto;
}
.file-tree .trees #tree-anchor {
[jira] [Resolved] (OPENMEETINGS-2328) Sending messages through an external mailbox
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved OPENMEETINGS-2328.
Fix Version/s: 5.0.0-M5
Resolution: Fixed
Should be fixed!
Thanks for testing email account [~khvalera]!
to check:
# get the new build with the fix
# turn {{mail.smtp.ssl.enable}} OFF
# create/update BOOL setting {{mail.smtp.ssl.enable}}, set it ON
no need to restart OM, parameters will have immediate access
> Sending messages through an external mailbox
>
>
> Key: OPENMEETINGS-2328
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2328
> Project: Openmeetings
> Issue Type: Bug
> Components: Email
>Reporter: khvalera
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> When sending via an external mailbox I get the following error:
> {code}
> javax.mail.MessagingException: Exception reading response;
> nested exception is:
> java.net.SocketTimeoutException: Read timed out
> at
> com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2460)
> at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:2187)
> at com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:740)
> at javax.mail.Service.connect(Service.java:388)
> at javax.mail.Service.connect(Service.java:246)
> at javax.mail.Service.connect(Service.java:195)
> at javax.mail.Transport.send0(Transport.java:254)
> at javax.mail.Transport.send(Transport.java:124)
> at
> org.apache.openmeetings.core.mail.MailHandler.lambda$send$0(MailHandler.java:250)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.net.SocketTimeoutException: Read timed out
> at java.base/java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.base/java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.base/java.net.SocketInputStream.read(SocketInputStream.java:140)
> at com.sun.mail.util.TraceInputStream.read(TraceInputStream.java:126)
> at java.base/java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> at com.sun.mail.util.LineInputStream.readLine(LineInputStream.java:106)
> at
> com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2440)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2328] additional config for SSL is added, code clean-up
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new c46b7d8 [OPENMEETINGS-2328] additional config for SSL is added, code
clean-up
c46b7d8 is described below
commit c46b7d89f38b0bf4ea3c66365f87b26b1c992961
Author: Maxim Solodovnik
AuthorDate: Thu May 7 12:32:58 2020 +0700
[OPENMEETINGS-2328] additional config for SSL is added, code clean-up
---
.../apache/openmeetings/core/mail/MailHandler.java | 90 ++--
.../{user => core/mail}/TestMailSending.java | 16 ++-
.../db/dao/basic/ConfigurationDao.java | 120 +
.../installation/ImportInitvalues.java | 2 +
.../openmeetings/util/OpenmeetingsVariables.java | 92
5 files changed, 163 insertions(+), 157 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/mail/MailHandler.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/mail/MailHandler.java
index 0d19dff..3fbcc18 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/mail/MailHandler.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/mail/MailHandler.java
@@ -19,16 +19,17 @@
package org.apache.openmeetings.core.mail;
import static java.nio.charset.StandardCharsets.UTF_8;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_REPLY_TO_ORGANIZER;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_PASS;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_PORT;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_SERVER;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_SYSTEM_EMAIL;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_TIMEOUT;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_TIMEOUT_CON;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_TLS;
-import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_SMTP_USER;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.getMailFrom;
+import static
org.apache.openmeetings.util.OpenmeetingsVariables.getSmtpConnectionTimeOut;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.getSmtpPass;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.getSmtpPort;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.getSmtpServer;
+import static
org.apache.openmeetings.util.OpenmeetingsVariables.getSmtpTimeOut;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.getSmtpUser;
import static
org.apache.openmeetings.util.OpenmeetingsVariables.isInitComplete;
+import static
org.apache.openmeetings.util.OpenmeetingsVariables.isMailAddReplyTo;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.isSmtpUseSsl;
+import static org.apache.openmeetings.util.OpenmeetingsVariables.isSmtpUseTls;
import java.io.ByteArrayInputStream;
import java.io.IOException;
@@ -54,7 +55,6 @@ import javax.mail.internet.MimeMessage;
import javax.mail.internet.MimeMultipart;
import javax.mail.util.ByteArrayDataSource;
-import org.apache.openmeetings.db.dao.basic.ConfigurationDao;
import org.apache.openmeetings.db.dao.basic.MailMessageDao;
import org.apache.openmeetings.db.entity.basic.MailMessage;
import org.apache.openmeetings.db.entity.basic.MailMessage.Status;
@@ -70,7 +70,7 @@ import org.springframework.stereotype.Component;
*
* @author swagner
*
- * For a documentation about Javax mail please see fro example:
+ * For a documentation about Javax mail please see for example:
* http://connector.sourceforge.net/doc-files/Properties.html
*
*/
@@ -81,44 +81,10 @@ public class MailHandler {
private static final int MAXIMUM_ERROR_COUNT = 5;
@Autowired
- private ConfigurationDao cfgDao;
- @Autowired
private TaskExecutor taskExecutor;
@Autowired
private MailMessageDao mailMessageDao;
- private String smtpServer;
- private int smtpPort;
- private String from;
- private String mailAuthUser;
- private String mailAuthPass;
- private boolean mailTls;
- private boolean mailAddReplyTo;
- private int smtpConnectionTimeOut;
- private int smtpTimeOut;
-
- private void init() {
- smtpServer = cfgDao.getString(CONFIG_SMTP_SERVER, null);
- smtpPort = cfgDao.getInt(CONFIG_SMTP_PORT, 25);
- from = cfgDao.getString(CONFIG_SMTP_SYSTEM_EMAIL, null);
- mailAuthUser = cfgDao.getString(CONFIG_SMTP_USER, null);
- mailAuthPass = cfgDao.getString(CONFIG_SMTP_PASS, null);
- mailTls =
[jira] [Commented] (OPENMEETINGS-2328) Sending messages through an external mailbox
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101382#comment-17101382
]
ASF subversion and git services commented on OPENMEETINGS-2328:
---
Commit c46b7d89f38b0bf4ea3c66365f87b26b1c992961 in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=c46b7d8 ]
[OPENMEETINGS-2328] additional config for SSL is added, code clean-up
> Sending messages through an external mailbox
>
>
> Key: OPENMEETINGS-2328
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2328
> Project: Openmeetings
> Issue Type: Bug
> Components: Email
>Reporter: khvalera
>Assignee: Maxim Solodovnik
>Priority: Major
>
> When sending via an external mailbox I get the following error:
> {code}
> javax.mail.MessagingException: Exception reading response;
> nested exception is:
> java.net.SocketTimeoutException: Read timed out
> at
> com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2460)
> at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:2187)
> at com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:740)
> at javax.mail.Service.connect(Service.java:388)
> at javax.mail.Service.connect(Service.java:246)
> at javax.mail.Service.connect(Service.java:195)
> at javax.mail.Transport.send0(Transport.java:254)
> at javax.mail.Transport.send(Transport.java:124)
> at
> org.apache.openmeetings.core.mail.MailHandler.lambda$send$0(MailHandler.java:250)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.net.SocketTimeoutException: Read timed out
> at java.base/java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.base/java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.base/java.net.SocketInputStream.read(SocketInputStream.java:140)
> at com.sun.mail.util.TraceInputStream.read(TraceInputStream.java:126)
> at java.base/java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> at com.sun.mail.util.LineInputStream.readLine(LineInputStream.java:106)
> at
> com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2440)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100506#comment-17100506 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit e5cec8f8c1d82e169e88673e230f55902457b7c2 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=e5cec8f ] OPENMEETINGS-2344 Add non broken width for tree file item > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100509#comment-17100509 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit b869b5b0a81b26ed4aa0aa7e1b559f6acb872215 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b869b5b ] Merge pull request #75 from apache/feature/OPENMEETINGS-2344-file-explorer-files-to-use-whitespace OPENMEETINGS-2344 Resize according to size > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100510#comment-17100510 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit b869b5b0a81b26ed4aa0aa7e1b559f6acb872215 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b869b5b ] Merge pull request #75 from apache/feature/OPENMEETINGS-2344-file-explorer-files-to-use-whitespace OPENMEETINGS-2344 Resize according to size > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100505#comment-17100505 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit 42adc474d7cadd0c8088a44127cd9a6abe6a117e in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=42adc47 ] OPENMEETINGS-2344 Add iterative more width depending on tree level. Up to maximum of 7 levels down. > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100504#comment-17100504 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit a17aea621a283993b8ea4ed37fb8bc4fd09cc07b in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=a17aea6 ] OPENMEETINGS-2344 Fix filetree item width to resize according to panel width. > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated (e7bb4b9 -> b869b5b)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from e7bb4b9 [OPENMEETINGS-2346] getDisplayMedia reside in normal place for chromium-based edge (#76) add a17aea6 OPENMEETINGS-2344 Fix filetree item width to resize according to panel width. add 42adc47 OPENMEETINGS-2344 Add iterative more width depending on tree level. Up to maximum of 7 levels down. add e5cec8f OPENMEETINGS-2344 Add non broken width for tree file item add f37658e OPENMEETINGS-2344 Move tree css it tree css file. new b869b5b Merge pull request #75 from apache/feature/OPENMEETINGS-2344-file-explorer-files-to-use-whitespace The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: openmeetings-web/src/main/webapp/css/raw-room.css | 5 -- openmeetings-web/src/main/webapp/css/raw-tree.css | 89 ++- 2 files changed, 86 insertions(+), 8 deletions(-)
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100508#comment-17100508 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit f37658e8ec6b5d9394babf134206a8dc36d59450 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=f37658e ] OPENMEETINGS-2344 Move tree css it tree css file. > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] 01/01: Merge pull request #75 from apache/feature/OPENMEETINGS-2344-file-explorer-files-to-use-whitespace
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit b869b5b0a81b26ed4aa0aa7e1b559f6acb872215 Merge: e7bb4b9 f37658e Author: Sebastian Wagner AuthorDate: Wed May 6 18:36:03 2020 +1200 Merge pull request #75 from apache/feature/OPENMEETINGS-2344-file-explorer-files-to-use-whitespace OPENMEETINGS-2344 Resize according to size openmeetings-web/src/main/webapp/css/raw-room.css | 5 -- openmeetings-web/src/main/webapp/css/raw-tree.css | 89 ++- 2 files changed, 86 insertions(+), 8 deletions(-)
[openmeetings] 01/01: OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size.
This is an automated email from the ASF dual-hosted git repository.
sebawagner pushed a commit to branch
feature/OPENMEETINGS-2344-file-explorer-overflow
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
commit 03b9dc2a131dcacb40c79c5bb880ee052786ca3e
Author: Sebastian Wagner
AuthorDate: Wed May 6 19:04:34 2020 +1200
OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size.
---
openmeetings-web/src/main/webapp/css/raw-tree.css | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/openmeetings-web/src/main/webapp/css/raw-tree.css
b/openmeetings-web/src/main/webapp/css/raw-tree.css
index 8ce7d97..b978f1d 100644
--- a/openmeetings-web/src/main/webapp/css/raw-tree.css
+++ b/openmeetings-web/src/main/webapp/css/raw-tree.css
@@ -7,7 +7,8 @@
}
.file-tree .trees {
height: calc(100% - var(--tree-header-height) -
var(--tree-footer-height));
- overflow-x: hidden;
+ width: var(--room-sidebar-width);
+ overflow-x: auto;
overflow-y: auto;
}
.file-tree .trees #tree-anchor {
[openmeetings] branch feature/OPENMEETINGS-2344-file-explorer-overflow created (now 03b9dc2)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch feature/OPENMEETINGS-2344-file-explorer-overflow in repository https://gitbox.apache.org/repos/asf/openmeetings.git. at 03b9dc2 OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size. This branch includes the following new commits: new 03b9dc2 OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[openmeetings] 01/01: OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough.
This is an automated email from the ASF dual-hosted git repository.
sebawagner pushed a commit to branch
feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
commit f7aa3115568c713dec1d1d93c759ab588dcc9ce1
Author: Sebastian Wagner
AuthorDate: Wed May 6 19:28:35 2020 +1200
OPENMEETINGS-2343 Menu header minor change to spacing and size if there is
enough.
---
openmeetings-web/src/main/webapp/css/raw-room.css | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/openmeetings-web/src/main/webapp/css/raw-room.css
b/openmeetings-web/src/main/webapp/css/raw-room.css
index 11256c8..2cea1c8 100644
--- a/openmeetings-web/src/main/webapp/css/raw-room.css
+++ b/openmeetings-web/src/main/webapp/css/raw-room.css
@@ -374,7 +374,9 @@ html[dir="rtl"] .room-block .sb-wb .sidebar {
.room-block .sb-wb .sidebar .tab.om-icon.big {
line-height: 30px;
width: auto;
- max-width: 80px;
+ padding-left: 10px;
+ min-width: 100px;
+ max-width: 120px;
position: relative;
}
.room-block .sb-wb .sidebar .tab .badge {
@@ -391,7 +393,9 @@ html[dir="rtl"] .room-block .sb-wb .sidebar {
}
.room-block.narrow .sidebar .tab.om-icon.big {
max-width: 40px;
+ min-width: auto;
width: 40px;
+ padding-left: 6px;
padding-right: 0;
}
.room-block.narrow .sidebar .tab.om-icon.big .label {
[openmeetings] branch feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing created (now f7aa311)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing in repository https://gitbox.apache.org/repos/asf/openmeetings.git. at f7aa311 OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough. This branch includes the following new commits: new f7aa311 OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[jira] [Commented] (OPENMEETINGS-2344) File explorer - resize text to fill up whitespace
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100524#comment-17100524 ] ASF subversion and git services commented on OPENMEETINGS-2344: --- Commit 03b9dc2a131dcacb40c79c5bb880ee052786ca3e in openmeetings's branch refs/heads/feature/OPENMEETINGS-2344-file-explorer-overflow from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=03b9dc2 ] OPENMEETINGS-2344 Add horizontal scroll if size exceeds window size. > File explorer - resize text to fill up whitespace > - > > Key: OPENMEETINGS-2344 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2344 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: > [https://markmail.org/message/tvqfiryzodf4iagg] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2343) Slight user and files menu header change
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100538#comment-17100538 ] ASF subversion and git services commented on OPENMEETINGS-2343: --- Commit f7aa3115568c713dec1d1d93c759ab588dcc9ce1 in openmeetings's branch refs/heads/feature/OPENMEETINGS-2343-file-tabs-menu-headers-spacing from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=f7aa311 ] OPENMEETINGS-2343 Menu header minor change to spacing and size if there is enough. > Slight user and files menu header change > > > Key: OPENMEETINGS-2343 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.0.0-M5 > > > Giving header minimum size and adding 20px. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2301) Sporadic internal error on room entering
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100577#comment-17100577
]
Maxim Solodovnik commented on OPENMEETINGS-2301:
Partially caused by this issue
> Sporadic internal error on room entering
>
>
> Key: OPENMEETINGS-2301
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2301
> Project: Openmeetings
> Issue Type: Bug
> Components: Room
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.0.0-M5
>
>
> Sometimes when entering a room it throws Internal error page.
> {code:java}
> DEBUG 04-26 05:00:31.359 o.a.o.w.a.ClientManager:386 [nio-5443-exec-2] -
> Cluster:: The only server found
> DEBUG 04-26 05:00:31.360 o.a.o.w.c.MainPanel:401 [nio-5443-exec-2] -
> updateContents:: npanels IS null ? false, client IS null ? false
> DEBUG 04-26 05:00:31.376 o.a.o.w.r.RoomPanel:345 [nio-5443-exec-2] - public ?
> true, ownedId ? null true
> DEBUG 04-26 05:00:31.377 o.a.o.d.d.l.ConferenceLogDao:52 [nio-5443-exec-2] -
> [add]: org.apache.openmeetings.db.entity.log.ConferenceLog@4abadb1e
> DEBUG 04-26 05:00:31.400 o.a.o.w.a.ClientManager:232 [nio-5443-exec-2] -
> Adding online room client: 170bfba9-781c-40da-91b0-6db499ee5679, room: 3
> DEBUG 04-26 05:00:31.402 o.a.o.w.a.ClientManager:250 [nio-5443-exec-2] -
> Cluster:: room 3 was not found for server 'server-1', adding ...
> DEBUG 04-26 05:00:31.403 o.a.o.w.a.ClientManager:479 [nio-5443-exec-2] -
> Cluster:: room 3 is added to server, whole list [3]
> DEBUG 04-26 05:00:31.403 o.a.o.w.a.ClientManager:117 [erver-1.event-1] -
> Cluster:: Server was updated server-1 -> ServerInfo[rooms: [3]]
> DEBUG 04-26 05:00:31.405 o.a.o.d.u.AuthLevelUtil:40 [nio-5443-exec-2] - Level
> ADMIN :: [GRANTED]
> INFO 04-26 05:00:31.406 o.a.o.w.r.RoomPanel:394 [nio-5443-exec-2] - Setting
> rights for client:: [SUPER_MODERATOR] -> true
> DEBUG 04-26 05:00:31.407 o.a.o.d.u.AuthLevelUtil:40 [nio-5443-exec-2] - Level
> ADMIN :: [GRANTED]
> DEBUG 04-26 05:00:31.409 o.a.o.d.d.r.PollDao:87 [nio-5443-exec-2] - ::
> getPoll :: 3
> DEBUG 04-26 05:00:31.415 o.a.o.d.d.r.PollDao:98 [nio-5443-exec-2] - ::
> getArchived :: 3
> DEBUG 04-26 05:00:31.440 o.a.o.d.d.f.FileItemDao:55 [nio-5443-exec-2] -
> getByOwner() started
> DEBUG 04-26 05:00:31.446 o.a.o.d.d.f.FileItemDao:50 [nio-5443-exec-2] -
> getByRoom roomId :: 3
> DEBUG 04-26 05:00:31.716 o.a.o.w.r.RoomPanel:136 [nio-5443-exec-3] -
> RoomPanel::roomEnter
> DEBUG 04-26 05:00:31.726 o.a.o.w.r.RoomPanel:166 [nio-5443-exec-3] -
> RoomPanel::roomEnter, mods IS EMPTY ? false, is MOD ? true
> DEBUG 04-26 05:00:31.735 o.a.o.d.d.r.PollDao:104 [Thread-127] - :: hasPoll
> :: 3
> DEBUG 04-26 05:00:31.740 o.a.o.d.d.r.PollDao:98 [Thread-127] - ::
> getArchived :: 3
> DEBUG 04-26 05:00:31.741 o.a.o.c.r.KurentoHandler:222 [Thread-127] -
> Searching for room 3
> DEBUG 04-26 05:00:31.741 o.a.o.c.r.KurentoHandler:226 [Thread-127] - Room 3
> does not exist. Will create now!
> INFO 04-26 05:00:31.763 o.a.o.c.r.KRoom:75 [Thread-127] - ROOM 3 has been
> created
> DEBUG 04-26 05:00:31.763 o.a.o.c.r.KurentoHandler:236 [Thread-127] - Room 3
> found!
> DEBUG 04-26 05:00:31.764 o.a.o.c.r.KurentoHandler:397 [EventExec-e2-t4] -
> Kurento::ObjectCreated -> [RemoteObject: type=MediaPipeline
> remoteRef=fec772df-072e-4a32-8f5a-c94150645f2f_kurento.MediaPipeline]
> ERROR 04-26 05:00:31.833 o.a.w.DefaultExceptionMapper:170 [nio-5443-exec-1] -
> Unexpected error occurred
> java.lang.NullPointerException: null
> at
> org.apache.openmeetings.web.room.sidebar.RoomSidebar$1.respond(RoomSidebar.java:94)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:597)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.internalInvoke(ListenerRequestHandler.java:306)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.invoke(ListenerRequestHandler.java:280)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.invokeListener(ListenerRequestHandler.java:222)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.respond(ListenerRequestHandler.java:208)
> at
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:917)
> at
> org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:63)
> at
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283)
> at
> org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:254)
> at
>
[jira] [Resolved] (OPENMEETINGS-2301) Sporadic internal error on room entering
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved OPENMEETINGS-2301.
Resolution: Fixed
should be fixed
please re-open with additional steps if not
> Sporadic internal error on room entering
>
>
> Key: OPENMEETINGS-2301
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2301
> Project: Openmeetings
> Issue Type: Bug
> Components: Room
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.0.0-M5
>
>
> Sometimes when entering a room it throws Internal error page.
> {code:java}
> DEBUG 04-26 05:00:31.359 o.a.o.w.a.ClientManager:386 [nio-5443-exec-2] -
> Cluster:: The only server found
> DEBUG 04-26 05:00:31.360 o.a.o.w.c.MainPanel:401 [nio-5443-exec-2] -
> updateContents:: npanels IS null ? false, client IS null ? false
> DEBUG 04-26 05:00:31.376 o.a.o.w.r.RoomPanel:345 [nio-5443-exec-2] - public ?
> true, ownedId ? null true
> DEBUG 04-26 05:00:31.377 o.a.o.d.d.l.ConferenceLogDao:52 [nio-5443-exec-2] -
> [add]: org.apache.openmeetings.db.entity.log.ConferenceLog@4abadb1e
> DEBUG 04-26 05:00:31.400 o.a.o.w.a.ClientManager:232 [nio-5443-exec-2] -
> Adding online room client: 170bfba9-781c-40da-91b0-6db499ee5679, room: 3
> DEBUG 04-26 05:00:31.402 o.a.o.w.a.ClientManager:250 [nio-5443-exec-2] -
> Cluster:: room 3 was not found for server 'server-1', adding ...
> DEBUG 04-26 05:00:31.403 o.a.o.w.a.ClientManager:479 [nio-5443-exec-2] -
> Cluster:: room 3 is added to server, whole list [3]
> DEBUG 04-26 05:00:31.403 o.a.o.w.a.ClientManager:117 [erver-1.event-1] -
> Cluster:: Server was updated server-1 -> ServerInfo[rooms: [3]]
> DEBUG 04-26 05:00:31.405 o.a.o.d.u.AuthLevelUtil:40 [nio-5443-exec-2] - Level
> ADMIN :: [GRANTED]
> INFO 04-26 05:00:31.406 o.a.o.w.r.RoomPanel:394 [nio-5443-exec-2] - Setting
> rights for client:: [SUPER_MODERATOR] -> true
> DEBUG 04-26 05:00:31.407 o.a.o.d.u.AuthLevelUtil:40 [nio-5443-exec-2] - Level
> ADMIN :: [GRANTED]
> DEBUG 04-26 05:00:31.409 o.a.o.d.d.r.PollDao:87 [nio-5443-exec-2] - ::
> getPoll :: 3
> DEBUG 04-26 05:00:31.415 o.a.o.d.d.r.PollDao:98 [nio-5443-exec-2] - ::
> getArchived :: 3
> DEBUG 04-26 05:00:31.440 o.a.o.d.d.f.FileItemDao:55 [nio-5443-exec-2] -
> getByOwner() started
> DEBUG 04-26 05:00:31.446 o.a.o.d.d.f.FileItemDao:50 [nio-5443-exec-2] -
> getByRoom roomId :: 3
> DEBUG 04-26 05:00:31.716 o.a.o.w.r.RoomPanel:136 [nio-5443-exec-3] -
> RoomPanel::roomEnter
> DEBUG 04-26 05:00:31.726 o.a.o.w.r.RoomPanel:166 [nio-5443-exec-3] -
> RoomPanel::roomEnter, mods IS EMPTY ? false, is MOD ? true
> DEBUG 04-26 05:00:31.735 o.a.o.d.d.r.PollDao:104 [Thread-127] - :: hasPoll
> :: 3
> DEBUG 04-26 05:00:31.740 o.a.o.d.d.r.PollDao:98 [Thread-127] - ::
> getArchived :: 3
> DEBUG 04-26 05:00:31.741 o.a.o.c.r.KurentoHandler:222 [Thread-127] -
> Searching for room 3
> DEBUG 04-26 05:00:31.741 o.a.o.c.r.KurentoHandler:226 [Thread-127] - Room 3
> does not exist. Will create now!
> INFO 04-26 05:00:31.763 o.a.o.c.r.KRoom:75 [Thread-127] - ROOM 3 has been
> created
> DEBUG 04-26 05:00:31.763 o.a.o.c.r.KurentoHandler:236 [Thread-127] - Room 3
> found!
> DEBUG 04-26 05:00:31.764 o.a.o.c.r.KurentoHandler:397 [EventExec-e2-t4] -
> Kurento::ObjectCreated -> [RemoteObject: type=MediaPipeline
> remoteRef=fec772df-072e-4a32-8f5a-c94150645f2f_kurento.MediaPipeline]
> ERROR 04-26 05:00:31.833 o.a.w.DefaultExceptionMapper:170 [nio-5443-exec-1] -
> Unexpected error occurred
> java.lang.NullPointerException: null
> at
> org.apache.openmeetings.web.room.sidebar.RoomSidebar$1.respond(RoomSidebar.java:94)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:597)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.internalInvoke(ListenerRequestHandler.java:306)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.invoke(ListenerRequestHandler.java:280)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.invokeListener(ListenerRequestHandler.java:222)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.respond(ListenerRequestHandler.java:208)
> at
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:917)
> at
> org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:63)
> at
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283)
> at
> org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:254)
> at
>
[openmeetings] branch master updated: [OPENMEETINGS-2301] there should be no ghost users
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new ea62bd3 [OPENMEETINGS-2301] there should be no ghost users
new 87b7629 Merge branch 'master' of github.com:apache/openmeetings
ea62bd3 is described below
commit ea62bd30cbc6ba5136a9a72ef167028eb6ab8ba3
Author: Maxim Solodovnik
AuthorDate: Wed May 6 22:18:48 2020 +0700
[OPENMEETINGS-2301] there should be no ghost users
---
.../openmeetings/core/util/WebSocketHelper.java| 38 --
.../openmeetings/db/entity/basic/Client.java | 7 ++--
.../apache/openmeetings/web/app/ClientManager.java | 3 +-
pom.xml| 2 +-
4 files changed, 19 insertions(+), 31 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/WebSocketHelper.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/WebSocketHelper.java
index 30d9750..c75254f 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/WebSocketHelper.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/WebSocketHelper.java
@@ -63,7 +63,6 @@ public class WebSocketHelper {
} catch (Throwable e) {
log.error("Error while sending binary
message to client", e);
}
- checkClosed(c, omClient);
});
}
}
@@ -77,36 +76,25 @@ public class WebSocketHelper {
} catch (Throwable e) {
log.error("Error while sending message
to client", e);
}
- checkClosed(c, omClient);
});
}
}
- private static void checkClosed(IWebSocketConnection c, final IWsClient
omClient) {
- if (c.isOpen()) {
- return;
- }
- log.error("WS connection is closed in sendMessage");
- WebSocketSettings settings =
WebSocketSettings.Holder.get((Application)getApp());
- IWebSocketConnectionRegistry reg =
settings.getConnectionRegistry();
- reg.removeConnection(c.getApplication(), c.getSessionId(),
c.getKey());
- if (omClient instanceof Client) {
-
getApp().getBean(IClientManager.class).exit((Client)omClient);
- }
- }
public static IApplication getApp() {
return
(IApplication)Application.get(getWicketApplicationName());
}
private static void sendClient(IWsClient client,
Consumer wsc) {
- Application app = (Application)getApp();
- WebSocketSettings settings = WebSocketSettings.Holder.get(app);
- IWebSocketConnectionRegistry reg =
settings.getConnectionRegistry();
- Executor executor = settings.getWebSocketPushMessageExecutor();
- final IWebSocketConnection wc = reg.getConnection(app,
client.getSessionId(), new PageIdKey(client.getPageId()));
- if (wc != null && wc.isOpen()) {
- executor.run(() -> wsc.accept(wc));
- }
+ new Thread(() -> {
+ Application app = (Application)getApp();
+ WebSocketSettings settings =
WebSocketSettings.Holder.get(app);
+ IWebSocketConnectionRegistry reg =
settings.getConnectionRegistry();
+ Executor executor =
settings.getWebSocketPushMessageExecutor();
+ final IWebSocketConnection wc = reg.getConnection(app,
client.getSessionId(), new PageIdKey(client.getPageId()));
+ if (wc != null && wc.isOpen()) {
+ executor.run(() -> wsc.accept(wc));
+ }
+ }).start();
}
public static boolean send(IClusterWsMessage msg) {
@@ -205,8 +193,10 @@ public class WebSocketHelper {
WebSocketSettings settings =
WebSocketSettings.Holder.get(app);
IWebSocketConnectionRegistry reg =
settings.getConnectionRegistry();
Executor executor =
settings.getWebSocketPushMessageExecutor();
- for (IWebSocketConnection c : reg.getConnections(app)) {
- executor.run(() -> sender.accept(c));
+ for (IWebSocketConnection wc : reg.getConnections(app))
{
+ if (wc != null && wc.isOpen()) {
+ executor.run(() -> sender.accept(wc));
+ }
[jira] [Commented] (OPENMEETINGS-2301) Sporadic internal error on room entering
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100886#comment-17100886
]
ASF subversion and git services commented on OPENMEETINGS-2301:
---
Commit ea62bd30cbc6ba5136a9a72ef167028eb6ab8ba3 in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ea62bd3 ]
[OPENMEETINGS-2301] there should be no ghost users
> Sporadic internal error on room entering
>
>
> Key: OPENMEETINGS-2301
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2301
> Project: Openmeetings
> Issue Type: Bug
> Components: Room
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.0.0-M5
>
>
> Sometimes when entering a room it throws Internal error page.
> {code:java}
> DEBUG 04-26 05:00:31.359 o.a.o.w.a.ClientManager:386 [nio-5443-exec-2] -
> Cluster:: The only server found
> DEBUG 04-26 05:00:31.360 o.a.o.w.c.MainPanel:401 [nio-5443-exec-2] -
> updateContents:: npanels IS null ? false, client IS null ? false
> DEBUG 04-26 05:00:31.376 o.a.o.w.r.RoomPanel:345 [nio-5443-exec-2] - public ?
> true, ownedId ? null true
> DEBUG 04-26 05:00:31.377 o.a.o.d.d.l.ConferenceLogDao:52 [nio-5443-exec-2] -
> [add]: org.apache.openmeetings.db.entity.log.ConferenceLog@4abadb1e
> DEBUG 04-26 05:00:31.400 o.a.o.w.a.ClientManager:232 [nio-5443-exec-2] -
> Adding online room client: 170bfba9-781c-40da-91b0-6db499ee5679, room: 3
> DEBUG 04-26 05:00:31.402 o.a.o.w.a.ClientManager:250 [nio-5443-exec-2] -
> Cluster:: room 3 was not found for server 'server-1', adding ...
> DEBUG 04-26 05:00:31.403 o.a.o.w.a.ClientManager:479 [nio-5443-exec-2] -
> Cluster:: room 3 is added to server, whole list [3]
> DEBUG 04-26 05:00:31.403 o.a.o.w.a.ClientManager:117 [erver-1.event-1] -
> Cluster:: Server was updated server-1 -> ServerInfo[rooms: [3]]
> DEBUG 04-26 05:00:31.405 o.a.o.d.u.AuthLevelUtil:40 [nio-5443-exec-2] - Level
> ADMIN :: [GRANTED]
> INFO 04-26 05:00:31.406 o.a.o.w.r.RoomPanel:394 [nio-5443-exec-2] - Setting
> rights for client:: [SUPER_MODERATOR] -> true
> DEBUG 04-26 05:00:31.407 o.a.o.d.u.AuthLevelUtil:40 [nio-5443-exec-2] - Level
> ADMIN :: [GRANTED]
> DEBUG 04-26 05:00:31.409 o.a.o.d.d.r.PollDao:87 [nio-5443-exec-2] - ::
> getPoll :: 3
> DEBUG 04-26 05:00:31.415 o.a.o.d.d.r.PollDao:98 [nio-5443-exec-2] - ::
> getArchived :: 3
> DEBUG 04-26 05:00:31.440 o.a.o.d.d.f.FileItemDao:55 [nio-5443-exec-2] -
> getByOwner() started
> DEBUG 04-26 05:00:31.446 o.a.o.d.d.f.FileItemDao:50 [nio-5443-exec-2] -
> getByRoom roomId :: 3
> DEBUG 04-26 05:00:31.716 o.a.o.w.r.RoomPanel:136 [nio-5443-exec-3] -
> RoomPanel::roomEnter
> DEBUG 04-26 05:00:31.726 o.a.o.w.r.RoomPanel:166 [nio-5443-exec-3] -
> RoomPanel::roomEnter, mods IS EMPTY ? false, is MOD ? true
> DEBUG 04-26 05:00:31.735 o.a.o.d.d.r.PollDao:104 [Thread-127] - :: hasPoll
> :: 3
> DEBUG 04-26 05:00:31.740 o.a.o.d.d.r.PollDao:98 [Thread-127] - ::
> getArchived :: 3
> DEBUG 04-26 05:00:31.741 o.a.o.c.r.KurentoHandler:222 [Thread-127] -
> Searching for room 3
> DEBUG 04-26 05:00:31.741 o.a.o.c.r.KurentoHandler:226 [Thread-127] - Room 3
> does not exist. Will create now!
> INFO 04-26 05:00:31.763 o.a.o.c.r.KRoom:75 [Thread-127] - ROOM 3 has been
> created
> DEBUG 04-26 05:00:31.763 o.a.o.c.r.KurentoHandler:236 [Thread-127] - Room 3
> found!
> DEBUG 04-26 05:00:31.764 o.a.o.c.r.KurentoHandler:397 [EventExec-e2-t4] -
> Kurento::ObjectCreated -> [RemoteObject: type=MediaPipeline
> remoteRef=fec772df-072e-4a32-8f5a-c94150645f2f_kurento.MediaPipeline]
> ERROR 04-26 05:00:31.833 o.a.w.DefaultExceptionMapper:170 [nio-5443-exec-1] -
> Unexpected error occurred
> java.lang.NullPointerException: null
> at
> org.apache.openmeetings.web.room.sidebar.RoomSidebar$1.respond(RoomSidebar.java:94)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:597)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.internalInvoke(ListenerRequestHandler.java:306)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.invoke(ListenerRequestHandler.java:280)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.invokeListener(ListenerRequestHandler.java:222)
> at
> org.apache.wicket.core.request.handler.ListenerRequestHandler.respond(ListenerRequestHandler.java:208)
> at
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:917)
> at
> org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:63)
> at
>
