[jira] [Created] (OPENMEETINGS-2481) event cancelation/deletion email: attached event is not deleting event in calendar tool
Uwe Simon created OPENMEETINGS-2481: --- Summary: event cancelation/deletion email: attached event is not deleting event in calendar tool Key: OPENMEETINGS-2481 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2481 Project: Openmeetings Issue Type: Bug Components: Email Affects Versions: 5.0.1, 5.1.0 Reporter: Uwe Simon Assignee: Maxim Solodovnik Wenn deleting an event emails with the cancelation of the event are send to all attendees. When opening the attached ics-file in ths email, the cancelation is added as a new event to the calendar. This happens with thunderbird/lightning and with kalendar tool on smartphone and tablet. Possible reason: RFC5546 stated that METHODs CANCEL/ADD must increment the SEQUENCE field. openmeetings sends always SEQUENCE:0 Expectation: Opening the event attached to the cancelation email should cause the deletion of the event in the calender tool. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2479) Leaving meeting entered by invitation shows "access denied"
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214392#comment-17214392 ] Maxim Solodovnik commented on OPENMEETINGS-2479: the exit button is not available for those who were invited (might be visible in 5.0.1, but NOT in 5.1.0) Are you sure you can reproduce this on 5.1.0? if yes, what are the steps? > Leaving meeting entered by invitation shows "access denied" > --- > > Key: OPENMEETINGS-2479 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2479 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.1, 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Attachments: Bildschirmfoto vom 2020-10-14 19-55-38.png > > > When entering a meeting via the link from the email like > | > |[http://localhost:8080/openmeetings/hash?invitation=4e0678fd-952a-463d-ba1b-c8aec245f64c=1|http://localhost:8080/openmeetings/hash?invitation=4e0678fd-952a-463d-ba1b-c8aec245f64c=2]| > leaving it with"Exit" will shows the errorpage "Access denied". > !Bildschirmfoto vom 2020-10-14 19-55-38.png! > Expactation: A "goodbye page" or the "Login page" should appear -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2482) GeneralConfiguration page should be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214432#comment-17214432 ] ASF subversion and git services commented on OPENMEETINGS-2482: --- Commit a76466949046e2d4e9fb61cc003d2cae91630719 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=a764669 ] [OPENMEETINGS-2482] GeneralConfiguration page is refactored > GeneralConfiguration page should be improved > > > Key: OPENMEETINGS-2482 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2482 > Project: Openmeetings > Issue Type: Improvement > Components: Documentation >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > GeneralConfiguration page should be improved > following data should be added > # order > # key type -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2482] GeneralConfiguration page is refactored
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new a764669 [OPENMEETINGS-2482] GeneralConfiguration page is refactored
a764669 is described below
commit a76466949046e2d4e9fb61cc003d2cae91630719
Author: Maxim Solodovnik
AuthorDate: Thu Oct 15 11:35:44 2020 +0700
[OPENMEETINGS-2482] GeneralConfiguration page is refactored
---
.../src/site/resources/css/site.css| 3 ++
.../src/site/stylesheets/configs.xsl | 32 --
2 files changed, 21 insertions(+), 14 deletions(-)
diff --git a/openmeetings-server/src/site/resources/css/site.css
b/openmeetings-server/src/site/resources/css/site.css
index 29052c3..e8f6de2 100644
--- a/openmeetings-server/src/site/resources/css/site.css
+++ b/openmeetings-server/src/site/resources/css/site.css
@@ -121,3 +121,6 @@ iframe {
font-weight: bold;
color: var(--info);
}
+.grid-striped .row:nth-of-type(odd) {
+ background-color: rgba(0,0,0,.05);
+}
diff --git a/openmeetings-server/src/site/stylesheets/configs.xsl
b/openmeetings-server/src/site/stylesheets/configs.xsl
index e66fc69..10dfb3b 100644
--- a/openmeetings-server/src/site/stylesheets/configs.xsl
+++ b/openmeetings-server/src/site/stylesheets/configs.xsl
@@ -40,26 +40,30 @@
configuration values.
-
-
-key
-default
-meaning
-availabe since OpenMeetings
version
-
+
+
+#
+key
+type
+
default
+
meaning
+version
+
-
+
-
-
-
-
-
-
+
+
+
+
+
+
+
+
[jira] [Created] (OPENMEETINGS-2482) GeneralConfiguration page should be improved
Maxim Solodovnik created OPENMEETINGS-2482: -- Summary: GeneralConfiguration page should be improved Key: OPENMEETINGS-2482 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2482 Project: Openmeetings Issue Type: Improvement Components: Documentation Affects Versions: 5.0.1 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 5.1.0 GeneralConfiguration page should be improved following data should be added # order # key type -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2482) GeneralConfiguration page should be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2482. Resolution: Fixed > GeneralConfiguration page should be improved > > > Key: OPENMEETINGS-2482 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2482 > Project: Openmeetings > Issue Type: Improvement > Components: Documentation >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > GeneralConfiguration page should be improved > following data should be added > # order > # key type -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2239] some sonar issues
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new ef105b6 [OPENMEETINGS-2239] some sonar issues
ef105b6 is described below
commit ef105b6704146b81bf702451d7f8652f97a82ed1
Author: Maxim Solodovnik
AuthorDate: Wed Oct 14 20:09:28 2020 +0700
[OPENMEETINGS-2239] some sonar issues
---
.../main/java/org/apache/openmeetings/db/dao/room/SipDao.java| 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
index c41fdc6..5f8b2f5 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/SipDao.java
@@ -89,7 +89,7 @@ public class SipDao implements SipListenerExt {
public static final String SIP_FIRST_NAME = "SIP Transport";
public static final String SIP_USER_NAME = "--SIP--";
private static final String SIP_TRANSPORT = "ws";
- private static final Consumer NOOP() {
+ private static final Consumer noop() {
return t -> {};
}
@@ -100,7 +100,6 @@ public class SipDao implements SipListenerExt {
private String branch;
private SipProvider sipProvider;
- private SipFactory sipFactory;
private SipStackExt sipStack;
private MessageFactory messageFactory;
private HeaderFactory headerFactory;
@@ -119,7 +118,7 @@ public class SipDao implements SipListenerExt {
, config.getManagerPort()
, config.getManagerUser()
, config.getManagerPass());
- sipFactory = SipFactory.getInstance();
+ final SipFactory sipFactory = SipFactory.getInstance();
sipFactory.setPathName("gov.nist");
final Properties properties = new Properties();
@@ -356,7 +355,7 @@ public class SipDao implements SipListenerExt {
}
private Address createAddr(String user) {
- return createAddr(user, config.getSipHostname(), NOOP());
+ return createAddr(user, config.getSipHostname(), noop());
}
private Address createAddr(String user, String host, Consumer
cons) {
@@ -437,7 +436,7 @@ public class SipDao implements SipListenerExt {
sendRequest(
REGISTER
, config.getOmSipUser()
- , NOOP()
+ , noop()
, req -> {
try {
addAllow(req);
[jira] [Commented] (OPENMEETINGS-2239) (Re-) Implementation SIP
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213901#comment-17213901 ] ASF subversion and git services commented on OPENMEETINGS-2239: --- Commit ef105b6704146b81bf702451d7f8652f97a82ed1 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ef105b6 ] [OPENMEETINGS-2239] some sonar issues > (Re-) Implementation SIP > > > Key: OPENMEETINGS-2239 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2239 > Project: Openmeetings > Issue Type: Wish > Components: VoIP/SIP >Affects Versions: 5.0.0-M3 >Reporter: Rene Scholz >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.1.0 > > > In OM5 the SIP is no longer working - please "reactivate" ist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2476] InterruptedException is re-thrown, internal error page is changed
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new bfdacc3 [OPENMEETINGS-2476] InterruptedException is re-thrown, internal error page is changed bfdacc3 is described below commit bfdacc3fdb6597eedf71f54248efca223893ca52 Author: Maxim Solodovnik AuthorDate: Wed Oct 14 20:06:02 2020 +0700 [OPENMEETINGS-2476] InterruptedException is re-thrown, internal error page is changed --- .../apache/openmeetings/web/app/Application.java | 4 ++ .../web/app/Application.properties.xml | 2 + .../web/app/Application_ar.properties.xml | 2 + .../web/app/Application_bg.properties.xml | 2 + .../web/app/Application_bn.properties.xml | 2 + .../web/app/Application_ca.properties.xml | 2 + .../web/app/Application_cs.properties.xml | 2 + .../web/app/Application_da.properties.xml | 2 + .../web/app/Application_de.properties.xml | 2 + .../web/app/Application_el.properties.xml | 2 + .../web/app/Application_es.properties.xml | 2 + .../web/app/Application_fa.properties.xml | 2 + .../web/app/Application_fi.properties.xml | 2 + .../web/app/Application_fr.properties.xml | 2 + .../web/app/Application_gl.properties.xml | 2 + .../web/app/Application_hi.properties.xml | 2 + .../web/app/Application_hu.properties.xml | 2 + .../web/app/Application_in.properties.xml | 2 + .../web/app/Application_it.properties.xml | 2 + .../web/app/Application_iw.properties.xml | 2 + .../web/app/Application_ja.properties.xml | 2 + .../web/app/Application_ko.properties.xml | 2 + .../web/app/Application_lo.properties.xml | 2 + .../web/app/Application_nl.properties.xml | 2 + .../web/app/Application_pl.properties.xml | 2 + .../web/app/Application_pt.properties.xml | 2 + .../web/app/Application_pt_BR.properties.xml | 2 + .../web/app/Application_ru.properties.xml | 2 + .../web/app/Application_sk.properties.xml | 2 + .../web/app/Application_sv.properties.xml | 2 + .../web/app/Application_ta.properties.xml | 2 + .../web/app/Application_th.properties.xml | 2 + .../web/app/Application_tr.properties.xml | 2 + .../web/app/Application_uk.properties.xml | 2 + .../web/app/Application_zh_CN.properties.xml | 2 + .../web/app/Application_zh_TW.properties.xml | 2 + .../openmeetings/web/pages/InternalErrorPage.html | 36 +++ .../openmeetings/web/pages/InternalErrorPage.java | 52 ++ .../openmeetings/web/pages/auth/SignInPage.java| 6 +-- 39 files changed, 165 insertions(+), 3 deletions(-) diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java b/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java index 87b2a85..ac4c389 100644 --- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java +++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java @@ -68,6 +68,7 @@ import org.apache.openmeetings.util.ws.IClusterWsMessage; import org.apache.openmeetings.web.pages.AccessDeniedPage; import org.apache.openmeetings.web.pages.ActivatePage; import org.apache.openmeetings.web.pages.HashPage; +import org.apache.openmeetings.web.pages.InternalErrorPage; import org.apache.openmeetings.web.pages.MainPage; import org.apache.openmeetings.web.pages.NotInitedPage; import org.apache.openmeetings.web.pages.PrivacyPage; @@ -118,6 +119,7 @@ import org.apache.wicket.request.http.WebResponse; import org.apache.wicket.request.mapper.info.PageComponentInfo; import org.apache.wicket.request.mapper.parameter.PageParameters; import org.apache.wicket.request.mapper.parameter.PageParametersEncoder; +import org.apache.wicket.settings.ExceptionSettings; import org.apache.wicket.spring.injection.annot.SpringComponentInjector; import org.apache.wicket.util.string.Strings; import org.apache.wicket.validation.validator.UrlValidator; @@ -189,6 +191,8 @@ public class Application extends AuthenticatedWebApplication implements IApplica setWicketApplicationName(super.getName()); getSecuritySettings().setAuthenticationStrategy(new OmAuthenticationStrategy()); getApplicationSettings().setAccessDeniedPage(AccessDeniedPage.class); + getApplicationSettings().setInternalErrorPage(InternalErrorPage.class); + getExceptionSettings().setUnexpectedExceptionDisplay(ExceptionSettings.SHOW_INTERNAL_ERROR_PAGE); getComponentInstantiationListeners().add(new SpringComponentInjector(this, ctx,
[jira] [Commented] (OPENMEETINGS-2476) HttpURLConnection should be replaced with HttpClient
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213896#comment-17213896 ] ASF subversion and git services commented on OPENMEETINGS-2476: --- Commit bfdacc3fdb6597eedf71f54248efca223893ca52 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=bfdacc3 ] [OPENMEETINGS-2476] InterruptedException is re-thrown, internal error page is changed > HttpURLConnection should be replaced with HttpClient > > > Key: OPENMEETINGS-2476 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2476 > Project: Openmeetings > Issue Type: Improvement > Components: OAuth >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > HttpURLConnection should be replaced with HttpClient > this will eliminate possible resource leak -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2478) Sonar issues need to be addressed
Maxim Solodovnik created OPENMEETINGS-2478: -- Summary: Sonar issues need to be addressed Key: OPENMEETINGS-2478 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2478 Project: Openmeetings Issue Type: Task Components: Builds Affects Versions: 5.1.0 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 5.1.0 Sonar issues need to be addressed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2478] sonar should be more happy
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 1c14c66 [OPENMEETINGS-2478] sonar should be more happy
1c14c66 is described below
commit 1c14c6683bcea29c9621c0b9d9204e0b0ec29575
Author: Maxim Solodovnik
AuthorDate: Wed Oct 14 20:53:24 2020 +0700
[OPENMEETINGS-2478] sonar should be more happy
---
.../apache/openmeetings/core/remote/KStream.java | 36 ++
.../apache/openmeetings/backup/BackupImport.java | 6 ++--
.../apache/openmeetings/web/common/BasePanel.java | 4 +++
.../apache/openmeetings/web/common/MainPanel.java | 2 +-
.../openmeetings/web/common/menu/OmMenuItem.java | 1 +
.../web/common/tree/FileTreePanel.java | 4 +++
.../web/common/tree/OmTreeProvider.java| 4 ++-
.../sidebar/RoomFileUploadResourceReference.java | 2 +-
.../openmeetings/web/user/MessageDialog.java | 2 +-
9 files changed, 35 insertions(+), 26 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
index 77a5e2d..754ee15 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
@@ -48,6 +48,7 @@ import org.apache.openmeetings.db.util.ws.RoomMessage;
import org.apache.openmeetings.db.util.ws.TextRoomMessage;
import org.kurento.client.Continuation;
import org.kurento.client.IceCandidate;
+import org.kurento.client.MediaFlowState;
import org.kurento.client.MediaProfileSpecType;
import org.kurento.client.MediaType;
import org.kurento.client.RecorderEndpoint;
@@ -122,25 +123,22 @@ public class KStream extends AbstractStream {
outgoingMedia.addMediaSessionTerminatedListener(evt ->
log.warn("Media stream terminated {}", sd));
outgoingMedia.addMediaFlowOutStateChangeListener(evt -> {
log.info("Media Flow STATE :: {}, type {}, evt {}",
evt.getState(), evt.getType(), evt.getMediaType());
- switch (evt.getState()) {
- case NOT_FLOWING:
- log.warn("FlowOut Future is created");
- flowoutFuture = Optional.of(new
CompletableFuture<>().completeAsync(() -> {
- log.warn("KStream will be
dropped {}", sd);
- if (StreamType.SCREEN ==
streamType) {
-
processor.doStopSharing(sid, uid);
- }
- stopBroadcast();
- return null;
- }, delayedExecutor(getFlowoutTimeout(),
TimeUnit.SECONDS)));
- break;
- case FLOWING:
- flowoutFuture.ifPresent(f -> {
- log.warn("FlowOut Future is
canceled");
- f.cancel(true);
- flowoutFuture =
Optional.empty();
- });
- break;
+ if (MediaFlowState.NOT_FLOWING == evt.getState()) {
+ log.warn("FlowOut Future is created");
+ flowoutFuture = Optional.of(new
CompletableFuture<>().completeAsync(() -> {
+ log.warn("KStream will be dropped {}",
sd);
+ if (StreamType.SCREEN == streamType) {
+ processor.doStopSharing(sid,
uid);
+ }
+ stopBroadcast();
+ return null;
+ }, delayedExecutor(getFlowoutTimeout(),
TimeUnit.SECONDS)));
+ } else {
+ flowoutFuture.ifPresent(f -> {
+ log.warn("FlowOut Future is canceled");
+ f.cancel(true);
+ flowoutFuture = Optional.empty();
+ });
}
});
outgoingMedia.addMediaFlowInStateChangeListener(evt ->
log.warn("Media FlowIn :: {}", evt));
diff --git
a/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java
[openmeetings] branch master updated: [OPENMEETINGS-2478] sonar should be more happy
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 1c14c66 [OPENMEETINGS-2478] sonar should be more happy
1c14c66 is described below
commit 1c14c6683bcea29c9621c0b9d9204e0b0ec29575
Author: Maxim Solodovnik
AuthorDate: Wed Oct 14 20:53:24 2020 +0700
[OPENMEETINGS-2478] sonar should be more happy
---
.../apache/openmeetings/core/remote/KStream.java | 36 ++
.../apache/openmeetings/backup/BackupImport.java | 6 ++--
.../apache/openmeetings/web/common/BasePanel.java | 4 +++
.../apache/openmeetings/web/common/MainPanel.java | 2 +-
.../openmeetings/web/common/menu/OmMenuItem.java | 1 +
.../web/common/tree/FileTreePanel.java | 4 +++
.../web/common/tree/OmTreeProvider.java| 4 ++-
.../sidebar/RoomFileUploadResourceReference.java | 2 +-
.../openmeetings/web/user/MessageDialog.java | 2 +-
9 files changed, 35 insertions(+), 26 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
index 77a5e2d..754ee15 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
@@ -48,6 +48,7 @@ import org.apache.openmeetings.db.util.ws.RoomMessage;
import org.apache.openmeetings.db.util.ws.TextRoomMessage;
import org.kurento.client.Continuation;
import org.kurento.client.IceCandidate;
+import org.kurento.client.MediaFlowState;
import org.kurento.client.MediaProfileSpecType;
import org.kurento.client.MediaType;
import org.kurento.client.RecorderEndpoint;
@@ -122,25 +123,22 @@ public class KStream extends AbstractStream {
outgoingMedia.addMediaSessionTerminatedListener(evt ->
log.warn("Media stream terminated {}", sd));
outgoingMedia.addMediaFlowOutStateChangeListener(evt -> {
log.info("Media Flow STATE :: {}, type {}, evt {}",
evt.getState(), evt.getType(), evt.getMediaType());
- switch (evt.getState()) {
- case NOT_FLOWING:
- log.warn("FlowOut Future is created");
- flowoutFuture = Optional.of(new
CompletableFuture<>().completeAsync(() -> {
- log.warn("KStream will be
dropped {}", sd);
- if (StreamType.SCREEN ==
streamType) {
-
processor.doStopSharing(sid, uid);
- }
- stopBroadcast();
- return null;
- }, delayedExecutor(getFlowoutTimeout(),
TimeUnit.SECONDS)));
- break;
- case FLOWING:
- flowoutFuture.ifPresent(f -> {
- log.warn("FlowOut Future is
canceled");
- f.cancel(true);
- flowoutFuture =
Optional.empty();
- });
- break;
+ if (MediaFlowState.NOT_FLOWING == evt.getState()) {
+ log.warn("FlowOut Future is created");
+ flowoutFuture = Optional.of(new
CompletableFuture<>().completeAsync(() -> {
+ log.warn("KStream will be dropped {}",
sd);
+ if (StreamType.SCREEN == streamType) {
+ processor.doStopSharing(sid,
uid);
+ }
+ stopBroadcast();
+ return null;
+ }, delayedExecutor(getFlowoutTimeout(),
TimeUnit.SECONDS)));
+ } else {
+ flowoutFuture.ifPresent(f -> {
+ log.warn("FlowOut Future is canceled");
+ f.cancel(true);
+ flowoutFuture = Optional.empty();
+ });
}
});
outgoingMedia.addMediaFlowInStateChangeListener(evt ->
log.warn("Media FlowIn :: {}", evt));
diff --git
a/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java
[jira] [Commented] (OPENMEETINGS-2478) Sonar issues need to be addressed
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213935#comment-17213935 ] ASF subversion and git services commented on OPENMEETINGS-2478: --- Commit 1c14c6683bcea29c9621c0b9d9204e0b0ec29575 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=1c14c66 ] [OPENMEETINGS-2478] sonar should be more happy > Sonar issues need to be addressed > - > > Key: OPENMEETINGS-2478 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2478 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Sonar issues need to be addressed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2478) Sonar issues need to be addressed
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213936#comment-17213936 ] ASF subversion and git services commented on OPENMEETINGS-2478: --- Commit 1c14c6683bcea29c9621c0b9d9204e0b0ec29575 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=1c14c66 ] [OPENMEETINGS-2478] sonar should be more happy > Sonar issues need to be addressed > - > > Key: OPENMEETINGS-2478 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2478 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Sonar issues need to be addressed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2465) Enter a meetingroom a few minutes before scheduled start
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2465. Resolution: Fixed hopefully should be fixed > Enter a meetingroom a few minutes before scheduled start > > > Key: OPENMEETINGS-2465 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2465 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.1 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-10-13 22-23-46.png, > Bildschirmfoto vom 2020-10-13 22-29-35.png, Bildschirmfoto vom 2020-10-13 > 22-50-00.png, Bildschirmfoto vom 2020-10-13 23-18-42.png > > > When a meetin is scheduled for 20:00 it is only possible to enter the room > after 20.00. > Improvement: > It should be possible to enter the room a few minutes before the scheduled > starttime (for example 5 min). So the presentation could start in time. > Interval configurable in configuration? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2465] invitation should be re-checked each time in session
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new fd3a6b1 [OPENMEETINGS-2465] invitation should be re-checked each time
in session
fd3a6b1 is described below
commit fd3a6b176a4e91ce0d4fd3931b67c48325b8f11c
Author: Maxim Solodovnik
AuthorDate: Wed Oct 14 19:30:37 2020 +0700
[OPENMEETINGS-2465] invitation should be re-checked each time in session
---
.../apache/openmeetings/web/app/WebSession.java| 35 --
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/WebSession.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/WebSession.java
index c56386c..9197201 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/WebSession.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/WebSession.java
@@ -114,7 +114,7 @@ public class WebSession extends
AbstractAuthenticatedWebSession implements IWebS
private FastDateFormat iso8601Format = null;
private FastDateFormat sdf = null;
private UserDashboard dashboard;
- private Invitation i = null;
+ private Invitation invitation = null;
private SOAPLogin soap = null;
private Long roomId = null;
private Long recordingId = null;
@@ -153,7 +153,7 @@ public class WebSession extends
AbstractAuthenticatedWebSession implements IWebS
iso8601Format = null;
sdf = null;
languageId = -1;
- i = null;
+ invitation = null;
soap = null;
roomId = null;
recordingId = null;
@@ -219,8 +219,8 @@ public class WebSession extends
AbstractAuthenticatedWebSession implements IWebS
}
}
- public void checkHashes(StringValue secure, StringValue invitation) {
- log.debug("checkHashes, secure: '{}', invitation: '{}'",
secure, invitation);
+ public void checkHashes(StringValue secure, StringValue inviteStr) {
+ log.debug("checkHashes, secure: '{}', invitation: '{}'",
secure, inviteStr);
try {
log.debug("checkHashes, has soap in session ? '{}'",
(soap != null));
if (!secure.isEmpty() && (soap == null ||
!soap.getHash().equals(secure.toString( {
@@ -231,29 +231,32 @@ public class WebSession extends
AbstractAuthenticatedWebSession implements IWebS
}
signIn(secure.toString(), true);
}
- if (!invitation.isEmpty() && (i == null ||
!i.getHash().equals(invitation.toString( {
+ if (!inviteStr.isEmpty()) {
+ // invitation should be re-checked each time,
due to PERIOD invitation can be
+ // 1) not ready
+ // 2) already expired
// otherwise already logged-in with the same
hash
if (isSignedIn()) {
log.debug("invitation: Session is
authorized, going to invalidate");
invalidateNow();
}
- i = inviteDao.getByHash(invitation.toString(),
false);
+ invitation =
inviteDao.getByHash(inviteStr.toString(), false);
Room r = null;
- if (i != null && i.isAllowEntry()) {
+ if (invitation != null &&
invitation.isAllowEntry()) {
Set hrights = new HashSet<>();
- if (i.getRoom() != null) {
- r = i.getRoom();
- } else if (i.getAppointment() != null
&& i.getAppointment().getRoom() != null) {
- r =
i.getAppointment().getRoom();
- } else if (i.getRecording() != null) {
- recordingId =
i.getRecording().getId();
+ if (invitation.getRoom() != null) {
+ r = invitation.getRoom();
+ } else if (invitation.getAppointment()
!= null && invitation.getAppointment().getRoom() != null) {
+ r =
invitation.getAppointment().getRoom();
+ } else if (invitation.getRecording() !=
null) {
+
[jira] [Commented] (OPENMEETINGS-2465) Enter a meetingroom a few minutes before scheduled start
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213875#comment-17213875 ] ASF subversion and git services commented on OPENMEETINGS-2465: --- Commit fd3a6b176a4e91ce0d4fd3931b67c48325b8f11c in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=fd3a6b1 ] [OPENMEETINGS-2465] invitation should be re-checked each time in session > Enter a meetingroom a few minutes before scheduled start > > > Key: OPENMEETINGS-2465 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2465 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.1 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-10-13 22-23-46.png, > Bildschirmfoto vom 2020-10-13 22-29-35.png, Bildschirmfoto vom 2020-10-13 > 22-50-00.png, Bildschirmfoto vom 2020-10-13 23-18-42.png > > > When a meetin is scheduled for 20:00 it is only possible to enter the room > after 20.00. > Improvement: > It should be possible to enter the room a few minutes before the scheduled > starttime (for example 5 min). So the presentation could start in time. > Interval configurable in configuration? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2480) Email for a changed event contains wrong URL
Uwe Simon created OPENMEETINGS-2480: --- Summary: Email for a changed event contains wrong URL Key: OPENMEETINGS-2480 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2480 Project: Openmeetings Issue Type: Bug Components: Email Affects Versions: 5.0.1, 5.1.0 Reporter: Uwe Simon Assignee: Maxim Solodovnik Attachments: Bildschirmfoto vom 2020-10-14 20-02-00.png, Bildschirmfoto vom 2020-10-14 20-02-34.png When inviting persons via calendar an email with a link like [http://localhost:8080/openmeetings/hash?invitation=4e0678fd-952a-463d-ba1b-c8aec245f64c=1|http://localhost:8080/openmeetings/hash?invitation=4e0678fd-952a-463d-ba1b-c8aec245f64c=2] is send which can be used without any login. !Bildschirmfoto vom 2020-10-14 20-02-00.png! When changing the event a "change email" is send. Ths email contains the the room insted of the invitation. !Bildschirmfoto vom 2020-10-14 20-02-34.png! Expectation: The "change emails" contain the invitation link too. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2479) Leaving meeting entered by invitation shows "access denied"
Uwe Simon created OPENMEETINGS-2479: --- Summary: Leaving meeting entered by invitation shows "access denied" Key: OPENMEETINGS-2479 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2479 Project: Openmeetings Issue Type: Bug Components: UI Affects Versions: 5.0.1, 5.1.0 Reporter: Uwe Simon Assignee: Maxim Solodovnik Attachments: Bildschirmfoto vom 2020-10-14 19-55-38.png When entering a meeting via the link from the email like | |[http://localhost:8080/openmeetings/hash?invitation=4e0678fd-952a-463d-ba1b-c8aec245f64c=1|http://localhost:8080/openmeetings/hash?invitation=4e0678fd-952a-463d-ba1b-c8aec245f64c=2]| leaving it with"Exit" will shows the errorpage "Access denied". !Bildschirmfoto vom 2020-10-14 19-55-38.png! Expactation: A "goodbye page" or the "Login page" should appear -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2465) Enter a meetingroom a few minutes before scheduled start
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214199#comment-17214199 ] Uwe Simon commented on OPENMEETINGS-2465: - Works now. > Enter a meetingroom a few minutes before scheduled start > > > Key: OPENMEETINGS-2465 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2465 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 5.0.1 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-10-13 22-23-46.png, > Bildschirmfoto vom 2020-10-13 22-29-35.png, Bildschirmfoto vom 2020-10-13 > 22-50-00.png, Bildschirmfoto vom 2020-10-13 23-18-42.png > > > When a meetin is scheduled for 20:00 it is only possible to enter the room > after 20.00. > Improvement: > It should be possible to enter the room a few minutes before the scheduled > starttime (for example 5 min). So the presentation could start in time. > Interval configurable in configuration? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
