[jira] [Commented] (OPENMEETINGS-1789) WicketRuntimeException comes suddenly while entering the meeting with the obtained hash
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299891#comment-16299891 ] Maxim Solodovnik commented on OPENMEETINGS-1789: There shouldn't be any issues Could you please test using latest nightly build? https://builds.apache.org/view/M-R/view/OpenMeetings/job/OpenMeetings%204.0.x/ (166+)? And provide very detailed steps how this can be reproduced if it fails at 4.0.2-SNAPSHOT? Thanks in advance > WicketRuntimeException comes suddenly while entering the meeting with the > obtained hash > --- > > Key: OPENMEETINGS-1789 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1789 > Project: Openmeetings > Issue Type: Bug > Components: HTML5/Room >Affects Versions: 3.2.1, 3.3.0, 3.3.1, 3.3.2, 4.0.0 > Environment: ubuntu 14.04, 16.04 and windows >Reporter: Sridhar S >Assignee: Maxim Solodovnik > Labels: newbie > Attachments: openmeetings_errorlog > > Original Estimate: 128h > Remaining Estimate: 128h > > The openmeetings will be running properly for some time and entering into > room and carrying out the meetings will also run without any issues, but > suddenly after a day or after some time, when a user tries to join a meeting, > he will get the hash, but after entering that hash to join the meeting, he > gets "internal server error" at the UI of the room and after checking the > logs, there will be an exception called > org.apache.wicket.WicketRuntimeException: Exception in rendering component: > [HtmlHeaderItemsContainer [Component id = _header_]]. > Then, after we restart the openmeetings, It continues to work fine. > But, after deploying in production it not acceptable to keep restarting and > also it becomes difficult to track issues. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OPENMEETINGS-1799) Tab for global chat is displayed in room if global chat is OFF
[
https://issues.apache.org/jira/browse/OPENMEETINGS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved OPENMEETINGS-1799.
Resolution: Fixed
> Tab for global chat is displayed in room if global chat is OFF
> --
>
> Key: OPENMEETINGS-1799
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1799
> Project: Openmeetings
> Issue Type: Bug
> Components: HTML5/Chat
>Affects Versions: 4.0.1
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
> Fix For: 4.0.2
>
>
> Tab for global chat is displayed in room if global chat is OFF
> Steps:
> # go to Admin -> Config, set {{dashboard.show.chat}} == {{false}}
> # reload page
> Result: global chat is removed
> # enter any room
> # open chat
> Result: {{All}} tab is displayed in chat tabs
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENMEETINGS-1799) Tab for global chat is displayed in room if global chat is OFF
[
https://issues.apache.org/jira/browse/OPENMEETINGS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299887#comment-16299887
]
ASF subversion and git services commented on OPENMEETINGS-1799:
---
Commit 1739c9ad4efb495e8d795c8be21b10fab99d8e0a in openmeetings's branch
refs/heads/4.0.x from [~solomax]
[ https://git-wip-us.apache.org/repos/asf?p=openmeetings.git;h=1739c9a ]
[OPENMEETINGS-1799] Tab for global chat is NOT displayed in room if global chat
is OFF
> Tab for global chat is displayed in room if global chat is OFF
> --
>
> Key: OPENMEETINGS-1799
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1799
> Project: Openmeetings
> Issue Type: Bug
> Components: HTML5/Chat
>Affects Versions: 4.0.1
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
> Fix For: 4.0.2
>
>
> Tab for global chat is displayed in room if global chat is OFF
> Steps:
> # go to Admin -> Config, set {{dashboard.show.chat}} == {{false}}
> # reload page
> Result: global chat is removed
> # enter any room
> # open chat
> Result: {{All}} tab is displayed in chat tabs
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
openmeetings git commit: [OPENMEETINGS-1799] Tab for global chat is NOT displayed in room if global chat is OFF
Repository: openmeetings
Updated Branches:
refs/heads/master e5ab7c55e -> bdfbdc80a
[OPENMEETINGS-1799] Tab for global chat is NOT displayed in room if global chat
is OFF
Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo
Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/bdfbdc80
Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/bdfbdc80
Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/bdfbdc80
Branch: refs/heads/master
Commit: bdfbdc80a4b1a07d31d93d89c266474f211e3999
Parents: e5ab7c5
Author: Maxim Solodovnik
Authored: Thu Dec 21 18:28:10 2017 +0700
Committer: Maxim Solodovnik
Committed: Thu Dec 21 18:28:31 2017 +0700
--
.../apache/openmeetings/web/user/chat/Chat.java| 17 +
.../openmeetings/web/user/chat/ChatForm.java | 2 +-
.../openmeetings/web/user/chat/ChatPanel.java | 5 +++--
3 files changed, 17 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/bdfbdc80/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
index 38107de..0607aac 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
@@ -18,6 +18,7 @@
*/
package org.apache.openmeetings.web.user.chat;
+import static org.apache.openmeetings.core.util.WebSocketHelper.ID_ALL;
import static org.apache.openmeetings.core.util.WebSocketHelper.ID_ROOM_PREFIX;
import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_DASHBOARD_SHOW_CHAT;
import static
org.apache.openmeetings.util.OpenmeetingsVariables.getWebAppRootKey;
@@ -130,10 +131,18 @@ public class Chat extends Panel {
}
public CharSequence getReinit() {
- StringBuilder sb = new StringBuilder("Chat.reinit(");
- sb.append('\'').append(getString("1494")).append('\'')
-
.append(',').append('\'').append(getString("406")).append('\'');
- return sb.append("); ");
+ StringBuilder sb = new StringBuilder("Chat.reinit(")
+
.append('\'').append(getString("1494")).append('\'')
+
.append(',').append('\'').append(getString("406")).append('\'')
+ .append("); ");
+ return processGlobal(sb);
+ }
+
+ public CharSequence processGlobal(StringBuilder sb) {
+ if (!showDashboardChat) {
+ sb.append(String.format("Chat.removeTab('%s');",
ID_ALL));
+ }
+ return sb;
}
public CharSequence addRoom(Room r) {
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/bdfbdc80/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
index b2d40e7..0500aae 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
@@ -107,7 +107,7 @@ public class ChatForm extends Form {
m.setSent(new Date());
m.setFromUser(getBean(UserDao.class).get(getUserId()));
if (!process(
- () -> true
+ () ->
getChat().isShowDashboardChat()
, r -> {
if
(isUserInRoom(r.getId(), getUserId())) {
m.setToRoom(r);
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/bdfbdc80/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
index cbccd80..a1b4683 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
+++
b/openmeetings-web/src/main/j
[jira] [Commented] (OPENMEETINGS-1799) Tab for global chat is displayed in room if global chat is OFF
[
https://issues.apache.org/jira/browse/OPENMEETINGS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299888#comment-16299888
]
ASF subversion and git services commented on OPENMEETINGS-1799:
---
Commit bdfbdc80a4b1a07d31d93d89c266474f211e3999 in openmeetings's branch
refs/heads/master from [~solomax]
[ https://git-wip-us.apache.org/repos/asf?p=openmeetings.git;h=bdfbdc8 ]
[OPENMEETINGS-1799] Tab for global chat is NOT displayed in room if global chat
is OFF
> Tab for global chat is displayed in room if global chat is OFF
> --
>
> Key: OPENMEETINGS-1799
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1799
> Project: Openmeetings
> Issue Type: Bug
> Components: HTML5/Chat
>Affects Versions: 4.0.1
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
> Fix For: 4.0.2
>
>
> Tab for global chat is displayed in room if global chat is OFF
> Steps:
> # go to Admin -> Config, set {{dashboard.show.chat}} == {{false}}
> # reload page
> Result: global chat is removed
> # enter any room
> # open chat
> Result: {{All}} tab is displayed in chat tabs
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
openmeetings git commit: [OPENMEETINGS-1799] Tab for global chat is NOT displayed in room if global chat is OFF
Repository: openmeetings
Updated Branches:
refs/heads/4.0.x 0297c55c1 -> 1739c9ad4
[OPENMEETINGS-1799] Tab for global chat is NOT displayed in room if global chat
is OFF
Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo
Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/1739c9ad
Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/1739c9ad
Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/1739c9ad
Branch: refs/heads/4.0.x
Commit: 1739c9ad4efb495e8d795c8be21b10fab99d8e0a
Parents: 0297c55
Author: Maxim Solodovnik
Authored: Thu Dec 21 18:28:10 2017 +0700
Committer: Maxim Solodovnik
Committed: Thu Dec 21 18:28:10 2017 +0700
--
.../apache/openmeetings/web/user/chat/Chat.java| 17 +
.../openmeetings/web/user/chat/ChatForm.java | 2 +-
.../openmeetings/web/user/chat/ChatPanel.java | 5 +++--
3 files changed, 17 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/1739c9ad/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
index 38107de..0607aac 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
@@ -18,6 +18,7 @@
*/
package org.apache.openmeetings.web.user.chat;
+import static org.apache.openmeetings.core.util.WebSocketHelper.ID_ALL;
import static org.apache.openmeetings.core.util.WebSocketHelper.ID_ROOM_PREFIX;
import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_DASHBOARD_SHOW_CHAT;
import static
org.apache.openmeetings.util.OpenmeetingsVariables.getWebAppRootKey;
@@ -130,10 +131,18 @@ public class Chat extends Panel {
}
public CharSequence getReinit() {
- StringBuilder sb = new StringBuilder("Chat.reinit(");
- sb.append('\'').append(getString("1494")).append('\'')
-
.append(',').append('\'').append(getString("406")).append('\'');
- return sb.append("); ");
+ StringBuilder sb = new StringBuilder("Chat.reinit(")
+
.append('\'').append(getString("1494")).append('\'')
+
.append(',').append('\'').append(getString("406")).append('\'')
+ .append("); ");
+ return processGlobal(sb);
+ }
+
+ public CharSequence processGlobal(StringBuilder sb) {
+ if (!showDashboardChat) {
+ sb.append(String.format("Chat.removeTab('%s');",
ID_ALL));
+ }
+ return sb;
}
public CharSequence addRoom(Room r) {
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/1739c9ad/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
index b2d40e7..0500aae 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatForm.java
@@ -107,7 +107,7 @@ public class ChatForm extends Form {
m.setSent(new Date());
m.setFromUser(getBean(UserDao.class).get(getUserId()));
if (!process(
- () -> true
+ () ->
getChat().isShowDashboardChat()
, r -> {
if
(isUserInRoom(r.getId(), getUserId())) {
m.setToRoom(r);
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/1739c9ad/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
index cbccd80..a1b4683 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatPanel.java
+++
b/openmeetings-web/src/main/jav
[jira] [Created] (OPENMEETINGS-1799) Tab for global chat is displayed in room if global chat is OFF
Maxim Solodovnik created OPENMEETINGS-1799:
--
Summary: Tab for global chat is displayed in room if global chat
is OFF
Key: OPENMEETINGS-1799
URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1799
Project: Openmeetings
Issue Type: Bug
Components: HTML5/Chat
Affects Versions: 4.0.1
Reporter: Maxim Solodovnik
Assignee: Maxim Solodovnik
Fix For: 4.0.2
Tab for global chat is displayed in room if global chat is OFF
Steps:
# go to Admin -> Config, set {{dashboard.show.chat}} == {{false}}
# reload page
Result: global chat is removed
# enter any room
# open chat
Result: {{All}} tab is displayed in chat tabs
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OPENMEETINGS-1789) WicketRuntimeException comes suddenly while entering the meeting with the obtained hash
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299873#comment-16299873 ] Sridhar S commented on OPENMEETINGS-1789: - Sir, is there a problem if that user is added as an external user > WicketRuntimeException comes suddenly while entering the meeting with the > obtained hash > --- > > Key: OPENMEETINGS-1789 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1789 > Project: Openmeetings > Issue Type: Bug > Components: HTML5/Room >Affects Versions: 3.2.1, 3.3.0, 3.3.1, 3.3.2, 4.0.0 > Environment: ubuntu 14.04, 16.04 and windows >Reporter: Sridhar S >Assignee: Maxim Solodovnik > Labels: newbie > Attachments: openmeetings_errorlog > > Original Estimate: 128h > Remaining Estimate: 128h > > The openmeetings will be running properly for some time and entering into > room and carrying out the meetings will also run without any issues, but > suddenly after a day or after some time, when a user tries to join a meeting, > he will get the hash, but after entering that hash to join the meeting, he > gets "internal server error" at the UI of the room and after checking the > logs, there will be an exception called > org.apache.wicket.WicketRuntimeException: Exception in rendering component: > [HtmlHeaderItemsContainer [Component id = _header_]]. > Then, after we restart the openmeetings, It continues to work fine. > But, after deploying in production it not acceptable to keep restarting and > also it becomes difficult to track issues. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENMEETINGS-1789) WicketRuntimeException comes suddenly while entering the meeting with the obtained hash
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299871#comment-16299871 ] Sridhar S commented on OPENMEETINGS-1789: - yes > WicketRuntimeException comes suddenly while entering the meeting with the > obtained hash > --- > > Key: OPENMEETINGS-1789 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1789 > Project: Openmeetings > Issue Type: Bug > Components: HTML5/Room >Affects Versions: 3.2.1, 3.3.0, 3.3.1, 3.3.2, 4.0.0 > Environment: ubuntu 14.04, 16.04 and windows >Reporter: Sridhar S >Assignee: Maxim Solodovnik > Labels: newbie > Attachments: openmeetings_errorlog > > Original Estimate: 128h > Remaining Estimate: 128h > > The openmeetings will be running properly for some time and entering into > room and carrying out the meetings will also run without any issues, but > suddenly after a day or after some time, when a user tries to join a meeting, > he will get the hash, but after entering that hash to join the meeting, he > gets "internal server error" at the UI of the room and after checking the > logs, there will be an exception called > org.apache.wicket.WicketRuntimeException: Exception in rendering component: > [HtmlHeaderItemsContainer [Component id = _header_]]. > Then, after we restart the openmeetings, It continues to work fine. > But, after deploying in production it not acceptable to keep restarting and > also it becomes difficult to track issues. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENMEETINGS-1789) WicketRuntimeException comes suddenly while entering the meeting with the obtained hash
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299869#comment-16299869 ] Maxim Solodovnik commented on OPENMEETINGS-1789: 4.0.1? > WicketRuntimeException comes suddenly while entering the meeting with the > obtained hash > --- > > Key: OPENMEETINGS-1789 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1789 > Project: Openmeetings > Issue Type: Bug > Components: HTML5/Room >Affects Versions: 3.2.1, 3.3.0, 3.3.1, 3.3.2, 4.0.0 > Environment: ubuntu 14.04, 16.04 and windows >Reporter: Sridhar S >Assignee: Maxim Solodovnik > Labels: newbie > Attachments: openmeetings_errorlog > > Original Estimate: 128h > Remaining Estimate: 128h > > The openmeetings will be running properly for some time and entering into > room and carrying out the meetings will also run without any issues, but > suddenly after a day or after some time, when a user tries to join a meeting, > he will get the hash, but after entering that hash to join the meeting, he > gets "internal server error" at the UI of the room and after checking the > logs, there will be an exception called > org.apache.wicket.WicketRuntimeException: Exception in rendering component: > [HtmlHeaderItemsContainer [Component id = _header_]]. > Then, after we restart the openmeetings, It continues to work fine. > But, after deploying in production it not acceptable to keep restarting and > also it becomes difficult to track issues. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENMEETINGS-1789) WicketRuntimeException comes suddenly while entering the meeting with the obtained hash
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299867#comment-16299867 ] Sridhar S commented on OPENMEETINGS-1789: - Hi Maxim, This has occured again, but only for one user this time. The logger says org.apache.wicket.WicketRuntimeException: Exception in rendering component: [HtmlHeaderItemsContainer [Component id = _header_]]. UI is getting Internal Error. > WicketRuntimeException comes suddenly while entering the meeting with the > obtained hash > --- > > Key: OPENMEETINGS-1789 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1789 > Project: Openmeetings > Issue Type: Bug > Components: HTML5/Room >Affects Versions: 3.2.1, 3.3.0, 3.3.1, 3.3.2, 4.0.0 > Environment: ubuntu 14.04, 16.04 and windows >Reporter: Sridhar S >Assignee: Maxim Solodovnik > Labels: newbie > Attachments: openmeetings_errorlog > > Original Estimate: 128h > Remaining Estimate: 128h > > The openmeetings will be running properly for some time and entering into > room and carrying out the meetings will also run without any issues, but > suddenly after a day or after some time, when a user tries to join a meeting, > he will get the hash, but after entering that hash to join the meeting, he > gets "internal server error" at the UI of the room and after checking the > logs, there will be an exception called > org.apache.wicket.WicketRuntimeException: Exception in rendering component: > [HtmlHeaderItemsContainer [Component id = _header_]]. > Then, after we restart the openmeetings, It continues to work fine. > But, after deploying in production it not acceptable to keep restarting and > also it becomes difficult to track issues. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OPENMEETINGS-1789) WicketRuntimeException comes suddenly while entering the meeting with the obtained hash
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sridhar S updated OPENMEETINGS-1789: Environment: ubuntu 14.04, 16.04 and windows (was: ubuntu 14.04 and 16.04) > WicketRuntimeException comes suddenly while entering the meeting with the > obtained hash > --- > > Key: OPENMEETINGS-1789 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1789 > Project: Openmeetings > Issue Type: Bug > Components: HTML5/Room >Affects Versions: 3.2.1, 3.3.0, 3.3.1, 3.3.2, 4.0.0 > Environment: ubuntu 14.04, 16.04 and windows >Reporter: Sridhar S >Assignee: Maxim Solodovnik > Labels: newbie > Attachments: openmeetings_errorlog > > Original Estimate: 128h > Remaining Estimate: 128h > > The openmeetings will be running properly for some time and entering into > room and carrying out the meetings will also run without any issues, but > suddenly after a day or after some time, when a user tries to join a meeting, > he will get the hash, but after entering that hash to join the meeting, he > gets "internal server error" at the UI of the room and after checking the > logs, there will be an exception called > org.apache.wicket.WicketRuntimeException: Exception in rendering component: > [HtmlHeaderItemsContainer [Component id = _header_]]. > Then, after we restart the openmeetings, It continues to work fine. > But, after deploying in production it not acceptable to keep restarting and > also it becomes difficult to track issues. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OPENMEETINGS-1790) Translations need to be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299851#comment-16299851 ] ASF subversion and git services commented on OPENMEETINGS-1790: --- Commit e5ab7c55e80a6e8eee04b1a8a3dfae7323e95044 in openmeetings's branch refs/heads/master from [~solomax] [ https://git-wip-us.apache.org/repos/asf?p=openmeetings.git;h=e5ab7c5 ] [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString > Translations need to be improved > > > Key: OPENMEETINGS-1790 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1790 > Project: Openmeetings > Issue Type: Improvement > Components: BuildsAndReleases >Affects Versions: 4.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik > Fix For: 4.0.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[2/3] openmeetings git commit: [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/e5ab7c55/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
index 28c175f..611bd6e 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
@@ -100,10 +100,10 @@ public class MainPanel extends Panel {
private static final String DELIMITER = " ";
private final WebMarkupContainer EMPTY = new
WebMarkupContainer(CHILD_ID);
private String uid = null;
- private final MenuPanel menu;
+ private MenuPanel menu;
private final WebMarkupContainer topControls = new
WebMarkupContainer("topControls");
private final WebMarkupContainer topLinks = new
WebMarkupContainer("topLinks");
- private final MarkupContainer contents;
+ private final MarkupContainer contents = new
WebMarkupContainer("contents");
private ChatPanel chat;
private MessageDialog newMessage;
private UserInfoDialog userInfo;
@@ -129,8 +129,6 @@ public class MainPanel extends Panel {
setAuto(true);
setOutputMarkupId(true);
setOutputMarkupPlaceholderTag(true);
- menu = new MenuPanel("menu", getMainMenu());
- contents = new WebMarkupContainer("contents");
pingTimer.stop(null);
add(pingTimer, new WebSocketBehavior() {
private static final long serialVersionUID = 1L;
@@ -187,7 +185,7 @@ public class MainPanel extends Panel {
@Override
protected void onInitialize() {
- super.onInitialize();
+ menu = new MenuPanel("menu", getMainMenu());
add(topControls.setOutputMarkupPlaceholderTag(true).setMarkupId("topControls"));
add(contents.add(getClient() == null || panel == null ? EMPTY :
panel).setOutputMarkupId(true).setMarkupId("contents"));
topControls.add(menu.setVisible(false),
topLinks.setVisible(false).setOutputMarkupPlaceholderTag(true).setMarkupId("topLinks"));
@@ -301,6 +299,7 @@ public class MainPanel extends Panel {
setResponsePage(Application.get().getSignInPageClass());
}
});
+ super.onInitialize();
}
private IMenuItem getSubItem(String lbl, String title, MenuActions
action, MenuParams param) {
@@ -321,7 +320,7 @@ public class MainPanel extends Panel {
List l = new ArrayList<>();
l.add(getSubItem("290", "1450",
MenuActions.dashboardModuleStartScreen, null));
l.add(getSubItem("291", "1451",
MenuActions.dashboardModuleCalendar, null));
- mmenu.add(new OmMenuItem(Application.getString("124"),
l));
+ mmenu.add(new OmMenuItem(getString("124"), l));
}
{
// Conference Menu Points
@@ -346,13 +345,13 @@ public class MainPanel extends Panel {
}
});
}
- mmenu.add(new OmMenuItem(Application.getString("792"),
l));
+ mmenu.add(new OmMenuItem(getString("792"), l));
}
{
// Recording Menu Points
List l = new ArrayList<>();
l.add(getSubItem("395", "1452",
MenuActions.recordModule, null));
- mmenu.add(new OmMenuItem(Application.getString("395"),
l));
+ mmenu.add(new OmMenuItem(getString("395"), l));
}
Set r = WebSession.getRights();
boolean isAdmin = hasAdminLevel(r);
@@ -373,7 +372,7 @@ public class MainPanel extends Panel {
l.add(getSubItem("367", "1461",
MenuActions.adminModuleBackup, null));
l.add(getSubItem("main.menu.admin.email",
"main.menu.admin.email.desc", MenuActions.adminModuleEmail, null));
}
- mmenu.add(new OmMenuItem(Application.getString("6"),
l));
+ mmenu.add(new OmMenuItem(getString("6"), l));
}
return mmenu;
}
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/e5ab7c55/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/NameDialog.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/N
[1/3] openmeetings git commit: [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString
Repository: openmeetings
Updated Branches:
refs/heads/master 510c008d7 -> e5ab7c55e
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/e5ab7c55/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
index 020b92d..1a8093b 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
@@ -30,7 +30,6 @@ import org.apache.openmeetings.db.dao.calendar.AppointmentDao;
import org.apache.openmeetings.db.entity.calendar.Appointment;
import org.apache.openmeetings.db.entity.calendar.OmCalendar;
import org.apache.openmeetings.service.calendar.caldav.AppointmentManager;
-import org.apache.openmeetings.web.app.Application;
import org.apache.wicket.AttributeModifier;
import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.form.AjaxCheckBox;
@@ -68,9 +67,9 @@ public class CalendarDialog extends
AbstractFormDialog {
private CalendarPanel calendarPanel;
private final KendoFeedbackPanel feedback = new
KendoFeedbackPanel("feedback", new Options("button", true));
- private DialogButton save = new DialogButton("save",
Application.getString("144"));
- private DialogButton cancel = new DialogButton("cancel",
Application.getString("lbl.cancel"));
- private DialogButton delete = new DialogButton("delete",
Application.getString("80"));
+ private DialogButton save;
+ private DialogButton cancel;
+ private DialogButton delete;
private UserCalendarForm form;
private MessageDialog confirmDelete;
private List cals; //List of calendars for syncing
@@ -87,12 +86,20 @@ public class CalendarDialog extends
AbstractFormDialog {
private DIALOG_TYPE type = DIALOG_TYPE.UPDATE_CALENDAR;
private Appointment appointment = null;
- public CalendarDialog(String id, String title, final CalendarPanel
calendarPanel, CompoundPropertyModel model) {
- super(id, title, true);
+ public CalendarDialog(String id, final CalendarPanel calendarPanel,
CompoundPropertyModel model) {
+ super(id, "", true);
this.calendarPanel = calendarPanel;
form = new UserCalendarForm("calform", model);
add(form);
- confirmDelete = new MessageDialog("confirmDelete",
Application.getString("80"), Application.getString("833"),
DialogButtons.OK_CANCEL, DialogIcon.WARN) {
+ }
+
+ @Override
+ protected void onInitialize() {
+ getTitle().setObject(getString("calendar.dialogTitle"));
+ save = new DialogButton("save", getString("144"));
+ cancel = new DialogButton("cancel", getString("lbl.cancel"));
+ delete = new DialogButton("delete", getString("80"));
+ confirmDelete = new MessageDialog("confirmDelete",
getString("80"), getString("833"), DialogButtons.OK_CANCEL, DialogIcon.WARN) {
private static final long serialVersionUID = 1L;
@Override
@@ -105,6 +112,7 @@ public class CalendarDialog extends
AbstractFormDialog {
}
};
add(confirmDelete);
+ super.onInitialize();
}
/**
@@ -409,9 +417,9 @@ public class CalendarDialog extends
AbstractFormDialog {
RequiredTextField title = new
RequiredTextField<>("title");
// Fields required for adding Google Calendar
- Label urlLabel = new Label("urlLabel",
Application.getString("calendar.url")),
- userLabel = new Label("userLabel",
Application.getString("114")),
- passLabel = new Label("passLabel",
Application.getString("110"));
+ private Label urlLabel;
+ private Label userLabel;
+ private Label passLabel;
AjaxCheckBox gcal; // Checkbox for Google Calendar
UrlTextField url = new UrlTextField("url", Model.of(""), new
UrlValidator() {
@@ -438,6 +446,13 @@ public class CalendarDialog extends
AbstractFormDialog {
public UserCalendarForm(String id,
CompoundPropertyModel model) {
super(id, model);
setOutputMarkupId(true);
+ }
+
+ @Override
+ protected void onInitialize() {
+ urlLabel = new Label("urlLabel",
getString("calendar.url"));
+ userLabel = new Label("userLabel", getString("114"));
+
[jira] [Commented] (OPENMEETINGS-1790) Translations need to be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299849#comment-16299849 ] ASF subversion and git services commented on OPENMEETINGS-1790: --- Commit 0297c55c13bf075ac65935434db45eff4ad5f41d in openmeetings's branch refs/heads/4.0.x from [~solomax] [ https://git-wip-us.apache.org/repos/asf?p=openmeetings.git;h=0297c55 ] [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString > Translations need to be improved > > > Key: OPENMEETINGS-1790 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1790 > Project: Openmeetings > Issue Type: Improvement > Components: BuildsAndReleases >Affects Versions: 4.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik > Fix For: 4.0.2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[3/3] openmeetings git commit: [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString
[OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/e5ab7c55 Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/e5ab7c55 Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/e5ab7c55 Branch: refs/heads/master Commit: e5ab7c55e80a6e8eee04b1a8a3dfae7323e95044 Parents: 510c008 Author: Maxim Solodovnik Authored: Thu Dec 21 17:41:30 2017 +0700 Committer: Maxim Solodovnik Committed: Thu Dec 21 17:42:01 2017 +0700 -- .../openmeetings/web/admin/AdminSavePanel.java | 11 +- .../web/admin/backup/BackupPanel.java | 8 +- .../web/admin/configurations/ConfigForm.java| 83 +++--- .../web/admin/configurations/ConfigsPanel.java | 6 +- .../web/admin/labels/AddLanguageDialog.java | 12 +- .../web/admin/labels/LangPanel.java | 14 +- .../openmeetings/web/admin/ldaps/LdapForm.java | 10 +- .../web/admin/ldaps/LdapsPanel.java | 8 +- .../openmeetings/web/admin/oauth/OAuthForm.java | 31 ++- .../web/admin/oauth/OAuthPanel.java | 5 + .../openmeetings/web/admin/rooms/RoomForm.java | 7 +- .../openmeetings/web/admin/users/UserForm.java | 3 +- .../web/admin/users/UsersPanel.java | 22 +- .../web/app/Application.properties.xml | 12 + .../web/app/Application_ar.properties.xml | 14 +- .../web/app/Application_bg.properties.xml | 12 + .../web/app/Application_ca.properties.xml | 12 + .../web/app/Application_cs.properties.xml | 12 + .../web/app/Application_da.properties.xml | 12 + .../web/app/Application_de.properties.xml | 12 + .../web/app/Application_el.properties.xml | 12 + .../web/app/Application_es.properties.xml | 12 + .../web/app/Application_fa.properties.xml | 12 + .../web/app/Application_fi.properties.xml | 12 + .../web/app/Application_fr.properties.xml | 12 + .../web/app/Application_gl.properties.xml | 12 + .../web/app/Application_he.properties.xml | 12 + .../web/app/Application_hu.properties.xml | 12 + .../web/app/Application_id.properties.xml | 12 + .../web/app/Application_it.properties.xml | 12 + .../web/app/Application_ja.properties.xml | 12 + .../web/app/Application_ko.properties.xml | 12 + .../web/app/Application_nl.properties.xml | 12 + .../web/app/Application_pl.properties.xml | 12 + .../web/app/Application_pt.properties.xml | 12 + .../web/app/Application_pt_BR.properties.xml| 12 + .../web/app/Application_ru.properties.xml | 12 + .../web/app/Application_sk.properties.xml | 12 + .../web/app/Application_sv.properties.xml | 12 + .../web/app/Application_th.properties.xml | 12 + .../web/app/Application_tr.properties.xml | 12 + .../web/app/Application_uk.properties.xml | 12 + .../web/app/Application_zh_CN.properties.xml| 12 + .../web/app/Application_zh_TW.properties.xml| 12 + .../web/common/GeneralUserForm.java | 5 +- .../web/common/InvitationDialog.java| 18 +- .../openmeetings/web/common/InvitationForm.java | 15 +- .../openmeetings/web/common/MainPanel.java | 17 +- .../openmeetings/web/common/NameDialog.java | 12 +- .../web/common/tree/ConvertingErrorsDialog.java | 11 +- .../web/pages/InvitationPasswordDialog.java | 17 +- .../web/pages/auth/ForgetPasswordDialog.java| 9 +- .../web/pages/auth/RegisterDialog.java | 32 ++- .../web/pages/auth/ResetPasswordDialog.java | 9 +- .../web/pages/auth/SignInDialog.java| 37 ++- .../web/room/ExpiredMessageDialog.java | 9 +- .../openmeetings/web/room/NicknameDialog.java | 17 +- .../web/room/RedirectMessageDialog.java | 5 +- .../apache/openmeetings/web/room/SwfPanel.java | 5 +- .../web/room/menu/RoomInvitationForm.java | 9 +- .../web/room/menu/RoomMenuPanel.java| 251 ++- .../web/room/menu/SipDialerDialog.java | 9 +- .../web/room/menu/StartSharingButton.java | 8 +- .../web/room/poll/CreatePollDialog.java | 24 +- .../web/room/poll/PollResultsDialog.java| 76 +++--- .../openmeetings/web/room/poll/VoteDialog.java | 25 +- .../web/room/sidebar/RoomSidebar.java | 17 +- .../web/room/sidebar/UploadDialog.java | 31 ++- .../openmeetings/web/room/wb/WbPanel.java | 3 +- .../openmeetings/web/user/AboutDialog.java | 9 +- .../web/user/InviteUserMessageDialog.java | 15 +- .../web/user/InviteUserToRoomDialog.java| 20 +- .../openmeetings/web/user/MessageDialog.java| 15 +- .../openmeetings/web/user/UserInfoDialog.java | 20 +- .../web/user/calen
[1/3] openmeetings git commit: [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString
Repository: openmeetings
Updated Branches:
refs/heads/4.0.x dd125aead -> 0297c55c1
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/0297c55c/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
index 020b92d..1a8093b 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/calendar/CalendarDialog.java
@@ -30,7 +30,6 @@ import org.apache.openmeetings.db.dao.calendar.AppointmentDao;
import org.apache.openmeetings.db.entity.calendar.Appointment;
import org.apache.openmeetings.db.entity.calendar.OmCalendar;
import org.apache.openmeetings.service.calendar.caldav.AppointmentManager;
-import org.apache.openmeetings.web.app.Application;
import org.apache.wicket.AttributeModifier;
import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.form.AjaxCheckBox;
@@ -68,9 +67,9 @@ public class CalendarDialog extends
AbstractFormDialog {
private CalendarPanel calendarPanel;
private final KendoFeedbackPanel feedback = new
KendoFeedbackPanel("feedback", new Options("button", true));
- private DialogButton save = new DialogButton("save",
Application.getString("144"));
- private DialogButton cancel = new DialogButton("cancel",
Application.getString("lbl.cancel"));
- private DialogButton delete = new DialogButton("delete",
Application.getString("80"));
+ private DialogButton save;
+ private DialogButton cancel;
+ private DialogButton delete;
private UserCalendarForm form;
private MessageDialog confirmDelete;
private List cals; //List of calendars for syncing
@@ -87,12 +86,20 @@ public class CalendarDialog extends
AbstractFormDialog {
private DIALOG_TYPE type = DIALOG_TYPE.UPDATE_CALENDAR;
private Appointment appointment = null;
- public CalendarDialog(String id, String title, final CalendarPanel
calendarPanel, CompoundPropertyModel model) {
- super(id, title, true);
+ public CalendarDialog(String id, final CalendarPanel calendarPanel,
CompoundPropertyModel model) {
+ super(id, "", true);
this.calendarPanel = calendarPanel;
form = new UserCalendarForm("calform", model);
add(form);
- confirmDelete = new MessageDialog("confirmDelete",
Application.getString("80"), Application.getString("833"),
DialogButtons.OK_CANCEL, DialogIcon.WARN) {
+ }
+
+ @Override
+ protected void onInitialize() {
+ getTitle().setObject(getString("calendar.dialogTitle"));
+ save = new DialogButton("save", getString("144"));
+ cancel = new DialogButton("cancel", getString("lbl.cancel"));
+ delete = new DialogButton("delete", getString("80"));
+ confirmDelete = new MessageDialog("confirmDelete",
getString("80"), getString("833"), DialogButtons.OK_CANCEL, DialogIcon.WARN) {
private static final long serialVersionUID = 1L;
@Override
@@ -105,6 +112,7 @@ public class CalendarDialog extends
AbstractFormDialog {
}
};
add(confirmDelete);
+ super.onInitialize();
}
/**
@@ -409,9 +417,9 @@ public class CalendarDialog extends
AbstractFormDialog {
RequiredTextField title = new
RequiredTextField<>("title");
// Fields required for adding Google Calendar
- Label urlLabel = new Label("urlLabel",
Application.getString("calendar.url")),
- userLabel = new Label("userLabel",
Application.getString("114")),
- passLabel = new Label("passLabel",
Application.getString("110"));
+ private Label urlLabel;
+ private Label userLabel;
+ private Label passLabel;
AjaxCheckBox gcal; // Checkbox for Google Calendar
UrlTextField url = new UrlTextField("url", Model.of(""), new
UrlValidator() {
@@ -438,6 +446,13 @@ public class CalendarDialog extends
AbstractFormDialog {
public UserCalendarForm(String id,
CompoundPropertyModel model) {
super(id, model);
setOutputMarkupId(true);
+ }
+
+ @Override
+ protected void onInitialize() {
+ urlLabel = new Label("urlLabel",
getString("calendar.url"));
+ userLabel = new Label("userLabel", getString("114"));
+
[2/3] openmeetings git commit: [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/0297c55c/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
index 28c175f..611bd6e 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
@@ -100,10 +100,10 @@ public class MainPanel extends Panel {
private static final String DELIMITER = " ";
private final WebMarkupContainer EMPTY = new
WebMarkupContainer(CHILD_ID);
private String uid = null;
- private final MenuPanel menu;
+ private MenuPanel menu;
private final WebMarkupContainer topControls = new
WebMarkupContainer("topControls");
private final WebMarkupContainer topLinks = new
WebMarkupContainer("topLinks");
- private final MarkupContainer contents;
+ private final MarkupContainer contents = new
WebMarkupContainer("contents");
private ChatPanel chat;
private MessageDialog newMessage;
private UserInfoDialog userInfo;
@@ -129,8 +129,6 @@ public class MainPanel extends Panel {
setAuto(true);
setOutputMarkupId(true);
setOutputMarkupPlaceholderTag(true);
- menu = new MenuPanel("menu", getMainMenu());
- contents = new WebMarkupContainer("contents");
pingTimer.stop(null);
add(pingTimer, new WebSocketBehavior() {
private static final long serialVersionUID = 1L;
@@ -187,7 +185,7 @@ public class MainPanel extends Panel {
@Override
protected void onInitialize() {
- super.onInitialize();
+ menu = new MenuPanel("menu", getMainMenu());
add(topControls.setOutputMarkupPlaceholderTag(true).setMarkupId("topControls"));
add(contents.add(getClient() == null || panel == null ? EMPTY :
panel).setOutputMarkupId(true).setMarkupId("contents"));
topControls.add(menu.setVisible(false),
topLinks.setVisible(false).setOutputMarkupPlaceholderTag(true).setMarkupId("topLinks"));
@@ -301,6 +299,7 @@ public class MainPanel extends Panel {
setResponsePage(Application.get().getSignInPageClass());
}
});
+ super.onInitialize();
}
private IMenuItem getSubItem(String lbl, String title, MenuActions
action, MenuParams param) {
@@ -321,7 +320,7 @@ public class MainPanel extends Panel {
List l = new ArrayList<>();
l.add(getSubItem("290", "1450",
MenuActions.dashboardModuleStartScreen, null));
l.add(getSubItem("291", "1451",
MenuActions.dashboardModuleCalendar, null));
- mmenu.add(new OmMenuItem(Application.getString("124"),
l));
+ mmenu.add(new OmMenuItem(getString("124"), l));
}
{
// Conference Menu Points
@@ -346,13 +345,13 @@ public class MainPanel extends Panel {
}
});
}
- mmenu.add(new OmMenuItem(Application.getString("792"),
l));
+ mmenu.add(new OmMenuItem(getString("792"), l));
}
{
// Recording Menu Points
List l = new ArrayList<>();
l.add(getSubItem("395", "1452",
MenuActions.recordModule, null));
- mmenu.add(new OmMenuItem(Application.getString("395"),
l));
+ mmenu.add(new OmMenuItem(getString("395"), l));
}
Set r = WebSession.getRights();
boolean isAdmin = hasAdminLevel(r);
@@ -373,7 +372,7 @@ public class MainPanel extends Panel {
l.add(getSubItem("367", "1461",
MenuActions.adminModuleBackup, null));
l.add(getSubItem("main.menu.admin.email",
"main.menu.admin.email.desc", MenuActions.adminModuleEmail, null));
}
- mmenu.add(new OmMenuItem(Application.getString("6"),
l));
+ mmenu.add(new OmMenuItem(getString("6"), l));
}
return mmenu;
}
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/0297c55c/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/NameDialog.java
--
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/N
[3/3] openmeetings git commit: [OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString
[OPENMEETINGS-1790] getString should be used were it is possible instead of Application.getString Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/0297c55c Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/0297c55c Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/0297c55c Branch: refs/heads/4.0.x Commit: 0297c55c13bf075ac65935434db45eff4ad5f41d Parents: dd125ae Author: Maxim Solodovnik Authored: Thu Dec 21 17:41:30 2017 +0700 Committer: Maxim Solodovnik Committed: Thu Dec 21 17:41:30 2017 +0700 -- .../openmeetings/web/admin/AdminSavePanel.java | 11 +- .../web/admin/backup/BackupPanel.java | 8 +- .../web/admin/configurations/ConfigForm.java| 83 +++--- .../web/admin/configurations/ConfigsPanel.java | 6 +- .../web/admin/labels/AddLanguageDialog.java | 12 +- .../web/admin/labels/LangPanel.java | 14 +- .../openmeetings/web/admin/ldaps/LdapForm.java | 10 +- .../web/admin/ldaps/LdapsPanel.java | 8 +- .../openmeetings/web/admin/oauth/OAuthForm.java | 31 ++- .../web/admin/oauth/OAuthPanel.java | 5 + .../openmeetings/web/admin/rooms/RoomForm.java | 7 +- .../openmeetings/web/admin/users/UserForm.java | 3 +- .../web/admin/users/UsersPanel.java | 22 +- .../web/app/Application.properties.xml | 12 + .../web/app/Application_ar.properties.xml | 14 +- .../web/app/Application_bg.properties.xml | 12 + .../web/app/Application_ca.properties.xml | 12 + .../web/app/Application_cs.properties.xml | 12 + .../web/app/Application_da.properties.xml | 12 + .../web/app/Application_de.properties.xml | 12 + .../web/app/Application_el.properties.xml | 12 + .../web/app/Application_es.properties.xml | 12 + .../web/app/Application_fa.properties.xml | 12 + .../web/app/Application_fi.properties.xml | 12 + .../web/app/Application_fr.properties.xml | 12 + .../web/app/Application_gl.properties.xml | 12 + .../web/app/Application_he.properties.xml | 12 + .../web/app/Application_hu.properties.xml | 12 + .../web/app/Application_id.properties.xml | 12 + .../web/app/Application_it.properties.xml | 12 + .../web/app/Application_ja.properties.xml | 12 + .../web/app/Application_ko.properties.xml | 12 + .../web/app/Application_nl.properties.xml | 12 + .../web/app/Application_pl.properties.xml | 12 + .../web/app/Application_pt.properties.xml | 12 + .../web/app/Application_pt_BR.properties.xml| 12 + .../web/app/Application_ru.properties.xml | 12 + .../web/app/Application_sk.properties.xml | 12 + .../web/app/Application_sv.properties.xml | 12 + .../web/app/Application_th.properties.xml | 12 + .../web/app/Application_tr.properties.xml | 12 + .../web/app/Application_uk.properties.xml | 12 + .../web/app/Application_zh_CN.properties.xml| 12 + .../web/app/Application_zh_TW.properties.xml| 12 + .../web/common/GeneralUserForm.java | 5 +- .../web/common/InvitationDialog.java| 18 +- .../openmeetings/web/common/InvitationForm.java | 15 +- .../openmeetings/web/common/MainPanel.java | 17 +- .../openmeetings/web/common/NameDialog.java | 12 +- .../web/common/tree/ConvertingErrorsDialog.java | 11 +- .../web/pages/InvitationPasswordDialog.java | 17 +- .../web/pages/auth/ForgetPasswordDialog.java| 9 +- .../web/pages/auth/RegisterDialog.java | 32 ++- .../web/pages/auth/ResetPasswordDialog.java | 9 +- .../web/pages/auth/SignInDialog.java| 37 ++- .../web/room/ExpiredMessageDialog.java | 9 +- .../openmeetings/web/room/NicknameDialog.java | 17 +- .../web/room/RedirectMessageDialog.java | 5 +- .../apache/openmeetings/web/room/SwfPanel.java | 5 +- .../web/room/menu/RoomInvitationForm.java | 9 +- .../web/room/menu/RoomMenuPanel.java| 251 ++- .../web/room/menu/SipDialerDialog.java | 9 +- .../web/room/menu/StartSharingButton.java | 8 +- .../web/room/poll/CreatePollDialog.java | 24 +- .../web/room/poll/PollResultsDialog.java| 76 +++--- .../openmeetings/web/room/poll/VoteDialog.java | 25 +- .../web/room/sidebar/RoomSidebar.java | 17 +- .../web/room/sidebar/UploadDialog.java | 31 ++- .../openmeetings/web/room/wb/WbPanel.java | 3 +- .../openmeetings/web/user/AboutDialog.java | 9 +- .../web/user/InviteUserMessageDialog.java | 15 +- .../web/user/InviteUserToRoomDialog.java| 20 +- .../openmeetings/web/user/MessageDialog.java| 15 +- .../openmeetings/web/user/UserInfoDialog.java | 20 +- .../web/user/calend
[jira] [Resolved] (OPENMEETINGS-1798) errors when send email from OM
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-1798. Resolution: Information Provided This functionality works as expected for everybody This is why it is NOT OM issue but issue in configuration of your server According to the logs javax.mail is unable to get answer from mail server for reasonable amount of time This usually happens when FW blocks the request please contact mailing lists to get further help > errors when send email from OM > -- > > Key: OPENMEETINGS-1798 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1798 > Project: Openmeetings > Issue Type: Bug > Components: Email >Affects Versions: 4.0.0 > Environment: OM 4.0.0, Windows 10 Professional >Reporter: Prytsepov Andrey >Assignee: Maxim Solodovnik >Priority: Critical > > Minimal parameters are configured: > mail.smtp.server > mail.smtp.port > mail.smtp.system.email > mail.smtp.user > mail.smtp.pass > But i got errors when send message. I check availability smtp port and server > by telnet. I install thunderbird and check sending on the server with OM, > then i delete it after checking. I check conflicts port by cmd "netstat > -ano". All clear, but errors in OM: > javax.mail.MessagingException: Exception reading response; > nested exception is: > java.net.SocketTimeoutException: Read timed out > at > com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2445) > at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:2172) > at > com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:726) > at javax.mail.Service.connect(Service.java:388) > at javax.mail.Service.connect(Service.java:246) > at javax.mail.Service.connect(Service.java:195) > at javax.mail.Transport.send0(Transport.java:254) > at javax.mail.Transport.send(Transport.java:124) > at > org.apache.openmeetings.core.mail.MailHandler.lambda$send$0(MailHandler.java:250) > at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > Caused by: java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at java.net.SocketInputStream.socketRead(Unknown Source) > at java.net.SocketInputStream.read(Unknown Source) > at java.net.SocketInputStream.read(Unknown Source) > at com.sun.mail.util.TraceInputStream.read(TraceInputStream.java:126) > at java.io.BufferedInputStream.fill(Unknown Source) > at java.io.BufferedInputStream.read(Unknown Source) > at com.sun.mail.util.LineInputStream.readLine(LineInputStream.java:104) > at > com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2425) > ... 11 more > Second bug, that u see in errors "11 more" it is not clickable, so i can't > see all errors that system fixed in logs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (OPENMEETINGS-1798) errors when send email from OM
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prytsepov Andrey reopened OPENMEETINGS-1798: 1. As i say i install on OM server to check it Thunderbird and send email 2. Windows Firewall is off. On OM Server no Anti-virus programs. > errors when send email from OM > -- > > Key: OPENMEETINGS-1798 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1798 > Project: Openmeetings > Issue Type: Bug > Components: Email >Affects Versions: 4.0.0 > Environment: OM 4.0.0, Windows 10 Professional >Reporter: Prytsepov Andrey >Assignee: Maxim Solodovnik >Priority: Critical > > Minimal parameters are configured: > mail.smtp.server > mail.smtp.port > mail.smtp.system.email > mail.smtp.user > mail.smtp.pass > But i got errors when send message. I check availability smtp port and server > by telnet. I install thunderbird and check sending on the server with OM, > then i delete it after checking. I check conflicts port by cmd "netstat > -ano". All clear, but errors in OM: > javax.mail.MessagingException: Exception reading response; > nested exception is: > java.net.SocketTimeoutException: Read timed out > at > com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2445) > at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:2172) > at > com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:726) > at javax.mail.Service.connect(Service.java:388) > at javax.mail.Service.connect(Service.java:246) > at javax.mail.Service.connect(Service.java:195) > at javax.mail.Transport.send0(Transport.java:254) > at javax.mail.Transport.send(Transport.java:124) > at > org.apache.openmeetings.core.mail.MailHandler.lambda$send$0(MailHandler.java:250) > at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > Caused by: java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at java.net.SocketInputStream.socketRead(Unknown Source) > at java.net.SocketInputStream.read(Unknown Source) > at java.net.SocketInputStream.read(Unknown Source) > at com.sun.mail.util.TraceInputStream.read(TraceInputStream.java:126) > at java.io.BufferedInputStream.fill(Unknown Source) > at java.io.BufferedInputStream.read(Unknown Source) > at com.sun.mail.util.LineInputStream.readLine(LineInputStream.java:104) > at > com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2425) > ... 11 more > Second bug, that u see in errors "11 more" it is not clickable, so i can't > see all errors that system fixed in logs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
