[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098239#comment-17098239
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit 1685130be4fde2a9c166889069583d874b095e8a in openmeetings's branch 
refs/heads/feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal 
from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=1685130 ]

[OPENMEETINGS-2299] test should be fixed


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2275) Update whiteboard panel with proposal

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098243#comment-17098243
 ] 

ASF subversion and git services commented on OPENMEETINGS-2275:
---

Commit 044ffdc967da0cf6b67ab3cf9e1ddde1c6410bc4 in openmeetings's branch 
refs/heads/feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal 
from Sebastian Wagner
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=044ffdc ]

Merge branch 'master' into 
feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal


> Update whiteboard panel with proposal
> -
>
> Key: OPENMEETINGS-2275
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2275
> Project: Openmeetings
>  Issue Type: Bug
>  Components: UI, WhiteBoard
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Minor
> Fix For: 5.0.0-M5
>
>
> Proposed new design and behaviour:
> [https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+UI+and+UX+Style+Guide#OpenMeetingsUIandUXStyleGuide-Whiteboardtoolbarmenu]
> Mailing list discussion TBD



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098241#comment-17098241
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit 67a772eb41f164b6fe8023fd834a9fe4967f6b03 in openmeetings's branch 
refs/heads/feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal 
from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=67a772e ]

[OPENMEETINGS-2299] changes are reverted


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098242#comment-17098242
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit 0421988be9a6923b6f365a7094dde7c10e852a6e in openmeetings's branch 
refs/heads/feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal 
from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0421988 ]

[OPENMEETINGS-2299] test should be fixed


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098240#comment-17098240
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit bf421d8a72fb4868fb882bcaae2f40c3a38d58d4 in openmeetings's branch 
refs/heads/feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal 
from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=bf421d8 ]

[OPENMEETINGS-2299] test should be fixed


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal updated (0947371 -> 044ffdc)

2020-05-02 Thread sebawagner
This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a change to branch 
feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal
in repository https://gitbox.apache.org/repos/asf/openmeetings.git.


from 0947371  OPENMEETINGS-2275 Update whiteboard tools bar with proposed 
design changes.
 add 1685130  [OPENMEETINGS-2299] test should be fixed
 add bf421d8  [OPENMEETINGS-2299] test should be fixed
 add 67a772e  [OPENMEETINGS-2299] changes are reverted
 add 0421988  [OPENMEETINGS-2299] test should be fixed
 add 044ffdc  Merge branch 'master' into 
feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal

No new revisions were added by this update.

Summary of changes:
 .../org/apache/openmeetings/core/remote/BaseMockedTest.java |  5 +++--
 .../openmeetings/core/remote/TestRecordingFlowMocked.java   |  8 
 .../apache/openmeetings/core/remote/TestRoomFlowMocked.java | 10 +-
 .../openmeetings/core/remote/TestSetupFlowMocked.java   | 13 ++---
 .../apache/openmeetings/web/app/TestUserManagerMocked.java  |  5 +++--
 5 files changed, 21 insertions(+), 20 deletions(-)



[openmeetings] branch master updated: [OPENMEETINGS-2299] test should be fixed

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new 0421988  [OPENMEETINGS-2299] test should be fixed
0421988 is described below

commit 0421988be9a6923b6f365a7094dde7c10e852a6e
Author: Maxim Solodovnik 
AuthorDate: Sun May 3 10:06:24 2020 +0700

[OPENMEETINGS-2299] test should be fixed
---
 .../org/apache/openmeetings/core/remote/BaseMockedTest.java |  5 +++--
 .../openmeetings/core/remote/TestRecordingFlowMocked.java   |  8 
 .../apache/openmeetings/core/remote/TestRoomFlowMocked.java | 10 +-
 .../openmeetings/core/remote/TestSetupFlowMocked.java   | 13 ++---
 .../apache/openmeetings/web/app/TestUserManagerMocked.java  |  5 +++--
 5 files changed, 21 insertions(+), 20 deletions(-)

diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/BaseMockedTest.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/BaseMockedTest.java
index 84487ff..731a95b 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/BaseMockedTest.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/BaseMockedTest.java
@@ -21,6 +21,7 @@ package org.apache.openmeetings.core.remote;
 
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.nullable;
+import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.when;
 import static org.powermock.api.mockito.PowerMockito.mockStatic;
 
@@ -67,9 +68,9 @@ public class BaseMockedTest {
MockitoAnnotations.initMocks(this);
mockStatic(KurentoClient.class);
mockStatic(WebSocketHelper.class);
-   when(client.getServerManager()).thenReturn(kServerManager);
+   doReturn(kServerManager).when(client).getServerManager();
when(KurentoClient.create(nullable(String.class), 
any(KurentoConnectionListener.class))).thenReturn(client);
-   when(client.beginTransaction()).thenReturn(new 
TransactionImpl(romManager));
+   doReturn(new 
TransactionImpl(romManager)).when(client).beginTransaction();
handler.init();
}
 }
diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
index da50102..5f22af0 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
@@ -74,12 +74,12 @@ public class TestRecordingFlowMocked extends BaseMockedTest 
{
@Override
public void setup() {
super.setup();
-   
when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
+   
doReturn(mock(MediaPipeline.class)).when(client).createMediaPipeline(any(Transaction.class));
User u = new User();
u.setId(USER_ID);
u.setFirstname("firstname");
u.setLastname("lastname");
-   when(userDao.get(USER_ID)).thenReturn(u);
+   doReturn(u).when(userDao).get(USER_ID);
doReturn(true).when(handler).isConnected();

when(recDao.update(any(Recording.class))).thenAnswer((invocation) ->  {
Object[] args = invocation.getArguments();
@@ -93,7 +93,7 @@ public class TestRecordingFlowMocked extends BaseMockedTest {
 
// init client object for this test
c = getClientFull();
-   when(roomDao.get(ROOM_ID)).thenReturn(c.getRoom());
+   doReturn(c.getRoom()).when(roomDao).get(ROOM_ID);
 
// Mock out the methods that do webRTC
doReturn(null).when(streamProcessor).startBroadcast(any(), 
any(), any());
@@ -193,7 +193,7 @@ public class TestRecordingFlowMocked extends BaseMockedTest 
{
 
// Mock out the methods that would produce the Recording
Recording rec = new Recording();
-   when(recDao.get(Long.valueOf(1L))).thenReturn(rec);
+   doReturn(rec).when(recDao).get(Long.valueOf(1L));
 
// Mock out the method that would start recording

doReturn(true).when(streamProcessor).startConvertion(any(Recording.class));
diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
index 5f5061d..9a1cf0b 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
+++ 

[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098196#comment-17098196
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit 0421988be9a6923b6f365a7094dde7c10e852a6e in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0421988 ]

[OPENMEETINGS-2299] test should be fixed


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098190#comment-17098190
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit 67a772eb41f164b6fe8023fd834a9fe4967f6b03 in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=67a772e ]

[OPENMEETINGS-2299] changes are reverted


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch master updated: [OPENMEETINGS-2299] changes are reverted

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new 67a772e  [OPENMEETINGS-2299] changes are reverted
67a772e is described below

commit 67a772eb41f164b6fe8023fd834a9fe4967f6b03
Author: Maxim Solodovnik 
AuthorDate: Sun May 3 09:47:39 2020 +0700

[OPENMEETINGS-2299] changes are reverted
---
 .../org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java| 2 --
 .../java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java| 2 --
 .../java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java   | 2 --
 3 files changed, 6 deletions(-)

diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
index 46839ad..da50102 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
@@ -44,7 +44,6 @@ import org.apache.openmeetings.db.entity.user.User;
 import org.apache.openmeetings.db.manager.IClientManager;
 import org.junit.Test;
 import org.kurento.client.MediaPipeline;
-import org.kurento.client.ServerManager;
 import org.kurento.client.Transaction;
 import org.mockito.BDDMockito;
 import org.mockito.Mock;
@@ -75,7 +74,6 @@ public class TestRecordingFlowMocked extends BaseMockedTest {
@Override
public void setup() {
super.setup();
-   
when(client.getServerManager()).thenReturn(mock(ServerManager.class));

when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
User u = new User();
u.setId(USER_ID);
diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
index 484af03..5f5061d 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
@@ -40,7 +40,6 @@ import org.apache.openmeetings.db.entity.user.User;
 import org.apache.openmeetings.db.manager.IClientManager;
 import org.junit.Test;
 import org.kurento.client.MediaPipeline;
-import org.kurento.client.ServerManager;
 import org.kurento.client.Transaction;
 import org.mockito.BDDMockito;
 import org.mockito.Mock;
@@ -65,7 +64,6 @@ public class TestRoomFlowMocked extends BaseMockedTest {
@Override
public void setup() {
super.setup();
-   
when(client.getServerManager()).thenReturn(mock(ServerManager.class));

when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
User u = new User();
u.setId(USER_ID);
diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
index 7c61f5c..26956f4 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
@@ -35,7 +35,6 @@ import org.kurento.client.MediaPipeline;
 import org.kurento.client.MediaProfileSpecType;
 import org.kurento.client.PlayerEndpoint;
 import org.kurento.client.RecorderEndpoint;
-import org.kurento.client.ServerManager;
 import org.kurento.client.Transaction;
 import org.kurento.client.WebRtcEndpoint;
 
@@ -58,7 +57,6 @@ public class TestSetupFlowMocked extends BaseMockedTest {
 
@Test
public void testMsgTestRecord1() throws Exception {
-   
when(client.getServerManager()).thenReturn(mock(ServerManager.class));

when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
WebRtcEndpoint.Builder builder = 
mock(WebRtcEndpoint.Builder.class);

whenNew(WebRtcEndpoint.Builder.class).withArguments(any(MediaPipeline.class)).thenReturn(builder);



[openmeetings] branch master updated: [OPENMEETINGS-2299] test should be fixed

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new bf421d8  [OPENMEETINGS-2299] test should be fixed
bf421d8 is described below

commit bf421d8a72fb4868fb882bcaae2f40c3a38d58d4
Author: Maxim Solodovnik 
AuthorDate: Sun May 3 09:10:54 2020 +0700

[OPENMEETINGS-2299] test should be fixed
---
 .../java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java| 2 ++
 .../java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java   | 2 ++
 2 files changed, 4 insertions(+)

diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
index 5f5061d..484af03 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java
@@ -40,6 +40,7 @@ import org.apache.openmeetings.db.entity.user.User;
 import org.apache.openmeetings.db.manager.IClientManager;
 import org.junit.Test;
 import org.kurento.client.MediaPipeline;
+import org.kurento.client.ServerManager;
 import org.kurento.client.Transaction;
 import org.mockito.BDDMockito;
 import org.mockito.Mock;
@@ -64,6 +65,7 @@ public class TestRoomFlowMocked extends BaseMockedTest {
@Override
public void setup() {
super.setup();
+   
when(client.getServerManager()).thenReturn(mock(ServerManager.class));

when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
User u = new User();
u.setId(USER_ID);
diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
index 26956f4..7c61f5c 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestSetupFlowMocked.java
@@ -35,6 +35,7 @@ import org.kurento.client.MediaPipeline;
 import org.kurento.client.MediaProfileSpecType;
 import org.kurento.client.PlayerEndpoint;
 import org.kurento.client.RecorderEndpoint;
+import org.kurento.client.ServerManager;
 import org.kurento.client.Transaction;
 import org.kurento.client.WebRtcEndpoint;
 
@@ -57,6 +58,7 @@ public class TestSetupFlowMocked extends BaseMockedTest {
 
@Test
public void testMsgTestRecord1() throws Exception {
+   
when(client.getServerManager()).thenReturn(mock(ServerManager.class));

when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
WebRtcEndpoint.Builder builder = 
mock(WebRtcEndpoint.Builder.class);

whenNew(WebRtcEndpoint.Builder.class).withArguments(any(MediaPipeline.class)).thenReturn(builder);



[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098174#comment-17098174
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit bf421d8a72fb4868fb882bcaae2f40c3a38d58d4 in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=bf421d8 ]

[OPENMEETINGS-2299] test should be fixed


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch master updated: [OPENMEETINGS-2299] test should be fixed

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new 1685130  [OPENMEETINGS-2299] test should be fixed
1685130 is described below

commit 1685130be4fde2a9c166889069583d874b095e8a
Author: Maxim Solodovnik 
AuthorDate: Sun May 3 09:09:25 2020 +0700

[OPENMEETINGS-2299] test should be fixed
---
 .../org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java| 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
index da50102..46839ad 100644
--- 
a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
+++ 
b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
@@ -44,6 +44,7 @@ import org.apache.openmeetings.db.entity.user.User;
 import org.apache.openmeetings.db.manager.IClientManager;
 import org.junit.Test;
 import org.kurento.client.MediaPipeline;
+import org.kurento.client.ServerManager;
 import org.kurento.client.Transaction;
 import org.mockito.BDDMockito;
 import org.mockito.Mock;
@@ -74,6 +75,7 @@ public class TestRecordingFlowMocked extends BaseMockedTest {
@Override
public void setup() {
super.setup();
+   
when(client.getServerManager()).thenReturn(mock(ServerManager.class));

when(client.createMediaPipeline(any(Transaction.class))).thenReturn(mock(MediaPipeline.class));
User u = new User();
u.setId(USER_ID);



[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098171#comment-17098171
 ] 

ASF subversion and git services commented on OPENMEETINGS-2299:
---

Commit 1685130be4fde2a9c166889069583d874b095e8a in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=1685130 ]

[OPENMEETINGS-2299] test should be fixed


> Add more functional unit tests for Recording in room
> 
>
> Key: OPENMEETINGS-2299
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299
> Project: Openmeetings
>  Issue Type: Improvement
>  Components: Recordings
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Add more functional unit tests for the recording feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OPENMEETINGS-2343) Slight user and files menu header change

2020-05-02 Thread Sebastian Wagner (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wagner updated OPENMEETINGS-2343:
---
Description: Giving header minimum size and adding 20px.  (was: Giving 
header minimum size and adding 20px.

Mailing list discussion TBD)

> Slight user and files menu header change
> 
>
> Key: OPENMEETINGS-2343
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343
> Project: Openmeetings
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Minor
> Fix For: 5.0.0-M5
>
>
> Giving header minimum size and adding 20px.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OPENMEETINGS-2343) Slight user and files menu header change

2020-05-02 Thread Sebastian Wagner (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wagner updated OPENMEETINGS-2343:
---
Component/s: (was: WhiteBoard)

> Slight user and files menu header change
> 
>
> Key: OPENMEETINGS-2343
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343
> Project: Openmeetings
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Minor
> Fix For: 5.0.0-M5
>
>
> Proposed new design and behaviour:
> [https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+UI+and+UX+Style+Guide#OpenMeetingsUIandUXStyleGuide-Whiteboardtoolbarmenu]
> Mailing list discussion TBD



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OPENMEETINGS-2343) Slight user and files menu header change

2020-05-02 Thread Sebastian Wagner (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wagner updated OPENMEETINGS-2343:
---
Description: 
Giving header minimum size and adding 20px.

Mailing list discussion TBD

  was:
Proposed new design and behaviour:

[https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+UI+and+UX+Style+Guide#OpenMeetingsUIandUXStyleGuide-Whiteboardtoolbarmenu]

Mailing list discussion TBD


> Slight user and files menu header change
> 
>
> Key: OPENMEETINGS-2343
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343
> Project: Openmeetings
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Minor
> Fix For: 5.0.0-M5
>
>
> Giving header minimum size and adding 20px.
> Mailing list discussion TBD



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OPENMEETINGS-2343) Slight user and files menu header change

2020-05-02 Thread Sebastian Wagner (Jira)
Sebastian Wagner created OPENMEETINGS-2343:
--

 Summary: Slight user and files menu header change
 Key: OPENMEETINGS-2343
 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2343
 Project: Openmeetings
  Issue Type: Bug
  Components: UI, WhiteBoard
Affects Versions: 5.0.0-M3, 5.0.0-M4
Reporter: Sebastian Wagner
Assignee: Sebastian Wagner
 Fix For: 5.0.0-M5


Proposed new design and behaviour:

[https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+UI+and+UX+Style+Guide#OpenMeetingsUIandUXStyleGuide-Whiteboardtoolbarmenu]

Mailing list discussion TBD



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2275) Update whiteboard panel with proposal

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098138#comment-17098138
 ] 

ASF subversion and git services commented on OPENMEETINGS-2275:
---

Commit 0947371cd534662fba370724d9da6c50b2e0192b in openmeetings's branch 
refs/heads/feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal 
from Sebastian Wagner
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0947371 ]

OPENMEETINGS-2275 Update whiteboard tools bar with proposed design changes.


> Update whiteboard panel with proposal
> -
>
> Key: OPENMEETINGS-2275
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2275
> Project: Openmeetings
>  Issue Type: Bug
>  Components: UI, WhiteBoard
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Minor
> Fix For: 5.0.0-M5
>
>
> Proposed new design and behaviour:
> [https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+UI+and+UX+Style+Guide#OpenMeetingsUIandUXStyleGuide-Whiteboardtoolbarmenu]
> Mailing list discussion TBD



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal created (now 0947371)

2020-05-02 Thread sebawagner
This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a change to branch 
feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal
in repository https://gitbox.apache.org/repos/asf/openmeetings.git.


  at 0947371  OPENMEETINGS-2275 Update whiteboard tools bar with proposed 
design changes.

This branch includes the following new commits:

 new 0947371  OPENMEETINGS-2275 Update whiteboard tools bar with proposed 
design changes.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[openmeetings] 01/01: OPENMEETINGS-2275 Update whiteboard tools bar with proposed design changes.

2020-05-02 Thread sebawagner
This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a commit to branch 
feature/OPENMEETINGS-2275-update-whiteboard-tool-panel-with-proposal
in repository https://gitbox.apache.org/repos/asf/openmeetings.git

commit 0947371cd534662fba370724d9da6c50b2e0192b
Author: Sebastian Wagner 
AuthorDate: Sun May 3 11:42:29 2020 +1200

OPENMEETINGS-2275 Update whiteboard tools bar with proposed design changes.
---
 .../apache/openmeetings/web/room/wb/WbPanel.html   | 58 +++---
 .../apache/openmeetings/web/room/wb/raw-wb-area.js |  1 +
 .../openmeetings/web/room/wb/raw-wb-board.js   | 14 +-
 openmeetings-web/src/main/webapp/css/raw-wb.css| 13 +
 4 files changed, 56 insertions(+), 30 deletions(-)

diff --git 
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/WbPanel.html
 
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/WbPanel.html
index 15c7970..4e5f7fb 100644
--- 
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/WbPanel.html
+++ 
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/WbPanel.html
@@ -81,7 +81,7 @@



-   
+   



@@ -90,7 +90,7 @@



-   
+   



@@ -105,39 +105,41 @@
1


-   
+   





-   
-   
-   
-   
-   
-   
-   
-   
-   
-   120%
-   50%
-   75%
-   100%
-   125%
-   150%
-   200%
-   300%
-   400%
-   
-   
-   
-   
-   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   120%
+   50%
+   75%
+   100%
+   125%
+   150%
+   200%
+   300%
+   400%
+   
+   
+   
+   
+   
+   


-   
-   
+   
+   



diff --git 
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
 
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
index 0770af9..f3d7ed6 100644
--- 
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
+++ 
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
@@ -232,6 +232,7 @@ var DrawWbArea = function() {

[jira] [Comment Edited] (OPENMEETINGS-2331) KMS connectivity isn't auto-recovering

2020-05-02 Thread Konstantin Kuzov (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098123#comment-17098123
 ] 

Konstantin Kuzov edited comment on OPENMEETINGS-2331 at 5/2/20, 11:01 PM:
--

On build #3175 it's even somewhat worse: [https://pastebin.com/xsCyvWUx]. Same 
test case of restarting KMS during already running OM with couple of users in 
the same chat-room.
After KMS restart stacktraces [1] and [2] from pastedbin starts spamming for a 
while. At user activity [3] stacktrace appears. If users try to exit through 
exit button they get invalid page error and "ghost" user appears. If they try 
refresh by F5 then same stuck user but without error page. After some time 
reconnection attempts gave up so there are no more [1]. Also there are no more 
"Media Server is not accessible" messages nor on clients nor in log after bunch 
of initial ones.

Full log with two consecutive tests 
[here|https://nosferatu.g0x.ru/openmeetings.log]. Both failed.


was (Author: nosferatu):
On build #3175 it's even somewhat worse: [https://pastebin.com/xsCyvWUx]. Same 
test case of restarting KMS during already running OM with couple of users in 
the same chat-room.
After KMS restart stacktraces [1] and [2] from pastedbin starts spamming for a 
while. At user activity [3] stacktrace appears. If users try to exit through 
exit button they get invalid page error and "ghost" user appears. If they try 
refresh by F5 then same stuck user but without error page. After some time 
reconnection attempts gave up so there are no more [1].

Full log with two consecutive tests 
[here|https://nosferatu.g0x.ru/openmeetings.log]. Both failed.

> KMS connectivity isn't auto-recovering
> --
>
> Key: OPENMEETINGS-2331
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2331
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Kurento
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> If OM was started after Kurento Media Server then all is well and dandy. But 
> if KMS was started after OM or was restarted for some reason later (for 
> example due to update or crash) then OM will never recover from that and 
> currently require full OM restart.
> There should be some auto-recovery mechanism in place which will continuously 
> try to reinitiate connection (with configurable intervals) to KMS until a new 
> connection is established.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OPENMEETINGS-2342) whiteboard at the moment of loading for the first time the classroom remains the background of the modalbox

2020-05-02 Thread Jira
Jorge Alberto Londoño Giraldo created OPENMEETINGS-2342:
---

 Summary: whiteboard at the moment of loading for the first time 
the classroom remains the background of the modalbox 
 Key: OPENMEETINGS-2342
 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2342
 Project: Openmeetings
  Issue Type: Test
  Components: WhiteBoard
Affects Versions: 5.0.0-M4
 Environment: Ubuntu 18.04 AWS lightsail instance 8 GB RAM, 2 vCPU, 160 
GB SSD 
Reporter: Jorge Alberto Londoño Giraldo
Assignee: Maxim Solodovnik
 Attachments: error-modalbox.png

Hello, at the moment of loading the event of the videoconference with video and 
whiteboard at the moment of loading for the first time the classroom remains 
the background of the modalbox (modal-backdrop) 

of the time zone and does not allow to interact with any element. the classroom 
must be recharged to start using it. I attach the screenshot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OPENMEETINGS-2331) KMS connectivity isn't auto-recovering

2020-05-02 Thread Konstantin Kuzov (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konstantin Kuzov reopened OPENMEETINGS-2331:


> KMS connectivity isn't auto-recovering
> --
>
> Key: OPENMEETINGS-2331
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2331
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Kurento
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> If OM was started after Kurento Media Server then all is well and dandy. But 
> if KMS was started after OM or was restarted for some reason later (for 
> example due to update or crash) then OM will never recover from that and 
> currently require full OM restart.
> There should be some auto-recovery mechanism in place which will continuously 
> try to reinitiate connection (with configurable intervals) to KMS until a new 
> connection is established.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2331) KMS connectivity isn't auto-recovering

2020-05-02 Thread Konstantin Kuzov (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098123#comment-17098123
 ] 

Konstantin Kuzov commented on OPENMEETINGS-2331:


On build #3175 it's even somewhat worse: [https://pastebin.com/xsCyvWUx]. Same 
test case of restarting KMS during already running OM with couple of users in 
the same chat-room.
After KMS restart stacktraces [1] and [2] from pastedbin starts spamming for a 
while. At user activity [3] stacktrace appears. If users try to exit through 
exit button they get invalid page error and "ghost" user appears. If they try 
refresh by F5 then same stuck user but without error page. After some time 
reconnection attempts gave up so there are no more [1].

Full log with two consecutive tests 
[here|https://nosferatu.g0x.ru/openmeetings.log]. Both failed.

> KMS connectivity isn't auto-recovering
> --
>
> Key: OPENMEETINGS-2331
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2331
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Kurento
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> If OM was started after Kurento Media Server then all is well and dandy. But 
> if KMS was started after OM or was restarted for some reason later (for 
> example due to update or crash) then OM will never recover from that and 
> currently require full OM restart.
> There should be some auto-recovery mechanism in place which will continuously 
> try to reinitiate connection (with configurable intervals) to KMS until a new 
> connection is established.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OPENMEETINGS-2281) Android Media Stream gets interrupted and cannot playback remote audio/video

2020-05-02 Thread Sebastian Wagner (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wagner closed OPENMEETINGS-2281.
--
Resolution: Won't Fix

> Android Media Stream gets interrupted and cannot playback remote audio/video
> 
>
> Key: OPENMEETINGS-2281
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2281
> Project: Openmeetings
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 5.0.0-M3, 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: image-2020-04-27-15-42-24-953.png
>
>
> In Android+Chrome whenever visiting a room with a video, the video will start 
> and after 3-5 sec there is an error saying the Media Connection is lost.
> I need to somehow capture some log(s). And/or screen capture. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2253) Interruption of a video session when the microphone is turned on / off

2020-05-02 Thread Sebastian Wagner (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098105#comment-17098105
 ] 

Sebastian Wagner commented on OPENMEETINGS-2253:


There seems to be a ref in our webRTC wrapper library:

[https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/adapter-latest.js#L1672]

> Interruption of a video session when the microphone is turned on / off
> --
>
> Key: OPENMEETINGS-2253
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2253
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M3
> Environment: Chrome, FF
>Reporter: Evgeny
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: icon_example.png
>
>
> Hello!
> 1. The participant turns on the camera - a camera window appears.
> 2. The participant turns on / off the microphone - the camera window closes, 
> after a delay of 2-3 seconds it opens, with a change from its original 
> position.
>  Each time the microphone is turned on / off, there is a delay and jerking of 
> the camera window of the conference participant, with the transition to the 
> default position.
> For other participants, the camera of this participant also disappears on the 
> screen.
>  Please make one button to turn on / off together - both the camera and the 
> microphone. Or a hotkey. So that the participant at the beginning and at the 
> end of the conversation does not press the camera and microphone separately 
> on the buttons.
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OPENMEETINGS-2327) Error while opening encoder for output stream #0:0

2020-05-02 Thread Maxim Solodovnik (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim Solodovnik resolved OPENMEETINGS-2327.

Fix Version/s: 5.0.0-M5
   Resolution: Fixed

Should be fixed
[~khvalera] please verify, I was unable to reproduce :((

> Error while opening encoder for output stream #0:0
> --
>
> Key: OPENMEETINGS-2327
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2327
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M4
>Reporter: khvalera
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> When recording, I periodically get an error:
> {code}
> process: generate MP4
> command: ffmpeg -y -itsoffset 00:00:01.436 -i 
> /opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b.webm
>  -i 
> /opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b_FINAL_WAVE.wav
>  -c:v h264 -crf 24 -vsync 0 -pix_fmt yuv420p -preset superfast -profile:v 
> baseline -level 3.0 -movflags faststart -c:a aac -ar 22050 -b:a 32k 
> /opt/openmeetings/webapps/openmeetings/data/streams/hibernate/53dff839-a8ee-4e2a-90e5-f66559ea4f71.mp4
>  
> exception: null
> error: ffmpeg version n4.2.2 Copyright (c) 2000-2019 the FFmpeg developers
>  built with gcc 9.3.0 (Arch Linux 9.3.0-1)
>  configuration: --prefix=/usr --disable-debug --disable-static 
> --disable-stripping --enable-fontconfig --enable-gmp --enable-gnutls 
> --enable-gpl --enable-ladspa --enable-libaom --enable-libass 
> --enable-libbluray --enable-libdav1d --enable-libdrm --enable-libfreetype 
> --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack 
> --enable-libmfx --enable-libmodplug --enable-libmp3lame 
> --enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg 
> --enable-libopus --enable-libpulse --enable-libsoxr --enable-libspeex 
> --enable-libsrt --enable-libssh --enable-libtheora --enable-libv4l2 
> --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwebp 
> --enable-libx264 --enable-libx265 --enable-libxcb --enable-libxml2 
> --enable-libxvid --enable-nvdec --enable-nvenc --enable-omx --enable-shared 
> --enable-version3
>  libavutil 56. 31.100 / 56. 31.100
>  libavcodec 58. 54.100 / 58. 54.100
>  libavformat 58. 29.100 / 58. 29.100
>  libavdevice 58. 8.100 / 58. 8.100
>  libavfilter 7. 57.100 / 7. 57.100
>  libswscale 5. 5.100 / 5. 5.100
>  libswresample 3. 5.100 / 3. 5.100
>  libpostproc 55. 5.100 / 55. 5.100
> Input #0, matroska,webm, from 
> '/opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b.webm':
>  Metadata:
>  encoder : GStreamer matroskamux version 1.16.2
>  creation_time : 2020-04-30T17:03:07.00Z
>  Duration: 00:00:13.93, start: 0.00, bitrate: 901 kb/s
>  Stream #0:0(eng): Video: vp8, yuv420p(progressive), 1920x1011, SAR 1:1 DAR 
> 640:337, 9 fps, 9.25 tbr, 1k tbn, 1k tbc (default)
>  Metadata:
>  title : Video
> Guessed Channel Layout for Input Stream #1.0 : stereo
> Input #1, wav, from 
> '/opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b_FINAL_WAVE.wav':
>  Duration: 00:00:15.00, bitrate: 1024 kb/s
>  Stream #1:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 32000 Hz, stereo, 
> s16, 1024 kb/s
> Stream mapping:
>  Stream #0:0 -> #0:0 (vp8 (native) -> h264 (libx264))
>  Stream #1:0 -> #0:1 (pcm_s16le (native) -> aac (native))
> Press [q] to stop, [?] for help
> [libx264 @ 0x556e7c061b00] height not divisible by 2 (1920x1011)
> Error initializing output stream 0:0 -- Error while opening encoder for 
> output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width 
> or height
> Conversion failed!
> exitValue: 1
> optional: false
> out:
> process: generate preview PNG :: 53dff839-a8ee-4e2a-90e5-f66559ea4f71
> command: ffmpeg -y -i 
> /opt/openmeetings/webapps/openmeetings/data/streams/hibernate/53dff839-a8ee-4e2a-90e5-f66559ea4f71.mp4
>  -vf thumbnail,scale=640:-1 -frames:v 1 
> /opt/openmeetings/webapps/openmeetings/data/streams/hibernate/53dff839-a8ee-4e2a-90e5-f66559ea4f71.png
>  
> exception: null
> error: ffmpeg version n4.2.2 Copyright (c) 2000-2019 the FFmpeg developers
>  built with gcc 9.3.0 (Arch Linux 9.3.0-1)
>  configuration: --prefix=/usr --disable-debug --disable-static 
> --disable-stripping --enable-fontconfig --enable-gmp --enable-gnutls 
> --enable-gpl --enable-ladspa --enable-libaom --enable-libass 
> --enable-libbluray --enable-libdav1d --enable-libdrm --enable-libfreetype 
> --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack 
> --enable-libmfx --enable-libmodplug --enable-libmp3lame 
> --enable-libopencore_amrnb 

[jira] [Commented] (OPENMEETINGS-2327) Error while opening encoder for output stream #0:0

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098042#comment-17098042
 ] 

ASF subversion and git services commented on OPENMEETINGS-2327:
---

Commit ba0d7f3a3ec387f1f78152a2f64652127373f0c5 in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ba0d7f3 ]

[OPENMEETINGS-2327] video dimentions are corrected to be dividable by 2


> Error while opening encoder for output stream #0:0
> --
>
> Key: OPENMEETINGS-2327
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2327
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M4
>Reporter: khvalera
>Assignee: Maxim Solodovnik
>Priority: Major
>
> When recording, I periodically get an error:
> {code}
> process: generate MP4
> command: ffmpeg -y -itsoffset 00:00:01.436 -i 
> /opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b.webm
>  -i 
> /opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b_FINAL_WAVE.wav
>  -c:v h264 -crf 24 -vsync 0 -pix_fmt yuv420p -preset superfast -profile:v 
> baseline -level 3.0 -movflags faststart -c:a aac -ar 22050 -b:a 32k 
> /opt/openmeetings/webapps/openmeetings/data/streams/hibernate/53dff839-a8ee-4e2a-90e5-f66559ea4f71.mp4
>  
> exception: null
> error: ffmpeg version n4.2.2 Copyright (c) 2000-2019 the FFmpeg developers
>  built with gcc 9.3.0 (Arch Linux 9.3.0-1)
>  configuration: --prefix=/usr --disable-debug --disable-static 
> --disable-stripping --enable-fontconfig --enable-gmp --enable-gnutls 
> --enable-gpl --enable-ladspa --enable-libaom --enable-libass 
> --enable-libbluray --enable-libdav1d --enable-libdrm --enable-libfreetype 
> --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack 
> --enable-libmfx --enable-libmodplug --enable-libmp3lame 
> --enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg 
> --enable-libopus --enable-libpulse --enable-libsoxr --enable-libspeex 
> --enable-libsrt --enable-libssh --enable-libtheora --enable-libv4l2 
> --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwebp 
> --enable-libx264 --enable-libx265 --enable-libxcb --enable-libxml2 
> --enable-libxvid --enable-nvdec --enable-nvenc --enable-omx --enable-shared 
> --enable-version3
>  libavutil 56. 31.100 / 56. 31.100
>  libavcodec 58. 54.100 / 58. 54.100
>  libavformat 58. 29.100 / 58. 29.100
>  libavdevice 58. 8.100 / 58. 8.100
>  libavfilter 7. 57.100 / 7. 57.100
>  libswscale 5. 5.100 / 5. 5.100
>  libswresample 3. 5.100 / 3. 5.100
>  libpostproc 55. 5.100 / 55. 5.100
> Input #0, matroska,webm, from 
> '/opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b.webm':
>  Metadata:
>  encoder : GStreamer matroskamux version 1.16.2
>  creation_time : 2020-04-30T17:03:07.00Z
>  Duration: 00:00:13.93, start: 0.00, bitrate: 901 kb/s
>  Stream #0:0(eng): Video: vp8, yuv420p(progressive), 1920x1011, SAR 1:1 DAR 
> 640:337, 9 fps, 9.25 tbr, 1k tbn, 1k tbc (default)
>  Metadata:
>  title : Video
> Guessed Channel Layout for Input Stream #1.0 : stereo
> Input #1, wav, from 
> '/opt/openmeetings/webapps/openmeetings/data/streams/1/rec_27_6233f6ad-ed16-4f2b-9209-38bce2c4914b_FINAL_WAVE.wav':
>  Duration: 00:00:15.00, bitrate: 1024 kb/s
>  Stream #1:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 32000 Hz, stereo, 
> s16, 1024 kb/s
> Stream mapping:
>  Stream #0:0 -> #0:0 (vp8 (native) -> h264 (libx264))
>  Stream #1:0 -> #0:1 (pcm_s16le (native) -> aac (native))
> Press [q] to stop, [?] for help
> [libx264 @ 0x556e7c061b00] height not divisible by 2 (1920x1011)
> Error initializing output stream 0:0 -- Error while opening encoder for 
> output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width 
> or height
> Conversion failed!
> exitValue: 1
> optional: false
> out:
> process: generate preview PNG :: 53dff839-a8ee-4e2a-90e5-f66559ea4f71
> command: ffmpeg -y -i 
> /opt/openmeetings/webapps/openmeetings/data/streams/hibernate/53dff839-a8ee-4e2a-90e5-f66559ea4f71.mp4
>  -vf thumbnail,scale=640:-1 -frames:v 1 
> /opt/openmeetings/webapps/openmeetings/data/streams/hibernate/53dff839-a8ee-4e2a-90e5-f66559ea4f71.png
>  
> exception: null
> error: ffmpeg version n4.2.2 Copyright (c) 2000-2019 the FFmpeg developers
>  built with gcc 9.3.0 (Arch Linux 9.3.0-1)
>  configuration: --prefix=/usr --disable-debug --disable-static 
> --disable-stripping --enable-fontconfig --enable-gmp --enable-gnutls 
> --enable-gpl --enable-ladspa --enable-libaom --enable-libass 
> --enable-libbluray --enable-libdav1d --enable-libdrm --enable-libfreetype 
> 

[openmeetings] branch master updated: [OPENMEETINGS-2327] video dimentions are corrected to be dividable by 2

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new ba0d7f3  [OPENMEETINGS-2327] video dimentions are corrected to be 
dividable by 2
ba0d7f3 is described below

commit ba0d7f3a3ec387f1f78152a2f64652127373f0c5
Author: Maxim Solodovnik 
AuthorDate: Sun May 3 00:45:20 2020 +0700

[OPENMEETINGS-2327] video dimentions are corrected to be dividable by 2
---
 .../openmeetings/core/converter/BaseConverter.java | 23 +++---
 .../core/converter/VideoConverter.java |  4 +++-
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/BaseConverter.java
 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/BaseConverter.java
index cbcc7d2..5599b11 100644
--- 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/BaseConverter.java
+++ 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/BaseConverter.java
@@ -315,17 +315,18 @@ public abstract class BaseConverter {
 
private List addMp4OutParams(Recording r, List argv, 
String mp4path) {
argv.addAll(List.of(
-   "-c:v", "h264", //
-   "-crf", "24",
-   "-vsync", "0",
-   "-pix_fmt", "yuv420p",
-   "-preset", getVideoPreset(),
-   "-profile:v", "baseline",
-   "-level", "3.0",
-   "-movflags", "faststart",
-   "-c:a", "aac",
-   "-ar", String.valueOf(getAudioRate()),
-   "-b:a", getAudioBitrate()
+   "-c:v", "h264" //
+   , "-crf", "24"
+   , "-vsync", "0"
+   , "-pix_fmt", "yuv420p"
+   , "-vf", "pad=ceil(iw/2)*2:ceil(ih/2)*2"
+   , "-preset", getVideoPreset()
+   , "-profile:v", "baseline"
+   , "-level", "3.0"
+   , "-movflags", "faststart"
+   , "-c:a", "aac"
+   , "-ar", String.valueOf(getAudioRate())
+   , "-b:a", getAudioBitrate()
));
argv.addAll(additionalMp4OutParams(r));
argv.add(mp4path);
diff --git 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/VideoConverter.java
 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/VideoConverter.java
index 660b568..0f444ae 100644
--- 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/VideoConverter.java
+++ 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/converter/VideoConverter.java
@@ -69,7 +69,9 @@ public class VideoConverter extends BaseConverter {
args.addAll(List.of("-i", input //
, "-c:v", "h264" //
, "-c:a", "aac" //
-   , "-pix_fmt", "yuv420p"));
+   , "-pix_fmt", "yuv420p"
+   , "-vf", "pad=ceil(iw/2)*2:ceil(ih/2)*2"
+   ));
if (sf.isAudio()) {
args.add("-shortest");
}



[jira] [Resolved] (OPENMEETINGS-2337) UI in room entered via invitation link generates different JS in modal close icon

2020-05-02 Thread Maxim Solodovnik (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim Solodovnik resolved OPENMEETINGS-2337.

Resolution: Fixed

> UI in room entered via invitation link generates different JS in modal close 
> icon
> -
>
> Key: OPENMEETINGS-2337
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2337
> Project: Openmeetings
>  Issue Type: Bug
>Affects Versions: 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: image-2020-05-02-09-59-36-627.png, 
> image-2020-05-02-10-01-58-944.png
>
>
> There is a strange issue in some of the Javascript if you enter via the 
> invitation Hash/link.
> The button to close the modal is missing the close icon.
> The close button on the top right of the ui dialog. Seems like a jQuery issue.
> Not sure if it has anything to do with CSP headers. But those warnings seem 
> only CSS errors. No JS, and below looks like different HTML is generated by 
> jQuery.
>  
> When inspecting the HTML it actually generates different HTML in the UI if 
> you enter via invitation link:
> {code:java}
> 
> {code}
> Screenshot:
> !image-2020-05-02-10-01-58-944.png|width=594,height=330!
>  
> Normally it would be:
> {code:java}
> 
>
> 
>"Close"
> 
> {code}
> !image-2020-05-02-09-59-36-627.png|width=603,height=370!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch master updated: [OPENMEETINGS-2337] bootstrap goes first, minor NPE issue is fixed

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new 7d2a4f8  [OPENMEETINGS-2337] bootstrap goes first, minor NPE issue is 
fixed
7d2a4f8 is described below

commit 7d2a4f859f8dc27fd7ce6876c9b02ea40511d15a
Author: Maxim Solodovnik 
AuthorDate: Sun May 3 00:33:35 2020 +0700

[OPENMEETINGS-2337] bootstrap goes first, minor NPE issue is fixed
---
 .../java/org/apache/openmeetings/core/remote/StreamProcessor.java | 3 +++
 .../main/java/org/apache/openmeetings/web/common/MainPanel.java   | 8 
 2 files changed, 11 insertions(+)

diff --git 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
index caceb36..4fa49fe 100644
--- 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
+++ 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
@@ -128,6 +128,9 @@ public class StreamProcessor implements IStreamProcessor {
if (sender != null) {
Client sendClient = 
cm.getBySid(sender.getSid());
sd = 
sendClient.getStream(sender.getUid());
+   if (sd == null) {
+   break;
+   }
if (StreamType.SCREEN == sd.getType() 
&& sd.hasActivity(Activity.RECORD) && !sd.hasActivity(Activity.SCREEN)) {
break;
}
diff --git 
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
 
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
index cd0b90b..ed16515 100644
--- 
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
+++ 
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/MainPanel.java
@@ -72,6 +72,7 @@ import org.apache.wicket.ajax.markup.html.AjaxLink;
 import org.apache.wicket.core.request.handler.IPartialPageRequestHandler;
 import org.apache.wicket.devutils.debugbar.DebugBar;
 import org.apache.wicket.markup.head.IHeaderResponse;
+import org.apache.wicket.markup.head.JavaScriptHeaderItem;
 import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
 import org.apache.wicket.markup.head.PriorityHeaderItem;
 import org.apache.wicket.markup.html.WebMarkupContainer;
@@ -89,6 +90,7 @@ import org.wicketstuff.urlfragment.UrlFragment;
 import com.github.openjson.JSONObject;
 
 import 
de.agilecoders.wicket.core.markup.html.bootstrap.navbar.INavbarComponent;
+import 
de.agilecoders.wicket.core.markup.html.references.BootstrapJavaScriptReference;
 
 public class MainPanel extends Panel {
private static final long serialVersionUID = 1L;
@@ -291,6 +293,12 @@ public class MainPanel extends Panel {
topLinks.add(logout);
}
 
+   @Override
+   public void renderHead(IHeaderResponse response) {
+   response.render(new 
PriorityHeaderItem(JavaScriptHeaderItem.forReference(BootstrapJavaScriptReference.instance(;
 //this one should go before jquery-ui
+   super.renderHead(response);
+   }
+
private OmMenuItem getSubItem(String lbl, String title, MenuActions 
action) {
return new MainMenuItem(lbl, title, action) {
private static final long serialVersionUID = 1L;



[jira] [Commented] (OPENMEETINGS-2337) UI in room entered via invitation link generates different JS in modal close icon

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098035#comment-17098035
 ] 

ASF subversion and git services commented on OPENMEETINGS-2337:
---

Commit 7d2a4f859f8dc27fd7ce6876c9b02ea40511d15a in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=7d2a4f8 ]

[OPENMEETINGS-2337] bootstrap goes first, minor NPE issue is fixed


> UI in room entered via invitation link generates different JS in modal close 
> icon
> -
>
> Key: OPENMEETINGS-2337
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2337
> Project: Openmeetings
>  Issue Type: Bug
>Affects Versions: 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: image-2020-05-02-09-59-36-627.png, 
> image-2020-05-02-10-01-58-944.png
>
>
> There is a strange issue in some of the Javascript if you enter via the 
> invitation Hash/link.
> The button to close the modal is missing the close icon.
> The close button on the top right of the ui dialog. Seems like a jQuery issue.
> Not sure if it has anything to do with CSP headers. But those warnings seem 
> only CSS errors. No JS, and below looks like different HTML is generated by 
> jQuery.
>  
> When inspecting the HTML it actually generates different HTML in the UI if 
> you enter via invitation link:
> {code:java}
> 
> {code}
> Screenshot:
> !image-2020-05-02-10-01-58-944.png|width=594,height=330!
>  
> Normally it would be:
> {code:java}
> 
>
> 
>"Close"
> 
> {code}
> !image-2020-05-02-09-59-36-627.png|width=603,height=370!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2337) UI in room entered via invitation link generates different JS in modal close icon

2020-05-02 Thread Maxim Solodovnik (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098029#comment-17098029
 ] 

Maxim Solodovnik commented on OPENMEETINGS-2337:


https://stackoverflow.com/questions/17367736/jquery-ui-dialog-missing-close-icon

> UI in room entered via invitation link generates different JS in modal close 
> icon
> -
>
> Key: OPENMEETINGS-2337
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2337
> Project: Openmeetings
>  Issue Type: Bug
>Affects Versions: 5.0.0-M4
>Reporter: Sebastian Wagner
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: image-2020-05-02-09-59-36-627.png, 
> image-2020-05-02-10-01-58-944.png
>
>
> There is a strange issue in some of the Javascript if you enter via the 
> invitation Hash/link.
> The button to close the modal is missing the close icon.
> The close button on the top right of the ui dialog. Seems like a jQuery issue.
> Not sure if it has anything to do with CSP headers. But those warnings seem 
> only CSS errors. No JS, and below looks like different HTML is generated by 
> jQuery.
>  
> When inspecting the HTML it actually generates different HTML in the UI if 
> you enter via invitation link:
> {code:java}
> 
> {code}
> Screenshot:
> !image-2020-05-02-10-01-58-944.png|width=594,height=330!
>  
> Normally it would be:
> {code:java}
> 
>
> 
>"Close"
> 
> {code}
> !image-2020-05-02-09-59-36-627.png|width=603,height=370!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2296) Library versions need to be updated (5.0.0-M5)

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098018#comment-17098018
 ] 

ASF subversion and git services commented on OPENMEETINGS-2296:
---

Commit 53db9a381f21a3048693a2ff7f86481a13caf55a in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=53db9a3 ]

[OPENMEETINGS-2296] spring and assembly=plugin are updated


> Library versions need to be updated (5.0.0-M5)
> --
>
> Key: OPENMEETINGS-2296
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2296
> Project: Openmeetings
>  Issue Type: Task
>  Components: Builds
>Affects Versions: 5.0.0-M5
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> Library versions need to be updated



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch master updated: [OPENMEETINGS-2296] spring and assembly=plugin are updated

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new 53db9a3  [OPENMEETINGS-2296] spring and assembly=plugin are updated
53db9a3 is described below

commit 53db9a381f21a3048693a2ff7f86481a13caf55a
Author: Maxim Solodovnik 
AuthorDate: Sat May 2 23:45:05 2020 +0700

[OPENMEETINGS-2296] spring and assembly=plugin are updated
---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index dd9a412..1d3ba2d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -55,7 +55,7 @@

3.8.1

3.0.0
3.2.0
-   
3.2.0
+   
3.3.0

3.1.2
4.2.1
3.2.3
@@ -81,7 +81,7 @@
9.0.0-M5.1
5.0.0-M2
1.2.3
-   5.2.5.RELEASE
+   5.2.6.RELEASE
2.1.3
9.0.34
3.0.14



[jira] [Commented] (OPENMEETINGS-2331) KMS connectivity isn't auto-recovering

2020-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098015#comment-17098015
 ] 

ASF subversion and git services commented on OPENMEETINGS-2331:
---

Commit 7407e68a3fe16f0a3b7037f01fce24076e69ce27 in openmeetings's branch 
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=7407e68 ]

[OPENMEETINGS-2331] KMS re-connection is refactored


> KMS connectivity isn't auto-recovering
> --
>
> Key: OPENMEETINGS-2331
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2331
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Kurento
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> If OM was started after Kurento Media Server then all is well and dandy. But 
> if KMS was started after OM or was restarted for some reason later (for 
> example due to update or crash) then OM will never recover from that and 
> currently require full OM restart.
> There should be some auto-recovery mechanism in place which will continuously 
> try to reinitiate connection (with configurable intervals) to KMS until a new 
> connection is established.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[openmeetings] branch master updated: [OPENMEETINGS-2331] KMS re-connection is refactored

2020-05-02 Thread solomax
This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/master by this push:
 new 7407e68  [OPENMEETINGS-2331] KMS re-connection is refactored
 new 93d8cff  Merge branch 'master' of github.com:apache/openmeetings
7407e68 is described below

commit 7407e68a3fe16f0a3b7037f01fce24076e69ce27
Author: Maxim Solodovnik 
AuthorDate: Sat May 2 23:33:27 2020 +0700

[OPENMEETINGS-2331] KMS re-connection is refactored
---
 .../openmeetings/core/remote/KurentoHandler.java   | 29 +-
 .../webapp/WEB-INF/classes/applicationContext.xml  |  2 +-
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
index 8c3e855..348f3e3 100644
--- 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
+++ 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
@@ -33,6 +33,8 @@ import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
 
+import javax.annotation.PostConstruct;
+import javax.annotation.PreDestroy;
 import javax.crypto.Mac;
 import javax.crypto.spec.SecretKeySpec;
 
@@ -57,7 +59,6 @@ import org.kurento.client.KurentoConnectionListener;
 import org.kurento.client.MediaObject;
 import org.kurento.client.MediaPipeline;
 import org.kurento.client.ObjectCreatedEvent;
-import org.kurento.client.ObjectDestroyedEvent;
 import org.kurento.client.PlayerEndpoint;
 import org.kurento.client.RecorderEndpoint;
 import org.kurento.client.Tag;
@@ -117,27 +118,33 @@ public class KurentoHandler {
return connctd;
}
 
+   @PostConstruct
public void init() {
check = () -> {
try {
+   if (isConnected()) {
+   return;
+   }
kuid = randomUUID().toString();
client = KurentoClient.create(kurentoWsUrl, new 
KConnectionListener(kuid));

client.getServerManager().addObjectCreatedListener(new KWatchDogCreate());
-   
client.getServerManager().addObjectDestroyedListener(new EventListener<>() {
-   @Override
-   public void 
onEvent(ObjectDestroyedEvent event) {
-   
log.debug("Kurento::ObjectDestroyedEvent objectId {}, tags {}, source {}", 
event.getObjectId(), event.getTags(), event.getSource());
-   }
-   });
+   
client.getServerManager().addObjectDestroyedListener(event ->
+   
log.debug("Kurento::ObjectDestroyedEvent objectId {}, tags {}, source {}", 
event.getObjectId(), event.getTags(), event.getSource())
+   );
} catch (Exception e) {
log.warn("Fail to create Kurento client, will 
re-try in {} ms", checkTimeout);
-   kmsRecheckScheduler.schedule(check, 
checkTimeout, MILLISECONDS);
}
};
-   check.run();
+   kmsRecheckScheduler.scheduleAtFixedRate(check, 0L, 
checkTimeout, MILLISECONDS);
}
 
+   @PreDestroy
public void destroy() {
+   clean();
+   kmsRecheckScheduler.shutdownNow();
+   }
+
+   private void clean() {
if (client != null) {
kuid = randomUUID().toString(); // will be changed to 
prevent double events
client.destroy();
@@ -377,11 +384,9 @@ public class KurentoHandler {
public void disconnected() {
log.info("Kurento disconnected");
if (lkuid.equals(kuid)) {
-   log.warn("Disconnected, will re-try in {} ms", 
checkTimeout);
connected = false;
notifyRooms();
-   destroy();
-   kmsRecheckScheduler.schedule(check, 
checkTimeout, MILLISECONDS);
+   clean();
}
}
 
diff --git 
a/openmeetings-web/src/main/webapp/WEB-INF/classes/applicationContext.xml 
b/openmeetings-web/src/main/webapp/WEB-INF/classes/applicationContext.xml
index 39fcbfb..e24aee8 100644
--- 

[jira] [Commented] (OPENMEETINGS-2341) invitation hash not generate on public room - openmeeting 5.0.0-M4

2020-05-02 Thread Maxim Solodovnik (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098014#comment-17098014
 ] 

Maxim Solodovnik commented on OPENMEETINGS-2341:


Works for me as expected on demo https://om.alteametasoft.com:8443/next

"Generate URL" is enabled if recipient(s) selected ...

> invitation hash not generate on public room - openmeeting 5.0.0-M4
> --
>
> Key: OPENMEETINGS-2341
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2341
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Admin, Invitation
>Affects Versions: 5.0.0-M4
> Environment: Demo https://om.alteametasoft.com:8443/next/#room/2 or 
> my own installation on ubuntu
>Reporter: David
>Assignee: Maxim Solodovnik
>Priority: Trivial
>  Labels: invitationhash
>
> Hello,
> I have a fresh install of Open Meetings 5.0.0-M4. Thanks for your great work, 
> and for the quick setup.
> I have already try older version in the past.
> In the web panel, I create a Public Conference Room (for example : 
> [https://om.alteametasoft.com:8443/next/#room/2] ).
> After I go to actions > Send invitation, when I click on generate URL, the 
> invitation hash or invitationhash is not generated, on older version it work 
> well.
> The function not working or is removed ?
> How can we invite unregistered people on a conference ?
> It is the same on the demo website, and my own installation.
>  
> Thanks in advance
> Have a good day.
> David



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OPENMEETINGS-2331) KMS connectivity isn't auto-recovering

2020-05-02 Thread Maxim Solodovnik (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim Solodovnik resolved OPENMEETINGS-2331.

Fix Version/s: 5.0.0-M5
   Resolution: Fixed

The code should be more bullet-proof now
please reopen with additional details if still an issue

> KMS connectivity isn't auto-recovering
> --
>
> Key: OPENMEETINGS-2331
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2331
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Kurento
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.0-M5
>
>
> If OM was started after Kurento Media Server then all is well and dandy. But 
> if KMS was started after OM or was restarted for some reason later (for 
> example due to update or crash) then OM will never recover from that and 
> currently require full OM restart.
> There should be some auto-recovery mechanism in place which will continuously 
> try to reinitiate connection (with configurable intervals) to KMS until a new 
> connection is established.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2340) Media server connection for user firstname lastname is failed, will try to re-connect

2020-05-02 Thread Maxim Solodovnik (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098012#comment-17098012
 ] 

Maxim Solodovnik commented on OPENMEETINGS-2340:


[~Gubenko] do you have TURN server configured?

> Media server connection for user firstname lastname is failed, will try to 
> re-connect
> -
>
> Key: OPENMEETINGS-2340
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2340
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M4
> Environment: Centos 7 (x64). Openmeetings installed according to the 
> instructions 
> https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
>  20Centos% 207.pdf
>Reporter: Alex
>Assignee: Maxim Solodovnik
>Priority: Major
>  Labels: RedHat
> Attachments: Error_Message.jpg, Log_of_Flip_Flop.jpg
>
>
> Periodically disappears and again there is a connection with the media server 
> (KMS)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OPENMEETINGS-2341) invitation hash not generate on public room - openmeeting 5.0.0-M4

2020-05-02 Thread David (Jira)
David created OPENMEETINGS-2341:
---

 Summary: invitation hash not generate on public room - openmeeting 
5.0.0-M4
 Key: OPENMEETINGS-2341
 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2341
 Project: Openmeetings
  Issue Type: Bug
  Components: Admin, Invitation
Affects Versions: 5.0.0-M4
 Environment: Demo https://om.alteametasoft.com:8443/next/#room/2 or my 
own installation on ubuntu
Reporter: David
Assignee: Maxim Solodovnik


Hello,

I have a fresh install of Open Meetings 5.0.0-M4. Thanks for your great work, 
and for the quick setup.

I have already try older version in the past.

In the web panel, I create a Public Conference Room (for example : 
[https://om.alteametasoft.com:8443/next/#room/2] ).

After I go to actions > Send invitation, when I click on generate URL, the 
invitation hash or invitationhash is not generated, on older version it work 
well.
The function not working or is removed ?

How can we invite unregistered people on a conference ?

It is the same on the demo website, and my own installation.

 

Thanks in advance

Have a good day.

David



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OPENMEETINGS-2253) Interruption of a video session when the microphone is turned on / off

2020-05-02 Thread Konstantin Kuzov (Jira)


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097869#comment-17097869
 ] 

Konstantin Kuzov commented on OPENMEETINGS-2253:


[~solomax], is RTCRtpSender.replaceTrack(null) which doesn't require 
renegotiation is still not well supported across all browsers/platforms? I 
tried [this old kurento experiment 
demo|https://github.com/Kurento/experiments/tree/master/WebRTC/mute-tracks] and 
it looks like working fine on chrome, firefox and android's chrome.

> Interruption of a video session when the microphone is turned on / off
> --
>
> Key: OPENMEETINGS-2253
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2253
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M3
> Environment: Chrome, FF
>Reporter: Evgeny
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 5.0.0-M5
>
> Attachments: icon_example.png
>
>
> Hello!
> 1. The participant turns on the camera - a camera window appears.
> 2. The participant turns on / off the microphone - the camera window closes, 
> after a delay of 2-3 seconds it opens, with a change from its original 
> position.
>  Each time the microphone is turned on / off, there is a delay and jerking of 
> the camera window of the conference participant, with the transition to the 
> default position.
> For other participants, the camera of this participant also disappears on the 
> screen.
>  Please make one button to turn on / off together - both the camera and the 
> microphone. Or a hotkey. So that the participant at the beginning and at the 
> end of the conversation does not press the camera and microphone separately 
> on the buttons.
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OPENMEETINGS-2340) Media server connection for user firstname lastname is failed, will try to re-connect

2020-05-02 Thread Alex (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex updated OPENMEETINGS-2340:
---
Environment: Centos 7 (x64). Installed according to the instructions 
https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
 20Centos% 207.pdf  (was: Centos 7 (x64), Installed according to the 
instructions 
https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
 20Centos% 207.pdf)

> Media server connection for user firstname lastname is failed, will try to 
> re-connect
> -
>
> Key: OPENMEETINGS-2340
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2340
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M4
> Environment: Centos 7 (x64). Installed according to the instructions 
> https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
>  20Centos% 207.pdf
>Reporter: Alex
>Assignee: Maxim Solodovnik
>Priority: Major
>  Labels: RedHat
> Attachments: Error_Message.jpg, Log_of_Flip_Flop.jpg
>
>
> Periodically disappears and again there is a connection with the media server 
> (KMS)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OPENMEETINGS-2340) Media server connection for user firstname lastname is failed, will try to re-connect

2020-05-02 Thread Alex (Jira)


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex updated OPENMEETINGS-2340:
---
Environment: Centos 7 (x64). Openmeetings installed according to the 
instructions 
https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
 20Centos% 207.pdf  (was: Centos 7 (x64). Installed according to the 
instructions 
https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
 20Centos% 207.pdf)

> Media server connection for user firstname lastname is failed, will try to 
> re-connect
> -
>
> Key: OPENMEETINGS-2340
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2340
> Project: Openmeetings
>  Issue Type: Bug
>  Components: Audio/Video
>Affects Versions: 5.0.0-M4
> Environment: Centos 7 (x64). Openmeetings installed according to the 
> instructions 
> https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
>  20Centos% 207.pdf
>Reporter: Alex
>Assignee: Maxim Solodovnik
>Priority: Major
>  Labels: RedHat
> Attachments: Error_Message.jpg, Log_of_Flip_Flop.jpg
>
>
> Periodically disappears and again there is a connection with the media server 
> (KMS)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OPENMEETINGS-2340) Media server connection for user firstname lastname is failed, will try to re-connect

2020-05-02 Thread Alex (Jira)
Alex created OPENMEETINGS-2340:
--

 Summary: Media server connection for user firstname lastname is 
failed, will try to re-connect
 Key: OPENMEETINGS-2340
 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2340
 Project: Openmeetings
  Issue Type: Bug
  Components: Audio/Video
Affects Versions: 5.0.0-M4
 Environment: Centos 7 (x64), Installed according to the instructions 
https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on%
 20Centos% 207.pdf
Reporter: Alex
Assignee: Maxim Solodovnik
 Attachments: Error_Message.jpg, Log_of_Flip_Flop.jpg

Periodically disappears and again there is a connection with the media server 
(KMS)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)